196963 2019-04-16 01:42:35 -0700 [WTF] Generic memoryFootprint() implementation should use bmalloc on Linux 2019-04-21 23:24:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan aperez basuke don.olmstead fujii webkit-bug-importer oldest_to_newest 1527665 0 zan 2019-04-16 01:42:35 -0700 [WTF] Generic memoryFootprint() implementation should use bmalloc on Linux 1527678 1 367519 zan 2019-04-16 02:42:59 -0700 Created attachment 367519 Patch 1527744 2 367519 don.olmstead 2019-04-16 09:02:45 -0700 Comment on attachment 367519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367519&action=review r=me with nits > Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp:29 > +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && OS(LINUX) Remove OS(LINUX) there's no reason for this to be OS specific. > Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp:37 > +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && OS(LINUX) Same 1528048 3 367519 zan 2019-04-17 01:01:18 -0700 Comment on attachment 367519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367519&action=review >> Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp:29 >> +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && OS(LINUX) > > Remove OS(LINUX) there's no reason for this to be OS specific. Didn't mention it in ChangeLog when I should have, but this bmalloc API at the moment is only implemented and exposed on Linux and iOS platforms. Given this implementation of WTF::memoryFootprint() would be used only on Linux (iOS has a different one), the OS(LINUX) guard is used here. The PlayStation port also uses this implementation, but I'm not sure whether bmalloc is used there and/or if the underlying OS identifies as Linux-like to the point of being able to use the bmalloc implementation. 1528214 4 367519 basuke 2019-04-17 12:23:55 -0700 Comment on attachment 367519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367519&action=review >>> Source/WTF/wtf/generic/MemoryFootprintGeneric.cpp:29 >>> +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC) && OS(LINUX) >> >> Remove OS(LINUX) there's no reason for this to be OS specific. > > Didn't mention it in ChangeLog when I should have, but this bmalloc API at the moment is only implemented and exposed on Linux and iOS platforms. Given this implementation of WTF::memoryFootprint() would be used only on Linux (iOS has a different one), the OS(LINUX) guard is used here. > > The PlayStation port also uses this implementation, but I'm not sure whether bmalloc is used there and/or if the underlying OS identifies as Linux-like to the point of being able to use the bmalloc implementation. We use bmalloc, but we didn't follow memoryFootprint() API yet. We'll see how we can do that and enable here also after doing that. 1529186 5 zan 2019-04-21 23:23:02 -0700 Committed r244496: <https://trac.webkit.org/changeset/244496> 1529187 6 webkit-bug-importer 2019-04-21 23:24:24 -0700 <rdar://problem/50087037> 367519 2019-04-16 02:42:59 -0700 2019-04-16 09:02:45 -0700 Patch bug-196963-20190416114258.patch text/plain 2386 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk1YzhjNWQ2NDY5YmVkM2E2NDhhYTA0 Y2JiNzU5MmE2OGYxMTg1YzguLmFiZjhmZjk3NmUwMTg5N2MwMDM1ZGI3YWM0NjQ4OWI1NDAxNTEy MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDQtMTYgIFphbiBEb2JlcnNlayAgPHpkb2Jl cnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXVEZdIEdlbmVyaWMgbWVtb3J5Rm9vdHByaW50 KCkgaW1wbGVtZW50YXRpb24gc2hvdWxkIHVzZSBibWFsbG9jIG9uIExpbnV4CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY5NjMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIYXZlIHRoZSBnZW5lcmljIG1l bW9yeUZvb3RwcmludCgpIGltcGxlbWVudGF0aW9uIHVzZSBibWFsbG9jJ3MKKyAgICAgICAgbWVt b3J5Rm9vdHByaW50KCkgQVBJIG9uIExpbnV4LCB3aGVuZXZlciB0aGUgc3lzdGVtIG1hbGxvYyBv cHRpb24gaXMKKyAgICAgICAgbm90IGVuYWJsZWQuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1X UEUuY21ha2U6IFN3aXRjaCB0byBidWlsZGluZyBNZW1vcnlGb290cHJpbnRHZW5lcmljLmNwcC4K KyAgICAgICAgKiB3dGYvZ2VuZXJpYy9NZW1vcnlGb290cHJpbnRHZW5lcmljLmNwcDoKKyAgICAg ICAgKFdURjo6bWVtb3J5Rm9vdHByaW50KToKKwogMjAxOS0wNC0xNSAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gRm9udFBsYXRmb3Jt RGF0YSBvYmplY3RzIGFyZW4ndCBjYWNoZWQgYXQgYWxsIHdoZW4gdXNpbmcgZm9udC1mYW1pbHk6 c3lzdGVtLXVpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybVdQRS5jbWFrZSBi L1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IDM4ZTYzMmMzZWY4YjMxMzdh YTk3MTE5OTBlNzE0NTVmYmFhMDMyY2MuLjc3ODdjZmVmNWIyZTMxMWFlODg0YjU5MTZkOGJmNDVh MmE3YzA0ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtV1BFLmNtYWtlCisr KyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0xNCw2ICsxNCw3IEBAIGxp c3QoQVBQRU5EIFdURl9TT1VSQ0VTCiAgICAgVW5pU3RkRXh0cmFzLmNwcAogCiAgICAgZ2VuZXJp Yy9NYWluVGhyZWFkR2VuZXJpYy5jcHAKKyAgICBnZW5lcmljL01lbW9yeUZvb3RwcmludEdlbmVy aWMuY3BwCiAgICAgZ2VuZXJpYy9Xb3JrUXVldWVHZW5lcmljLmNwcAogCiAgICAgZ2xpYi9GaWxl U3lzdGVtR2xpYi5jcHAKQEAgLTIzLDcgKzI0LDYgQEAgbGlzdChBUFBFTkQgV1RGX1NPVVJDRVMK ICAgICBnbGliL1VSTEdMaWIuY3BwCiAKICAgICBsaW51eC9DdXJyZW50UHJvY2Vzc01lbW9yeVN0 YXR1cy5jcHAKLSAgICBsaW51eC9NZW1vcnlGb290cHJpbnRMaW51eC5jcHAKICAgICBsaW51eC9N ZW1vcnlQcmVzc3VyZUhhbmRsZXJMaW51eC5jcHAKIAogICAgIHBvc2l4L09TQWxsb2NhdG9yUE9T SVguY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9nZW5lcmljL01lbW9yeUZvb3Rwcmlu dEdlbmVyaWMuY3BwIGIvU291cmNlL1dURi93dGYvZ2VuZXJpYy9NZW1vcnlGb290cHJpbnRHZW5l cmljLmNwcAppbmRleCAwZGU5NDcyOTEwZTc2ODI5OTdjOTMyZjkxYTJlODBlMWZmMjM1YzJjLi5l NmNiOWRkNTFkZGZiNzIxODgzZDczZjA3N2Y0NzVjYmFkNDUyNTFlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi9nZW5lcmljL01lbW9yeUZvb3RwcmludEdlbmVyaWMuY3BwCisrKyBiL1NvdXJj ZS9XVEYvd3RmL2dlbmVyaWMvTWVtb3J5Rm9vdHByaW50R2VuZXJpYy5jcHAKQEAgLTI2LDExICsy NiwxOSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgPHd0Zi9NZW1vcnlGb290cHJp bnQuaD4KIAorI2lmICEoZGVmaW5lZChVU0VfU1lTVEVNX01BTExPQykgJiYgVVNFX1NZU1RFTV9N QUxMT0MpICYmIE9TKExJTlVYKQorI2luY2x1ZGUgPGJtYWxsb2MvYm1hbGxvYy5oPgorI2VuZGlm CisKIG5hbWVzcGFjZSBXVEYgewogCiBzaXplX3QgbWVtb3J5Rm9vdHByaW50KCkKIHsKKyNpZiAh KGRlZmluZWQoVVNFX1NZU1RFTV9NQUxMT0MpICYmIFVTRV9TWVNURU1fTUFMTE9DKSAmJiBPUyhM SU5VWCkKKyAgICByZXR1cm4gYm1hbGxvYzo6YXBpOjptZW1vcnlGb290cHJpbnQoKTsKKyNlbHNl CiAgICAgcmV0dXJuIDA7CisjZW5kaWYKIH0KIAogfSAvLyBuYW1lc3BhY2UgV1RGCg==