19696 2008-06-20 14:34:08 -0700 Memory leak in WebCore/editing/DeleteButtonController.cpp 2008-06-22 17:52:14 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 kuchhal webkit-unassigned oldest_to_newest 83998 0 kuchhal 2008-06-20 14:34:08 -0700 Purify reports a memory leak at: webkit/webcore/editing/deletebuttoncontroller.cpp:198 WebCore::DeleteButtonController::createDeletionUI(void) webkit/webcore/editing/deletebuttoncontroller.cpp:230 WebCore::DeleteButtonController::show(HTMLElement::WebCore *) webkit/webcore/editing/deletebuttoncontroller.cpp:138 WebCore::DeleteButtonController::respondToChangedSelection(Selection::WebCore const&) webkit/webcore/editing/editor.cpp:396 WebCore::Editor::respondToChangedSelection(Selection::WebCore const&) 84002 1 21860 kuchhal 2008-06-20 14:44:00 -0700 Created attachment 21860 Patch for the bug 84005 2 21862 kuchhal 2008-06-20 15:18:41 -0700 Created attachment 21862 Patch 84011 3 21862 darin 2008-06-20 15:53:29 -0700 Comment on attachment 21862 Patch r=me 84088 4 mrowe 2008-06-22 17:51:35 -0700 As per my comment in bug 19697, please take care when creating the ChangeLog entry. 84089 5 mrowe 2008-06-22 17:52:14 -0700 Landed in r34730. 21860 2008-06-20 14:44:00 -0700 2008-06-20 15:18:11 -0700 Patch for the bug patch.txt text/plain 648 kuchhal SW5kZXg6IFdlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9sbGVyLmNwcA0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIFdlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9sbGVyLmNwcAkocmV2 aXNpb24gMzQ3MDApCisrKyBXZWJDb3JlL2VkaXRpbmcvRGVsZXRlQnV0dG9uQ29udHJvbGxlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTE5Niw4ICsxOTYsMTAgQEAgdm9pZCBEZWxldGVCdXR0b25D b250cm9sbGVyOjpjcmVhdGVEZWxldAogICAgIHN0eWxlLT5zZXRQcm9wZXJ0eShDU1NQcm9wZXJ0 eUhlaWdodCwgU3RyaW5nOjpudW1iZXIoYnV0dG9uSGVpZ2h0KSArICJweCIpOwogCiAgICAgSW1h Z2UqIGJ1dHRvbkltYWdlID0gSW1hZ2U6OmxvYWRQbGF0Zm9ybVJlc291cmNlKCJkZWxldGVCdXR0 b24iKTsKLSAgICBpZiAoYnV0dG9uSW1hZ2UtPmlzTnVsbCgpKQorICAgIGlmIChidXR0b25JbWFn ZS0+aXNOdWxsKCkpIHsKKyAgICAgICAgZGVsZXRlIGJ1dHRvbkltYWdlOwogICAgICAgICByZXR1 cm47CisgICAgfQogICAgIAogICAgIGJ1dHRvbi0+c2V0Q2FjaGVkSW1hZ2UobmV3IENhY2hlZElt YWdlKGJ1dHRvbkltYWdlKSk7CiAK 21862 2008-06-20 15:18:41 -0700 2008-06-20 15:53:29 -0700 Patch patch.txt text/plain 1154 kuchhal SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMzQ3 MDQpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0w Ni0yMCAga3VjaGhhbCAgPGt1Y2hoYWxAeWFob28uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisJaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5Njk2CisJRml4IGZvciB0aGUgbWVtb3J5IGxlYWsgbWVudGlvbmVkIGluIHRoZSBidWcg YWJvdmUuCisKKyAgICAgICAgKiBXZWJDb3JlXGVkaXRpbmdcRGVsZXRlQnV0dG9uQ29udHJvbGxl ci5jcHA6CisKIDIwMDgtMDYtMTggIE1hcmNvIEJhcmlzaW9uZSAgPG1hcmNvLmJhcmlzaW9uZUBj b2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxwIFRva2VyLgpJbmRleDog V2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuY3BwDQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQot LS0gV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZUJ1dHRvbkNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAz NDcwMCkKKysrIFdlYkNvcmUvZWRpdGluZy9EZWxldGVCdXR0b25Db250cm9sbGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTk2LDggKzE5NiwxMCBAQCB2b2lkIERlbGV0ZUJ1dHRvbkNvbnRyb2xs ZXI6OmNyZWF0ZURlbGV0CiAgICAgc3R5bGUtPnNldFByb3BlcnR5KENTU1Byb3BlcnR5SGVpZ2h0 LCBTdHJpbmc6Om51bWJlcihidXR0b25IZWlnaHQpICsgInB4Iik7CiAKICAgICBJbWFnZSogYnV0 dG9uSW1hZ2UgPSBJbWFnZTo6bG9hZFBsYXRmb3JtUmVzb3VyY2UoImRlbGV0ZUJ1dHRvbiIpOwot ICAgIGlmIChidXR0b25JbWFnZS0+aXNOdWxsKCkpCisgICAgaWYgKGJ1dHRvbkltYWdlLT5pc051 bGwoKSkgeworICAgICAgICBkZWxldGUgYnV0dG9uSW1hZ2U7CiAgICAgICAgIHJldHVybjsKKyAg ICB9CiAgICAgCiAgICAgYnV0dG9uLT5zZXRDYWNoZWRJbWFnZShuZXcgQ2FjaGVkSW1hZ2UoYnV0 dG9uSW1hZ2UpKTsKIAo=