196954 2019-04-15 20:33:58 -0700 Web Inspector: CRASH when reopening tab with docked inspector on crashed page 2019-04-16 11:28:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck rniwa webkit-bug-importer oldest_to_newest 1527598 0 joepeck 2019-04-15 20:33:58 -0700 CRASH when reopening tab with docked inspector on crashed page Steps to Reproduce: 1. Open Safari window 2. Open a Tab to example.com 3. Inspect example.com 4. Dock inspector 5. Open and focus a second tab 6. Kill the example.com web process 7. Switch back to the example.com tab => UIProcess crashes Crash: ... Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x0000000109d7f086 WebKit::WebPageProxy::pageClient() const + 4 (DumbPtrTraits.h:41) 1 com.apple.WebKit 0x0000000109e2d457 WebKit::WebInspectorProxy::inspectedViewFrameDidChange(double) + 55 (WebPageProxyMac.mm:655) 2 com.apple.WebKit 0x0000000109e1c629 -[WKInspectorWKWebView viewDidMoveToWindow] + 80 (WKInspectorWKWebView.mm:73) ... 1527599 1 joepeck 2019-04-15 20:34:06 -0700 <rdar://problem/48716433> 1527600 2 367493 joepeck 2019-04-15 20:34:58 -0700 Created attachment 367493 [PATCH] Proposed Fix 1527617 3 367493 rniwa 2019-04-15 22:56:00 -0700 Comment on attachment 367493 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=367493&action=review > Source/WebKit/ChangeLog:3 > + Web Inspector: CRASH when reopening tab with docked inspector on crashed page Is there anyway to write a test for this? 1527623 4 367493 commit-queue 2019-04-15 23:22:46 -0700 Comment on attachment 367493 [PATCH] Proposed Fix Clearing flags on attachment: 367493 Committed r244326: <https://trac.webkit.org/changeset/244326> 1527624 5 commit-queue 2019-04-15 23:22:48 -0700 All reviewed patches have been landed. Closing bug. 1527792 6 joepeck 2019-04-16 11:28:35 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 367493 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367493&action=review > > > Source/WebKit/ChangeLog:3 > > + Web Inspector: CRASH when reopening tab with docked inspector on crashed page > > Is there anyway to write a test for this? Hmm, this relied on Safari changing tabs to trigger the -[WKInspectorWKWebView viewDidMoveToWindow]. There might be an API test I could come up with using WKWebViews in NSWindows. 367493 2019-04-15 20:34:58 -0700 2019-04-15 23:22:46 -0700 [PATCH] Proposed Fix prevent-crash.patch text/plain 1259 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNjNmOTYzODU2YzIuLmQxZDE0NWViMTE3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE5LTA0LTE1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ1JBU0ggd2hlbiByZW9wZW5pbmcgdGFiIHdpdGgg ZG9ja2VkIGluc3BlY3RvciBvbiBjcmFzaGVkIHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njk1NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDg3MTY0MzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2Vi S2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6aW5zcGVjdGVkVmlld0ZyYW1lRGlkQ2hhbmdlKToKKwog MjAxOS0wNC0xNSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS11bV1BFXSBBZGQgZW5hYmxlLW1lZGlhIHdlYnNldHRpbmcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbSBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCBi ZTM3ODlhOTA0OS4uMDA3ZDg3ZGZjZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KQEAgLTU2Miw2ICs1NjIsOSBAQCB2b2lk IFdlYkluc3BlY3RvclByb3h5OjppbnNwZWN0ZWRWaWV3RnJhbWVEaWRDaGFuZ2UoQ0dGbG9hdCBj dXJyZW50RGltZW5zaW9uKQogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgaWYgKCFpbnNw ZWN0ZWRQYWdlKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIE5TVmlldyAqaW5zcGVjdGVkVmll dyA9IGluc3BlY3RlZFBhZ2UoKS0+aW5zcGVjdG9yQXR0YWNobWVudFZpZXcoKTsKICAgICBXS1dl YlZpZXcgKmluc3BlY3RvclZpZXcgPSBbbV9pbnNwZWN0b3JWaWV3Q29udHJvbGxlciB3ZWJWaWV3 XTsKIAo=