196949 2019-04-15 17:19:36 -0700 Stop using hyphenationFactor 2019-04-15 18:43:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen commit-queue ggaren webkit-bug-importer oldest_to_newest 1527538 0 achristensen 2019-04-15 17:19:36 -0700 Stop using hyphenationFactor 1527539 1 367479 achristensen 2019-04-15 17:21:25 -0700 Created attachment 367479 Patch 1527540 2 achristensen 2019-04-15 17:21:27 -0700 <rdar://problem/49779594> 1527541 3 367479 ggaren 2019-04-15 17:25:04 -0700 Comment on attachment 367479 Patch r=me How did you test the visual result? Is this covered by regression tests? 1527558 4 achristensen 2019-04-15 18:15:49 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 367479 [details] > Patch > > r=me > > How did you test the visual result? I tested that the visual result was good without this call when working on r241124. I actually saw no effect when adding this, and I considered it unnecessary but added it anyway based on feedback from you and out of abundance of caution. > Is this covered by regression tests? No. 1527565 5 367479 commit-queue 2019-04-15 18:43:35 -0700 Comment on attachment 367479 Patch Clearing flags on attachment: 367479 Committed r244319: <https://trac.webkit.org/changeset/244319> 1527566 6 commit-queue 2019-04-15 18:43:37 -0700 All reviewed patches have been landed. Closing bug. 367479 2019-04-15 17:21:25 -0700 2019-04-15 18:43:35 -0700 Patch bug-196949-20190415172124.patch text/plain 1391 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQzMTIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTE1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU3RvcCB1c2luZyBo eXBoZW5hdGlvbkZhY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2OTQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTc3OTU5ND4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9D b2NvYS9XS1NhZmVCcm93c2luZ1dhcm5pbmcubW06CisgICAgICAgICgtW1dLU2FmZUJyb3dzaW5n VGV4dFZpZXcgaW5pdFdpdGhBdHRyaWJ1dGVkU3RyaW5nOmZvcldhcm5pbmc6XSk6CisgICAgICAg IEkgYWRkZWQgdGhpcyB1c2Ugb2YgaHlwaGVuYXRpb25GYWN0b3IgaW4gcjI0MTEyNCBidXQgdGhl IG90aGVyIGNoYW5nZXMgaW4gdGhhdCByZXZpc2lvbiBtYWtlIHRoZSB1c2Ugb2YgaHlwaGVuYXRp b25GYWN0b3IgcmVkdW5kYW50LgorICAgICAgICBUaGVyZSBpcyBhIHJlYXNvbiB0byByZW1vdmUg aXQgaW4gdGhlIHJhZGFyLgorCiAyMDE5LTA0LTE1ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBhIERpYWdub3N0aWNMb2dnaW5nIG1ldGhvZCB0YWtpbmcg YW4gYXJiaXRyYXJ5IGRpY3Rpb25hcnkgb2YgdmFsdWVzLgpJbmRleDogU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJvd3NpbmdXYXJuaW5nLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dLU2FmZUJyb3dzaW5nV2FybmluZy5tbQkocmV2 aXNpb24gMjQ0Mjg4KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV0tTYWZlQnJv d3NpbmdXYXJuaW5nLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01NjIsOSArNTYyLDYgQEAgLSAoaW5z dGFuY2V0eXBlKWluaXRXaXRoQXR0cmlidXRlZFN0cmluZwogI2lmICFQTEFURk9STShNQUMpCiAg ICAgc2VsZi5zY3JvbGxFbmFibGVkID0gTk87CiAjZW5kaWYKLSNpZiBQTEFURk9STShXQVRDSE9T KQotICAgIHNlbGYubGF5b3V0TWFuYWdlci5oeXBoZW5hdGlvbkZhY3RvciA9IDE7Ci0jZW5kaWYK IAogICAgIHJldHVybiBzZWxmOwogfQo=