<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>196945</bug_id>
          
          <creation_ts>2019-04-15 15:51:30 -0700</creation_ts>
          <short_desc>SafeToExecute for GetByOffset/GetGetterByOffset/PutByOffset is using the wrong child for the base</short_desc>
          <delta_ts>2019-04-23 12:48:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>guijemont</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>saelo</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1527486</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-04-15 15:51:30 -0700</bug_when>
    <thetext>...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1527487</commentid>
    <comment_count>1</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-04-15 15:54:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/49802750&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1527488</commentid>
    <comment_count>2</comment_count>
      <attachid>367468</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-04-15 15:57:51 -0700</bug_when>
    <thetext>Created attachment 367468
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1527548</commentid>
    <comment_count>3</comment_count>
      <attachid>367468</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-15 17:39:31 -0700</bug_when>
    <thetext>Comment on attachment 367468
patch

Clearing flags on attachment: 367468

Committed r244314: &lt;https://trac.webkit.org/changeset/244314&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1527549</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-04-15 17:39:33 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1529694</commentid>
    <comment_count>5</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2019-04-23 12:48:13 -0700</bug_when>
    <thetext>*** Bug 196964 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>367468</attachid>
            <date>2019-04-15 15:57:51 -0700</date>
            <delta_ts>2019-04-15 17:39:31 -0700</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>3407</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyNDQzMDEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTE1ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu
Y29tPgorCisgICAgICAgIFNhZmVUb0V4ZWN1dGUgZm9yIEdldEJ5T2Zmc2V0L0dldEdldHRlckJ5
T2Zmc2V0L1B1dEJ5T2Zmc2V0IGlzIHVzaW5nIHRoZSB3cm9uZyBjaGlsZCBmb3IgdGhlIGJhc2UK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njk0NQor
ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk4MDI3NTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZ2V0LWJ5LW9mZnNldC1zaG91bGQt
dXNlLWNvcnJlY3QtY2hpbGQuanM6IEFkZGVkLgorICAgICAgICAoZm9vLmJhcik6CisgICAgICAg
IChmb28pOgorCiAyMDE5LTA0LTE1ICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUuY29t
PgogCiAgICAgICAgIEluY3JlbWVudGFsIGJ5dGVjb2RlIGNhY2hlIHNob3VsZCBub3QgYXBwZW5k
IGZ1bmN0aW9uIHVwZGF0ZXMgd2hlbiBsb2FkZWQgZnJvbSBtZW1vcnkKSW5kZXg6IEpTVGVzdHMv
c3RyZXNzL2dldC1ieS1vZmZzZXQtc2hvdWxkLXVzZS1jb3JyZWN0LWNoaWxkLmpzCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIEpTVGVzdHMvc3RyZXNzL2dldC1ieS1vZmZzZXQtc2hvdWxkLXVzZS1jb3JyZWN0LWNo
aWxkLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2dldC1ieS1vZmZzZXQtc2hv
dWxkLXVzZS1jb3JyZWN0LWNoaWxkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMjUgQEAK
K2Z1bmN0aW9uIGZvbyh4KSB7CisgICAgZm9yIChsZXQgaSA9IDA7IGkgPCA0MDA7IGkrKykgewor
ICAgICAgICBmb3IgKGxldCBqID0gMDsgaiA8IDI7IGorKykgeworICAgICAgICAgICAgZm9yIChj
b25zdCBrIG9mIGFyZ3VtZW50cykgeworICAgICAgICAgICAgfQorICAgICAgICAgICAgYXJndW1l
bnRzLmxlbmd0aCA9IDA7CisgICAgICAgICAgICBjb25zdCBxID0geworICAgICAgICAgICAgICAg
IHo6IDAKKyAgICAgICAgICAgIH07CisgICAgICAgICAgICBmdW5jdGlvbiBiYXIoKSB7CisgICAg
ICAgICAgICAgICAgcTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGZvciAobGV0IHcgPSAw
OyB3IDwgMzAwOyB3KyspIHsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIHdp
dGggKHt9KSB7CisgICAgICAgIH0KKworICAgICAgICAre307CisgICAgfQorfQorCitmb28oMCk7
Citmb28oMCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NDI3NSkK
KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs
MyArMSwxNCBAQAorMjAxOS0wNC0xNSAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4K
KworICAgICAgICBTYWZlVG9FeGVjdXRlIGZvciBHZXRCeU9mZnNldC9HZXRHZXR0ZXJCeU9mZnNl
dC9QdXRCeU9mZnNldCBpcyB1c2luZyB0aGUgd3JvbmcgY2hpbGQgZm9yIHRoZSBiYXNlCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY5NDUKKyAgICAg
ICAgPHJkYXI6Ly9wcm9ibGVtLzQ5ODAyNzUwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR1NhZmVUb0V4ZWN1dGUuaDoKKyAgICAgICAg
KEpTQzo6REZHOjpzYWZlVG9FeGVjdXRlKToKKwogMjAxOS0wNC0xNCAgRG9uIE9sbXN0ZWFkICA8
ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtDTWFrZV0gSmF2YVNjcmlwdENvcmUg
ZGVyaXZlZCBzb3VyY2VzIHNob3VsZCBvbmx5IGJlIHJlZmVyZW5jZWQgaW5zaWRlIEphdmFTY3Jp
cHRDb3JlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NhZmVUb0V4ZWN1dGUu
aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NhZmVUb0V4ZWN1
dGUuaAkocmV2aXNpb24gMjQ0MjcyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT
YWZlVG9FeGVjdXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU0NSwxMyArNTQ1LDEzIEBAIGJvb2wg
c2FmZVRvRXhlY3V0ZShBYnN0cmFjdFN0YXRlVHlwZSYgc3QKICAgICAgICAgLy8ga25vdyBhbnl0
aGluZyBhYm91dCBpbmZlcnJlZCB0eXBlcy4gQnV0IGlmIHdlIGhhdmUgYSBwcm9vZiBkZXJpdmVk
IGZyb20gd2F0Y2hpbmcgYQogICAgICAgICAvLyBzdHJ1Y3R1cmUgdGhhdCBoYXMgYSB0eXBlIHBy
b29mLCB0aGVuIHRoZSBuZXh0IGNhc2UgYmVsb3cgd2lsbCBkZWFsIHdpdGggaXQuCiAgICAgICAg
IGlmIChzdGF0ZS5zdHJ1Y3R1cmVDbG9iYmVyU3RhdGUoKSA9PSBTdHJ1Y3R1cmVzQXJlV2F0Y2hl
ZCkgewotICAgICAgICAgICAgaWYgKEpTT2JqZWN0KiBrbm93bkJhc2UgPSBub2RlLT5jaGlsZDEo
KS0+ZHluYW1pY0Nhc3RDb25zdGFudDxKU09iamVjdCo+KGdyYXBoLm1fdm0pKSB7CisgICAgICAg
ICAgICBpZiAoSlNPYmplY3QqIGtub3duQmFzZSA9IG5vZGUtPmNoaWxkMigpLT5keW5hbWljQ2Fz
dENvbnN0YW50PEpTT2JqZWN0Kj4oZ3JhcGgubV92bSkpIHsKICAgICAgICAgICAgICAgICBpZiAo
Z3JhcGguaXNTYWZlVG9Mb2FkKGtub3duQmFzZSwgb2Zmc2V0KSkKICAgICAgICAgICAgICAgICAg
ICAgcmV0dXJuIHRydWU7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgCi0gICAg
ICAgIFN0cnVjdHVyZUFic3RyYWN0VmFsdWUmIHZhbHVlID0gc3RhdGUuZm9yTm9kZShub2RlLT5j
aGlsZDEoKSkubV9zdHJ1Y3R1cmU7CisgICAgICAgIFN0cnVjdHVyZUFic3RyYWN0VmFsdWUmIHZh
bHVlID0gc3RhdGUuZm9yTm9kZShub2RlLT5jaGlsZDIoKSkubV9zdHJ1Y3R1cmU7CiAgICAgICAg
IGlmICh2YWx1ZS5pc0luZmluaXRlKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAg
ICAgIGZvciAodW5zaWduZWQgaSA9IHZhbHVlLnNpemUoKTsgaS0tOykgewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>