196940 2019-04-15 15:17:51 -0700 Using Tools/Scripts/clean-webkit should not install requests 2019-04-16 22:37:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dean_johnson dean_johnson aakash_jain commit-queue dewei_zhu ews-watchlist glenn jbedard lforschler webkit-bug-importer oldest_to_newest 1527461 0 dean_johnson 2019-04-15 15:17:51 -0700 Importing webkitpy.port.base automatically starts installing `requests` into Tools/Scripts/thirdparty/autoinstalled. Since the Port class is integral to many scripts which will not be doing uploads of WebKit test results, we should avoid auto-installing unnecessary modules like `requests` until they're actually needed. 1527495 1 367472 dean_johnson 2019-04-15 16:08:51 -0700 Created attachment 367472 Patch 1527500 2 jbedard 2019-04-15 16:13:40 -0700 Unofficial r+. 1527502 3 367472 lforschler 2019-04-15 16:17:21 -0700 Comment on attachment 367472 Patch r=me if EWS passes. 1527523 4 367472 commit-queue 2019-04-15 17:00:55 -0700 Comment on attachment 367472 Patch Clearing flags on attachment: 367472 Committed r244310: <https://trac.webkit.org/changeset/244310> 1527524 5 commit-queue 2019-04-15 17:00:56 -0700 All reviewed patches have been landed. Closing bug. 1527526 6 webkit-bug-importer 2019-04-15 17:02:30 -0700 <rdar://problem/49924067> 367472 2019-04-15 16:08:51 -0700 2019-04-16 22:37:52 -0700 Patch bug-196940-20190415160850.patch text/plain 3254 dean_johnson U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MjkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWU0NDgxYWQ0YTJhYTc5YmJkMTYwNDFhOGRiZDM0MDA5 ZjQxNjA0NC4uZTVmZTlhYzM2YjkwYWI3ZDRlNGQwOTJlOTQwNTQ5ZmM1MTVhNDlkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE5LTA0LTE1ICBEZWFuIEpvaG5zb24gIDxkZWFuX2pvaG5zb25AYXBwbGUuY29tPgor CisgICAgICAgIFVzaW5nIFRvb2xzL1NjcmlwdHMvY2xlYW4td2Via2l0IHNob3VsZCBub3QgaW5z dGFsbCByZXF1ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2OTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHk6IERy aXZlLWJ5IGZpeCBmb3Igbm8gbG9nZ2luZyBoYW5kbGVycworICAgICAgICBleGlzdGluZywgZGVw ZW5kaW5nIG9uIHRoZSBwYXRoIGF1dG9pbnN0YWxsZWQgaXMgcnVuIHRocm91Z2guCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHk6IEltcG9ydCB3ZWJraXRweS5yZXN1bHRz LnVwbG9hZC5VcGxvYWQgb25seSB3aGVyZSBpdCdzCisgICAgICAgIG5lZWRlZC4KKyAgICAgICAg KFBvcnQuY29uZmlndXJhdGlvbl9mb3JfdXBsb2FkKToKKyAgICAgICAgKFBvcnQuY29tbWl0c19m b3JfdXBsb2FkKToKKwogMjAxOS0wNC0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBIYXNoVGFibGU6OnJlbW92ZUlmIGFsd2F5cyBzaHJpbmtzIHRoZSBoYXNo IHRhYmxlIGJ5IGhhbGYgZXZlbiBpZiB0aGVyZSBpcyBub3RoaW5nIGxlZnQKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9hdXRvaW5zdGFsbC5weQppbmRleCBi MTczYTI5OTdiZjMxZDY5ZmIwMzRmMzFmZjI5N2RiOTY0YzhjZjk5Li40ZThhMjY5NjQ3YzUyMWVh OWVhYjdmNDMxNzc5NDkyY2E4NzI1NDZlIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vYXV0b2luc3RhbGwucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL2F1dG9pbnN0YWxsLnB5CkBAIC00Nyw3ICs0NywxNSBAQCBmcm9t IGRpc3R1dGlscyBpbXBvcnQgZGlyX3V0aWwKIGZyb20gZ2xvYiBpbXBvcnQgZ2xvYgogaW1wb3J0 IHVybHBhcnNlCiAKKwogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQoraWYgbm90 IF9sb2cuaGFuZGxlcnM6ICAjIE5vIHBhcmVudCBsb2dnZXJzIHNldHVwLgorICAgIGhhbmRsZXIg PSBsb2dnaW5nLlN0cmVhbUhhbmRsZXIoKQorICAgIGhhbmRsZXIuc2V0TGV2ZWwobG9nZ2luZy5J TkZPKQorICAgIGZvcm1hdHRlciA9IGxvZ2dpbmcuRm9ybWF0dGVyKCclKGFzY3RpbWUpcyAtICUo bmFtZSlzIC0gJShsZXZlbG5hbWUpcyAtICUobWVzc2FnZSlzJykKKyAgICBoYW5kbGVyLnNldEZv cm1hdHRlcihmb3JtYXR0ZXIpCisgICAgX2xvZy5hZGRIYW5kbGVyKGhhbmRsZXIpCisKIF9NSVJS T1JfUkVHRVhTID0gcmUuY29tcGlsZSgnLipzb3VyY2Vmb3JnZS4qJyksIHJlLmNvbXBpbGUoJy4q cHlwaS4qJykKIF9QWVBJX0VOVl9WQVIgPSAnUFlQSV9NSVJST1JTJwogX1NPVVJDRUZPUkdFX0VO Vl9WQVIgPSAnU09VUkNFRk9SR0VfTUlSUk9SUycKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2Uu cHkKaW5kZXggZjVjOTQ3Njg0ZmQ3NDMyYzMzNTIwMWFmZDQ1ZTQ0NmM3OTc2ODIxOC4uZDA2Nzk5 YzZhZTBlMjYwZDkxOTJmNGI4Njg1NmI4YWQzYWE2Zjk5MSAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L2Jhc2UucHkKQEAgLTYyLDcgKzYyLDYgQEAgZnJvbSB3ZWJraXRweS5wb3J0LmZhY3Rvcnkg aW1wb3J0IFBvcnRGYWN0b3J5CiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzIGlt cG9ydCBhcGFjaGVfaHR0cF9zZXJ2ZXIsIGh0dHBfc2VydmVyLCBodHRwX3NlcnZlcl9iYXNlCiBm cm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5zZXJ2ZXJzIGltcG9ydCB3ZWJfcGxhdGZvcm1fdGVz dF9zZXJ2ZXIKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnNlcnZlcnMgaW1wb3J0IHdlYnNv Y2tldF9zZXJ2ZXIKLWZyb20gd2Via2l0cHkucmVzdWx0cy51cGxvYWQgaW1wb3J0IFVwbG9hZAog CiBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKQEAgLTE2MzgsNiArMTYzNyw4 IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgcGFzcwogCiAgICAgZGVmIGNvbmZpZ3Vy YXRpb25fZm9yX3VwbG9hZChzZWxmLCBob3N0PU5vbmUpOgorICAgICAgICBmcm9tIHdlYmtpdHB5 LnJlc3VsdHMudXBsb2FkIGltcG9ydCBVcGxvYWQKKwogICAgICAgICBjb25maWd1cmF0aW9uID0g c2VsZi50ZXN0X2NvbmZpZ3VyYXRpb24oKQogICAgICAgICBob3N0ID0gc2VsZi5ob3N0IG9yIGhv c3QKIApAQCAtMTY1MiwxMiArMTY1MywxMyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAKICAgICBA bWVtb2l6ZWQKICAgICBkZWYgY29tbWl0c19mb3JfdXBsb2FkKHNlbGYpOgorICAgICAgICBmcm9t IHdlYmtpdHB5LnJlc3VsdHMudXBsb2FkIGltcG9ydCBVcGxvYWQKKwogICAgICAgICBzZWxmLmhv c3QuaW5pdGlhbGl6ZV9zY20oKQogCisgICAgICAgIHJlcG9zID0ge30KICAgICAgICAgaWYgcG9y dF9jb25maWcuYXBwbGVfYWRkaXRpb25zKCkgYW5kIGdldGF0dHIocG9ydF9jb25maWcuYXBwbGVf YWRkaXRpb25zKCksICdyZXBvcycsIEZhbHNlKToKICAgICAgICAgICAgIHJlcG9zID0gcG9ydF9j b25maWcuYXBwbGVfYWRkaXRpb25zKCkucmVwb3MoKQotICAgICAgICBlbHNlOgotICAgICAgICAg ICAgcmVwb3MgPSB7fQogCiAgICAgICAgIHVwID0gb3MucGF0aC5kaXJuYW1lCiAgICAgICAgIHJl cG9zWyd3ZWJraXQnXSA9IHVwKHVwKHVwKHVwKHVwKG9zLnBhdGguYWJzcGF0aChfX2ZpbGVfXykp KSkpKQo=