196925 2019-04-15 12:06:17 -0700 Web Inspector: REGRESSION(r244172): crash when trying to add extra domain while inspecting JSContext 2019-04-16 10:52:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 195971 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck keith_miller mark.lam msaboff saam sroberts webkit-bug-importer oldest_to_newest 1527313 0 hi 2019-04-15 12:06:17 -0700 . 1527314 1 hi 2019-04-15 12:06:36 -0700 <rdar://problem/49873994> 1527315 2 367439 hi 2019-04-15 12:10:16 -0700 Created attachment 367439 Patch 1527316 3 367439 joepeck 2019-04-15 12:12:20 -0700 Comment on attachment 367439 Patch r=me 1527366 4 367439 commit-queue 2019-04-15 13:29:36 -0700 Comment on attachment 367439 Patch Clearing flags on attachment: 367439 Committed r244285: <https://trac.webkit.org/changeset/244285> 1527367 5 commit-queue 2019-04-15 13:29:37 -0700 All reviewed patches have been landed. Closing bug. 1527767 6 sroberts 2019-04-16 10:45:22 -0700 After changes in https://trac.webkit.org/changeset/244285 http/tests/inspector/network/har/har-page.html is failing on WK2 Release and Debug builds. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html Was a flaky timeout/failure in previous revisions. Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt @@ -588,8 +588,7 @@ "path": "/", "expires": "", "httpOnly": false, - "secure": false, - "sameSite": "Strict" + "secure": false } ], "headers": "<filtered>", @@ -661,8 +660,7 @@ "path": "/", "expires": "", "httpOnly": false, - "secure": false, - "sameSite": "Strict" + "secure": false } ], "headers": "<filtered>", 1527771 7 sroberts 2019-04-16 10:52:38 -0700 Disregard last comment. I blamed the wrong revision. 367439 2019-04-15 12:10:16 -0700 2019-04-15 13:29:36 -0700 Patch bug-196925-20190415121015.patch text/plain 6007 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg0MWU3MjBiZDdhYmI5NWQ1Zjg3MzA2OTZlZDU3 MjVjYjEzZGYyNGEuLmQwMjc3NTc0ODk4NDIwMzNiYzlkZDJiYzU5NWJmNWU5MTU4NDdjYzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA0LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDQxNzIpOiBjcmFzaCB3aGVuIHRyeWluZyB0byBhZGQgZXh0cmEgZG9tYWlu IHdoaWxlIGluc3BlY3RpbmcgSlNDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY5MjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5ODcz OTk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1v dmUgdGhlIGxvZ2ljIGZvciBjcmVhdGluZyB0aGUgYEluc3BlY3RvckFnZW50YCBhbmQgYEluc3Bl Y3RvckRlYnVnZ2VyQWdlbnRgIGludG8gc2VwYXJhdGUKKyAgICAgICAgZnVuY3Rpb25zIHNvIHRo YXQgY2FsbGVycyBjYW4gYmUgZ3VhcmFudGVlZCB0byBoYXZlIGEgdmFsaWQgaW5zdGFuY2Ugb2Yg dGhlIGFnZW50LgorCisgICAgICAgICogaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9y Q29udHJvbGxlci5oOgorICAgICAgICAqIGluc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3Rv ckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3Bl Y3RvckNvbnRyb2xsZXI6OmNvbm5lY3RGcm9udGVuZCk6CisgICAgICAgIChJbnNwZWN0b3I6OkpT R2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6ZnJvbnRlbmRJbml0aWFsaXplZCk6Cisg ICAgICAgIChJbnNwZWN0b3I6OkpTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6YXBw ZW5kRXh0cmFBZ2VudCk6CisgICAgICAgIChJbnNwZWN0b3I6OkpTR2xvYmFsT2JqZWN0SW5zcGVj dG9yQ29udHJvbGxlcjo6ZW5zdXJlSW5zcGVjdG9yQWdlbnQpOiBBZGRlZC4KKyAgICAgICAgKElu c3BlY3Rvcjo6SlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyOjplbnN1cmVEZWJ1Z2dl ckFnZW50KTogQWRkZWQuCisgICAgICAgIChJbnNwZWN0b3I6OkpTR2xvYmFsT2JqZWN0SW5zcGVj dG9yQ29udHJvbGxlcjo6Y3JlYXRlTGF6eUFnZW50cyk6CisKIDIwMTktMDQtMTQgIERvbiBPbG1z dGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIEphdmFTY3Jp cHRDb3JlIGRlcml2ZWQgc291cmNlcyBzaG91bGQgb25seSBiZSByZWZlcmVuY2VkIGluc2lkZSBK YXZhU2NyaXB0Q29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCmlu ZGV4IDJiMzZkMGRkMjI0ZTUzYTg1ZjQ2MThiNGFmZGI2ZjYxNmY1MGY4NjAuLmM4ZGE1MmVmZDEz YzQ5MWNjYWU2Mzk1ZTA3NGM0NjQ0ZTcwY2MwYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVj dG9yQ29udHJvbGxlci5jcHAKQEAgLTExOCw4ICsxMTgsNyBAQCB2b2lkIEpTR2xvYmFsT2JqZWN0 SW5zcGVjdG9yQ29udHJvbGxlcjo6Y29ubmVjdEZyb250ZW5kKEZyb250ZW5kQ2hhbm5lbCYgZnJv bnRlbgogICAgIG1fYWdlbnRzLmRpZENyZWF0ZUZyb250ZW5kQW5kQmFja2VuZChudWxscHRyLCBu dWxscHRyKTsKIAogI2lmIEVOQUJMRShJTlNQRUNUT1JfQUxURVJOQVRFX0RJU1BBVENIRVJTKQot ICAgIEFTU0VSVChtX2luc3BlY3RvckFnZW50KTsKLSAgICBtX2luc3BlY3RvckFnZW50LT5hY3Rp dmF0ZUV4dHJhRG9tYWlucyhtX2FnZW50cy5leHRyYURvbWFpbnMoKSk7CisgICAgZW5zdXJlSW5z cGVjdG9yQWdlbnQoKS5hY3RpdmF0ZUV4dHJhRG9tYWlucyhtX2FnZW50cy5leHRyYURvbWFpbnMo KSk7CiAKICAgICBpZiAobV9hdWdtZW50aW5nQ2xpZW50KQogICAgICAgICBtX2F1Z21lbnRpbmdD bGllbnQtPmluc3BlY3RvckNvbm5lY3RlZCgpOwpAQCAtMjM3LDEwICsyMzYsOSBAQCB2b2lkIEpT R2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6ZnJvbnRlbmRJbml0aWFsaXplZCgpCiAg ICAgaWYgKG1fcGF1c2VBZnRlckluaXRpYWxpemF0aW9uKSB7CiAgICAgICAgIG1fcGF1c2VBZnRl ckluaXRpYWxpemF0aW9uID0gZmFsc2U7CiAKLSAgICAgICAgQVNTRVJUKG1fZGVidWdnZXJBZ2Vu dCk7CiAgICAgICAgIEVycm9yU3RyaW5nIGlnbm9yZWQ7Ci0gICAgICAgIG1fZGVidWdnZXJBZ2Vu dC0+ZW5hYmxlKGlnbm9yZWQpOwotICAgICAgICBtX2RlYnVnZ2VyQWdlbnQtPnBhdXNlKGlnbm9y ZWQpOworICAgICAgICBlbnN1cmVEZWJ1Z2dlckFnZW50KCkuZW5hYmxlKGlnbm9yZWQpOworICAg ICAgICBlbnN1cmVEZWJ1Z2dlckFnZW50KCkucGF1c2UoaWdub3JlZCk7CiAgICAgfQogCiAjaWYg RU5BQkxFKFJFTU9URV9JTlNQRUNUT1IpCkBAIC0yNzQsMTEgKzI3MiwzMyBAQCB2b2lkIEpTR2xv YmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6YXBwZW5kRXh0cmFBZ2VudChzdGQ6OnVuaXF1 ZV9wdHI8SW5zcGVjdAogCiAgICAgbV9hZ2VudHMuYXBwZW5kRXh0cmFBZ2VudChXVEZNb3ZlKGFn ZW50KSk7CiAKLSAgICBBU1NFUlQobV9pbnNwZWN0b3JBZ2VudCk7Ci0gICAgbV9pbnNwZWN0b3JB Z2VudC0+YWN0aXZhdGVFeHRyYURvbWFpbihkb21haW5OYW1lKTsKKyAgICBlbnN1cmVJbnNwZWN0 b3JBZ2VudCgpLmFjdGl2YXRlRXh0cmFEb21haW4oZG9tYWluTmFtZSk7CiB9CiAjZW5kaWYKIAor SW5zcGVjdG9yQWdlbnQmIEpTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6ZW5zdXJl SW5zcGVjdG9yQWdlbnQoKQoreworICAgIGlmICghbV9pbnNwZWN0b3JBZ2VudCkgeworICAgICAg ICBhdXRvIGNvbnRleHQgPSBqc0FnZW50Q29udGV4dCgpOworICAgICAgICBhdXRvIGluc3BlY3Rv ckFnZW50ID0gc3RkOjptYWtlX3VuaXF1ZTxJbnNwZWN0b3JBZ2VudD4oY29udGV4dCk7CisgICAg ICAgIG1faW5zcGVjdG9yQWdlbnQgPSBpbnNwZWN0b3JBZ2VudC5nZXQoKTsKKyAgICAgICAgbV9h Z2VudHMuYXBwZW5kKFdURk1vdmUoaW5zcGVjdG9yQWdlbnQpKTsKKyAgICB9CisgICAgcmV0dXJu ICptX2luc3BlY3RvckFnZW50OworfQorCitJbnNwZWN0b3JEZWJ1Z2dlckFnZW50JiBKU0dsb2Jh bE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmVuc3VyZURlYnVnZ2VyQWdlbnQoKQoreworICAg IGlmICghbV9kZWJ1Z2dlckFnZW50KSB7CisgICAgICAgIGF1dG8gY29udGV4dCA9IGpzQWdlbnRD b250ZXh0KCk7CisgICAgICAgIGF1dG8gZGVidWdnZXJBZ2VudCA9IHN0ZDo6bWFrZV91bmlxdWU8 SlNHbG9iYWxPYmplY3REZWJ1Z2dlckFnZW50Pihjb250ZXh0LCBtX2NvbnNvbGVBZ2VudCk7Cisg ICAgICAgIG1fZGVidWdnZXJBZ2VudCA9IGRlYnVnZ2VyQWdlbnQuZ2V0KCk7CisgICAgICAgIG1f Y29uc29sZUNsaWVudC0+c2V0SW5zcGVjdG9yRGVidWdnZXJBZ2VudChtX2RlYnVnZ2VyQWdlbnQp OworICAgICAgICBtX2FnZW50cy5hcHBlbmQoV1RGTW92ZShkZWJ1Z2dlckFnZW50KSk7CisgICAg fQorICAgIHJldHVybiAqbV9kZWJ1Z2dlckFnZW50OworfQorCiBKU0FnZW50Q29udGV4dCBKU0ds b2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmpzQWdlbnRDb250ZXh0KCkKIHsKICAgICBB Z2VudENvbnRleHQgYmFzZUNvbnRleHQgPSB7CkBAIC0zMDUsMTYgKzMyNSwxMSBAQCB2b2lkIEpT R2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6Y3JlYXRlTGF6eUFnZW50cygpCiAKICAg ICBhdXRvIGNvbnRleHQgPSBqc0FnZW50Q29udGV4dCgpOwogCi0gICAgYXV0byBpbnNwZWN0b3JB Z2VudCA9IHN0ZDo6bWFrZV91bmlxdWU8SW5zcGVjdG9yQWdlbnQ+KGNvbnRleHQpOwotICAgIG1f aW5zcGVjdG9yQWdlbnQgPSBpbnNwZWN0b3JBZ2VudC5nZXQoKTsKLSAgICBtX2FnZW50cy5hcHBl bmQoV1RGTW92ZShpbnNwZWN0b3JBZ2VudCkpOworICAgIGVuc3VyZUluc3BlY3RvckFnZW50KCk7 CiAKICAgICBtX2FnZW50cy5hcHBlbmQoc3RkOjptYWtlX3VuaXF1ZTxKU0dsb2JhbE9iamVjdFJ1 bnRpbWVBZ2VudD4oY29udGV4dCkpOwogCi0gICAgYXV0byBkZWJ1Z2dlckFnZW50ID0gc3RkOjpt YWtlX3VuaXF1ZTxKU0dsb2JhbE9iamVjdERlYnVnZ2VyQWdlbnQ+KGNvbnRleHQsIG1fY29uc29s ZUFnZW50KTsKLSAgICBtX2RlYnVnZ2VyQWdlbnQgPSBkZWJ1Z2dlckFnZW50LmdldCgpOwotICAg IG1fY29uc29sZUNsaWVudC0+c2V0SW5zcGVjdG9yRGVidWdnZXJBZ2VudChtX2RlYnVnZ2VyQWdl bnQpOwotICAgIG1fYWdlbnRzLmFwcGVuZChXVEZNb3ZlKGRlYnVnZ2VyQWdlbnQpKTsKKyAgICBl bnN1cmVEZWJ1Z2dlckFnZW50KCk7CiAKICAgICBhdXRvIHNjcmlwdFByb2ZpbGVyQWdlbnRQdHIg PSBzdGQ6Om1ha2VfdW5pcXVlPEluc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQ+KGNvbnRleHQp OwogICAgIG1fY29uc29sZUNsaWVudC0+c2V0SW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudChz Y3JpcHRQcm9maWxlckFnZW50UHRyLmdldCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29u dHJvbGxlci5oCmluZGV4IDFhYTA1YjVkMTg2M2ZkMjlhNjRiMGYyNTMwOWYzNzNhZmI2NDk3ODYu LmYwZmZjNDVkZDlmYTZjZGY2MTdmMDM4MWU0NmY4ZGNlYmZlZjNjOGMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250 cm9sbGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9i amVjdEluc3BlY3RvckNvbnRyb2xsZXIuaApAQCAtMTA0LDYgKzEwNCw5IEBAIHB1YmxpYzoKIHBy aXZhdGU6CiAgICAgdm9pZCBhcHBlbmRBUElCYWNrdHJhY2UoU2NyaXB0Q2FsbFN0YWNrJik7CiAK KyAgICBJbnNwZWN0b3JBZ2VudCYgZW5zdXJlSW5zcGVjdG9yQWdlbnQoKTsKKyAgICBJbnNwZWN0 b3JEZWJ1Z2dlckFnZW50JiBlbnN1cmVEZWJ1Z2dlckFnZW50KCk7CisKICAgICBKU0FnZW50Q29u dGV4dCBqc0FnZW50Q29udGV4dCgpOwogICAgIHZvaWQgY3JlYXRlTGF6eUFnZW50cygpOwogCkBA IC0xMTQsOCArMTE3LDEwIEBAIHByaXZhdGU6CiAgICAgSlNHbG9iYWxPYmplY3RTY3JpcHREZWJ1 Z1NlcnZlciBtX3NjcmlwdERlYnVnU2VydmVyOwogCiAgICAgQWdlbnRSZWdpc3RyeSBtX2FnZW50 czsKLSAgICBJbnNwZWN0b3JBZ2VudCogbV9pbnNwZWN0b3JBZ2VudCB7IG51bGxwdHIgfTsKICAg ICBJbnNwZWN0b3JDb25zb2xlQWdlbnQqIG1fY29uc29sZUFnZW50IHsgbnVsbHB0ciB9OworCisg ICAgLy8gTGF6eSwgYnV0IGFsc28gb24tZGVtYW5kIGFnZW50cy4KKyAgICBJbnNwZWN0b3JBZ2Vu dCogbV9pbnNwZWN0b3JBZ2VudCB7IG51bGxwdHIgfTsKICAgICBJbnNwZWN0b3JEZWJ1Z2dlckFn ZW50KiBtX2RlYnVnZ2VyQWdlbnQgeyBudWxscHRyIH07CiAKICAgICBSZWY8RnJvbnRlbmRSb3V0 ZXI+IG1fZnJvbnRlbmRSb3V0ZXI7Cg==