196922 2019-04-15 11:40:33 -0700 [WTF] holdLock should be marked WARN_UNUSED_RETURN 2019-04-16 12:51:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset benjamin cdumez cmarcelo commit-queue dbates ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1527288 0 rmorisset 2019-04-15 11:40:33 -0700 simply to catch cases where someone forgets to use the proper idiom auto locker = holdLock(lock); 1527289 1 367434 rmorisset 2019-04-15 11:43:23 -0700 Created attachment 367434 Patch 1527292 2 ews-watchlist 2019-04-15 11:47:21 -0700 Attachment 367434 did not pass style-queue: ERROR: Source/WTF/wtf/Locker.h:123: The parameter name "lock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/Locker.h:131: The parameter name "lock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/Locker.h:139: The parameter name "lock" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1527506 3 367476 rmorisset 2019-04-15 16:27:21 -0700 Created attachment 367476 Patch Just fix the trivial style nits. 1527517 4 367476 keith_miller 2019-04-15 16:53:05 -0700 Comment on attachment 367476 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367476&action=review r=me > Source/JavaScriptCore/heap/BlockDirectory.cpp:66 > + // FIXME: should we instead do a cheaper thing like a volatile load in the page? Wow, that’s weird. What’s this function used for? 1527817 5 rmorisset 2019-04-16 12:20:06 -0700 (In reply to Keith Miller from comment #4) > Comment on attachment 367476 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367476&action=review > > r=me > > > Source/JavaScriptCore/heap/BlockDirectory.cpp:66 > > + // FIXME: should we instead do a cheaper thing like a volatile load in the page? > > Wow, that’s weird. What’s this function used for? It is used for cancelling the full GC when any part of the heap is paged out. 1527824 6 367476 commit-queue 2019-04-16 12:46:33 -0700 Comment on attachment 367476 Patch Clearing flags on attachment: 367476 Committed r244352: <https://trac.webkit.org/changeset/244352> 1527825 7 commit-queue 2019-04-16 12:46:35 -0700 All reviewed patches have been landed. Closing bug. 1527829 8 webkit-bug-importer 2019-04-16 12:51:12 -0700 <rdar://problem/49950528> 367434 2019-04-15 11:43:23 -0700 2019-04-15 16:27:21 -0700 Patch file_196922.txt text/plain 3638 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQyNzQpDQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQ0KQEAgLTEsMyArMSwx NyBAQA0KKzIwMTktMDQtMTUgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4N CisNCisgICAgICAgIFtXVEZdIGhvbGRMb2NrIHNob3VsZCBiZSBtYXJrZWQgV0FSTl9VTlVTRURf UkVUVVJODQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk2OTIyDQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAg ICAgIFRoZXJlIHdhcyBvbmUgY2FzZSB3aGVyZSBob2xkTG9jayB3YXMgdXNlZCBhbmQgdGhlIHJl c3VsdCBpZ25vcmVkLg0KKyAgICAgICAgRnJvbSBhIGNvbW1lbnQgdGhhdCB3YXMgZGVsZXRlZCBp biBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9hdHRhY2htZW50LmNnaT9pZD0zMjg0MzgmYWN0aW9u PXByZXR0eXBhdGNoLCBJIGJlbGlldmUgdGhhdCBpdCBpcyBvbiBwdXJwb3NlLg0KKyAgICAgICAg U28gSSBicm91Z2h0IGJhY2sgYSB2YXJpYW50IG9mIHRoZSBjb21tZW50LCBhbmQgbWFkZSB0aGUg aWdub3Jpbmcgb2YgdGhlIHJldHVybiBleHBsaWNpdC4NCisNCisgICAgICAgICogaGVhcC9CbG9j a0RpcmVjdG9yeS5jcHA6DQorICAgICAgICAoSlNDOjpCbG9ja0RpcmVjdG9yeTo6aXNQYWdlZE91 dCk6DQorDQogMjAxOS0wNC0xNCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t Pg0KIA0KICAgICAgICAgW0NNYWtlXSBKYXZhU2NyaXB0Q29yZSBkZXJpdmVkIHNvdXJjZXMgc2hv dWxkIG9ubHkgYmUgcmVmZXJlbmNlZCBpbnNpZGUgSmF2YVNjcmlwdENvcmUNCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0RpcmVjdG9yeS5jcHANCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0RpcmVjdG9yeS5jcHAJKHJldmlzaW9u IDI0NDI3MSkNCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9CbG9ja0RpcmVjdG9yeS5j cHAJKHdvcmtpbmcgY29weSkNCkBAIC02MSw4ICs2MSwxMSBAQA0KIHsNCiAgICAgdW5zaWduZWQg aXRlcnNTaW5jZUxhc3RUaW1lQ2hlY2sgPSAwOw0KICAgICBmb3IgKGF1dG8qIGJsb2NrIDogbV9i bG9ja3MpIHsNCi0gICAgICAgIGlmIChibG9jaykNCi0gICAgICAgICAgICBob2xkTG9jayhibG9j ay0+YmxvY2soKS5sb2NrKCkpOw0KKyAgICAgICAgaWYgKGJsb2NrKSB7DQorICAgICAgICAgICAg Ly8gV2UgdGFrZSBhbmQgZHJvcCB0aGUgbG9jayBhcyBhIHdheSBvZiB0b3VjaGluZyB0aGF0IHBh Z2Ugb2YgbWVtb3J5Lg0KKyAgICAgICAgICAgIC8vIEZJWE1FOiBzaG91bGQgd2UgaW5zdGVhZCBk byBhIGNoZWFwZXIgdGhpbmcgbGlrZSBhIHZvbGF0aWxlIGxvYWQgaW4gdGhlIHBhZ2U/DQorICAg ICAgICAgICAgKHZvaWQpIGhvbGRMb2NrKGJsb2NrLT5ibG9jaygpLmxvY2soKSk7DQorICAgICAg ICB9DQogICAgICAgICArK2l0ZXJzU2luY2VMYXN0VGltZUNoZWNrOw0KICAgICAgICAgaWYgKGl0 ZXJzU2luY2VMYXN0VGltZUNoZWNrID49IEhlYXA6OnNfdGltZUNoZWNrUmVzb2x1dGlvbikgew0K ICAgICAgICAgICAgIE1vbm90b25pY1RpbWUgY3VycmVudFRpbWUgPSBNb25vdG9uaWNUaW1lOjpu b3coKTsNCkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFNvdXJj ZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQyNzEpDQorKysgU291cmNlL1dURi9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkNCkBAIC0xLDMgKzEsMTIgQEANCisyMDE5LTA0LTE1ICBSb2JpbiBN b3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+DQorDQorICAgICAgICBbV1RGXSBob2xkTG9j ayBzaG91bGQgYmUgbWFya2VkIFdBUk5fVU5VU0VEX1JFVFVSTg0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjkyMg0KKw0KKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICAqIHd0Zi9Mb2NrZXIuaDoNCisNCiAy MDE5LTA0LTEyICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPg0KIA0KICAg ICAgICAgVXBkYXRlIEF1ZGlvU2Vzc2lvbiByb3V0ZSBzaGFyaW5nIHBvbGljeQ0KSW5kZXg6IFNv dXJjZS9XVEYvd3RmL0xvY2tlci5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291cmNlL1dURi93dGYvTG9j a2VyLmgJKHJldmlzaW9uIDI0NDI3MSkNCisrKyBTb3VyY2UvV1RGL3d0Zi9Mb2NrZXIuaAkod29y a2luZyBjb3B5KQ0KQEAgLTMwLDYgKzMwLDcgQEANCiANCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlv bnMuaD4NCiAjaW5jbHVkZSA8d3RmL0F0b21pY3MuaD4NCisjaW5jbHVkZSA8d3RmL0NvbXBpbGVy Lmg+DQogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPg0KIA0KIG5hbWVzcGFjZSBXVEYgew0K QEAgLTExOSw2ICsxMjAsOCBAQA0KIC8vIFVzZSB0aGlzIGxvY2sgc2NvcGUgbGlrZSBzbzoNCiAv LyBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKGxvY2spOw0KIHRlbXBsYXRlPHR5cGVuYW1lIExvY2tU eXBlPg0KK0xvY2tlcjxMb2NrVHlwZT4gaG9sZExvY2soTG9ja1R5cGUmIGxvY2spIFdBUk5fVU5V U0VEX1JFVFVSTjsNCit0ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4NCiBMb2NrZXI8TG9ja1R5 cGU+IGhvbGRMb2NrKExvY2tUeXBlJiBsb2NrKQ0KIHsNCiAgICAgcmV0dXJuIExvY2tlcjxMb2Nr VHlwZT4obG9jayk7DQpAQCAtMTI1LDYgKzEyOCw4IEBADQogfQ0KIA0KIHRlbXBsYXRlPHR5cGVu YW1lIExvY2tUeXBlPg0KK0xvY2tlcjxMb2NrVHlwZT4gaG9sZExvY2tJZihMb2NrVHlwZSYgbG9j aywgYm9vbCBwcmVkaWNhdGUpIFdBUk5fVU5VU0VEX1JFVFVSTjsNCit0ZW1wbGF0ZTx0eXBlbmFt ZSBMb2NrVHlwZT4NCiBMb2NrZXI8TG9ja1R5cGU+IGhvbGRMb2NrSWYoTG9ja1R5cGUmIGxvY2ss IGJvb2wgcHJlZGljYXRlKQ0KIHsNCiAgICAgcmV0dXJuIExvY2tlcjxMb2NrVHlwZT4ocHJlZGlj YXRlID8gJmxvY2sgOiBudWxscHRyKTsNCkBAIC0xMzEsNiArMTM2LDggQEANCiB9DQogDQogdGVt cGxhdGU8dHlwZW5hbWUgTG9ja1R5cGU+DQorTG9ja2VyPExvY2tUeXBlPiB0cnlIb2xkTG9jayhM b2NrVHlwZSYgbG9jaykgV0FSTl9VTlVTRURfUkVUVVJOOw0KK3RlbXBsYXRlPHR5cGVuYW1lIExv Y2tUeXBlPg0KIExvY2tlcjxMb2NrVHlwZT4gdHJ5SG9sZExvY2soTG9ja1R5cGUmIGxvY2spDQog ew0KICAgICByZXR1cm4gTG9ja2VyPExvY2tUeXBlPjo6dHJ5TG9jayhsb2NrKTs= 367476 2019-04-15 16:27:21 -0700 2019-04-16 12:46:33 -0700 Patch patch196922 text/plain 3529 rmorisset SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjQ0Mjc0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE5LTA0LTE1ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAg ICAgICAgW1dURl0gaG9sZExvY2sgc2hvdWxkIGJlIG1hcmtlZCBXQVJOX1VOVVNFRF9SRVRVUk4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjkyMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHdh cyBvbmUgY2FzZSB3aGVyZSBob2xkTG9jayB3YXMgdXNlZCBhbmQgdGhlIHJlc3VsdCBpZ25vcmVk LgorICAgICAgICBGcm9tIGEgY29tbWVudCB0aGF0IHdhcyBkZWxldGVkIGluIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL2F0dGFjaG1lbnQuY2dpP2lkPTMyODQzOCZhY3Rpb249cHJldHR5cGF0Y2gs IEkgYmVsaWV2ZSB0aGF0IGl0IGlzIG9uIHB1cnBvc2UuCisgICAgICAgIFNvIEkgYnJvdWdodCBi YWNrIGEgdmFyaWFudCBvZiB0aGUgY29tbWVudCwgYW5kIG1hZGUgdGhlIGlnbm9yaW5nIG9mIHRo ZSByZXR1cm4gZXhwbGljaXQuCisKKyAgICAgICAgKiBoZWFwL0Jsb2NrRGlyZWN0b3J5LmNwcDoK KyAgICAgICAgKEpTQzo6QmxvY2tEaXJlY3Rvcnk6OmlzUGFnZWRPdXQpOgorCiAyMDE5LTA0LTE0 ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtl XSBKYXZhU2NyaXB0Q29yZSBkZXJpdmVkIHNvdXJjZXMgc2hvdWxkIG9ubHkgYmUgcmVmZXJlbmNl ZCBpbnNpZGUgSmF2YVNjcmlwdENvcmUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L0Jsb2NrRGlyZWN0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9CbG9ja0RpcmVjdG9yeS5jcHAJKHJldmlzaW9uIDI0NDI3MSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0Jsb2NrRGlyZWN0b3J5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjEs OCArNjEsMTEgQEAKIHsKICAgICB1bnNpZ25lZCBpdGVyc1NpbmNlTGFzdFRpbWVDaGVjayA9IDA7 CiAgICAgZm9yIChhdXRvKiBibG9jayA6IG1fYmxvY2tzKSB7Ci0gICAgICAgIGlmIChibG9jaykK LSAgICAgICAgICAgIGhvbGRMb2NrKGJsb2NrLT5ibG9jaygpLmxvY2soKSk7CisgICAgICAgIGlm IChibG9jaykgeworICAgICAgICAgICAgLy8gV2UgdGFrZSBhbmQgZHJvcCB0aGUgbG9jayBhcyBh IHdheSBvZiB0b3VjaGluZyB0aGF0IHBhZ2Ugb2YgbWVtb3J5LgorICAgICAgICAgICAgLy8gRklY TUU6IHNob3VsZCB3ZSBpbnN0ZWFkIGRvIGEgY2hlYXBlciB0aGluZyBsaWtlIGEgdm9sYXRpbGUg bG9hZCBpbiB0aGUgcGFnZT8KKyAgICAgICAgICAgICh2b2lkKSBob2xkTG9jayhibG9jay0+Ymxv Y2soKS5sb2NrKCkpOworICAgICAgICB9CiAgICAgICAgICsraXRlcnNTaW5jZUxhc3RUaW1lQ2hl Y2s7CiAgICAgICAgIGlmIChpdGVyc1NpbmNlTGFzdFRpbWVDaGVjayA+PSBIZWFwOjpzX3RpbWVD aGVja1Jlc29sdXRpb24pIHsKICAgICAgICAgICAgIE1vbm90b25pY1RpbWUgY3VycmVudFRpbWUg PSBNb25vdG9uaWNUaW1lOjpub3coKTsKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQyNzEpCisrKyBTb3Vy Y2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA0 LTE1ICBSb2JpbiBNb3Jpc3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CisKKyAgICAgICAgW1dU Rl0gaG9sZExvY2sgc2hvdWxkIGJlIG1hcmtlZCBXQVJOX1VOVVNFRF9SRVRVUk4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjkyMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0xvY2tlci5oOgor CiAyMDE5LTA0LTEyICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIFVwZGF0ZSBBdWRpb1Nlc3Npb24gcm91dGUgc2hhcmluZyBwb2xpY3kKSW5kZXg6IFNv dXJjZS9XVEYvd3RmL0xvY2tlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0xvY2tl ci5oCShyZXZpc2lvbiAyNDQyNzEpCisrKyBTb3VyY2UvV1RGL3d0Zi9Mb2NrZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzAsNiArMzAsNyBAQAogCiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4K ICNpbmNsdWRlIDx3dGYvQXRvbWljcy5oPgorI2luY2x1ZGUgPHd0Zi9Db21waWxlci5oPgogI2lu Y2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogCiBuYW1lc3BhY2UgV1RGIHsKQEAgLTExOSw2ICsx MjAsOCBAQAogLy8gVXNlIHRoaXMgbG9jayBzY29wZSBsaWtlIHNvOgogLy8gYXV0byBsb2NrZXIg PSBob2xkTG9jayhsb2NrKTsKIHRlbXBsYXRlPHR5cGVuYW1lIExvY2tUeXBlPgorTG9ja2VyPExv Y2tUeXBlPiBob2xkTG9jayhMb2NrVHlwZSYpIFdBUk5fVU5VU0VEX1JFVFVSTjsKK3RlbXBsYXRl PHR5cGVuYW1lIExvY2tUeXBlPgogTG9ja2VyPExvY2tUeXBlPiBob2xkTG9jayhMb2NrVHlwZSYg bG9jaykKIHsKICAgICByZXR1cm4gTG9ja2VyPExvY2tUeXBlPihsb2NrKTsKQEAgLTEyNSw2ICsx MjgsOCBAQAogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4KK0xvY2tlcjxMb2NrVHlw ZT4gaG9sZExvY2tJZihMb2NrVHlwZSYsIGJvb2wgcHJlZGljYXRlKSBXQVJOX1VOVVNFRF9SRVRV Uk47Cit0ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4KIExvY2tlcjxMb2NrVHlwZT4gaG9sZExv Y2tJZihMb2NrVHlwZSYgbG9jaywgYm9vbCBwcmVkaWNhdGUpCiB7CiAgICAgcmV0dXJuIExvY2tl cjxMb2NrVHlwZT4ocHJlZGljYXRlID8gJmxvY2sgOiBudWxscHRyKTsKQEAgLTEzMSw2ICsxMzYs OCBAQAogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBMb2NrVHlwZT4KK0xvY2tlcjxMb2NrVHlwZT4g dHJ5SG9sZExvY2soTG9ja1R5cGUmKSBXQVJOX1VOVVNFRF9SRVRVUk47Cit0ZW1wbGF0ZTx0eXBl bmFtZSBMb2NrVHlwZT4KIExvY2tlcjxMb2NrVHlwZT4gdHJ5SG9sZExvY2soTG9ja1R5cGUmIGxv Y2spCiB7CiAgICAgcmV0dXJuIExvY2tlcjxMb2NrVHlwZT46OnRyeUxvY2sobG9jayk7Cg==