196920 2019-04-15 11:31:44 -0700 Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears 2019-04-15 12:57:06 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 196888 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1527277 0 hi 2019-04-15 11:31:44 -0700 # STEPS TO REPRODUCE: 1. inspect any page with a <canvas> 2. go to the Canvas tab 3. click on one of the <canvas> cards => navigation sidebar does not show (and the button to toggle it is disabled) 1527278 1 webkit-bug-importer 2019-04-15 11:31:57 -0700 <rdar://problem/49910618> 1527286 2 367432 hi 2019-04-15 11:37:01 -0700 Created attachment 367432 Patch 1527287 3 367433 hi 2019-04-15 11:39:53 -0700 Created attachment 367433 Patch 1527322 4 367433 timothy 2019-04-15 12:30:53 -0700 Comment on attachment 367433 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367433&action=review > Source/WebInspectorUI/ChangeLog:12 > + Now that we no longer call `addSubview` when adding a sidebar panel, we can't check to see > + if `parentSidebar` has been set, as that is just an alias for `parentView`. Told you it would cause regressions. :) Maybe parentSidebar should change, since the Sidebar still holds it and shows it in the navigation bar. 1527338 5 367433 commit-queue 2019-04-15 12:57:04 -0700 Comment on attachment 367433 Patch Clearing flags on attachment: 367433 Committed r244282: <https://trac.webkit.org/changeset/244282> 1527339 6 commit-queue 2019-04-15 12:57:06 -0700 All reviewed patches have been landed. Closing bug. 367432 2019-04-15 11:37:01 -0700 2019-04-15 11:39:52 -0700 Patch bug-196920-20190415113700.patch text/plain 2416 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ5N2U4MTY0YjBjNTVmOGQxNjg3NmM3ODNhNTQw NDg0Y2M3NWRkYzYuLmY2OWViMzk5YThlOTZhZjhiNTdmOTBjOGIzMWYxMWJjMzQzNWM2ZTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDQyNjgpOiBDYW52YXM6IG5hdmlnYXRpb24gc2lkZWJhciBubyBsb25nZXIg YXBwZWFycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk2OTIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTkxMDYxOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv Q29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkNvbnRlbnRCcm93 c2VyVGFiQ29udGVudFZpZXcucHJvdG90eXBlLnNob3dOYXZpZ2F0aW9uU2lkZWJhclBhbmVsKToK KyAgICAgICAgTm93IHRoYXQgd2Ugbm8gbG9uZ2VyIGNhbGwgYGFkZFN1YnZpZXdgIHdoZW4gYWRk aW5nIGEgc2lkZWJhciBwYW5lbCwgd2UgY2FuJ3QgY2hlY2sgdG8gc2VlCisgICAgICAgIGlmIGBw YXJlbnRTaWRlYmFyYCBoYXMgYmVlbiBzZXQsIGFzIHRoYXQgaXMganVzdCBhbiBhbGlhcyBmb3Ig YHBhcmVudFZpZXdgLgorCiAyMDE5LTA0LTE1ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb246IG51bGwg aXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LnJl dmVhbCcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qcwpp bmRleCBkYWMxYmNkYWI5OTU4YjU0OGMxMmQyZDk5NTFhNjRlZmJjMzZhOWRkLi5mYzk3YmVmNjRh Mzk3MGNiMGQzZjFhY2NhMTdjYzY2YjllNGNjYmU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRl bnRCcm93c2VyVGFiQ29udGVudFZpZXcuanMKQEAgLTE1NCwxNCArMTU0LDEyIEBAIFdJLkNvbnRl bnRCcm93c2VyVGFiQ29udGVudFZpZXcgPSBjbGFzcyBDb250ZW50QnJvd3NlclRhYkNvbnRlbnRW aWV3IGV4dGVuZHMgV0kuCiAgICAgICAgIGlmIChzaG91bGRTaG93U2lkZWJhcikgewogICAgICAg ICAgICAgaWYgKCF0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcikKICAg ICAgICAgICAgICAgICBXSS5uYXZpZ2F0aW9uU2lkZWJhci5hZGRTaWRlYmFyUGFuZWwodGhpcy5u YXZpZ2F0aW9uU2lkZWJhclBhbmVsKTsKLSAgICAgICAgfSBlbHNlIGlmICh0aGlzLm5hdmlnYXRp b25TaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcikKLSAgICAgICAgICAgIFdJLm5hdmlnYXRpb25T aWRlYmFyLnJlbW92ZVNpZGViYXJQYW5lbCh0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwpOwot Ci0gICAgICAgIGlmICh0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcikg ewogICAgICAgICAgICAgV0kubmF2aWdhdGlvblNpZGViYXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWwg PSB0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWw7CiAgICAgICAgICAgICBXSS5uYXZpZ2F0aW9u U2lkZWJhci5jb2xsYXBzZWQgPSB0aGlzLm5hdmlnYXRpb25TaWRlYmFyQ29sbGFwc2VkU2V0dGlu Zy52YWx1ZTsKLSAgICAgICAgfSBlbHNlCisgICAgICAgIH0gZWxzZSBpZiAodGhpcy5uYXZpZ2F0 aW9uU2lkZWJhclBhbmVsLnBhcmVudFNpZGViYXIpIHsKICAgICAgICAgICAgIFdJLm5hdmlnYXRp b25TaWRlYmFyLmNvbGxhcHNlZCA9IHRydWU7CisgICAgICAgICAgICBXSS5uYXZpZ2F0aW9uU2lk ZWJhci5yZW1vdmVTaWRlYmFyUGFuZWwodGhpcy5uYXZpZ2F0aW9uU2lkZWJhclBhbmVsKTsKKyAg ICAgICAgfQogCiAgICAgICAgIHRoaXMuX2lnbm9yZU5hdmlnYXRpb25TaWRlYmFyUGFuZWxDb2xs YXBzZWRFdmVudCA9IGZhbHNlOwogCg== 367433 2019-04-15 11:39:53 -0700 2019-04-15 12:57:04 -0700 Patch bug-196920-20190415113953.patch text/plain 2433 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ5N2U4MTY0YjBjNTVmOGQxNjg3NmM3ODNhNTQw NDg0Y2M3NWRkYzYuLmY2OWViMzk5YThlOTZhZjhiNTdmOTBjOGIzMWYxMWJjMzQzNWM2ZTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDQyNjgpOiBDYW52YXM6IG5hdmlnYXRpb24gc2lkZWJhciBubyBsb25nZXIg YXBwZWFycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTk2OTIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTkxMDYxOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3Mv Q29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkNvbnRlbnRCcm93 c2VyVGFiQ29udGVudFZpZXcucHJvdG90eXBlLnNob3dOYXZpZ2F0aW9uU2lkZWJhclBhbmVsKToK KyAgICAgICAgTm93IHRoYXQgd2Ugbm8gbG9uZ2VyIGNhbGwgYGFkZFN1YnZpZXdgIHdoZW4gYWRk aW5nIGEgc2lkZWJhciBwYW5lbCwgd2UgY2FuJ3QgY2hlY2sgdG8gc2VlCisgICAgICAgIGlmIGBw YXJlbnRTaWRlYmFyYCBoYXMgYmVlbiBzZXQsIGFzIHRoYXQgaXMganVzdCBhbiBhbGlhcyBmb3Ig YHBhcmVudFZpZXdgLgorCiAyMDE5LTA0LTE1ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb246IG51bGwg aXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5zZWxlY3RlZFRyZWVFbGVtZW50LnJl dmVhbCcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudEJyb3dzZXJUYWJDb250ZW50Vmlldy5qcwpp bmRleCBkYWMxYmNkYWI5OTU4YjU0OGMxMmQyZDk5NTFhNjRlZmJjMzZhOWRkLi41NGFjYWFmNmQ3 ZDBlMGJjNzk0MTQ3MDVkMDM1YjhhYjE2MjZiNDUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50QnJvd3NlclRhYkNvbnRlbnRWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRl bnRCcm93c2VyVGFiQ29udGVudFZpZXcuanMKQEAgLTE1NCwxNCArMTU0LDEzIEBAIFdJLkNvbnRl bnRCcm93c2VyVGFiQ29udGVudFZpZXcgPSBjbGFzcyBDb250ZW50QnJvd3NlclRhYkNvbnRlbnRW aWV3IGV4dGVuZHMgV0kuCiAgICAgICAgIGlmIChzaG91bGRTaG93U2lkZWJhcikgewogICAgICAg ICAgICAgaWYgKCF0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcikKICAg ICAgICAgICAgICAgICBXSS5uYXZpZ2F0aW9uU2lkZWJhci5hZGRTaWRlYmFyUGFuZWwodGhpcy5u YXZpZ2F0aW9uU2lkZWJhclBhbmVsKTsKLSAgICAgICAgfSBlbHNlIGlmICh0aGlzLm5hdmlnYXRp b25TaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcikKLSAgICAgICAgICAgIFdJLm5hdmlnYXRpb25T aWRlYmFyLnJlbW92ZVNpZGViYXJQYW5lbCh0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwpOwot Ci0gICAgICAgIGlmICh0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWwucGFyZW50U2lkZWJhcikg ewogICAgICAgICAgICAgV0kubmF2aWdhdGlvblNpZGViYXIuc2VsZWN0ZWRTaWRlYmFyUGFuZWwg PSB0aGlzLm5hdmlnYXRpb25TaWRlYmFyUGFuZWw7CiAgICAgICAgICAgICBXSS5uYXZpZ2F0aW9u U2lkZWJhci5jb2xsYXBzZWQgPSB0aGlzLm5hdmlnYXRpb25TaWRlYmFyQ29sbGFwc2VkU2V0dGlu Zy52YWx1ZTsKLSAgICAgICAgfSBlbHNlCisgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBX SS5uYXZpZ2F0aW9uU2lkZWJhci5jb2xsYXBzZWQgPSB0cnVlOworICAgICAgICAgICAgaWYgKHRo aXMubmF2aWdhdGlvblNpZGViYXJQYW5lbC5wYXJlbnRTaWRlYmFyKQorICAgICAgICAgICAgICAg IFdJLm5hdmlnYXRpb25TaWRlYmFyLnJlbW92ZVNpZGViYXJQYW5lbCh0aGlzLm5hdmlnYXRpb25T aWRlYmFyUGFuZWwpOworICAgICAgICB9CiAKICAgICAgICAgdGhpcy5faWdub3JlTmF2aWdhdGlv blNpZGViYXJQYW5lbENvbGxhcHNlZEV2ZW50ID0gZmFsc2U7CiAK