196912 2019-04-15 08:24:54 -0700 [GTK] fix gtk_style_context_set_background deprecation 2019-04-22 09:31:48 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=197156 P2 Normal --- 1 ludovico.denittis webkit-unassigned berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro pnormand oldest_to_newest 1527172 0 ludovico.denittis 2019-04-15 08:24:54 -0700 Since gtk 3.18 gtk_style_context_set_background has been deprecated[1]. gtk_render_background should be used instead. gtk_style_context_set_background is still used in "Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp". In a few minutes I'm going to attach a patch to this issue. [1] https://developer.gnome.org/gtk3/stable/GtkStyleContext.html#gtk-style-context-set-background 1527174 1 367416 ludovico.denittis 2019-04-15 08:31:52 -0700 Created attachment 367416 Patch 1527175 2 ews-watchlist 2019-04-15 08:33:20 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1527242 3 367416 mcatanzaro 2019-04-15 10:48:15 -0700 Comment on attachment 367416 Patch This looks correct to me. Could you test webkit_web_view_set_background_color(), please? Especially with transparent background. 1527641 4 ludovico.denittis 2019-04-16 00:25:20 -0700 I tried to launch it with the bg-color option, e.g. `/Tools/Scripts/webkit-flatpak --gtk --bg-color="rgba(200,10,10,0)"` I was not sure how to test it though. In the fraction of a second before the webpage was loaded I saw that the background was indeed transparent. Then I tried to increase the alpha value and I got a colored background. 1527732 5 pnormand 2019-04-16 08:00:58 -0700 Can you try with Tools/Scripts/run-minibrowser --gtk --bg-color=rgba(....) ? run-minibrowser should invoke the built MiniBrowser in the Flatpak environment. 1527734 6 ludovico.denittis 2019-04-16 08:25:55 -0700 Philippe, yes I'm able to open the MiniBrowser even with webkit-flatpak. What I meant when I said that I wasn't sure how to test my changes, is that the chosen background color is visible only for a few ms before the webpage gets loaded on top of it. And I was unable to find another place where I could see the chosen background color. For example a blank you tab is always white. Is that how it is supposed to be? 1528032 7 ludovico.denittis 2019-04-16 23:32:59 -0700 s/blank you tab/blank new tab 1529213 8 367416 cgarcia 2019-04-22 03:53:32 -0700 Comment on attachment 367416 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367416&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:-387 > - gtk_style_context_set_background(gtk_widget_get_style_context(widget), window); > - Actually, I think this is no longer needed since we don't render backgrounds in the UI process. I think we can simply remove this without adding the render_background. 1529215 9 cgarcia 2019-04-22 03:55:51 -0700 (In reply to Ludovico de Nittis from comment #4) > I tried to launch it with the bg-color option, e.g. > `/Tools/Scripts/webkit-flatpak --gtk --bg-color="rgba(200,10,10,0)"` > > I was not sure how to test it though. > In the fraction of a second before the webpage was loaded I saw that the > background was indeed transparent. > Then I tried to increase the alpha value and I got a colored background. You can use the MiniBrowser editor mode (-e) to try it out. You can also try with any page not setting a background color in the css, as simple as <html></html> for example. But you have to load MiniBrowser without arguments and then load the test page (for some reason I don't remember the background color is not set when MiniBrowser receives arguments). 1529226 10 367936 ludovico.denittis 2019-04-22 05:18:59 -0700 Created attachment 367936 Patch 1529227 11 ludovico.denittis 2019-04-22 05:21:32 -0700 Carlos I tested it again and you are right, the background is available even without the gtk_render_background. So I uploaded a new patch, this time that just removes gtk_style_context_set_background. 1529269 12 367936 commit-queue 2019-04-22 09:31:46 -0700 Comment on attachment 367936 Patch Clearing flags on attachment: 367936 Committed r244500: <https://trac.webkit.org/changeset/244500> 1529270 13 commit-queue 2019-04-22 09:31:48 -0700 All reviewed patches have been landed. Closing bug. 367416 2019-04-15 08:31:52 -0700 2019-04-22 05:18:53 -0700 Patch bug-196912-20190415173155.patch text/plain 2046 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzZjk2Mzg1NmMyZDVmYjdk YjI3OWQxZjU1NjcyMDc1YWVkOTQ4ZmYuLmJiYzIyNWU0YWE4ZjlhM2I1ZmM2YWE3Y2E2M2FhMDE0 MTU1YWYzYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMTUgIEx1ZG92aWNv IGRlIE5pdHRpcyAgPGx1ZG92aWNvLmRlbml0dGlzQGNvbGxhYm9yYS5jb20+CisKKyAgICAgICAg W0dUS10gZml4IGd0a19zdHlsZV9jb250ZXh0X3NldF9iYWNrZ3JvdW5kIGRlcHJlY2F0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY5MTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBndGsg My4xOCBndGtfc3R5bGVfY29udGV4dF9zZXRfYmFja2dyb3VuZCBoYXMgYmVlbiBkZXByZWNhdGVk LAorICAgICAgICBndGtfcmVuZGVyX2JhY2tncm91bmQgc2hvdWxkIGJlIHVzZWQgaW5zdGVhZC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAg ICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlUmVhbGl6ZSk6CisgICAgICAgICh3ZWJraXRXZWJWaWV3 QmFzZURyYXcpOgorCiAyMDE5LTA0LTE1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEFkZCBlbmFibGUtbWVkaWEgd2Vic2V0dGlu ZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJW aWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXdCYXNlLmNwcAppbmRleCAwNTAwM2ExNjZkZGJhZmJmMTQ2OWFiMGZlNGQ3OWMwYTJlZGZiNTEx Li5kZWE3YjI5ODBhYWFkOWFjM2FiNjEwODU1NWY2MmM4YTQwNmY5MTZiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcApA QCAtMzgzLDggKzM4Myw2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdCYXNlUmVhbGl6ZShH dGtXaWRnZXQqIHdpZGdldCkKICAgICB9CiAjZW5kaWYKIAotICAgIGd0a19zdHlsZV9jb250ZXh0 X3NldF9iYWNrZ3JvdW5kKGd0a193aWRnZXRfZ2V0X3N0eWxlX2NvbnRleHQod2lkZ2V0KSwgd2lu ZG93KTsKLQogICAgIGd0a19pbV9jb250ZXh0X3NldF9jbGllbnRfd2luZG93KHByaXYtPmlucHV0 TWV0aG9kRmlsdGVyLmNvbnRleHQoKSwgd2luZG93KTsKIH0KIApAQCAtNTI5LDYgKzUyNywxMSBA QCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZUNvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVj dCkKIAogc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdCYXNlRHJhdyhHdGtXaWRnZXQqIHdp ZGdldCwgY2Fpcm9fdCogY3IpCiB7CisgICAgR3RrU3R5bGVDb250ZXh0KiBjb250ZXh0OworCisg ICAgY29udGV4dCA9IGd0a193aWRnZXRfZ2V0X3N0eWxlX2NvbnRleHQod2lkZ2V0KTsKKyAgICBn dGtfcmVuZGVyX2JhY2tncm91bmQoY29udGV4dCwgY3IsIDAsIDAsIGd0a193aWRnZXRfZ2V0X2Fs bG9jYXRlZF93aWR0aCh3aWRnZXQpLCBndGtfd2lkZ2V0X2dldF9hbGxvY2F0ZWRfaGVpZ2h0KHdp ZGdldCkpOworCiAgICAgV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlID0gV0VCS0lUX1dF Ql9WSUVXX0JBU0Uod2lkZ2V0KTsKICAgICBhdXRvKiBkcmF3aW5nQXJlYSA9IHN0YXRpY19jYXN0 PERyYXdpbmdBcmVhUHJveHlDb29yZGluYXRlZEdyYXBoaWNzKj4od2ViVmlld0Jhc2UtPnByaXYt PnBhZ2VQcm94eS0+ZHJhd2luZ0FyZWEoKSk7CiAgICAgaWYgKCFkcmF3aW5nQXJlYSkK 367936 2019-04-22 05:18:59 -0700 2019-04-22 09:31:46 -0700 Patch bug-196912-20190422141857.patch text/plain 1497 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJiZWYyYzUwODExNWUxODA5 M2NiMDc0ZThiNDEzMTQ3NWU0ODMxZDEuLjk1NmU5NDIzMDcxZDMyNGFlODgwMjIzY2M0NmJlNDA0 MzIyYjE2OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMjIgIEx1ZG92aWNv IGRlIE5pdHRpcyAgPGx1ZG92aWNvLmRlbml0dGlzQGNvbGxhYm9yYS5jb20+CisKKyAgICAgICAg W0dUS10gZml4IGd0a19zdHlsZV9jb250ZXh0X3NldF9iYWNrZ3JvdW5kIGRlcHJlY2F0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY5MTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBndGsg My4xOCBndGtfc3R5bGVfY29udGV4dF9zZXRfYmFja2dyb3VuZCBoYXMgYmVlbiBkZXByZWNhdGVk LgorICAgICAgICBCYWNrZ3JvdW5kcyBhcmUgbm90IHJlbmRlcmVkIGluIHRoZSBVSSBwcm9jZXNz LCBzbyBpdCBjYW4gYmUKKyAgICAgICAgc2ltcGx5IHJlbW92ZWQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJW aWV3QmFzZVJlYWxpemUpOgorCiAyMDE5LTA0LTA4ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3Rl YWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXVtXaW5DYWlyb10gU2VwYXJhdGUgY29waWVk IGhlYWRlcnMgaW50byBkaWZmZXJlbnQgZGlyZWN0b3JpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKaW5kZXggMDUwMDNh MTY2ZGRiYWZiZjE0NjlhYjBmZTRkNzljMGEyZWRmYjUxMS4uYTk2MTlkMTY5NGUwZjYxZTU4ZmE1 MGFiYzViYjNlMGRhOGJlMTA2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTM4Myw4ICszODMsNiBAQCBzdGF0 aWMgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVJlYWxpemUoR3RrV2lkZ2V0KiB3aWRnZXQpCiAgICAg fQogI2VuZGlmCiAKLSAgICBndGtfc3R5bGVfY29udGV4dF9zZXRfYmFja2dyb3VuZChndGtfd2lk Z2V0X2dldF9zdHlsZV9jb250ZXh0KHdpZGdldCksIHdpbmRvdyk7Ci0KICAgICBndGtfaW1fY29u dGV4dF9zZXRfY2xpZW50X3dpbmRvdyhwcml2LT5pbnB1dE1ldGhvZEZpbHRlci5jb250ZXh0KCks IHdpbmRvdyk7CiB9CiAK