196909 2019-04-14 16:14:58 -0700 Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement 2019-04-14 17:03:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196905 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain aestes ap lforschler webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1527119 0 aakash_jain 2019-04-14 16:14:58 -0700 API Test WKAttachmentTests.AddAttachmentToConnectedImageElement is very flaky. It makes EWS for API Test very inefficient (since in case of any test failure, EWS has to re-run the tests, and then re-run again on clean tree). We should disable the test to keep infrastructure happy, while the root-cause is being investigated. 1527120 1 aakash_jain 2019-04-14 16:15:37 -0700 This flaky test is slowing down EWS (since EWS has to re-run API tests few times to confirm that the failure is not because of the patch being tested). e.g.: https://ews-build.webkit.org/#/builders/3/builds/535 https://ews-build.webkit.org/#/builders/3/builds/530 https://ews-build.webkit.org/#/builders/3/builds/528 https://ews-build.webkit.org/#/builders/3/builds/503 https://ews-build.webkit.org/#/builders/3/builds/500 https://ews-build.webkit.org/#/builders/3/builds/467 https://ews-build.webkit.org/#/builders/3/builds/465 https://ews-build.webkit.org/#/builders/3/builds/460 https://ews-build.webkit.org/#/builders/3/builds/541 https://ews-build.webkit.org/#/builders/3/builds/527 https://ews-build.webkit.org/#/builders/3/builds/526 https://ews-build.webkit.org/#/builders/3/builds/518 https://ews-build.webkit.org/#/builders/3/builds/515 https://ews-build.webkit.org/#/builders/3/builds/509 https://ews-build.webkit.org/#/builders/3/builds/499 https://ews-build.webkit.org/#/builders/3/builds/497 https://ews-build.webkit.org/#/builders/3/builds/494 https://ews-build.webkit.org/#/builders/3/builds/493 https://ews-build.webkit.org/#/builders/3/builds/490 https://ews-build.webkit.org/#/builders/3/builds/480 https://ews-build.webkit.org/#/builders/3/builds/479 https://ews-build.webkit.org/#/builders/3/builds/477 https://ews-build.webkit.org/#/builders/3/builds/476 https://ews-build.webkit.org/#/builders/3/builds/474 https://ews-build.webkit.org/#/builders/3/builds/473 https://ews-build.webkit.org/#/builders/3/builds/470 In following builds, the test was so flaky that EWS incorrectly thought that the failure was introduced by the patch being tested (this test failed twice with the patch, and didn't fail on clean tree): https://ews-build.webkit.org/#/builders/3/builds/542 https://ews-build.webkit.org/#/builders/3/builds/546 https://ews-build.webkit.org/#/builders/3/builds/512 https://ews-build.webkit.org/#/builders/3/builds/495 https://ews-build.webkit.org/#/builders/3/builds/492 https://ews-build.webkit.org/#/builders/3/builds/488 https://ews-build.webkit.org/#/builders/3/builds/484 https://ews-build.webkit.org/#/builders/3/builds/471 https://ews-build.webkit.org/#/builders/3/builds/468 https://ews-build.webkit.org/#/builders/3/builds/464 https://ews-build.webkit.org/#/builders/3/builds/454 https://ews-build.webkit.org/#/builders/3/builds/440 https://ews-build.webkit.org/#/builders/3/builds/439 https://ews-build.webkit.org/#/builders/3/builds/429 https://ews-build.webkit.org/#/builders/3/builds/426 https://ews-build.webkit.org/#/builders/3/builds/414 1527121 2 367407 aakash_jain 2019-04-14 16:18:25 -0700 Created attachment 367407 Patch 1527122 3 wenson_hsieh 2019-04-14 16:20:15 -0700 Seems reasonable for the time being :( I'll be following up in https://bugs.webkit.org/show_bug.cgi?id=196905. 1527124 4 aakash_jain 2019-04-14 17:02:08 -0700 Committed r244249: <https://trac.webkit.org/changeset/244249> 1527125 5 webkit-bug-importer 2019-04-14 17:03:18 -0700 <rdar://problem/49889118> 367407 2019-04-14 16:18:25 -0700 2019-04-14 16:20:22 -0700 Patch bug-196909-20190414191939.patch text/plain 1376 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDI0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEaXNhYmxlIEZsYWt5IEFQSSBUZXN0IFdLQXR0YWNobWVudFRlc3RzLkFk ZEF0dGFjaG1lbnRUb0Nvbm5lY3RlZEltYWdlRWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2OTA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENv Y29hL1dLQXR0YWNobWVudFRlc3RzLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6 CisKIDIwMTktMDQtMTMgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAg ICAgICAgQ29kZUNhY2hlIHNob3VsZCBjaGVjayB0aGF0IHRoZSBVbmxpbmtlZENvZGVCbG9jayB3 YXMgc3VjY2Vzc2Z1bGx5IGNyZWF0ZWQgYmVmb3JlIGNhY2hpbmcgaXQKSW5kZXg6IFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1l bnRUZXN0cy5tbQkocmV2aXNpb24gMjQ0MjQ4KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTM0 Niw3ICsxMzQ2LDcgQEAgVEVTVChXS0F0dGFjaG1lbnRUZXN0cywgQ2hhbmdlRmlsZVdyYXBwZQog ICAgIFt3ZWJWaWV3IHdhaXRGb3JJbWFnZUVsZW1lbnRTaXplVG9CZWNvbWU6Q0dTaXplTWFrZSgy MTUsIDE3NCldOwogfQogCi1URVNUKFdLQXR0YWNobWVudFRlc3RzLCBBZGRBdHRhY2htZW50VG9D b25uZWN0ZWRJbWFnZUVsZW1lbnQpCitURVNUKFdLQXR0YWNobWVudFRlc3RzLCBESVNBQkxFRF9B ZGRBdHRhY2htZW50VG9Db25uZWN0ZWRJbWFnZUVsZW1lbnQpCiB7CiAgICAgYXV0byB3ZWJWaWV3 ID0gd2ViVmlld0ZvclRlc3RpbmdBdHRhY2htZW50cygpOwogICAgIFt3ZWJWaWV3IF9zeW5jaHJv bm91c2x5RXhlY3V0ZUVkaXRDb21tYW5kOkAiSW5zZXJ0SFRNTCIgYXJndW1lbnQ6QCI8aW1nPjwv aW1nPiJdOwo=