196900 2019-04-13 15:05:59 -0700 Web Inspector: REGRESSION: Heap: snapshots taken manually don't appear in the list 2019-04-15 10:23:33 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1527072 0 hi 2019-04-13 15:05:59 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Timelines tab 3. enable "JavaScript Allocations" 4. take a heap snapshot => the [S] appears in the graph area, but not in the "Snapshot List" area 1527073 1 webkit-bug-importer 2019-04-13 15:06:13 -0700 <rdar://problem/49880278> 1527074 2 367395 hi 2019-04-13 15:36:11 -0700 Created attachment 367395 Patch 1527214 3 367395 commit-queue 2019-04-15 10:23:32 -0700 Comment on attachment 367395 Patch Clearing flags on attachment: 367395 Committed r244265: <https://trac.webkit.org/changeset/244265> 1527215 4 commit-queue 2019-04-15 10:23:33 -0700 All reviewed patches have been landed. Closing bug. 367395 2019-04-13 15:36:11 -0700 2019-04-15 10:23:32 -0700 Patch bug-196900-20190413153610.patch text/plain 7490 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkzODM1NTE2MTc2MDYwMzQxODYzMWUzNDNlZjc5 ODI1M2FmOGQzMjQuLjFlYjE2MmUwNjgwOTFkYTU3NzY0N2U5ZDM5MWUxN2MwMTdmYmI5YTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE5LTA0LTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBIZWFwOiBzbmFwc2hvdHMgdGFrZW4gbWFudWFsbHkgZG9uJ3QgYXBwZWFyIGlu IHRoZSBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTY5MDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5ODgwMjc4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXSS5IZWFwQWxsb2Nh dGlvbnNUaW1lbGluZVZpZXcpOgorICAgICAgICAoV0kuSGVhcEFsbG9jYXRpb25zVGltZWxpbmVW aWV3LnByb3RvdHlwZS5sYXlvdXQpOgorICAgICAgICAoV0kuSGVhcEFsbG9jYXRpb25zVGltZWxp bmVWaWV3LnByb3RvdHlwZS5faW1wb3J0QnV0dG9uTmF2aWdhdGlvbkl0ZW1DbGlja2VkKToKKyAg ICAgICAgKFdJLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5wcm90b3R5cGUuX3Rha2VIZWFw U25hcHNob3RDbGlja2VkKToKKyAgICAgICAgRHJpdmUtYnk6IG9ubHkgc2hvdyBoZWFwIHNuYXBz aG90cyBmb3IgdGhlIHNlbGVjdGVkIHJhbmdlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9UaW1lbGluZVZpZXcuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuVGltZWxpbmVSZWNvcmRp bmdDb250ZW50Vmlldyk6CisgICAgICAgIChXSS5UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3 LnByb3RvdHlwZS5faGFuZGxlVGltZWxpbmVWaWV3TmVlZHNFbnRpcmVTZWxlY3RlZFJhbmdlKTog QWRkZWQuCisgICAgICAgIERyaXZlLWJ5OiB0YWtpbmcgKG9yIGltcG9ydGluZykgYSBoZWFwIHNu YXBzaG90IHNob3VsZCBzZWxlY3QgdGhlIGVudGlyZSByYW5nZSBzbyB0aGF0IHRoZQorICAgICAg ICBuZXcgcmVjb3JkIHdpbGwgYXBwZWFyIGluIHRoZSBsaXN0IG9mIGhlYXAgc25hcHNob3RzLgor CiAyMDE5LTA0LTExICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OKHIyNDQxOTUpOiBUaW1lbGluZXM6IHVuYWJsZSB0 byB0YWtlIGhlYXAgc25hcHNob3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVs aW5lVmlldy5qcwppbmRleCBlMDI1ZWJlOWQ5ODk2ZDk3Y2VlMjM2ZWM1NzZjMGRjOWE3ZGQwMmFi Li5jYTIyNjdkYjA1YWNmMjBjNGRmMTBkMTIxNGZlNzBkMWVmOWQxOWI1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwQWxsb2NhdGlvbnNU aW1lbGluZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3LmpzCkBAIC05Myw3ICs5Myw3IEBAIFdJ LkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyA9IGNsYXNzIEhlYXBBbGxvY2F0aW9uc1RpbWVs aW5lVmlldyBleHRlbmRzIFdJLlRpCiAgICAgICAgIHRoaXMuX2RhdGFHcmlkLnNvcnRPcmRlciA9 IFdJLkRhdGFHcmlkLlNvcnRPcmRlci5Bc2NlbmRpbmc7CiAgICAgICAgIHRoaXMuX2RhdGFHcmlk LmNyZWF0ZVNldHRpbmdzKCJoZWFwLWFsbG9jYXRpb25zLXRpbWVsaW5lLXZpZXciKTsKICAgICAg ICAgdGhpcy5fZGF0YUdyaWQuYWRkRXZlbnRMaXN0ZW5lcihXSS5EYXRhR3JpZC5FdmVudC5TZWxl Y3RlZE5vZGVDaGFuZ2VkLCB0aGlzLl9kYXRhR3JpZE5vZGVTZWxlY3RlZCwgdGhpcyk7Ci0KKyAg ICAgICAgdGhpcy5zZXR1cERhdGFHcmlkKHRoaXMuX2RhdGFHcmlkKTsKICAgICAgICAgdGhpcy5h ZGRTdWJ2aWV3KHRoaXMuX2RhdGFHcmlkKTsKIAogICAgICAgICB0aGlzLl9jb250ZW50Vmlld0Nv bnRhaW5lciA9IG5ldyBXSS5Db250ZW50Vmlld0NvbnRhaW5lcjsKQEAgLTI2MiwxNyArMjYyLDIw IEBAIFdJLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyA9IGNsYXNzIEhlYXBBbGxvY2F0aW9u c1RpbWVsaW5lVmlldyBleHRlbmRzIFdJLlRpCiAKICAgICBsYXlvdXQoKQogICAgIHsKLSAgICAg ICAgaWYgKHRoaXMuX3BlbmRpbmdSZWNvcmRzLmxlbmd0aCAmJiB0aGlzLnplcm9UaW1lKSB7Ci0g ICAgICAgICAgICBmb3IgKGxldCBoZWFwQWxsb2NhdGlvbnNUaW1lbGluZVJlY29yZCBvZiB0aGlz Ll9wZW5kaW5nUmVjb3JkcykgewotICAgICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFkZFJv d0luU29ydE9yZGVyKG5ldyBXSS5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZSho ZWFwQWxsb2NhdGlvbnNUaW1lbGluZVJlY29yZCwgewotICAgICAgICAgICAgICAgICAgICBncmFw aERhdGFTb3VyY2U6IHRoaXMsCi0gICAgICAgICAgICAgICAgICAgIGhlYXBBbGxvY2F0aW9uc1Zp ZXc6IHRoaXMsCi0gICAgICAgICAgICAgICAgfSkpOwotICAgICAgICAgICAgfQorICAgICAgICBz dXBlci5sYXlvdXQoKTsKIAotICAgICAgICAgICAgdGhpcy5fcGVuZGluZ1JlY29yZHMgPSBbXTsK LSAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUNvbXBhcmVIZWFwU25hcHNob3RCdXR0b24oKTsKKyAg ICAgICAgaWYgKCF0aGlzLl9wZW5kaW5nUmVjb3Jkcy5sZW5ndGgpCisgICAgICAgICAgICByZXR1 cm47CisKKyAgICAgICAgZm9yIChsZXQgaGVhcEFsbG9jYXRpb25zVGltZWxpbmVSZWNvcmQgb2Yg dGhpcy5fcGVuZGluZ1JlY29yZHMpIHsKKyAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFkZFJv d0luU29ydE9yZGVyKG5ldyBXSS5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZURhdGFHcmlkTm9kZSho ZWFwQWxsb2NhdGlvbnNUaW1lbGluZVJlY29yZCwgeworICAgICAgICAgICAgICAgIGdyYXBoRGF0 YVNvdXJjZTogdGhpcywKKyAgICAgICAgICAgICAgICBoZWFwQWxsb2NhdGlvbnNWaWV3OiB0aGlz LAorICAgICAgICAgICAgfSkpOwogICAgICAgICB9CisKKyAgICAgICAgdGhpcy5fcGVuZGluZ1Jl Y29yZHMgPSBbXTsKKyAgICAgICAgdGhpcy5fdXBkYXRlQ29tcGFyZUhlYXBTbmFwc2hvdEJ1dHRv bigpOwogICAgIH0KIAogICAgIHJlc2V0KCkKQEAgLTM4MCw3ICszODMsNyBAQCBXSS5IZWFwQWxs b2NhdGlvbnNUaW1lbGluZVZpZXcgPSBjbGFzcyBIZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZpZXcg ZXh0ZW5kcyBXSS5UaQogCiAgICAgX2ltcG9ydEJ1dHRvbk5hdmlnYXRpb25JdGVtQ2xpY2tlZCgp CiAgICAgewotICAgICAgICBXSS5GaWxlVXRpbGl0aWVzLmltcG9ydFRleHQoZnVuY3Rpb24ocmVz dWx0KSB7CisgICAgICAgIFdJLkZpbGVVdGlsaXRpZXMuaW1wb3J0VGV4dCgocmVzdWx0KSA9PiB7 CiAgICAgICAgICAgICBsZXQgc25hcHNob3RTdHJpbmdEYXRhID0gcmVzdWx0LnRleHQ7CiAgICAg ICAgICAgICBsZXQgd29ya2VyUHJveHkgPSBXSS5IZWFwU25hcHNob3RXb3JrZXJQcm94eS5zaW5n bGV0b24oKTsKICAgICAgICAgICAgIHdvcmtlclByb3h5LmNyZWF0ZUltcG9ydGVkU25hcHNob3Qo c25hcHNob3RTdHJpbmdEYXRhLCByZXN1bHQuZmlsZW5hbWUsICh7b2JqZWN0SWQsIHNuYXBzaG90 OiBzZXJpYWxpemVkU25hcHNob3R9KSA9PiB7CkBAIC0zODgsMTggKzM5MSwyMCBAQCBXSS5IZWFw QWxsb2NhdGlvbnNUaW1lbGluZVZpZXcgPSBjbGFzcyBIZWFwQWxsb2NhdGlvbnNUaW1lbGluZVZp ZXcgZXh0ZW5kcyBXSS5UaQogICAgICAgICAgICAgICAgIHNuYXBzaG90LnNuYXBzaG90U3RyaW5n RGF0YSA9IHNuYXBzaG90U3RyaW5nRGF0YTsKICAgICAgICAgICAgICAgICBjb25zdCB0aW1lc3Rh bXAgPSBOYU47CiAgICAgICAgICAgICAgICAgV0kudGltZWxpbmVNYW5hZ2VyLmhlYXBTbmFwc2hv dEFkZGVkKHRpbWVzdGFtcCwgc25hcHNob3QpOworICAgICAgICAgICAgICAgIHRoaXMuZGlzcGF0 Y2hFdmVudFRvTGlzdGVuZXJzKFdJLlRpbWVsaW5lVmlldy5FdmVudC5OZWVkc0VudGlyZVNlbGVj dGVkUmFuZ2UpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOwogICAgIH0KIAogICAgIF90 YWtlSGVhcFNuYXBzaG90Q2xpY2tlZCgpCiAgICAgewotICAgICAgICBIZWFwQWdlbnQuc25hcHNo b3QoZnVuY3Rpb24oZXJyb3IsIHRpbWVzdGFtcCwgc25hcHNob3RTdHJpbmdEYXRhKSB7CisgICAg ICAgIEhlYXBBZ2VudC5zbmFwc2hvdCgoZXJyb3IsIHRpbWVzdGFtcCwgc25hcHNob3RTdHJpbmdE YXRhKSA9PiB7CiAgICAgICAgICAgICBsZXQgd29ya2VyUHJveHkgPSBXSS5IZWFwU25hcHNob3RX b3JrZXJQcm94eS5zaW5nbGV0b24oKTsKICAgICAgICAgICAgIHdvcmtlclByb3h5LmNyZWF0ZVNu YXBzaG90KHNuYXBzaG90U3RyaW5nRGF0YSwgKHtvYmplY3RJZCwgc25hcHNob3Q6IHNlcmlhbGl6 ZWRTbmFwc2hvdH0pID0+IHsKICAgICAgICAgICAgICAgICBsZXQgc25hcHNob3QgPSBXSS5IZWFw U25hcHNob3RQcm94eS5kZXNlcmlhbGl6ZShvYmplY3RJZCwgc2VyaWFsaXplZFNuYXBzaG90KTsK ICAgICAgICAgICAgICAgICBzbmFwc2hvdC5zbmFwc2hvdFN0cmluZ0RhdGEgPSBzbmFwc2hvdFN0 cmluZ0RhdGE7CiAgICAgICAgICAgICAgICAgV0kudGltZWxpbmVNYW5hZ2VyLmhlYXBTbmFwc2hv dEFkZGVkKHRpbWVzdGFtcCwgc25hcHNob3QpOworICAgICAgICAgICAgICAgIHRoaXMuZGlzcGF0 Y2hFdmVudFRvTGlzdGVuZXJzKFdJLlRpbWVsaW5lVmlldy5FdmVudC5OZWVkc0VudGlyZVNlbGVj dGVkUmFuZ2UpOwogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0pOwogICAgIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVj b3JkaW5nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IDU2MjkyY2NmNzgy NzM2YjZkMGZiZWYxZjg1MTFmNjMyYjVlOTNjMTguLmE2YjdiZDY4NTIyZGU3ZTEwYjZmN2U2ZDVj Y2I4ZjdlODQ1MzI1ZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcwpAQCAtMTE0LDYgKzExNCw3IEBAIFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuCiAg ICAgICAgIFdJLlRpbWVsaW5lVmlldy5hZGRFdmVudExpc3RlbmVyKFdJLlRpbWVsaW5lVmlldy5F dmVudC5SZWNvcmRXYXNTZWxlY3RlZCwgdGhpcy5faGFuZGxlVGltZWxpbmVWaWV3UmVjb3JkU2Vs ZWN0ZWQsIHRoaXMpOwogICAgICAgICBXSS5UaW1lbGluZVZpZXcuYWRkRXZlbnRMaXN0ZW5lcihX SS5UaW1lbGluZVZpZXcuRXZlbnQuU2Nhbm5lclNob3csIHRoaXMuX2hhbmRsZVRpbWVsaW5lVmll d1NjYW5uZXJTaG93LCB0aGlzKTsKICAgICAgICAgV0kuVGltZWxpbmVWaWV3LmFkZEV2ZW50TGlz dGVuZXIoV0kuVGltZWxpbmVWaWV3LkV2ZW50LlNjYW5uZXJIaWRlLCB0aGlzLl9oYW5kbGVUaW1l bGluZVZpZXdTY2FubmVySGlkZSwgdGhpcyk7CisgICAgICAgIFdJLlRpbWVsaW5lVmlldy5hZGRF dmVudExpc3RlbmVyKFdJLlRpbWVsaW5lVmlldy5FdmVudC5OZWVkc0VudGlyZVNlbGVjdGVkUmFu Z2UsIHRoaXMuX2hhbmRsZVRpbWVsaW5lVmlld05lZWRzRW50aXJlU2VsZWN0ZWRSYW5nZSwgdGhp cyk7CiAKICAgICAgICAgV0kubm90aWZpY2F0aW9ucy5hZGRFdmVudExpc3RlbmVyKFdJLk5vdGlm aWNhdGlvbi5WaXNpYmlsaXR5U3RhdGVEaWRDaGFuZ2UsIHRoaXMuX2luc3BlY3RvclZpc2liaWxp dHlTdGF0ZUNoYW5nZWQsIHRoaXMpOwogCkBAIC05MzMsNiArOTM0LDE0IEBAIFdJLlRpbWVsaW5l UmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3 IGV4dGVuZHMgV0kuCiAgICAgICAgIHRoaXMuX3RpbWVsaW5lT3ZlcnZpZXcuaGlkZVNjYW5uZXIo KTsKICAgICB9CiAKKyAgICBfaGFuZGxlVGltZWxpbmVWaWV3TmVlZHNFbnRpcmVTZWxlY3RlZFJh bmdlKGV2ZW50KQorICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLnZpc2libGUpCisgICAgICAgICAg ICByZXR1cm47CisKKyAgICAgICAgdGhpcy5fdGltZWxpbmVPdmVydmlldy50aW1lbGluZVJ1bGVy LnNlbGVjdEVudGlyZVJhbmdlKCk7CisgICAgfQorCiAgICAgX3VwZGF0ZVByb2dyZXNzVmlldygp CiAgICAgewogICAgICAgICBsZXQgaXNDYXB0dXJpbmcgPSBXSS50aW1lbGluZU1hbmFnZXIuaXND YXB0dXJpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVmlldy5qcwppbmRleCBhYjEzY2NiODNhMTYzYTIzYjA1NDBh MjVjNzJjZjNlYTgwOTkyZDlhLi5hY2FmNWZhMzBjZDE3ZGZkMGM0YmFmYTJmZmQ0Y2JiZTc2ZjQ3 Y2RmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVWaWV3LmpzCkBAIC0zNDUsNCArMzQ1LDUgQEAgV0kuVGltZWxpbmVW aWV3LkV2ZW50ID0gewogICAgIFJlY29yZFdhc1NlbGVjdGVkOiAidGltZWxpbmUtdmlldy1yZWNv cmQtd2FzLXNlbGVjdGVkIiwKICAgICBTY2FubmVyU2hvdzogInRpbWVsaW5lLXZpZXctc2Nhbm5l ci1zaG93IiwKICAgICBTY2FubmVySGlkZTogInRpbWVsaW5lLXZpZXctc2Nhbm5lci1oaWRlIiwK KyAgICBOZWVkc0VudGlyZVNlbGVjdGVkUmFuZ2U6ICJ0aW1lbGluZS12aWV3LW5lZWRzLWVudGly ZS1zZWxlY3RlZC1yYW5nZSIsCiB9Owo=