196897 2019-04-13 06:23:00 -0700 [ews-build] Do not run clean build by default on EWS builders 2019-04-15 13:13:22 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195851 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap lforschler webkit-bug-importer oldest_to_newest 1527036 0 aakash_jain 2019-04-13 06:23:00 -0700 Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. Old EWS also doesn't run clean builds, ews-build should do the same. ews-build is currently running clean builds (even though we have not explicitly specified clean build in our configuration). 1527037 1 ap 2019-04-13 07:27:52 -0700 To elaborate on old EWS behavior, it dies build clean when retrying. Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention. 1527044 2 aakash_jain 2019-04-13 08:06:12 -0700 (In reply to Alexey Proskuryakov from comment #1) > To elaborate on old EWS behavior, it does build clean when retrying. > Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention. Yes, we will continue to do clean build on retry (unapply-patch step removes untracked files including WebKitBuild directory). 1527045 3 367387 aakash_jain 2019-04-13 08:06:44 -0700 Created attachment 367387 Patch 1527342 4 367387 lforschler 2019-04-15 13:02:46 -0700 Comment on attachment 367387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367387&action=review > Tools/ChangeLog:10 > + file is present, during the Source checkout, Buildbot clean the working directory completely (including removing nit: buildbot cleans 1527349 5 aakash_jain 2019-04-15 13:12:42 -0700 Committed r244283: <https://trac.webkit.org/changeset/244283> 1527350 6 webkit-bug-importer 2019-04-15 13:13:22 -0700 <rdar://problem/49914488> 367387 2019-04-13 08:06:44 -0700 2019-04-15 13:02:46 -0700 Patch bug-196897-20190413110756.patch text/plain 2155 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDI0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA0LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBEbyBub3QgcnVuIGNsZWFuIGJ1aWxkIGJ5IGRlZmF1 bHQgb24gRVdTIGJ1aWxkZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTY4OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAg ICAgKEFwcGx5UGF0Y2guc3RhcnQpOiBEbyBub3QgY3JlYXRlIC5idWlsZGJvdC1wYXRjaGVkIGZp bGUuIFRoaXMgaXMgYSBzcGVjaWFsIGZpbGUgZm9yIEJ1aWxkYm90IGFuZCBpZiB0aGlzCisgICAg ICAgIGZpbGUgaXMgcHJlc2VudCwgZHVyaW5nIHRoZSBTb3VyY2UgY2hlY2tvdXQsIEJ1aWxkYm90 IGNsZWFuIHRoZSB3b3JraW5nIGRpcmVjdG9yeSBjb21wbGV0ZWx5IChpbmNsdWRpbmcgcmVtb3Zp bmcgCisgICAgICAgIHVudHJhY2tlZCBkaXJlY3RvcmllcyBsaWtlIFdlYktpdEJ1aWxkKS4KKyAg ICAgICAgKENoZWNrT3V0U291cmNlLl9faW5pdF9fKTogUGFzcyBtZXRob2Q9Y2xlYW4gc28gdGhh dCBCdWlsZGJvdCBjbGVhbiB0aGUgd29ya2luZyBkaXJlY3RvcnkuIFRoaXMgZG9lcyBub3QgcmVt b3ZlCisgICAgICAgIHVudHJhY2tlZCBmaWxlcy9kaXJlY3RvcmllcyAobGlrZSBXZWJLaXRCdWls ZCkuCisKIDIwMTktMDQtMTMgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAK ICAgICAgICAgQ29kZUNhY2hlIHNob3VsZCBjaGVjayB0aGF0IHRoZSBVbmxpbmtlZENvZGVCbG9j ayB3YXMgc3VjY2Vzc2Z1bGx5IGNyZWF0ZWQgYmVmb3JlIGNhY2hpbmcgaXQKSW5kZXg6IFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0NDI0MSkK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBj b3B5KQpAQCAtOTMsNiArOTMsNyBAQCBjbGFzcyBDaGVja091dFNvdXJjZShnaXQuR2l0KToKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHJ5PXNlbGYu Q0hFQ0tPVVRfREVMQVlfQU5EX01BWF9SRVRSSUVTX1BBSVIsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0aW1lb3V0PTIgKiA2MCAqIDYwLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWx3YXlzVXNlTGF0ZXN0 PVRydWUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBt ZXRob2Q9J2NsZWFuJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHByb2dyZXNzPVRydWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAqKmt3YXJncykKIApAQCAtMTMzLDcgKzEzNCw2IEBAIGNsYXNzIEFwcGx5 UGF0Y2goc2hlbGwuU2hlbGxDb21tYW5kLCBDb20KICAgICAgICAgICAgIHJldHVybiBOb25lCiAK ICAgICAgICAgZCA9IHNlbGYuZG93bmxvYWRGaWxlQ29udGVudFRvV29ya2VyKCcuYnVpbGRib3Qt ZGlmZicsIHBhdGNoKQotICAgICAgICBkLmFkZENhbGxiYWNrKGxhbWJkYSBfOiBzZWxmLmRvd25s b2FkRmlsZUNvbnRlbnRUb1dvcmtlcignLmJ1aWxkYm90LXBhdGNoZWQnLCAncGF0Y2hlZFxuJykp CiAgICAgICAgIGQuYWRkQ2FsbGJhY2sobGFtYmRhIHJlczogc2hlbGwuU2hlbGxDb21tYW5kLnN0 YXJ0KHNlbGYpKQogCiAgICAgZGVmIGdldFJlc3VsdFN1bW1hcnkoc2VsZik6Cg==