196889 2019-04-12 18:23:13 -0700 Web Inspector: Heap: logging an object from a snapshot shouldn't use the "special" style if the object is reachable 2019-04-15 11:47:45 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1526970 0 hi 2019-04-12 18:23:13 -0700 `window.foo.bar.baz` vs `Heap Snapshot Object (%s)` 1526971 1 webkit-bug-importer 2019-04-12 18:24:43 -0700 <rdar://problem/49870693> 1526974 2 367365 hi 2019-04-12 18:28:46 -0700 Created attachment 367365 Patch 1527273 3 367365 joepeck 2019-04-15 11:19:14 -0700 Comment on attachment 367365 Patch r=me, Nice! 1527293 4 367365 commit-queue 2019-04-15 11:47:43 -0700 Comment on attachment 367365 Patch Clearing flags on attachment: 367365 Committed r244275: <https://trac.webkit.org/changeset/244275> 1527294 5 commit-queue 2019-04-15 11:47:45 -0700 All reviewed patches have been landed. Closing bug. 367365 2019-04-12 18:28:46 -0700 2019-04-15 11:47:43 -0700 Patch 196889.diff text/plain 3921 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkzODM1NTE2MTc2Li4zNWY4NWI3MGFhOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDQtMTIgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhl YXA6IGxvZ2dpbmcgYW4gb2JqZWN0IGZyb20gYSBzbmFwc2hvdCBzaG91bGRuJ3QgdXNlIHRoZSAi c3BlY2lhbCIgc3R5bGUgaWYgdGhlIG9iamVjdCBpcyByZWFjaGFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njg4OQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDk4NzA2OTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBTbmFwc2hvdEluc3RhbmNlRGF0 YUdyaWROb2RlLmpzOgorICAgICAgICAoV0kuSGVhcFNuYXBzaG90SW5zdGFuY2VEYXRhR3JpZE5v ZGUubG9nSGVhcFNuYXBzaG90Tm9kZSk6CisKIDIwMTktMDQtMTEgIERldmluIFJvdXNzbyAgPGRy b3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04ocjI0 NDE5NSk6IFRpbWVsaW5lczogdW5hYmxlIHRvIHRha2UgaGVhcCBzbmFwc2hvdApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSGVhcFNuYXBzaG90 SW5zdGFuY2VEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9IZWFwU25hcHNob3RJbnN0YW5jZURhdGFHcmlkTm9kZS5qcwppbmRleCAzMjQ4 ODI2NzkzYy4uNTQ4NDZmNTAyYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBTbmFwc2hvdEluc3RhbmNlRGF0YUdyaWROb2RlLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBTbmFwc2hv dEluc3RhbmNlRGF0YUdyaWROb2RlLmpzCkBAIC01MiwxMSArNTIsMTAgQEAgV0kuSGVhcFNuYXBz aG90SW5zdGFuY2VEYXRhR3JpZE5vZGUgPSBjbGFzcyBIZWFwU25hcHNob3RJbnN0YW5jZURhdGFH cmlkTm9kZSBleHQKIAogICAgIHN0YXRpYyBsb2dIZWFwU25hcHNob3ROb2RlKG5vZGUpCiAgICAg ewotICAgICAgICBsZXQgaGVhcE9iamVjdElkZW50aWZpZXIgPSBub2RlLmlkOwotICAgICAgICBs ZXQgc2hvdWxkUmV2ZWFsQ29uc29sZSA9IHRydWU7Ci0gICAgICAgIGxldCB0ZXh0ID0gV0kuVUlT dHJpbmcoIkhlYXAgU25hcHNob3QgT2JqZWN0ICglcykiKS5mb3JtYXQoIkAiICsgaGVhcE9iamVj dElkZW50aWZpZXIpOwotCiAgICAgICAgIG5vZGUuc2hvcnRlc3RHQ1Jvb3RQYXRoKChnY1Jvb3RQ YXRoKSA9PiB7CisgICAgICAgICAgICBsZXQgdGV4dCA9IFdJLlVJU3RyaW5nKCJIZWFwIFNuYXBz aG90IE9iamVjdCAoJXMpIikuZm9ybWF0KCJAIiArIG5vZGUuaWQpOworICAgICAgICAgICAgbGV0 IGFkZFNwZWNpYWxVc2VyTG9nQ2xhc3MgPSAhZ2NSb290UGF0aC5sZW5ndGg7CisKICAgICAgICAg ICAgIGlmIChnY1Jvb3RQYXRoLmxlbmd0aCkgewogICAgICAgICAgICAgICAgIGdjUm9vdFBhdGgg PSBnY1Jvb3RQYXRoLnNsaWNlKCkucmV2ZXJzZSgpOwogICAgICAgICAgICAgICAgIGxldCB3aW5k b3dJbmRleCA9IGdjUm9vdFBhdGguZmluZEluZGV4KCh4KSA9PiB7CkBAIC03MywxOSArNzIsMjMg QEAgV0kuSGVhcFNuYXBzaG90SW5zdGFuY2VEYXRhR3JpZE5vZGUgPSBjbGFzcyBIZWFwU25hcHNo b3RJbnN0YW5jZURhdGFHcmlkTm9kZSBleHQKICAgICAgICAgICAgICAgICAgICAgICAgIGhlYXBT bmFwc2hvdFJvb3RQYXRoID0gaGVhcFNuYXBzaG90Um9vdFBhdGguYXBwZW5kRWRnZShjb21wb25l bnQpOwogICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAgIGlmICghaGVhcFNuYXBz aG90Um9vdFBhdGguaXNGdWxsUGF0aEltcG9zc2libGUoKSkKKyAgICAgICAgICAgICAgICBpZiAo aGVhcFNuYXBzaG90Um9vdFBhdGguaXNGdWxsUGF0aEltcG9zc2libGUoKSkKKyAgICAgICAgICAg ICAgICAgICAgYWRkU3BlY2lhbFVzZXJMb2dDbGFzcyA9IHRydWU7CisgICAgICAgICAgICAgICAg ZWxzZQogICAgICAgICAgICAgICAgICAgICB0ZXh0ID0gaGVhcFNuYXBzaG90Um9vdFBhdGguZnVs bFBhdGg7CiAgICAgICAgICAgICB9CiAKKyAgICAgICAgICAgIGNvbnN0IHNob3VsZFJldmVhbENv bnNvbGUgPSB0cnVlOworCiAgICAgICAgICAgICBpZiAobm9kZS5jbGFzc05hbWUgPT09ICJzdHJp bmciKSB7Ci0gICAgICAgICAgICAgICAgSGVhcEFnZW50LmdldFByZXZpZXcoaGVhcE9iamVjdElk ZW50aWZpZXIsIGZ1bmN0aW9uKGVycm9yLCBzdHJpbmcsIGZ1bmN0aW9uRGV0YWlscywgb2JqZWN0 UHJldmlld1BheWxvYWQpIHsKKyAgICAgICAgICAgICAgICBIZWFwQWdlbnQuZ2V0UHJldmlldyhu b2RlLmlkLCBmdW5jdGlvbihlcnJvciwgc3RyaW5nLCBmdW5jdGlvbkRldGFpbHMsIG9iamVjdFBy ZXZpZXdQYXlsb2FkKSB7CiAgICAgICAgICAgICAgICAgICAgIGxldCByZW1vdGVPYmplY3QgPSBl cnJvciA/IFdJLlJlbW90ZU9iamVjdC5mcm9tUHJpbWl0aXZlVmFsdWUodW5kZWZpbmVkKSA6IFdJ LlJlbW90ZU9iamVjdC5mcm9tUHJpbWl0aXZlVmFsdWUoc3RyaW5nKTsKLSAgICAgICAgICAgICAg ICAgICAgV0kuY29uc29sZUxvZ1ZpZXdDb250cm9sbGVyLmFwcGVuZEltbWVkaWF0ZUV4ZWN1dGlv bldpdGhSZXN1bHQodGV4dCwgcmVtb3RlT2JqZWN0LCBzaG91bGRSZXZlYWxDb25zb2xlKTsKKyAg ICAgICAgICAgICAgICAgICAgV0kuY29uc29sZUxvZ1ZpZXdDb250cm9sbGVyLmFwcGVuZEltbWVk aWF0ZUV4ZWN1dGlvbldpdGhSZXN1bHQodGV4dCwgcmVtb3RlT2JqZWN0LCBhZGRTcGVjaWFsVXNl ckxvZ0NsYXNzLCBzaG91bGRSZXZlYWxDb25zb2xlKTsKICAgICAgICAgICAgICAgICB9KTsKICAg ICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgSGVhcEFnZW50LmdldFJlbW90ZU9i amVjdChoZWFwT2JqZWN0SWRlbnRpZmllciwgV0kuUnVudGltZU1hbmFnZXIuQ29uc29sZU9iamVj dEdyb3VwLCBmdW5jdGlvbihlcnJvciwgcmVtb3RlT2JqZWN0UGF5bG9hZCkgeworICAgICAgICAg ICAgICAgIEhlYXBBZ2VudC5nZXRSZW1vdGVPYmplY3Qobm9kZS5pZCwgV0kuUnVudGltZU1hbmFn ZXIuQ29uc29sZU9iamVjdEdyb3VwLCBmdW5jdGlvbihlcnJvciwgcmVtb3RlT2JqZWN0UGF5bG9h ZCkgewogICAgICAgICAgICAgICAgICAgICBsZXQgcmVtb3RlT2JqZWN0ID0gZXJyb3IgPyBXSS5S ZW1vdGVPYmplY3QuZnJvbVByaW1pdGl2ZVZhbHVlKHVuZGVmaW5lZCkgOiBXSS5SZW1vdGVPYmpl Y3QuZnJvbVBheWxvYWQocmVtb3RlT2JqZWN0UGF5bG9hZCwgV0kuYXNzdW1pbmdNYWluVGFyZ2V0 KCkpOwotICAgICAgICAgICAgICAgICAgICBXSS5jb25zb2xlTG9nVmlld0NvbnRyb2xsZXIuYXBw ZW5kSW1tZWRpYXRlRXhlY3V0aW9uV2l0aFJlc3VsdCh0ZXh0LCByZW1vdGVPYmplY3QsIHNob3Vs ZFJldmVhbENvbnNvbGUpOworICAgICAgICAgICAgICAgICAgICBXSS5jb25zb2xlTG9nVmlld0Nv bnRyb2xsZXIuYXBwZW5kSW1tZWRpYXRlRXhlY3V0aW9uV2l0aFJlc3VsdCh0ZXh0LCByZW1vdGVP YmplY3QsIGFkZFNwZWNpYWxVc2VyTG9nQ2xhc3MsIHNob3VsZFJldmVhbENvbnNvbGUpOwogICAg ICAgICAgICAgICAgIH0pOwogICAgICAgICAgICAgfQogICAgICAgICB9KTsK