196888 2019-04-12 18:22:08 -0700 Web Inspector: sidebar panels shouldn't be added as subviews unless visible 2019-08-15 16:40:43 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 200797 196920 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1526968 0 hi 2019-04-12 18:22:08 -0700 Although most of the top-level sidebar panel subclasses will bail if they're not visible, subviews don't have knowledge of that state and may still layout even when the parent panel is hidden. The only subview of a sidebar should the currently visible panel. 1526969 1 webkit-bug-importer 2019-04-12 18:22:28 -0700 <rdar://problem/49870659> 1526977 2 367367 hi 2019-04-12 18:31:46 -0700 Created attachment 367367 Patch 1527205 3 367367 timothy 2019-04-15 10:05:25 -0700 Comment on attachment 367367 Patch We should keep an eye on this change, it could introduce regressions. 1527222 4 367367 commit-queue 2019-04-15 10:27:33 -0700 Comment on attachment 367367 Patch Clearing flags on attachment: 367367 Committed r244268: <https://trac.webkit.org/changeset/244268> 1527223 5 commit-queue 2019-04-15 10:27:35 -0700 All reviewed patches have been landed. Closing bug. 367367 2019-04-12 18:31:46 -0700 2019-04-15 10:27:33 -0700 Patch 196888.diff text/plain 3239 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkzODM1NTE2MTc2Li5kZDUyNTkxYjE4MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDQtMTIgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNp ZGViYXIgcGFuZWxzIHNob3VsZG4ndCBiZSBhZGRlZCBhcyBzdWJ2aWV3cyB1bmxlc3MgdmlzaWJs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODg4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTg3MDY1OT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJh ci5qczoKKyAgICAgICAgKFdJLlNpZGViYXIucHJvdG90eXBlLmluc2VydFNpZGViYXJQYW5lbCk6 CisgICAgICAgIChXSS5TaWRlYmFyLnByb3RvdHlwZS5yZW1vdmVTaWRlYmFyUGFuZWwpOgorICAg ICAgICAoV0kuU2lkZWJhci5wcm90b3R5cGUuc2V0IHNlbGVjdGVkU2lkZWJhclBhbmVsKToKKwog MjAxOS0wNC0xMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjQ0MTk1KTogVGltZWxpbmVzOiB1bmFibGUgdG8g dGFrZSBoZWFwIHNuYXBzaG90CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TaWRlYmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvU2lkZWJhci5qcwppbmRleCA4NTZhYTFlNDQ5NS4uMzc2ODQ4NWVhM2Mg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Np ZGViYXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv U2lkZWJhci5qcwpAQCAtNzgsOSArNzgsNiBAQCBXSS5TaWRlYmFyID0gY2xhc3MgU2lkZWJhciBl eHRlbmRzIFdJLlZpZXcKICAgICAgICAgY29uc29sZS5hc3NlcnQoaW5kZXggPj0gMCAmJiBpbmRl eCA8PSB0aGlzLl9zaWRlYmFyUGFuZWxzLmxlbmd0aCk7CiAgICAgICAgIHRoaXMuX3NpZGViYXJQ YW5lbHMuc3BsaWNlKGluZGV4LCAwLCBzaWRlYmFyUGFuZWwpOwogCi0gICAgICAgIGxldCByZWZl cmVuY2VWaWV3ID0gdGhpcy5fc2lkZWJhclBhbmVsc1tpbmRleCArIDFdIHx8IG51bGw7Ci0gICAg ICAgIHRoaXMuaW5zZXJ0U3Vidmlld0JlZm9yZShzaWRlYmFyUGFuZWwsIHJlZmVyZW5jZVZpZXcp OwotCiAgICAgICAgIGlmICh0aGlzLl9uYXZpZ2F0aW9uQmFyKSB7CiAgICAgICAgICAgICBjb25z b2xlLmFzc2VydChzaWRlYmFyUGFuZWwubmF2aWdhdGlvbkl0ZW0pOwogICAgICAgICAgICAgdGhp cy5fbmF2aWdhdGlvbkJhci5pbnNlcnROYXZpZ2F0aW9uSXRlbShzaWRlYmFyUGFuZWwubmF2aWdh dGlvbkl0ZW0sIGluZGV4KTsKQEAgLTEwNiw3ICsxMDMsNiBAQCBXSS5TaWRlYmFyID0gY2xhc3Mg U2lkZWJhciBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMuX3NpZGVi YXJQYW5lbHMucmVtb3ZlKHNpZGViYXJQYW5lbCk7Ci0gICAgICAgIHRoaXMucmVtb3ZlU3Vidmll dyhzaWRlYmFyUGFuZWwpOwogCiAgICAgICAgIGlmICh0aGlzLl9uYXZpZ2F0aW9uQmFyKSB7CiAg ICAgICAgICAgICBjb25zb2xlLmFzc2VydChzaWRlYmFyUGFuZWwubmF2aWdhdGlvbkl0ZW0pOwpA QCAtMTI2LDEyICsxMjIsMTAgQEAgV0kuU2lkZWJhciA9IGNsYXNzIFNpZGViYXIgZXh0ZW5kcyBX SS5WaWV3CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVk U2lkZWJhclBhbmVsKSB7Ci0gICAgICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFu ZWwudmlzaWJsZSkgewotICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVs LmhpZGRlbigpOwotICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsLnZp c2liaWxpdHlEaWRDaGFuZ2UoKTsKLSAgICAgICAgICAgIH0KLQorICAgICAgICAgICAgdGhpcy5f c2VsZWN0ZWRTaWRlYmFyUGFuZWwuaGlkZGVuKCk7CisgICAgICAgICAgICB0aGlzLl9zZWxlY3Rl ZFNpZGViYXJQYW5lbC52aXNpYmlsaXR5RGlkQ2hhbmdlKCk7CiAgICAgICAgICAgICB0aGlzLl9z ZWxlY3RlZFNpZGViYXJQYW5lbC5zZWxlY3RlZCA9IGZhbHNlOworICAgICAgICAgICAgdGhpcy5y ZW1vdmVTdWJ2aWV3KHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsKTsKICAgICAgICAgfQogCiAg ICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsID0gc2lkZWJhclBhbmVsIHx8IG51bGw7 CkBAIC0xNDAsMTIgKzEzNCwxMCBAQCBXSS5TaWRlYmFyID0gY2xhc3MgU2lkZWJhciBleHRlbmRz IFdJLlZpZXcKICAgICAgICAgICAgIHRoaXMuX25hdmlnYXRpb25CYXIuc2VsZWN0ZWROYXZpZ2F0 aW9uSXRlbSA9IHNpZGViYXJQYW5lbCA/IHNpZGViYXJQYW5lbC5uYXZpZ2F0aW9uSXRlbSA6IG51 bGw7CiAKICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsKSB7CisgICAgICAg ICAgICB0aGlzLmFkZFN1YnZpZXcodGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwpOwogICAgICAg ICAgICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwuc2VsZWN0ZWQgPSB0cnVlOwotCi0gICAg ICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwudmlzaWJsZSkgewotICAgICAg ICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsLnNob3duKCk7Ci0gICAgICAgICAg ICAgICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwudmlzaWJpbGl0eURpZENoYW5nZSgpOwot ICAgICAgICAgICAgfQorICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRTaWRlYmFyUGFuZWwuc2hv d24oKTsKKyAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBhbmVsLnZpc2liaWxpdHlE aWRDaGFuZ2UoKTsKICAgICAgICAgfQogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlz dGVuZXJzKFdJLlNpZGViYXIuRXZlbnQuU2lkZWJhclBhbmVsU2VsZWN0ZWQpOwo=