196872 2019-04-12 11:27:58 -0700 WebDriver: Set Cookie endpoint does not correctly set subdomain cookies 2019-04-15 12:49:15 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue hi joepeck webkit-bug-importer oldest_to_newest 1526848 0 hi 2019-04-12 11:27:58 -0700 ```py from selenium import webdriver driver = webdriver.Safari(executable_path='$build/Release/safaridriver') driver.get("https://apple.com") driver.add_cookie({ 'name': 'testfromotherdomain', 'value': '42', 'domain': 'school.apple.com', }) driver.get("https://school.apple.com") driver.add_cookie({ 'name': 'testfromsamedomain', 'value': '42', 'domain': 'school.apple.com', }) ``` After running the above, stop the active session and inspect <https://school.apple.com>. There should be two cookies ("testfromotherdomain" and "testfromsamedomain"), but there's only one ("testfromsamedomain"). 1526849 1 hi 2019-04-12 11:28:20 -0700 <rdar://problem/49233240> 1526851 2 367336 hi 2019-04-12 11:30:51 -0700 Created attachment 367336 Patch 1527321 3 367336 joepeck 2019-04-15 12:21:02 -0700 Comment on attachment 367336 Patch r=me 1527333 4 367336 commit-queue 2019-04-15 12:49:13 -0700 Comment on attachment 367336 Patch Clearing flags on attachment: 367336 Committed r244281: <https://trac.webkit.org/changeset/244281> 1527334 5 commit-queue 2019-04-15 12:49:15 -0700 All reviewed patches have been landed. Closing bug. 367336 2019-04-12 11:30:51 -0700 2019-04-15 12:49:13 -0700 Patch bug-196872-20190412113050.patch text/plain 2178 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMTU3ZDNhMDRjMTI2NGNkNTJiNGVkYmIzZDRlNmU0YzkzMGMzNDdjMS4uZDkz MjNiZDkwODZkYThlZDhlOGNlZjlkZGYxM2FjZTllYjg3MzVkMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAxOS0wNC0xMiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisK KyAgICAgICAgV2ViRHJpdmVyOiBTZXQgQ29va2llIGVuZHBvaW50IGRvZXMgbm90IGNvcnJlY3Rs eSBzZXQgc3ViZG9tYWluIGNvb2tpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Njg3MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkyMzMyNDA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjphZGRTaW5nbGVDb29raWUpOgorICAgICAgICBSYXRo ZXIgdGhhbiB0cnkgdG8gImZvcmNlIiB0aGUgY29va2llIHRvIGJlIHNldCBvbiB0aGUgY3VycmVu dCBhY3RpdmUgVVJMLCB1c2UgdGhlIGNvb2tpZQorICAgICAgICBpdHNlbGYgdG8gZmlndXJlIG91 dCB3aGljaCBkb21haW4gaXQgc2hvdWxkIGJlIHNldCBvbi4KKwogMjAxOS0wNC0xMSAgU2FpZCBB Ym91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKHIyNDQxODIpOiBSZW1vdGVMYXllclRyZWVEcmF3aW5nQXJlYTo6Zmx1c2hMYXllcnMoKSBz aG91bGQgbm90IGJlIHJlZW50cmFudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAppbmRleCA1OTQyMWZk ODgxZmQxMzg2YjMzMGEyYWZlNTk1MzEwMmVhMmM1YWRkLi5iODljNWE3MjE1NGM4ZDdhNTY4M2Y5 OThhZjZjMGQ5ZGM2ZDVjNDNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B dXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcApAQCAtMTM1MiwxMCAr MTM1Miw3IEBAIHZvaWQgV2ViQXV0b21hdGlvblNlc3Npb246OmFkZFNpbmdsZUNvb2tpZShjb25z dCBTdHJpbmcmIGJyb3dzaW5nQ29udGV4dEhhbmRsZSwKICAgICAgICAgQVNZTkNfRkFJTF9XSVRI X1BSRURFRklORURfRVJST1JfQU5EX0RFVEFJTFMoTWlzc2luZ1BhcmFtZXRlciwgIlRoZSBwYXJh bWV0ZXIgJ2h0dHBPbmx5JyB3YXMgbm90IGZvdW5kLiIpOwogCiAgICAgV2ViQ29va2llTWFuYWdl clByb3h5KiBjb29raWVNYW5hZ2VyID0gbV9wcm9jZXNzUG9vbC0+c3VwcGxlbWVudDxXZWJDb29r aWVNYW5hZ2VyUHJveHk+KCk7Ci0KLSAgICAvLyBGSVhNRTogVXNpbmcgYWN0aXZlVVJMIGhlcmUg dHdpY2UgaXMgYmFzaWNhbGx5IHNheWluZyAidGhpcyBpcyBhbHdheXMgaW4gdGhlIGNvbnRleHQg b2YgdGhlIG1haW4gZG9jdW1lbnQiCi0gICAgLy8gd2hpY2ggcHJvYmFibHkgaXNuJ3QgYWNjdXJh dGUuCi0gICAgY29va2llTWFuYWdlci0+c2V0Q29va2llcyhwYWdlLT53ZWJzaXRlRGF0YVN0b3Jl KCkuc2Vzc2lvbklEKCksIHsgY29va2llIH0sIGFjdGl2ZVVSTCwgYWN0aXZlVVJMLCBbY2FsbGJh Y2sgPSBjYWxsYmFjay5jb3B5UmVmKCldKENhbGxiYWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKKyAg ICBjb29raWVNYW5hZ2VyLT5zZXRDb29raWVzKHBhZ2UtPndlYnNpdGVEYXRhU3RvcmUoKS5zZXNz aW9uSUQoKSwgeyBjb29raWUgfSwgW2NhbGxiYWNrID0gY2FsbGJhY2suY29weVJlZigpXShDYWxs YmFja0Jhc2U6OkVycm9yIGVycm9yKSB7CiAgICAgICAgIGlmIChlcnJvciA9PSBDYWxsYmFja0Jh c2U6OkVycm9yOjpOb25lKQogICAgICAgICAgICAgY2FsbGJhY2stPnNlbmRTdWNjZXNzKCk7CiAg ICAgICAgIGVsc2UK