196850 2019-04-11 21:27:55 -0700 [JSC] op_has_indexed_property should not assume subscript part is Uint32 2019-04-11 23:35:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1526623 0 ysuzuki 2019-04-11 21:27:55 -0700 [JSC] op_has_indexed_property should not assume subscript part is Uint32 1526624 1 367284 ysuzuki 2019-04-11 21:29:42 -0700 Created attachment 367284 Patch 1526625 2 ysuzuki 2019-04-11 21:30:29 -0700 <rdar://problem/49726277> 1526628 3 367286 ysuzuki 2019-04-11 21:40:11 -0700 Created attachment 367286 Patch 1526640 4 367286 saam 2019-04-11 22:30:25 -0700 Comment on attachment 367286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367286&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:2070 > + ASSERT(subscript.asAnyInt() <= UINT32_MAX); Maybe it’s worth a helper function since this is the second time you’re adding this code > Source/JavaScriptCore/jit/JITOperations.cpp:2074 > + uint32_t index = static_cast<uint32_t>(subscript.asAnyInt()); Ditto 1526651 5 367286 ysuzuki 2019-04-11 22:54:23 -0700 Comment on attachment 367286 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367286&action=review >> Source/JavaScriptCore/jit/JITOperations.cpp:2070 >> + ASSERT(subscript.asAnyInt() <= UINT32_MAX); > > Maybe it’s worth a helper function since this is the second time you’re adding this code Sounds nice! Like, asUint32AsAnyInt() / isUInt32AsAnyInt(). 1526662 6 ysuzuki 2019-04-11 23:35:21 -0700 Committed r244211: <https://trac.webkit.org/changeset/244211> 367284 2019-04-11 21:29:42 -0700 2019-04-11 21:40:09 -0700 Patch bug-196850-20190411212942.patch text/plain 7580 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl N2IzZjk4ZmJiOGVkYzhhNzE5N2I0NDczMGQyOWUzYThkNmVlM2ZjLi40YjJjYzBiMzEzNTcwNDMy MjhkYzRmOTdkMGYxNjUwY2M2YzM5MzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0wNC0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIG9wX2hhc19pbmRleGVkX3Byb3BlcnR5IHNob3VsZCBub3QgYXNz dW1lIHN1YnNjcmlwdCBwYXJ0IGlzIFVpbnQzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgb3BfaGFzX2luZGV4ZWRfcHJvcGVydHkgYXNzdW1lZCB0aGF0 IHN1YnNjcmlwdCBwYXJ0IGlzIGFsd2F5cyBVaW50MzIuIEhvd2V2ZXIsIHRoaXMgaXMganVzdCBh IGxvYWQgZnJvbSBub24tY29uc3RhbnQgUmVnaXN0ZXJJRCwKKyAgICAgICAgREZHIGNhbiBzdG9y ZSBpdCBpbiBkb3VibGUgZm9ybWF0IGFuZCBjYW4gcGVyZm9ybSBPU1IgZXhpdC4gb3BfaGFzX2lu ZGV4ZWRfcHJvcGVydHkgc2hvdWxkIG5vdCBhc3N1bWUgdGhhdC4KKyAgICAgICAgSW4gdGhpcyBw YXRjaCwgaW5zdGVhZCwgd2UgY2hlY2sgaXQgd2l0aCBpc0FueUludCBhbmQgZ2V0IHVpbnQzMl90 IGZyb20gQW55SW50LgorCisgICAgICAgICogaml0L0pJVE9wY29kZXMuY3BwOgorICAgICAgICAo SlNDOjpKSVQ6OmVtaXRfb3BfaGFzX2luZGV4ZWRfcHJvcGVydHkpOgorICAgICAgICAqIGppdC9K SVRPcGNvZGVzMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfaGFzX2luZGV4 ZWRfcHJvcGVydHkpOgorICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAg KiBydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHA6CisgICAgICAgIChKU0M6OlNMT1dfUEFUSF9E RUNMKToKKwogMjAxOS0wNC0xMSAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgaW52YWxpZCBhc3NlcnRpb24gaW4gb3BlcmF0aW9uSW5zdGFuY2VPZkN1 c3RvbQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAKaW5kZXggZTY1ODUx YzEzMjUyMGY5YWZkZWI2YWRjYjM4YTlhY2RkMWVkOWExNS4uNDE0ZDcyNGZjYmNkZmY2YmE3OTBk M2VmMjBhNjViZmQ0YWMyMzdhYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRPcGNvZGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29k ZXMuY3BwCkBAIC0xMjQ5LDYgKzEyNDksOCBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9oYXNfaW5kZXhl ZF9wcm9wZXJ0eShjb25zdCBJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIAog ICAgIGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXJzKGJhc2UsIHJlZ1QwLCBwcm9wZXJ0eSwgcmVnVDEp OwogCisgICAgYWRkU2xvd0Nhc2UoYnJhbmNoSWZOb3RJbnQzMihyZWdUMSkpOworCiAgICAgLy8g VGhpcyBpcyB0ZWNobmljYWxseSBpbmNvcnJlY3QgLSB3ZSdyZSB6ZXJvLWV4dGVuZGluZyBhbiBp bnQzMi4gT24gdGhlIGhvdCBwYXRoIHRoaXMgZG9lc24ndCBtYXR0ZXIuCiAgICAgLy8gV2UgY2hl Y2sgdGhlIHZhbHVlIGFzIGlmIGl0IHdhcyBhIHVpbnQzMiBhZ2FpbnN0IHRoZSBtX3ZlY3Rvckxl bmd0aCAtIHdoaWNoIHdpbGwgYWx3YXlzIGZhaWwgaWYKICAgICAvLyBudW1iZXIgd2FzIHNpZ25l ZCBzaW5jZSBtX3ZlY3Rvckxlbmd0aCBpcyBhbHdheXMgbGVzcyB0aGFuIGludG1heCAoc2luY2Ug dGhlIHRvdGFsIGFsbG9jYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvSklUT3Bjb2RlczMyXzY0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bj b2RlczMyXzY0LmNwcAppbmRleCAwODE2ZGE0YTVmZTcxMDZlMmY1ODI3OTViZWJkMGI1ODU5MDc0 YmJkLi41M2Y1ZmNhM2NhYTM3YmMzZTYyZDA4MWQ0MDhmMjgxZjcwOTJmYWEzIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMzMl82NC5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwCkBAIC0xMTIxLDcgKzEx MjEsOCBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9oYXNfaW5kZXhlZF9wcm9wZXJ0eShjb25zdCBJbnN0 cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIGVtaXRMb2FkUGF5bG9hZChiYXNlLCBy ZWdUMCk7CiAgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SlNDZWxsKGJhc2UpOwogCi0gICAgZW1p dExvYWRQYXlsb2FkKHByb3BlcnR5LCByZWdUMSk7CisgICAgZW1pdExvYWQocHJvcGVydHksIHJl Z1QzLCByZWdUMSk7CisgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SW50KHJlZ1QzKTsKIAogICAg IC8vIFRoaXMgaXMgdGVjaG5pY2FsbHkgaW5jb3JyZWN0IC0gd2UncmUgemVyby1leHRlbmRpbmcg YW4gaW50MzIuIE9uIHRoZSBob3QgcGF0aCB0aGlzIGRvZXNuJ3QgbWF0dGVyLgogICAgIC8vIFdl IGNoZWNrIHRoZSB2YWx1ZSBhcyBpZiBpdCB3YXMgYSB1aW50MzIgYWdhaW5zdCB0aGUgbV92ZWN0 b3JMZW5ndGggLSB3aGljaCB3aWxsIGFsd2F5cyBmYWlsIGlmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAppbmRleCBjZWRkNWJmODQ5MmVkZTI5ZTI4MjY4NzIz ZjA1NmM2OWI4MGQyNzZjLi5jODE5NTNhNmIwZjBjYzFjM2Y0YzYwZGEwN2E0MjljYmY3NTcwMTQz IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTIw MTMsNyArMjAxMyw5IEBAIEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uSGFz SW5kZXhlZFByb3BlcnR5RGVmYXVsdChFeGVjU3RhdGUqIGV4ZWMsCiAgICAgSlNWYWx1ZSBzdWJz Y3JpcHQgPSBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZFN1YnNjcmlwdCk7CiAgICAgCiAgICAgQVNT RVJUKGJhc2VWYWx1ZS5pc09iamVjdCgpKTsKLSAgICBBU1NFUlQoc3Vic2NyaXB0LmlzVUludDMy KCkpOworICAgIEFTU0VSVChzdWJzY3JpcHQuaXNBbnlJbnQoKSk7CisgICAgQVNTRVJUKHN1YnNj cmlwdC5hc0FueUludCgpIDw9IFVJTlQzMl9NQVgpOworICAgIEFTU0VSVChzdWJzY3JpcHQuYXNB bnlJbnQoKSA+PSAwKTsKIAogICAgIEpTT2JqZWN0KiBvYmplY3QgPSBhc09iamVjdChiYXNlVmFs dWUpOwogICAgIGJvb2wgZGlkT3B0aW1pemUgPSBmYWxzZTsKQEAgLTIwNDMsNyArMjA0NSw3IEBA IEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uSGFzSW5kZXhlZFByb3BlcnR5 RGVmYXVsdChFeGVjU3RhdGUqIGV4ZWMsCiAgICAgICAgIH0KICAgICB9CiAKLSAgICB1aW50MzJf dCBpbmRleCA9IHN1YnNjcmlwdC5hc1VJbnQzMigpOworICAgIHVpbnQzMl90IGluZGV4ID0gc3Rh dGljX2Nhc3Q8dWludDMyX3Q+KHN1YnNjcmlwdC5hc0FueUludCgpKTsKICAgICBpZiAob2JqZWN0 LT5jYW5HZXRJbmRleFF1aWNrbHkoaW5kZXgpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKEpTVmFsdWUoSlNWYWx1ZTo6SlNUcnVlKSk7CiAKQEAgLTIwNjQsMTAgKzIwNjYsMTIgQEAg RW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25IYXNJbmRleGVkUHJvcGVydHlH ZW5lcmljKEV4ZWNTdGF0ZSogZXhlYywKICAgICBKU1ZhbHVlIHN1YnNjcmlwdCA9IEpTVmFsdWU6 OmRlY29kZShlbmNvZGVkU3Vic2NyaXB0KTsKICAgICAKICAgICBBU1NFUlQoYmFzZVZhbHVlLmlz T2JqZWN0KCkpOwotICAgIEFTU0VSVChzdWJzY3JpcHQuaXNVSW50MzIoKSk7CisgICAgQVNTRVJU KHN1YnNjcmlwdC5pc0FueUludCgpKTsKKyAgICBBU1NFUlQoc3Vic2NyaXB0LmFzQW55SW50KCkg PD0gVUlOVDMyX01BWCk7CisgICAgQVNTRVJUKHN1YnNjcmlwdC5hc0FueUludCgpID49IDApOwog CiAgICAgSlNPYmplY3QqIG9iamVjdCA9IGFzT2JqZWN0KGJhc2VWYWx1ZSk7Ci0gICAgdWludDMy X3QgaW5kZXggPSBzdWJzY3JpcHQuYXNVSW50MzIoKTsKKyAgICB1aW50MzJfdCBpbmRleCA9IHN0 YXRpY19jYXN0PHVpbnQzMl90PihzdWJzY3JpcHQuYXNBbnlJbnQoKSk7CiAgICAgaWYgKG9iamVj dC0+Y2FuR2V0SW5kZXhRdWlja2x5KGluZGV4KSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShKU1ZhbHVlKEpTVmFsdWU6OkpTVHJ1ZSkpOwogCkBAIC0yMDc3LDcgKzIwODEsNyBAQCBF bmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkhhc0luZGV4ZWRQcm9wZXJ0eUdl bmVyaWMoRXhlY1N0YXRlKiBleGVjLAogICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5ODg2CiAgICAgICAgIGJ5VmFsSW5mby0+YXJyYXlQcm9maWxl LT5zZXRPdXRPZkJvdW5kcygpOwogICAgIH0KLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpz Qm9vbGVhbihvYmplY3QtPmhhc1Byb3BlcnR5R2VuZXJpYyhleGVjLCBzdWJzY3JpcHQuYXNVSW50 MzIoKSwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OkdldE93blByb3BlcnR5KSkp OworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKG9iamVjdC0+aGFzUHJvcGVy dHlHZW5lcmljKGV4ZWMsIGluZGV4LCBQcm9wZXJ0eVNsb3Q6OkludGVybmFsTWV0aG9kVHlwZTo6 R2V0T3duUHJvcGVydHkpKSk7CiB9CiAgICAgCiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9O IG9wZXJhdGlvbkdldEJ5VmFsU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTVmFsdWUg ZW5jb2RlZEJhc2UsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRTdWJzY3JpcHQsIEJ5VmFsSW5mbyog YnlWYWxJbmZvKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29t bW9uU2xvd1BhdGhzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1vblNs b3dQYXRocy5jcHAKaW5kZXggNTljYjUwZjE1NzE1NzY0YzEyYTAzNWUxZDQ5MzExYTdiNjY0Mzk2 YS4uNDkwMWIxM2IzNWQyODM3ZGU4NDZlNjgyOTk2ZTg1ZDVjZDk3M2Q5ZCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuY3BwCkBAIC05MDMs OCArOTAzLDEwIEBAIFNMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9oYXNfaW5kZXhlZF9wcm9wZXJ0 eSkKICAgICBDSEVDS19FWENFUFRJT04oKTsKICAgICBKU1ZhbHVlIHByb3BlcnR5ID0gR0VUKGJ5 dGVjb2RlLm1fcHJvcGVydHkpLmpzVmFsdWUoKTsKICAgICBtZXRhZGF0YS5tX2FycmF5UHJvZmls ZS5vYnNlcnZlU3RydWN0dXJlKGJhc2UtPnN0cnVjdHVyZSh2bSkpOwotICAgIEFTU0VSVChwcm9w ZXJ0eS5pc1VJbnQzMigpKTsKLSAgICBSRVRVUk4oanNCb29sZWFuKGJhc2UtPmhhc1Byb3BlcnR5 R2VuZXJpYyhleGVjLCBwcm9wZXJ0eS5hc1VJbnQzMigpLCBQcm9wZXJ0eVNsb3Q6OkludGVybmFs TWV0aG9kVHlwZTo6R2V0T3duUHJvcGVydHkpKSk7CisgICAgQVNTRVJUKHByb3BlcnR5LmlzQW55 SW50KCkpOworICAgIEFTU0VSVChwcm9wZXJ0eS5hc0FueUludCgpIDw9IFVJTlQzMl9NQVgpOwor ICAgIEFTU0VSVChwcm9wZXJ0eS5hc0FueUludCgpID49IDApOworICAgIFJFVFVSTihqc0Jvb2xl YW4oYmFzZS0+aGFzUHJvcGVydHlHZW5lcmljKGV4ZWMsIHN0YXRpY19jYXN0PHVpbnQzMl90Pihw cm9wZXJ0eS5hc0FueUludCgpKSwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6Okdl dE93blByb3BlcnR5KSkpOwogfQogCiBTTE9XX1BBVEhfREVDTChzbG93X3BhdGhfaGFzX3N0cnVj dHVyZV9wcm9wZXJ0eSkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9D aGFuZ2VMb2cKaW5kZXggN2JkZGVkOGE3YzJmZjkwZGUyOTA2M2U5YjQxZTg3MWE2MzFkYTkzZS4u ODhiY2FmNTAyODJlZTBlMGQxNjdhNTYzZDk2MWVmNjY1ZjhkYTZmMCAxMDA2NDQKLS0tIGEvSlNU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wNC0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAg IFtKU0NdIG9wX2hhc19pbmRleGVkX3Byb3BlcnR5IHNob3VsZCBub3QgYXNzdW1lIHN1YnNjcmlw dCBwYXJ0IGlzIFVpbnQzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2ODUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBzdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktc2hvdWxkLWFjY2VwdC1ub24t aW50MzIuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAxOS0wNC0xMSAgU2FhbSBiYXJh dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgaW52YWxpZCBhc3NlcnRp b24gaW4gb3BlcmF0aW9uSW5zdGFuY2VPZkN1c3RvbQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJl c3MvaGFzLWluZGV4ZWQtcHJvcGVydHktc2hvdWxkLWFjY2VwdC1ub24taW50MzIuanMgYi9KU1Rl c3RzL3N0cmVzcy9oYXMtaW5kZXhlZC1wcm9wZXJ0eS1zaG91bGQtYWNjZXB0LW5vbi1pbnQzMi5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi41ZTU0ODZiMmQxMGU0MmVmZWU0Y2JkMzRmOTI1MzQzZTQzNzFmNmE2Ci0t LSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktc2hv dWxkLWFjY2VwdC1ub24taW50MzIuanMKQEAgLTAsMCArMSwxMyBAQAorLy9AIHJ1bkRlZmF1bHQo Ii0tdXNlUmFuZG9taXppbmdGdXp6ZXJBZ2VudD0xIiwgIi0taml0UG9saWN5U2NhbGU9MCIsICIt LXVzZU1heGltYWxGbHVzaEluc2VydGlvblBoYXNlPTEiLCAiLS11c2VDb25jdXJyZW50SklUPTAi KQorZnVuY3Rpb24gZm9vKG9iaikgeworICBmb3IgKHZhciB4IGluIG9iaikgeworICAgIGlmICgw ID4gMCkgeworICAgICAgYnJlYWs7CisgICAgfQorICB9CisgIDAgJiYgT2JqZWN0LnByb3RvdHlw ZS5oYXNPd25Qcm9wZXJ0eQorfQorCitmb28oW10pOworZm9vKFtdKTsKK2ZvbyhbMCwgMF0pOwo= 367286 2019-04-11 21:40:11 -0700 2019-04-11 22:30:25 -0700 Patch bug-196850-20190411214010.patch text/plain 7580 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl N2IzZjk4ZmJiOGVkYzhhNzE5N2I0NDczMGQyOWUzYThkNmVlM2ZjLi40YjJjYzBiMzEzNTcwNDMy MjhkYzRmOTdkMGYxNjUwY2M2YzM5MzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxOS0wNC0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIG9wX2hhc19pbmRleGVkX3Byb3BlcnR5IHNob3VsZCBub3QgYXNz dW1lIHN1YnNjcmlwdCBwYXJ0IGlzIFVpbnQzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgb3BfaGFzX2luZGV4ZWRfcHJvcGVydHkgYXNzdW1lZCB0aGF0 IHN1YnNjcmlwdCBwYXJ0IGlzIGFsd2F5cyBVaW50MzIuIEhvd2V2ZXIsIHRoaXMgaXMganVzdCBh IGxvYWQgZnJvbSBub24tY29uc3RhbnQgUmVnaXN0ZXJJRCwKKyAgICAgICAgREZHIGNhbiBzdG9y ZSBpdCBpbiBkb3VibGUgZm9ybWF0IGFuZCBjYW4gcGVyZm9ybSBPU1IgZXhpdC4gb3BfaGFzX2lu ZGV4ZWRfcHJvcGVydHkgc2hvdWxkIG5vdCBhc3N1bWUgdGhhdC4KKyAgICAgICAgSW4gdGhpcyBw YXRjaCwgaW5zdGVhZCwgd2UgY2hlY2sgaXQgd2l0aCBpc0FueUludCBhbmQgZ2V0IHVpbnQzMl90 IGZyb20gQW55SW50LgorCisgICAgICAgICogaml0L0pJVE9wY29kZXMuY3BwOgorICAgICAgICAo SlNDOjpKSVQ6OmVtaXRfb3BfaGFzX2luZGV4ZWRfcHJvcGVydHkpOgorICAgICAgICAqIGppdC9K SVRPcGNvZGVzMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRfb3BfaGFzX2luZGV4 ZWRfcHJvcGVydHkpOgorICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKyAgICAgICAg KiBydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHA6CisgICAgICAgIChKU0M6OlNMT1dfUEFUSF9E RUNMKToKKwogMjAxOS0wNC0xMSAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgaW52YWxpZCBhc3NlcnRpb24gaW4gb3BlcmF0aW9uSW5zdGFuY2VPZkN1 c3RvbQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzLmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2Rlcy5jcHAKaW5kZXggZTY1ODUx YzEzMjUyMGY5YWZkZWI2YWRjYjM4YTlhY2RkMWVkOWExNS4uMThjZWJhNmFkOTBiODA4YzRlMDRm ZmQxOGYxY2I5MjY1MjJmNDI2MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRPcGNvZGVzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29k ZXMuY3BwCkBAIC0xMjQ5LDYgKzEyNDksOCBAQCB2b2lkIEpJVDo6ZW1pdF9vcF9oYXNfaW5kZXhl ZF9wcm9wZXJ0eShjb25zdCBJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIAog ICAgIGVtaXRHZXRWaXJ0dWFsUmVnaXN0ZXJzKGJhc2UsIHJlZ1QwLCBwcm9wZXJ0eSwgcmVnVDEp OwogCisgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SW50KHJlZ1QxKTsKKwogICAgIC8vIFRoaXMg aXMgdGVjaG5pY2FsbHkgaW5jb3JyZWN0IC0gd2UncmUgemVyby1leHRlbmRpbmcgYW4gaW50MzIu IE9uIHRoZSBob3QgcGF0aCB0aGlzIGRvZXNuJ3QgbWF0dGVyLgogICAgIC8vIFdlIGNoZWNrIHRo ZSB2YWx1ZSBhcyBpZiBpdCB3YXMgYSB1aW50MzIgYWdhaW5zdCB0aGUgbV92ZWN0b3JMZW5ndGgg LSB3aGljaCB3aWxsIGFsd2F5cyBmYWlsIGlmCiAgICAgLy8gbnVtYmVyIHdhcyBzaWduZWQgc2lu Y2UgbV92ZWN0b3JMZW5ndGggaXMgYWx3YXlzIGxlc3MgdGhhbiBpbnRtYXggKHNpbmNlIHRoZSB0 b3RhbCBhbGxvY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VE9wY29kZXMzMl82NC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wY29kZXMz Ml82NC5jcHAKaW5kZXggMDgxNmRhNGE1ZmU3MTA2ZTJmNTgyNzk1YmViZDBiNTg1OTA3NGJiZC4u MjVhOWM4ZjM1MGFkYzNlNjk0NDBkYWNhMzRkODI0MjJlZTRmMTgyYyAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGNvZGVzMzJfNjQuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUT3Bjb2RlczMyXzY0LmNwcApAQCAtMTEyMSw3ICsxMTIxLDgg QEAgdm9pZCBKSVQ6OmVtaXRfb3BfaGFzX2luZGV4ZWRfcHJvcGVydHkoY29uc3QgSW5zdHJ1Y3Rp b24qIGN1cnJlbnRJbnN0cnVjdGlvbikKICAgICBlbWl0TG9hZFBheWxvYWQoYmFzZSwgcmVnVDAp OwogICAgIGVtaXRKdW1wU2xvd0Nhc2VJZk5vdEpTQ2VsbChiYXNlKTsKIAotICAgIGVtaXRMb2Fk UGF5bG9hZChwcm9wZXJ0eSwgcmVnVDEpOworICAgIGVtaXRMb2FkKHByb3BlcnR5LCByZWdUMywg cmVnVDEpOworICAgIGFkZFNsb3dDYXNlKGJyYW5jaElmTm90SW50MzIocmVnVDMpKTsKIAogICAg IC8vIFRoaXMgaXMgdGVjaG5pY2FsbHkgaW5jb3JyZWN0IC0gd2UncmUgemVyby1leHRlbmRpbmcg YW4gaW50MzIuIE9uIHRoZSBob3QgcGF0aCB0aGlzIGRvZXNuJ3QgbWF0dGVyLgogICAgIC8vIFdl IGNoZWNrIHRoZSB2YWx1ZSBhcyBpZiBpdCB3YXMgYSB1aW50MzIgYWdhaW5zdCB0aGUgbV92ZWN0 b3JMZW5ndGggLSB3aGljaCB3aWxsIGFsd2F5cyBmYWlsIGlmCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAppbmRleCBjZWRkNWJmODQ5MmVkZTI5ZTI4MjY4NzIz ZjA1NmM2OWI4MGQyNzZjLi5jODE5NTNhNmIwZjBjYzFjM2Y0YzYwZGEwN2E0MjljYmY3NTcwMTQz IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTIw MTMsNyArMjAxMyw5IEBAIEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uSGFz SW5kZXhlZFByb3BlcnR5RGVmYXVsdChFeGVjU3RhdGUqIGV4ZWMsCiAgICAgSlNWYWx1ZSBzdWJz Y3JpcHQgPSBKU1ZhbHVlOjpkZWNvZGUoZW5jb2RlZFN1YnNjcmlwdCk7CiAgICAgCiAgICAgQVNT RVJUKGJhc2VWYWx1ZS5pc09iamVjdCgpKTsKLSAgICBBU1NFUlQoc3Vic2NyaXB0LmlzVUludDMy KCkpOworICAgIEFTU0VSVChzdWJzY3JpcHQuaXNBbnlJbnQoKSk7CisgICAgQVNTRVJUKHN1YnNj cmlwdC5hc0FueUludCgpIDw9IFVJTlQzMl9NQVgpOworICAgIEFTU0VSVChzdWJzY3JpcHQuYXNB bnlJbnQoKSA+PSAwKTsKIAogICAgIEpTT2JqZWN0KiBvYmplY3QgPSBhc09iamVjdChiYXNlVmFs dWUpOwogICAgIGJvb2wgZGlkT3B0aW1pemUgPSBmYWxzZTsKQEAgLTIwNDMsNyArMjA0NSw3IEBA IEVuY29kZWRKU1ZhbHVlIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uSGFzSW5kZXhlZFByb3BlcnR5 RGVmYXVsdChFeGVjU3RhdGUqIGV4ZWMsCiAgICAgICAgIH0KICAgICB9CiAKLSAgICB1aW50MzJf dCBpbmRleCA9IHN1YnNjcmlwdC5hc1VJbnQzMigpOworICAgIHVpbnQzMl90IGluZGV4ID0gc3Rh dGljX2Nhc3Q8dWludDMyX3Q+KHN1YnNjcmlwdC5hc0FueUludCgpKTsKICAgICBpZiAob2JqZWN0 LT5jYW5HZXRJbmRleFF1aWNrbHkoaW5kZXgpKQogICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKEpTVmFsdWUoSlNWYWx1ZTo6SlNUcnVlKSk7CiAKQEAgLTIwNjQsMTAgKzIwNjYsMTIgQEAg RW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25IYXNJbmRleGVkUHJvcGVydHlH ZW5lcmljKEV4ZWNTdGF0ZSogZXhlYywKICAgICBKU1ZhbHVlIHN1YnNjcmlwdCA9IEpTVmFsdWU6 OmRlY29kZShlbmNvZGVkU3Vic2NyaXB0KTsKICAgICAKICAgICBBU1NFUlQoYmFzZVZhbHVlLmlz T2JqZWN0KCkpOwotICAgIEFTU0VSVChzdWJzY3JpcHQuaXNVSW50MzIoKSk7CisgICAgQVNTRVJU KHN1YnNjcmlwdC5pc0FueUludCgpKTsKKyAgICBBU1NFUlQoc3Vic2NyaXB0LmFzQW55SW50KCkg PD0gVUlOVDMyX01BWCk7CisgICAgQVNTRVJUKHN1YnNjcmlwdC5hc0FueUludCgpID49IDApOwog CiAgICAgSlNPYmplY3QqIG9iamVjdCA9IGFzT2JqZWN0KGJhc2VWYWx1ZSk7Ci0gICAgdWludDMy X3QgaW5kZXggPSBzdWJzY3JpcHQuYXNVSW50MzIoKTsKKyAgICB1aW50MzJfdCBpbmRleCA9IHN0 YXRpY19jYXN0PHVpbnQzMl90PihzdWJzY3JpcHQuYXNBbnlJbnQoKSk7CiAgICAgaWYgKG9iamVj dC0+Y2FuR2V0SW5kZXhRdWlja2x5KGluZGV4KSkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShKU1ZhbHVlKEpTVmFsdWU6OkpTVHJ1ZSkpOwogCkBAIC0yMDc3LDcgKzIwODEsNyBAQCBF bmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvbkhhc0luZGV4ZWRQcm9wZXJ0eUdl bmVyaWMoRXhlY1N0YXRlKiBleGVjLAogICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5ODg2CiAgICAgICAgIGJ5VmFsSW5mby0+YXJyYXlQcm9maWxl LT5zZXRPdXRPZkJvdW5kcygpOwogICAgIH0KLSAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpz Qm9vbGVhbihvYmplY3QtPmhhc1Byb3BlcnR5R2VuZXJpYyhleGVjLCBzdWJzY3JpcHQuYXNVSW50 MzIoKSwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OkdldE93blByb3BlcnR5KSkp OworICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNCb29sZWFuKG9iamVjdC0+aGFzUHJvcGVy dHlHZW5lcmljKGV4ZWMsIGluZGV4LCBQcm9wZXJ0eVNsb3Q6OkludGVybmFsTWV0aG9kVHlwZTo6 R2V0T3duUHJvcGVydHkpKSk7CiB9CiAgICAgCiBFbmNvZGVkSlNWYWx1ZSBKSVRfT1BFUkFUSU9O IG9wZXJhdGlvbkdldEJ5VmFsU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTVmFsdWUg ZW5jb2RlZEJhc2UsIEVuY29kZWRKU1ZhbHVlIGVuY29kZWRTdWJzY3JpcHQsIEJ5VmFsSW5mbyog YnlWYWxJbmZvKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29t bW9uU2xvd1BhdGhzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1vblNs b3dQYXRocy5jcHAKaW5kZXggNTljYjUwZjE1NzE1NzY0YzEyYTAzNWUxZDQ5MzExYTdiNjY0Mzk2 YS4uNDkwMWIxM2IzNWQyODM3ZGU4NDZlNjgyOTk2ZTg1ZDVjZDk3M2Q5ZCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuY3BwCkBAIC05MDMs OCArOTAzLDEwIEBAIFNMT1dfUEFUSF9ERUNMKHNsb3dfcGF0aF9oYXNfaW5kZXhlZF9wcm9wZXJ0 eSkKICAgICBDSEVDS19FWENFUFRJT04oKTsKICAgICBKU1ZhbHVlIHByb3BlcnR5ID0gR0VUKGJ5 dGVjb2RlLm1fcHJvcGVydHkpLmpzVmFsdWUoKTsKICAgICBtZXRhZGF0YS5tX2FycmF5UHJvZmls ZS5vYnNlcnZlU3RydWN0dXJlKGJhc2UtPnN0cnVjdHVyZSh2bSkpOwotICAgIEFTU0VSVChwcm9w ZXJ0eS5pc1VJbnQzMigpKTsKLSAgICBSRVRVUk4oanNCb29sZWFuKGJhc2UtPmhhc1Byb3BlcnR5 R2VuZXJpYyhleGVjLCBwcm9wZXJ0eS5hc1VJbnQzMigpLCBQcm9wZXJ0eVNsb3Q6OkludGVybmFs TWV0aG9kVHlwZTo6R2V0T3duUHJvcGVydHkpKSk7CisgICAgQVNTRVJUKHByb3BlcnR5LmlzQW55 SW50KCkpOworICAgIEFTU0VSVChwcm9wZXJ0eS5hc0FueUludCgpIDw9IFVJTlQzMl9NQVgpOwor ICAgIEFTU0VSVChwcm9wZXJ0eS5hc0FueUludCgpID49IDApOworICAgIFJFVFVSTihqc0Jvb2xl YW4oYmFzZS0+aGFzUHJvcGVydHlHZW5lcmljKGV4ZWMsIHN0YXRpY19jYXN0PHVpbnQzMl90Pihw cm9wZXJ0eS5hc0FueUludCgpKSwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6Okdl dE93blByb3BlcnR5KSkpOwogfQogCiBTTE9XX1BBVEhfREVDTChzbG93X3BhdGhfaGFzX3N0cnVj dHVyZV9wcm9wZXJ0eSkKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9D aGFuZ2VMb2cKaW5kZXggN2JkZGVkOGE3YzJmZjkwZGUyOTA2M2U5YjQxZTg3MWE2MzFkYTkzZS4u ODhiY2FmNTAyODJlZTBlMGQxNjdhNTYzZDk2MWVmNjY1ZjhkYTZmMCAxMDA2NDQKLS0tIGEvSlNU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxOS0wNC0xMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAg IFtKU0NdIG9wX2hhc19pbmRleGVkX3Byb3BlcnR5IHNob3VsZCBub3QgYXNzdW1lIHN1YnNjcmlw dCBwYXJ0IGlzIFVpbnQzMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2ODUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBzdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktc2hvdWxkLWFjY2VwdC1ub24t aW50MzIuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKwogMjAxOS0wNC0xMSAgU2FhbSBiYXJh dGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgaW52YWxpZCBhc3NlcnRp b24gaW4gb3BlcmF0aW9uSW5zdGFuY2VPZkN1c3RvbQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJl c3MvaGFzLWluZGV4ZWQtcHJvcGVydHktc2hvdWxkLWFjY2VwdC1ub24taW50MzIuanMgYi9KU1Rl c3RzL3N0cmVzcy9oYXMtaW5kZXhlZC1wcm9wZXJ0eS1zaG91bGQtYWNjZXB0LW5vbi1pbnQzMi5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi41ZTU0ODZiMmQxMGU0MmVmZWU0Y2JkMzRmOTI1MzQzZTQzNzFmNmE2Ci0t LSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvaGFzLWluZGV4ZWQtcHJvcGVydHktc2hv dWxkLWFjY2VwdC1ub24taW50MzIuanMKQEAgLTAsMCArMSwxMyBAQAorLy9AIHJ1bkRlZmF1bHQo Ii0tdXNlUmFuZG9taXppbmdGdXp6ZXJBZ2VudD0xIiwgIi0taml0UG9saWN5U2NhbGU9MCIsICIt LXVzZU1heGltYWxGbHVzaEluc2VydGlvblBoYXNlPTEiLCAiLS11c2VDb25jdXJyZW50SklUPTAi KQorZnVuY3Rpb24gZm9vKG9iaikgeworICBmb3IgKHZhciB4IGluIG9iaikgeworICAgIGlmICgw ID4gMCkgeworICAgICAgYnJlYWs7CisgICAgfQorICB9CisgIDAgJiYgT2JqZWN0LnByb3RvdHlw ZS5oYXNPd25Qcm9wZXJ0eQorfQorCitmb28oW10pOworZm9vKFtdKTsKK2ZvbyhbMCwgMF0pOwo=