196849 2019-04-11 21:02:34 -0700 WebThread should run at a higher priority than user initiated 2019-04-12 13:37:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ddkilzer ggaren koivisto webkit-bug-importer oldest_to_newest 1526616 0 rniwa 2019-04-11 21:02:34 -0700 WebThread should run at a higher priority than user initiated 1526617 1 rniwa 2019-04-11 21:03:01 -0700 <rdar://problem/46851062> 1526618 2 367282 rniwa 2019-04-11 21:05:28 -0700 Created attachment 367282 Fixes the bug 1526619 3 rniwa 2019-04-11 21:05:30 -0700 <rdar://problem/46851062> 1526620 4 367283 rniwa 2019-04-11 21:06:09 -0700 Created attachment 367283 Fixes the bug 1526634 5 ggaren 2019-04-11 22:20:50 -0700 Can you include a description of the workload you used to qualify this change, and the improvement you saw? 1526636 6 367283 ggaren 2019-04-11 22:21:44 -0700 Comment on attachment 367283 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=367283&action=review r=me > Source/WebCore/platform/ios/wak/WebCoreThread.mm:670 > - pthread_attr_setstacksize(&tattr, 200 * 4096); > + pthread_attr_setstacksize(&tattr, 800 * KB); I'm pretty sure this change is harmless -- but it doesn't really seem related to this bug. 1526663 7 rniwa 2019-04-11 23:36:04 -0700 (In reply to Geoffrey Garen from comment #6) > Comment on attachment 367283 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367283&action=review > > r=me > > > Source/WebCore/platform/ios/wak/WebCoreThread.mm:670 > > - pthread_attr_setstacksize(&tattr, 200 * 4096); > > + pthread_attr_setstacksize(&tattr, 800 * KB); > > I'm pretty sure this change is harmless -- but it doesn't really seem > related to this bug. Oh ya, I forgot to mention in the change log. I'm just replaying 200 * 4096 by 200 * 4 * 1024 -> 800 * 1024 -> 800 KB. I think the code comes from when page size was 4KB in iOS. 1526897 8 rniwa 2019-04-12 13:37:11 -0700 (In reply to Geoffrey Garen from comment #5) > Can you include a description of the workload you used to qualify this > change, and the improvement you saw? Added: "This improves the blocked time in StartWebThread from 2~3ms to 250μs while cold launching iBooks to an opened book." 1526898 9 rniwa 2019-04-12 13:37:40 -0700 Committed r244229: <https://trac.webkit.org/changeset/244229> 367282 2019-04-11 21:05:28 -0700 2019-04-11 21:06:08 -0700 Fixes the bug bug-196849-20190411210528.patch text/plain 1887 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NDIwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA0LTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFdlYlRocmVhZCBzaG91bGQgcnVu IGF0IGEgaGlnaGVyIHByaW9yaXR5IHRoYW4gdXNlciBpbml0aWF0ZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njg0OQorCTxyZGFyOi8vcHJvYmxl bS80Njg1MTA2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVc2UgUU9TX0NMQVNTX1VTRVJfSU5URVJBQ1RJVkUgb24gV2ViVGhyZWFkIHdpdGggLTEw IHJlbGF0aXZlIHByaW9yaXR5IHNvIHRoYXQgV2ViVGhyZWFkCisgICAgICAgIHdvbid0IHdhaXQg Zm9yIG90aGVyIHRocmVhZHMgd2l0aCBwcmlvcml0eSAzMC0zNyBidXQgZG9lcyBub3QgY29udGVu dCB3aXRoIHRoZSBtYWluIHRocmVhZC4KKworICAgICAgICBBbHNvIHJlbW92ZWQgdGhlIGNhbGwg dG8gcHRocmVhZF9hdHRyX3NldHNjaGVkcGFyYW0gd2hpY2ggZGlzYWJsZXMgUW9TLgorCisgICAg ICAgICogcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1tOgorICAgICAgICAoU3RhcnRX ZWJUaHJlYWQpOgorCiAyMDE5LTA0LTExICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgVHJ5IHRvIGZpeCBXaW5kb3dzIGJ1aWxkLgpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbQkocmV2aXNpb24gMjQ0 MjA4KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XZWJDb3JlVGhyZWFkLm1t CSh3b3JraW5nIGNvcHkpCkBAIC02NjcsMTIgKzY2Nyw5IEBAIHN0YXRpYyB2b2lkIFN0YXJ0V2Vi VGhyZWFkKCkKICAgICAvLyBUaGUgd2ViIHRocmVhZCBpcyBhIHNlY29uZGFyeSB0aHJlYWQsIGFu ZCBzZWNvbmRhcnkgdGhyZWFkcyBhcmUgdXN1YWxseSBnaXZlbgogICAgIC8vIGEgNTEyIGtiIHN0 YWNrLCBidXQgd2UgbmVlZCBtb3JlIHNwYWNlIGluIG9yZGVyIHRvIGhhdmUgcm9vbSBmb3IgdGhl IEphdmFTY3JpcHRDb3JlCiAgICAgLy8gcmVlbnRyYW5jeSBsaW1pdC4gVGhpcyBsaW1pdCB3b3Jr cyBvbiBib3RoIHRoZSBzaW11bGF0b3IgYW5kIHRoZSBkZXZpY2UuCi0gICAgcHRocmVhZF9hdHRy X3NldHN0YWNrc2l6ZSgmdGF0dHIsIDIwMCAqIDQwOTYpOworICAgIHB0aHJlYWRfYXR0cl9zZXRz dGFja3NpemUoJnRhdHRyLCA4MDAgKiBLQik7CiAKLSAgICBzdHJ1Y3Qgc2NoZWRfcGFyYW0gcGFy YW07Ci0gICAgcHRocmVhZF9hdHRyX2dldHNjaGVkcGFyYW0oJnRhdHRyLCAmcGFyYW0pOwotICAg IHBhcmFtLnNjaGVkX3ByaW9yaXR5LS07Ci0gICAgcHRocmVhZF9hdHRyX3NldHNjaGVkcGFyYW0o JnRhdHRyLCAmcGFyYW0pOworICAgIHB0aHJlYWRfYXR0cl9zZXRfcW9zX2NsYXNzX25wKCZ0YXR0 ciwgUU9TX0NMQVNTX1VTRVJfSU5URVJBQ1RJVkUsIC0xMCk7CiAKICAgICAvLyBXYWl0IGZvciB0 aGUgd2ViIHRocmVhZCB0byBzdGFydHVwIGNvbXBsZXRlbHkgYmVmb3JlIHdlIGNvbnRpbnVlLgog ICAgIHsK 367283 2019-04-11 21:06:09 -0700 2019-04-11 22:21:44 -0700 Fixes the bug bug-196849-20190411210609.patch text/plain 1894 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NDIwOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA0LTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFdlYlRocmVhZCBzaG91bGQgcnVu IGF0IGEgaGlnaGVyIHByaW9yaXR5IHRoYW4gdXNlciBpbml0aWF0ZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njg0OQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNDY4NTEwNjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIFFPU19DTEFTU19VU0VSX0lOVEVSQUNUSVZFIG9uIFdlYlRocmVhZCB3 aXRoIC0xMCByZWxhdGl2ZSBwcmlvcml0eSBzbyB0aGF0IFdlYlRocmVhZAorICAgICAgICB3b24n dCB3YWl0IGZvciBvdGhlciB0aHJlYWRzIHdpdGggcHJpb3JpdHkgMzAtMzcgYnV0IGRvZXMgbm90 IGNvbnRlbnQgd2l0aCB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgQWxzbyByZW1vdmVkIHRo ZSBjYWxsIHRvIHB0aHJlYWRfYXR0cl9zZXRzY2hlZHBhcmFtIHdoaWNoIGRpc2FibGVzIFFvUy4K KworICAgICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbToKKyAgICAgICAg KFN0YXJ0V2ViVGhyZWFkKToKKwogMjAxOS0wNC0xMSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFRyeSB0byBmaXggV2luZG93cyBidWlsZC4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRocmVhZC5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dlYkNvcmVUaHJlYWQubW0JKHJldmlz aW9uIDI0NDIwOCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV2ViQ29yZVRo cmVhZC5tbQkod29ya2luZyBjb3B5KQpAQCAtNjY3LDEyICs2NjcsOSBAQCBzdGF0aWMgdm9pZCBT dGFydFdlYlRocmVhZCgpCiAgICAgLy8gVGhlIHdlYiB0aHJlYWQgaXMgYSBzZWNvbmRhcnkgdGhy ZWFkLCBhbmQgc2Vjb25kYXJ5IHRocmVhZHMgYXJlIHVzdWFsbHkgZ2l2ZW4KICAgICAvLyBhIDUx MiBrYiBzdGFjaywgYnV0IHdlIG5lZWQgbW9yZSBzcGFjZSBpbiBvcmRlciB0byBoYXZlIHJvb20g Zm9yIHRoZSBKYXZhU2NyaXB0Q29yZQogICAgIC8vIHJlZW50cmFuY3kgbGltaXQuIFRoaXMgbGlt aXQgd29ya3Mgb24gYm90aCB0aGUgc2ltdWxhdG9yIGFuZCB0aGUgZGV2aWNlLgotICAgIHB0aHJl YWRfYXR0cl9zZXRzdGFja3NpemUoJnRhdHRyLCAyMDAgKiA0MDk2KTsKKyAgICBwdGhyZWFkX2F0 dHJfc2V0c3RhY2tzaXplKCZ0YXR0ciwgODAwICogS0IpOwogCi0gICAgc3RydWN0IHNjaGVkX3Bh cmFtIHBhcmFtOwotICAgIHB0aHJlYWRfYXR0cl9nZXRzY2hlZHBhcmFtKCZ0YXR0ciwgJnBhcmFt KTsKLSAgICBwYXJhbS5zY2hlZF9wcmlvcml0eS0tOwotICAgIHB0aHJlYWRfYXR0cl9zZXRzY2hl ZHBhcmFtKCZ0YXR0ciwgJnBhcmFtKTsKKyAgICBwdGhyZWFkX2F0dHJfc2V0X3Fvc19jbGFzc19u cCgmdGF0dHIsIFFPU19DTEFTU19VU0VSX0lOVEVSQUNUSVZFLCAtMTApOwogCiAgICAgLy8gV2Fp dCBmb3IgdGhlIHdlYiB0aHJlYWQgdG8gc3RhcnR1cCBjb21wbGV0ZWx5IGJlZm9yZSB3ZSBjb250 aW51ZS4KICAgICB7Cg==