196842 2019-04-11 17:49:28 -0700 Remove invalid assertion in operationInstanceOfCustom 2019-04-11 18:04:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1526564 0 saam 2019-04-11 17:49:28 -0700 ... 1526565 1 saam 2019-04-11 17:50:12 -0700 <rdar://problem/49725493> 1526572 2 367272 saam 2019-04-11 17:58:37 -0700 Created attachment 367272 patch 1526574 3 367272 msaboff 2019-04-11 18:00:17 -0700 Comment on attachment 367272 patch View in context: https://bugs.webkit.org/attachment.cgi?id=367272&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + inlining accross global objects as exec->lexicalGlobalObject() uses the machine *across* 1526575 4 367272 saam 2019-04-11 18:00:51 -0700 Comment on attachment 367272 patch View in context: https://bugs.webkit.org/attachment.cgi?id=367272&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + inlining accross global objects as exec->lexicalGlobalObject() uses the machine > > *across* Thanks. Fixed. 1526577 5 saam 2019-04-11 18:04:49 -0700 landed in: https://trac.webkit.org/changeset/244206/webkit 367272 2019-04-11 17:58:37 -0700 2019-04-11 18:00:17 -0700 patch c-backup.diff text/plain 3270 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNDQyMDMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTExICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSBpbnZhbGlkIGFzc2VydGlvbiBpbiBvcGVyYXRpb25JbnN0 YW5jZU9mQ3VzdG9tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTY4NDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NzI1NDkzPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL29wZXJhdGlv bkluc3RhbmNlT2ZDdXN0b20tYmFkLWFzc2VydGlvbi5qczogQWRkZWQuCisgICAgICAgIChmb28p OgorCiAyMDE5LTA0LTEwICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAg ICAgIEFic3RyYWN0VmFsdWU6OnZhbGlkYXRlT1NSRW50cnlWYWx1ZSBpcyB3cm9uZyBmb3IgSW50 NTIgY29uc3RhbnRzCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9vcGVyYXRpb25JbnN0YW5jZU9mQ3Vz dG9tLWJhZC1hc3NlcnRpb24uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3Mvb3BlcmF0 aW9uSW5zdGFuY2VPZkN1c3RvbS1iYWQtYXNzZXJ0aW9uLmpzCShub25leGlzdGVudCkKKysrIEpT VGVzdHMvc3RyZXNzL29wZXJhdGlvbkluc3RhbmNlT2ZDdXN0b20tYmFkLWFzc2VydGlvbi5qcwko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDExIEBACitjb25zdCB4ID0gY3JlYXRlR2xvYmFsT2Jq ZWN0KCk7CisKK2Z1bmN0aW9uIGZvbyhyZXNvbHZlKSB7CisgICAgMCBpbnN0YW5jZW9mIHJlc29s dmU7Cit9CisKK25vSW5saW5lKHguUHJvbWlzZSk7CisKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAw MDsgaSsrKSB7CisgICAgbmV3IHguUHJvbWlzZShmb28pOworfQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCShyZXZpc2lvbiAyNDQxOTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTktMDQtMTEgIFNhYW0g YmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGludmFsaWQgYXNz ZXJ0aW9uIGluIG9wZXJhdGlvbkluc3RhbmNlT2ZDdXN0b20KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njg0MgorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDk3MjU0OTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW4gdGhlIGdlbmVyYXRlZCBKSVQgY29kZSwgd2UgZ28gdG8gdGhlIHNsb3cgcGF0aCB3 aGVuIHRoZSBpbmNvbWluZyBmdW5jdGlvbgorICAgICAgICBpc24ndCB0aGUgTm9kZSdzIENvZGVP cmlnaW4ncyBmdW5jdGlvblByb3RvSGFzSW5zdGFuY2VTeW1ib2xGdW5jdGlvbi4gSG93ZXZlciwK KyAgICAgICAgaW4gdGhlIEpJVCBvcGVyYXRpb24sIHdlIHdlcmUgYXNzZXJ0aW5nIGFnYWluc3Qg ZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpJ3MKKyAgICAgICAgZnVuY3Rpb25Qcm90b0hhc0lu c3RhbmNlU3ltYm9sRnVuY3Rpb24uIFRoYXQgYXNzZXJ0aW9uIG1pZ2h0IGJlIHdyb25nIHdoZW4K KyAgICAgICAgaW5saW5pbmcgYWNjcm9zcyBnbG9iYWwgb2JqZWN0cyBhcyBleGVjLT5sZXhpY2Fs R2xvYmFsT2JqZWN0KCkgdXNlcyB0aGUgbWFjaGluZQorICAgICAgICBmcmFtZSBmb3IgcHJvY3Vy aW5nIHRoZSBnbG9iYWwgb2JqZWN0LiBUaGVyZSBpcyBubyBoYXJtIHdoZW4gdGhpcyBhc3NlcnRp b24gZmFpbHMKKyAgICAgICAgYXMgd2UganVzdCBleGVjdXRlIHRoZSBzbG93IHBhdGguIFRoaXMg cGF0Y2ggcmVtb3ZlcyB0aGUgYXNzZXJ0aW9uLiAoSG93ZXZlciwgdGhpcworICAgICAgICBkb2Vz IHNoZWQgbGlnaHQgb24gdGhlIGRlZmljaWVuY3kgaW4gb3VyIGV4ZWMtPmxleGljYWxHbG9iYWxP YmplY3QoKSBmdW5jdGlvbiB3aXRoCisgICAgICAgIHJlc3BlY3QgdG8gaW5saW5pbmcuIEhvd2V2 ZXIsIHRoaXMgaXNuJ3QgbmV3IC0tIHdlJ3ZlIGtub3duIGFib3V0IHRoaXMgZm9yIGEgd2hpbGUu KQorCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuY3BwOgorCiAyMDE5LTA0LTExICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBU aW1lbGluZXM6IGNhbid0IHJlbGlhYmx5IHN0b3Avc3RhcnQgYSByZWNvcmRpbmcKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gMjQ0 MTk1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTgwMyw4ICsxODAzLDYgQEAgaW50MzJfdCBKSVRfT1BFUkFUSU9OIG9w ZXJhdGlvbkluc3RhbmNlTwogICAgIEpTVmFsdWUgdmFsdWUgPSBKU1ZhbHVlOjpkZWNvZGUoZW5j b2RlZFZhbHVlKTsKICAgICBKU1ZhbHVlIGhhc0luc3RhbmNlVmFsdWUgPSBKU1ZhbHVlOjpkZWNv ZGUoZW5jb2RlZEhhc0luc3RhbmNlKTsKIAotICAgIEFTU0VSVChoYXNJbnN0YW5jZVZhbHVlICE9 IGV4ZWMtPmxleGljYWxHbG9iYWxPYmplY3QoKS0+ZnVuY3Rpb25Qcm90b0hhc0luc3RhbmNlU3lt Ym9sRnVuY3Rpb24oKSB8fCAhY29uc3RydWN0b3ItPnN0cnVjdHVyZSh2bSktPnR5cGVJbmZvKCku aW1wbGVtZW50c0RlZmF1bHRIYXNJbnN0YW5jZSgpKTsKLQogICAgIGlmIChjb25zdHJ1Y3Rvci0+ aGFzSW5zdGFuY2UoZXhlYywgdmFsdWUsIGhhc0luc3RhbmNlVmFsdWUpKQogICAgICAgICByZXR1 cm4gMTsKICAgICByZXR1cm4gMDsK