196833 2019-04-11 15:28:30 -0700 Update 'Save Image' to more clear instructions 2019-04-12 14:31:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue wenson_hsieh oldest_to_newest 1526495 0 megan_gardner 2019-04-11 15:28:30 -0700 Update 'Save Image' to more clear instructions 1526500 1 367253 megan_gardner 2019-04-11 15:33:28 -0700 Created attachment 367253 Patch 1526501 2 megan_gardner 2019-04-11 15:33:52 -0700 <rdar://problem/47446845> 1526504 3 367253 wenson_hsieh 2019-04-11 15:42:38 -0700 Comment on attachment 367253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review > Source/WebCore/en.lproj/Localizable.strings:629 > -/* Title for Save Image action button */ > -"Save Image" = "Save Image"; > +/* Title for Add to Photos action button */ > +"Add to Photos" = "Add to Photos"; I think these are in sorted order. IIRC, Tools/Scripts/update-webkit-localizable-strings should do the trick. > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95 > +localizedStrings["Add to Photos"] = "Add to Photos"; Is this related? I think this is a separate web inspector feature... > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:951 > + contextMenu.appendItem(WI.UIString("Add to Photos"), () => { (Here too) 1526505 4 367253 wenson_hsieh 2019-04-11 15:45:08 -0700 Comment on attachment 367253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367253&action=review >> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:95 >> +localizedStrings["Add to Photos"] = "Add to Photos"; > > Is this related? I think this is a separate web inspector feature... This is the feature Devin added in WI that allows us to snapshot a DOM node. We don't want to change this string. 1526506 5 367254 megan_gardner 2019-04-11 15:50:33 -0700 Created attachment 367254 Patch 1526509 6 367254 wenson_hsieh 2019-04-11 15:52:18 -0700 Comment on attachment 367254 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367254&action=review > Source/WebInspectorUI/ChangeLog:15 > + Let's remove this ChangeLog entry. 1526520 7 367258 megan_gardner 2019-04-11 16:06:16 -0700 Created attachment 367258 Patch 1526521 8 megan_gardner 2019-04-11 16:06:47 -0700 Sorry, I meant to, I guess I missed it. 1526573 9 367258 commit-queue 2019-04-11 17:58:56 -0700 Comment on attachment 367258 Patch Clearing flags on attachment: 367258 Committed r244205: <https://trac.webkit.org/changeset/244205> 367253 2019-04-11 15:33:28 -0700 2019-04-11 15:50:32 -0700 Patch bug-196833-20190411153327.patch text/plain 6052 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ1YzhmOTNhY2U1ZTM0 ZWQ4OGI0OGY2NWI5ZDc2NDY3NTRhZGIyNS4uMzE3ZWMxMDA2NjEzN2Q5ZTllODkzZDQzY2NjZjMx Y2M4ZTVhYTdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTExICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlICdT YXZlIEltYWdlJyB0byBtb3JlIGNsZWFyIGluc3RydWN0aW9ucworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODMzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzQ0Njg0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBOb3QgdGVzdGFibGUsIFVJIGNoYW5nZSBvbmx5LgorCisgICAgICAgICogZW4ubHBy b2ovTG9jYWxpemFibGUuc3RyaW5nczoKKwogMjAxOS0wNC0xMSAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyB0aGUgTWVkaWFTb3VyY2UgQVBJ IHRvIGJlIGVuYWJsZWQgdmlhIHdlYnNpdGUgcG9saWN5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpp bmRleCA4YTEwM2FlZTg4YzNjZjZhMDFjMmM4NDNkNDFlMjg4OTUzNzJhOWMzLi4zNGRhN2FiMTZh MTVkNzliYTNmYjljMWRkZjYyZjYzNmIzZWQ5NGQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAxOS0wNC0xMSAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRu ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSAnU2F2ZSBJbWFnZScgdG8gbW9yZSBjbGVh ciBpbnN0cnVjdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NjgzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc0NDY4NDU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCB1cGRhdGluZyB0 byBhIG5ldyBzdHJpbmcuCisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVz c2FnZVZpZXcuanM6CisgICAgICAgIChXSS5Db25zb2xlTWVzc2FnZVZpZXcucHJvdG90eXBlLl9o YW5kbGVDb250ZXh0TWVudSk6CisgICAgICAgIChXSS5Db25zb2xlTWVzc2FnZVZpZXcpOgorCiAy MDE5LTA0LTExICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBUaW1lbGluZXM6IGNhbid0IHJlbGlhYmx5IHN0b3Avc3RhcnQgYSByZWNv cmRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKaW5kZXggNDUzZTBlZjZiODMyYzkyMTkyZGYzOGJkODJlMDU4NDQ2MTA0NGM0 NC4uMTFiMDBjNGJiOWVhYzhlOWY5YmYzODBiNjk2OGQzNTFiMzg0N2VmOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxOS0wNC0xMSAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJA YXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSAnU2F2ZSBJbWFnZScgdG8gbW9yZSBjbGVhciBp bnN0cnVjdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NjgzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc0NDY4NDU+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCB1cGRhdGluZyB0byBh IG5ldyBzdHJpbmcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRB Y3Rpb24ubW06CisgICAgICAgICgrW19XS0VsZW1lbnRBY3Rpb24gX2VsZW1lbnRBY3Rpb25XaXRo VHlwZTpjdXN0b21UaXRsZTphc3Npc3RhbnQ6XSk6CisKIDIwMTktMDQtMTEgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgdGhlIE1lZGlhU291 cmNlIEFQSSB0byBiZSBlbmFibGVkIHZpYSB3ZWJzaXRlIHBvbGljeQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncyBiL1NvdXJjZS9XZWJDb3Jl L2VuLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggYmMxODU0ZWFlYzNkMDliN2QxZGFk NjU3NmFiNDA3ZDY0YmE2ZGVlMi4uNTFkMTNiODk1MGVjMGNiYTYyMjc2ZDczODIwNjgzOGU5ZGU4 MjNmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3Ry aW5ncworKysgYi9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCkBA IC02MjUsOCArNjI1LDggQEAKIC8qIFJpZ2h0IHRvIExlZnQgY29udGV4dCBtZW51IGl0ZW0gKi8K ICJSaWdodCB0byBMZWZ0IiA9ICJSaWdodCB0byBMZWZ0IjsKIAotLyogVGl0bGUgZm9yIFNhdmUg SW1hZ2UgYWN0aW9uIGJ1dHRvbiAqLwotIlNhdmUgSW1hZ2UiID0gIlNhdmUgSW1hZ2UiOworLyog VGl0bGUgZm9yIEFkZCB0byBQaG90b3MgYWN0aW9uIGJ1dHRvbiAqLworIkFkZCB0byBQaG90b3Mi ID0gIkFkZCB0byBQaG90b3MiOwogCiAvKiBUaXRsZSBvZiB0aGUgU2VhcmNoIGJ1dHRvbiBmb3Ig em9vbWVkIGZvcm0gY29udHJvbHMuICovCiAiU2VhcmNoIiA9ICJTZWFyY2giOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVk U3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9q L2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggYjZmOWJmZDIzMmEwOWEzZGJlMWUwZGQ4ZDZjNmQ0 NjE1YjQwZTI2YS4uMTNhNTVmNThmNDhhYzRkZmYxYjlkZmZiODI0NDFmYTc0NzEzMTM0MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9j YWxpemVkU3RyaW5ncy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9u cy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCkBAIC05Miw2ICs5Miw3IEBAIGxvY2FsaXpl ZFN0cmluZ3NbIkFkZCBhIENsYXNzIl0gPSAiQWRkIGEgQ2xhc3MiOwogbG9jYWxpemVkU3RyaW5n c1siQWRkIG5ldyBicmVha3BvaW50IGFjdGlvbiBhZnRlciB0aGlzIGFjdGlvbiJdID0gIkFkZCBu ZXcgYnJlYWtwb2ludCBhY3Rpb24gYWZ0ZXIgdGhpcyBhY3Rpb24iOwogbG9jYWxpemVkU3RyaW5n c1siQWRkIG5ldyBydWxlIl0gPSAiQWRkIG5ldyBydWxlIjsKIGxvY2FsaXplZFN0cmluZ3NbIkFk ZCBwcm9iZSBleHByZXNzaW9uIl0gPSAiQWRkIHByb2JlIGV4cHJlc3Npb24iOworbG9jYWxpemVk U3RyaW5nc1siQWRkIHRvIFBob3RvcyJdID0gIkFkZCB0byBQaG90b3MiOwogbG9jYWxpemVkU3Ry aW5nc1siQWRkIHdhdGNoIGV4cHJlc3Npb24iXSA9ICJBZGQgd2F0Y2ggZXhwcmVzc2lvbiI7CiBs b2NhbGl6ZWRTdHJpbmdzWyJBZGRpdGlvbnMiXSA9ICJBZGRpdGlvbnMiOwogbG9jYWxpemVkU3Ry aW5nc1siQWRkcmVzcyJdID0gIkFkZHJlc3MiOwpAQCAtODc1LDcgKzg3Niw2IEBAIGxvY2FsaXpl ZFN0cmluZ3NbIlNWRyJdID0gIlNWRyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTYW1wbGVzIl0gPSAi U2FtcGxlcyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTYXZlICVkIl0gPSAiU2F2ZSAlZCI7CiBsb2Nh bGl6ZWRTdHJpbmdzWyJTYXZlIEZpbGUiXSA9ICJTYXZlIEZpbGUiOwotbG9jYWxpemVkU3RyaW5n c1siU2F2ZSBJbWFnZSJdID0gIlNhdmUgSW1hZ2UiOwogbG9jYWxpemVkU3RyaW5nc1siU2F2ZSBT ZWxlY3RlZCJdID0gIlNhdmUgU2VsZWN0ZWQiOwogbG9jYWxpemVkU3RyaW5nc1siU2F2ZSBjb25m aWd1cmF0aW9uIl0gPSAiU2F2ZSBjb25maWd1cmF0aW9uIjsKIGxvY2FsaXplZFN0cmluZ3NbIlNh dmVkIFN0YXRlcyJdID0gIlNhdmVkIFN0YXRlcyI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVzc2FnZVZpZXcu anMKaW5kZXggMjNhYzA2Y2Y5YTg5NzE1MzBlODZkZTM3Y2RkMThlOTE1MWY4NTIzYy4uM2VlYjc2 M2M5MGU4ODI5NDAyNTdlMDEzZjc1MDgxZTc0OGFlYjE2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZU1lc3NhZ2VWaWV3LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVNZXNz YWdlVmlldy5qcwpAQCAtOTQ4LDcgKzk0OCw3IEBAIFdJLkNvbnNvbGVNZXNzYWdlVmlldyA9IGNs YXNzIENvbnNvbGVNZXNzYWdlVmlldyBleHRlbmRzIFdJLk9iamVjdAogCiAgICAgICAgIGxldCBj b250ZXh0TWVudSA9IFdJLkNvbnRleHRNZW51LmNyZWF0ZUZyb21FdmVudChldmVudCk7CiAKLSAg ICAgICAgY29udGV4dE1lbnUuYXBwZW5kSXRlbShXSS5VSVN0cmluZygiU2F2ZSBJbWFnZSIpLCAo KSA9PiB7CisgICAgICAgIGNvbnRleHRNZW51LmFwcGVuZEl0ZW0oV0kuVUlTdHJpbmcoIkFkZCB0 byBQaG90b3MiKSwgKCkgPT4gewogICAgICAgICAgICAgY29uc3QgZm9yY2VTYXZlQXMgPSB0cnVl OwogICAgICAgICAgICAgV0kuRmlsZVV0aWxpdGllcy5zYXZlKHsKICAgICAgICAgICAgICAgICB1 cmw6IFdJLkZpbGVVdGlsaXRpZXMuaW5zcGVjdG9yVVJMRm9yRmlsZW5hbWUoaW1hZ2UuZ2V0QXR0 cmlidXRlKCJmaWxlbmFtZSIpKSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24ubW0KaW5kZXggM2M1MTBmNDMwMDJmOGM1YzllNjAy ZmU4ZDNhYjhiMTQyOGYyZDU4YS4uMjNjNGY2NTdhNTk1MmU3Yjg5YTUwNGE4ZjE2NzllMDAzYThi MDdjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0Vs ZW1lbnRBY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19X S0VsZW1lbnRBY3Rpb24ubW0KQEAgLTExMyw3ICsxMTMsNyBAQCArIChpbnN0YW5jZXR5cGUpX2Vs ZW1lbnRBY3Rpb25XaXRoVHlwZTooX1dLRWxlbWVudEFjdGlvblR5cGUpdHlwZSBjdXN0b21UaXRs ZTooTgogICAgICAgICB9OwogICAgICAgICBicmVhazsKICAgICBjYXNlIF9XS0VsZW1lbnRBY3Rp b25UeXBlU2F2ZUltYWdlOgotICAgICAgICB0aXRsZSA9IFdFQl9VSV9TVFJJTkcoIlNhdmUgSW1h Z2UiLCAiVGl0bGUgZm9yIFNhdmUgSW1hZ2UgYWN0aW9uIGJ1dHRvbiIpOworICAgICAgICB0aXRs ZSA9IFdFQl9VSV9TVFJJTkcoIkFkZCB0byBQaG90b3MiLCAiVGl0bGUgZm9yIEFkZCB0byBQaG90 b3MgYWN0aW9uIGJ1dHRvbiIpOwogICAgICAgICBoYW5kbGVyID0gXihXS0FjdGlvblNoZWV0QXNz aXN0YW50ICphc3Npc3RhbnQsIF9XS0FjdGl2YXRlZEVsZW1lbnRJbmZvICphY3Rpb25JbmZvKSB7 CiAgICAgICAgICAgICBbYXNzaXN0YW50LmRlbGVnYXRlIGFjdGlvblNoZWV0QXNzaXN0YW50OmFz c2lzdGFudCBwZXJmb3JtQWN0aW9uOldlYktpdDo6U2hlZXRBY3Rpb246OlNhdmVJbWFnZV07CiAg ICAgICAgIH07Cg== 367254 2019-04-11 15:50:33 -0700 2019-04-12 14:29:35 -0700 Patch bug-196833-20190411155033.patch text/plain 4163 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ1YzhmOTNhY2U1ZTM0 ZWQ4OGI0OGY2NWI5ZDc2NDY3NTRhZGIyNS4uMzE3ZWMxMDA2NjEzN2Q5ZTllODkzZDQzY2NjZjMx Y2M4ZTVhYTdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTExICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlICdT YXZlIEltYWdlJyB0byBtb3JlIGNsZWFyIGluc3RydWN0aW9ucworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODMzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzQ0Njg0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBOb3QgdGVzdGFibGUsIFVJIGNoYW5nZSBvbmx5LgorCisgICAgICAgICogZW4ubHBy b2ovTG9jYWxpemFibGUuc3RyaW5nczoKKwogMjAxOS0wNC0xMSAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyB0aGUgTWVkaWFTb3VyY2UgQVBJ IHRvIGJlIGVuYWJsZWQgdmlhIHdlYnNpdGUgcG9saWN5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwpp bmRleCA4YTEwM2FlZTg4YzNjZjZhMDFjMmM4NDNkNDFlMjg4OTUzNzJhOWMzLi4zNGRhN2FiMTZh MTVkNzliYTNmYjljMWRkZjYyZjYzNmIzZWQ5NGQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAxOS0wNC0xMSAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRu ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSAnU2F2ZSBJbWFnZScgdG8gbW9yZSBjbGVh ciBpbnN0cnVjdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NjgzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc0NDY4NDU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCB1cGRhdGluZyB0 byBhIG5ldyBzdHJpbmcuCisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlTWVz c2FnZVZpZXcuanM6CisgICAgICAgIChXSS5Db25zb2xlTWVzc2FnZVZpZXcucHJvdG90eXBlLl9o YW5kbGVDb250ZXh0TWVudSk6CisgICAgICAgIChXSS5Db25zb2xlTWVzc2FnZVZpZXcpOgorCiAy MDE5LTA0LTExICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBUaW1lbGluZXM6IGNhbid0IHJlbGlhYmx5IHN0b3Avc3RhcnQgYSByZWNv cmRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKaW5kZXggNDUzZTBlZjZiODMyYzkyMTkyZGYzOGJkODJlMDU4NDQ2MTA0NGM0 NC4uMTFiMDBjNGJiOWVhYzhlOWY5YmYzODBiNjk2OGQzNTFiMzg0N2VmOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxOS0wNC0xMSAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJA YXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSAnU2F2ZSBJbWFnZScgdG8gbW9yZSBjbGVhciBp bnN0cnVjdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NjgzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDc0NDY4NDU+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCB1cGRhdGluZyB0byBh IG5ldyBzdHJpbmcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRB Y3Rpb24ubW06CisgICAgICAgICgrW19XS0VsZW1lbnRBY3Rpb24gX2VsZW1lbnRBY3Rpb25XaXRo VHlwZTpjdXN0b21UaXRsZTphc3Npc3RhbnQ6XSk6CisKIDIwMTktMDQtMTEgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWxsb3cgdGhlIE1lZGlhU291 cmNlIEFQSSB0byBiZSBlbmFibGVkIHZpYSB3ZWJzaXRlIHBvbGljeQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncyBiL1NvdXJjZS9XZWJDb3Jl L2VuLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggYmMxODU0ZWFlYzNkMDliN2QxZGFk NjU3NmFiNDA3ZDY0YmE2ZGVlMi4uZTFkZGM0YjFjNzJmOTk5ODMzOGI1OGVkZWY2MzFmNTY5ZTc5 MDdkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZW4ubHByb2ovTG9jYWxpemFibGUuc3Ry aW5ncworKysgYi9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCkBA IC05NCw2ICs5NCw5IEBACiAvKiBXS0Vycm9ySmF2YVNjcmlwdEV4Y2VwdGlvbk9jY3VycmVkIGRl c2NyaXB0aW9uICovCiAiQSBKYXZhU2NyaXB0IGV4Y2VwdGlvbiBvY2N1cnJlZCIgPSAiQSBKYXZh U2NyaXB0IGV4Y2VwdGlvbiBvY2N1cnJlZCI7CiAKKy8qIFRpdGxlIGZvciBBZGQgdG8gUGhvdG9z IGFjdGlvbiBidXR0b24gKi8KKyJBZGQgdG8gUGhvdG9zIiA9ICJBZGQgdG8gUGhvdG9zIjsKKwog LyogVGl0bGUgZm9yIEFkZCB0byBSZWFkaW5nIExpc3QgYWN0aW9uIGJ1dHRvbiAqLwogIkFkZCB0 byBSZWFkaW5nIExpc3QiID0gIkFkZCB0byBSZWFkaW5nIExpc3QiOwogCkBAIC02MjUsOSArNjI4 LDYgQEAKIC8qIFJpZ2h0IHRvIExlZnQgY29udGV4dCBtZW51IGl0ZW0gKi8KICJSaWdodCB0byBM ZWZ0IiA9ICJSaWdodCB0byBMZWZ0IjsKIAotLyogVGl0bGUgZm9yIFNhdmUgSW1hZ2UgYWN0aW9u IGJ1dHRvbiAqLwotIlNhdmUgSW1hZ2UiID0gIlNhdmUgSW1hZ2UiOwotCiAvKiBUaXRsZSBvZiB0 aGUgU2VhcmNoIGJ1dHRvbiBmb3Igem9vbWVkIGZvcm0gY29udHJvbHMuICovCiAiU2VhcmNoIiA9 ICJTZWFyY2giOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLRWxlbWVudEFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tFbGVtZW50QWN0aW9uLm1tCmluZGV4IDNjNTEwZjQzMDAyZjhjNWM5ZTYwMmZlOGQzYWI4 YjE0MjhmMmQ1OGEuLjIzYzRmNjU3YTU5NTJlN2I4OWE1MDRhOGYxNjc5ZTAwM2E4YjA3YzEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0 aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50 QWN0aW9uLm1tCkBAIC0xMTMsNyArMTEzLDcgQEAgKyAoaW5zdGFuY2V0eXBlKV9lbGVtZW50QWN0 aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBlKXR5cGUgY3VzdG9tVGl0bGU6KE4KICAg ICAgICAgfTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBfV0tFbGVtZW50QWN0aW9uVHlwZVNh dmVJbWFnZToKLSAgICAgICAgdGl0bGUgPSBXRUJfVUlfU1RSSU5HKCJTYXZlIEltYWdlIiwgIlRp dGxlIGZvciBTYXZlIEltYWdlIGFjdGlvbiBidXR0b24iKTsKKyAgICAgICAgdGl0bGUgPSBXRUJf VUlfU1RSSU5HKCJBZGQgdG8gUGhvdG9zIiwgIlRpdGxlIGZvciBBZGQgdG8gUGhvdG9zIGFjdGlv biBidXR0b24iKTsKICAgICAgICAgaGFuZGxlciA9IF4oV0tBY3Rpb25TaGVldEFzc2lzdGFudCAq YXNzaXN0YW50LCBfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAqYWN0aW9uSW5mbykgewogICAgICAg ICAgICAgW2Fzc2lzdGFudC5kZWxlZ2F0ZSBhY3Rpb25TaGVldEFzc2lzdGFudDphc3Npc3RhbnQg cGVyZm9ybUFjdGlvbjpXZWJLaXQ6OlNoZWV0QWN0aW9uOjpTYXZlSW1hZ2VdOwogICAgICAgICB9 Owo= 367258 2019-04-11 16:06:16 -0700 2019-04-11 17:58:56 -0700 Patch bug-196833-20190411160616.patch text/plain 3279 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmQ1YzhmOTNhY2U1ZTM0 ZWQ4OGI0OGY2NWI5ZDc2NDY3NTRhZGIyNS4uMzE3ZWMxMDA2NjEzN2Q5ZTllODkzZDQzY2NjZjMx Y2M4ZTVhYTdmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTExICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlICdT YXZlIEltYWdlJyB0byBtb3JlIGNsZWFyIGluc3RydWN0aW9ucworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODMzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NzQ0Njg0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBOb3QgdGVzdGFibGUsIFVJIGNoYW5nZSBvbmx5LgorCisgICAgICAgICogZW4ubHBy b2ovTG9jYWxpemFibGUuc3RyaW5nczoKKwogMjAxOS0wNC0xMSAgV2Vuc29uIEhzaWVoICA8d2Vu c29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyB0aGUgTWVkaWFTb3VyY2UgQVBJ IHRvIGJlIGVuYWJsZWQgdmlhIHdlYnNpdGUgcG9saWN5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ1M2UwZWY2Yjgz MmM5MjE5MmRmMzhiZDgyZTA1ODQ0NjEwNDRjNDQuLjExYjAwYzRiYjllYWM4ZTlmOWJmMzgwYjY5 NjhkMzUxYjM4NDdlZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDQtMTEgIE1l Z2FuIEdhcmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUg J1NhdmUgSW1hZ2UnIHRvIG1vcmUgY2xlYXIgaW5zdHJ1Y3Rpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY4MzMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzQ3NDQ2ODQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEp1c3QgdXBkYXRpbmcgdG8gYSBuZXcgc3RyaW5nLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tOgorICAgICAgICAoK1tfV0tFbGVt ZW50QWN0aW9uIF9lbGVtZW50QWN0aW9uV2l0aFR5cGU6Y3VzdG9tVGl0bGU6YXNzaXN0YW50Ol0p OgorCiAyMDE5LTA0LTExICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgog CiAgICAgICAgIEFsbG93IHRoZSBNZWRpYVNvdXJjZSBBUEkgdG8gYmUgZW5hYmxlZCB2aWEgd2Vi c2l0ZSBwb2xpY3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VuLmxwcm9qL0xvY2FsaXph YmxlLnN0cmluZ3MgYi9Tb3VyY2UvV2ViQ29yZS9lbi5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdz CmluZGV4IGJjMTg1NGVhZWMzZDA5YjdkMWRhZDY1NzZhYjQwN2Q2NGJhNmRlZTIuLmUxZGRjNGIx YzcyZjk5OTgzMzhiNThlZGVmNjMxZjU2OWU3OTA3ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2VuLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKKysrIGIvU291cmNlL1dlYkNvcmUvZW4u bHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwpAQCAtOTQsNiArOTQsOSBAQAogLyogV0tFcnJvckph dmFTY3JpcHRFeGNlcHRpb25PY2N1cnJlZCBkZXNjcmlwdGlvbiAqLwogIkEgSmF2YVNjcmlwdCBl eGNlcHRpb24gb2NjdXJyZWQiID0gIkEgSmF2YVNjcmlwdCBleGNlcHRpb24gb2NjdXJyZWQiOwog CisvKiBUaXRsZSBmb3IgQWRkIHRvIFBob3RvcyBhY3Rpb24gYnV0dG9uICovCisiQWRkIHRvIFBo b3RvcyIgPSAiQWRkIHRvIFBob3RvcyI7CisKIC8qIFRpdGxlIGZvciBBZGQgdG8gUmVhZGluZyBM aXN0IGFjdGlvbiBidXR0b24gKi8KICJBZGQgdG8gUmVhZGluZyBMaXN0IiA9ICJBZGQgdG8gUmVh ZGluZyBMaXN0IjsKIApAQCAtNjI1LDkgKzYyOCw2IEBACiAvKiBSaWdodCB0byBMZWZ0IGNvbnRl eHQgbWVudSBpdGVtICovCiAiUmlnaHQgdG8gTGVmdCIgPSAiUmlnaHQgdG8gTGVmdCI7CiAKLS8q IFRpdGxlIGZvciBTYXZlIEltYWdlIGFjdGlvbiBidXR0b24gKi8KLSJTYXZlIEltYWdlIiA9ICJT YXZlIEltYWdlIjsKLQogLyogVGl0bGUgb2YgdGhlIFNlYXJjaCBidXR0b24gZm9yIHpvb21lZCBm b3JtIGNvbnRyb2xzLiAqLwogIlNlYXJjaCIgPSAiU2VhcmNoIjsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24ubW0gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbQppbmRleCAz YzUxMGY0MzAwMmY4YzVjOWU2MDJmZThkM2FiOGIxNDI4ZjJkNThhLi4yM2M0ZjY1N2E1OTUyZTdi ODlhNTA0YThmMTY3OWUwMDNhOGIwN2MxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFjdGlvbi5tbQpAQCAtMTEzLDcgKzExMyw3IEBA ICsgKGluc3RhbmNldHlwZSlfZWxlbWVudEFjdGlvbldpdGhUeXBlOihfV0tFbGVtZW50QWN0aW9u VHlwZSl0eXBlIGN1c3RvbVRpdGxlOihOCiAgICAgICAgIH07CiAgICAgICAgIGJyZWFrOwogICAg IGNhc2UgX1dLRWxlbWVudEFjdGlvblR5cGVTYXZlSW1hZ2U6Ci0gICAgICAgIHRpdGxlID0gV0VC X1VJX1NUUklORygiU2F2ZSBJbWFnZSIsICJUaXRsZSBmb3IgU2F2ZSBJbWFnZSBhY3Rpb24gYnV0 dG9uIik7CisgICAgICAgIHRpdGxlID0gV0VCX1VJX1NUUklORygiQWRkIHRvIFBob3RvcyIsICJU aXRsZSBmb3IgQWRkIHRvIFBob3RvcyBhY3Rpb24gYnV0dG9uIik7CiAgICAgICAgIGhhbmRsZXIg PSBeKFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKmFzc2lzdGFudCwgX1dLQWN0aXZhdGVkRWxlbWVu dEluZm8gKmFjdGlvbkluZm8pIHsKICAgICAgICAgICAgIFthc3Npc3RhbnQuZGVsZWdhdGUgYWN0 aW9uU2hlZXRBc3Npc3RhbnQ6YXNzaXN0YW50IHBlcmZvcm1BY3Rpb246V2ViS2l0OjpTaGVldEFj dGlvbjo6U2F2ZUltYWdlXTsKICAgICAgICAgfTsK