196832 2019-04-11 15:22:43 -0700 Web Inspector: REGRESSION(r244195): Timelines: unable to take heap snapshot 2019-04-11 15:56:47 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes simon.fraser webkit-bug-importer oldest_to_newest 1526490 0 hi 2019-04-11 15:22:43 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Timelines tab 3. enable the JavaScript Allocations timeline 4. select the JavaScript Allocations timeline 5. take a heap snapshot 1526491 1 hi 2019-04-11 15:22:56 -0700 <rdar://problem/49828862> 1526492 2 367249 hi 2019-04-11 15:23:28 -0700 Created attachment 367249 Patch 1526493 3 367249 simon.fraser 2019-04-11 15:27:32 -0700 Comment on attachment 367249 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367249&action=review > Source/WebInspectorUI/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). > + > + * UserInterface/Controllers/TimelineManager.js: Word here please like "This regressed when I discombobulated the rotary encabulator". 1526496 4 367251 hi 2019-04-11 15:29:52 -0700 Created attachment 367251 Patch 1526512 5 367251 commit-queue 2019-04-11 15:56:45 -0700 Comment on attachment 367251 Patch Clearing flags on attachment: 367251 Committed r244199: <https://trac.webkit.org/changeset/244199> 1526513 6 commit-queue 2019-04-11 15:56:47 -0700 All reviewed patches have been landed. Closing bug. 367249 2019-04-11 15:23:28 -0700 2019-04-11 15:29:50 -0700 Patch bug-196832-20190411152327.patch text/plain 1832 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhMTAzYWVlODhjM2NmNmEwMWMyYzg0M2Q0MWUy ODg5NTM3MmE5YzMuLjkzNWMwYjgxYmMzMWIzZjU2MGFlYmU0ZTMxZTA3ZjJjYWVjZDUxYjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTExICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDQxOTUpOiBUaW1lbGluZXM6IHVuYWJsZSB0byB0YWtlIGhlYXAgc25hcHNo b3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njgz MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk4Mjg4NjI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L1RpbWVsaW5lTWFuYWdlci5qczoKKyAgICAgICAgKFdJLlRpbWVsaW5lTWFuYWdlci5wcm90b3R5 cGUuaGVhcFNuYXBzaG90QWRkZWQpOgorICAgICAgICAoV0kuVGltZWxpbmVNYW5hZ2VyLnByb3Rv dHlwZS5fYWRkUmVjb3JkKToKKwogMjAxOS0wNC0xMSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVzOiBjYW4ndCByZWxp YWJseSBzdG9wL3N0YXJ0IGEgcmVjb3JkaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFn ZXIuanMKaW5kZXggODIyYzQwNTMwYTM1MDNlYWQ2OTQ0MjM5MDg0YmEyOGExYmNkM2RhNi4uYmI1 MmRjZjU3NjhkZWMxYjJhODE5MWUwMTQ2YzkxMTgzODdjNjVkYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2Vy LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJz L1RpbWVsaW5lTWFuYWdlci5qcwpAQCAtNTgyLDEwICs1ODIsNiBAQCBXSS5UaW1lbGluZU1hbmFn ZXIgPSBjbGFzcyBUaW1lbGluZU1hbmFnZXIgZXh0ZW5kcyBXSS5PYmplY3QKICAgICB7CiAgICAg ICAgIC8vIENhbGxlZCBmcm9tIFdJLkhlYXBBbGxvY2F0aW9uc0luc3RydW1lbnQuCiAKLSAgICAg ICAgY29uc29sZS5hc3NlcnQodGhpcy5pc0NhcHR1cmluZygpKTsKLSAgICAgICAgaWYgKCF0aGlz LmlzQ2FwdHVyaW5nKCkpCi0gICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgdGhpcy5fYWRk UmVjb3JkKG5ldyBXSS5IZWFwQWxsb2NhdGlvbnNUaW1lbGluZVJlY29yZCh0aW1lc3RhbXAsIHNu YXBzaG90KSk7CiAgICAgfQogCkBAIC04NjAsOCArODU2LDYgQEAgV0kuVGltZWxpbmVNYW5hZ2Vy ID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAKICAgICBfYWRkUmVj b3JkKHJlY29yZCkKICAgICB7Ci0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuaXNDYXB0dXJp bmcoKSk7Ci0KICAgICAgICAgdGhpcy5fYWN0aXZlUmVjb3JkaW5nLmFkZFJlY29yZChyZWNvcmQp OwogCiAgICAgICAgIC8vIE9ubHkgd29ycnkgYWJvdXQgZGVhZCB0aW1lIGFmdGVyIHRoZSBsb2Fk IGV2ZW50Lgo= 367251 2019-04-11 15:29:52 -0700 2019-04-11 15:56:45 -0700 Patch bug-196832-20190411152951.patch text/plain 2028 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhMTAzYWVlODhjM2NmNmEwMWMyYzg0M2Q0MWUy ODg5NTM3MmE5YzMuLjkzODM1NTE2MTc2MDYwMzQxODYzMWUzNDNlZjc5ODI1M2FmOGQzMjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA0LTExICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OKHIyNDQxOTUpOiBUaW1lbGluZXM6IHVuYWJsZSB0byB0YWtlIGhlYXAgc25hcHNo b3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njgz MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk4Mjg4NjI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9U aW1lbGluZU1hbmFnZXIuanM6CisgICAgICAgIChXSS5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBl LmhlYXBTbmFwc2hvdEFkZGVkKToKKyAgICAgICAgKFdJLlRpbWVsaW5lTWFuYWdlci5wcm90b3R5 cGUuX2FkZFJlY29yZCk6CisgICAgICAgIEhlYXAgc25hcHNob3RzIGNhbiBiZSB0YWtlbiBvdXRz aWRlIG9mIGEgdGltZWxpbmUgcmVjb3JkaW5nLCBzbyByZW1vdmUgdGhlIGVhcmx5IHJldHVybiAo YW5kCisgICAgICAgIGFzc2VydGlvbikgdGhhdCBjaGVja3MgZm9yIGFuIGFjdGl2ZSByZWNvcmRp bmcgYmVmb3JlIGFkZGluZyB0aGUgaGVhcCBzbmFwc2hvdCByZWNvcmQuCisKIDIwMTktMDQtMTEg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFRpbWVsaW5lczogY2FuJ3QgcmVsaWFibHkgc3RvcC9zdGFydCBhIHJlY29yZGluZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMv VGltZWxpbmVNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Q29udHJvbGxlcnMvVGltZWxpbmVNYW5hZ2VyLmpzCmluZGV4IDgyMmM0MDUzMGEzNTAzZWFkNjk0 NDIzOTA4NGJhMjhhMWJjZDNkYTYuLmJiNTJkY2Y1NzY4ZGVjMWIyYTgxOTFlMDE0NmM5MTE4Mzg3 YzY1ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Nv bnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAgLTU4MiwxMCAr NTgyLDYgQEAgV0kuVGltZWxpbmVNYW5hZ2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVu ZHMgV0kuT2JqZWN0CiAgICAgewogICAgICAgICAvLyBDYWxsZWQgZnJvbSBXSS5IZWFwQWxsb2Nh dGlvbnNJbnN0cnVtZW50LgogCi0gICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMuaXNDYXB0dXJp bmcoKSk7Ci0gICAgICAgIGlmICghdGhpcy5pc0NhcHR1cmluZygpKQotICAgICAgICAgICAgcmV0 dXJuOwotCiAgICAgICAgIHRoaXMuX2FkZFJlY29yZChuZXcgV0kuSGVhcEFsbG9jYXRpb25zVGlt ZWxpbmVSZWNvcmQodGltZXN0YW1wLCBzbmFwc2hvdCkpOwogICAgIH0KIApAQCAtODYwLDggKzg1 Niw2IEBAIFdJLlRpbWVsaW5lTWFuYWdlciA9IGNsYXNzIFRpbWVsaW5lTWFuYWdlciBleHRlbmRz IFdJLk9iamVjdAogCiAgICAgX2FkZFJlY29yZChyZWNvcmQpCiAgICAgewotICAgICAgICBjb25z b2xlLmFzc2VydCh0aGlzLmlzQ2FwdHVyaW5nKCkpOwotCiAgICAgICAgIHRoaXMuX2FjdGl2ZVJl Y29yZGluZy5hZGRSZWNvcmQocmVjb3JkKTsKIAogICAgICAgICAvLyBPbmx5IHdvcnJ5IGFib3V0 IGRlYWQgdGltZSBhZnRlciB0aGUgbG9hZCBldmVudC4K