196814 2019-04-11 04:34:20 -0700 [MotionMark] The text "kkkj" is causing Firefox console warning: `unreachable code after return statement` 2019-04-16 13:52:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Trivial --- 1 howaboutsynergy jonlee cdumez commit-queue ews-watchlist howaboutsynergy jonlee lforschler rniwa sabouhallawa webkit-bug-importer wenson_hsieh oldest_to_newest 1526348 0 howaboutsynergy 2019-04-11 04:34:20 -0700 See https://github.com/WebKit/webkit/search?utf8=%E2%9C%93&q=kkkj&type= or: $ grep -nrIFw kkkj Websites/browserbench.org/MotionMark1.1/resources/extensions.js:403: return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj Websites/browserbench.org/MotionMark/resources/extensions.js:374: return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj PerformanceTests/MotionMark/resources/extensions.js:403: return ((this._a.y * t + this._b.y) * t + this._c.y) * t;kkkj This looks like navigation text from an editor(like vim, emacs) where pressing 'k' causes cursor to go up one line, 'j' is go down one line, 'l' is go right one char and 'h' is go left one char. 1526610 1 webkit-bug-importer 2019-04-11 20:24:18 -0700 <rdar://problem/49839036> 1526963 2 sabouhallawa 2019-04-12 18:02:51 -0700 This gibberish was added in <http://trac.webkit.org/changeset/197908>. 1526983 3 jonlee 2019-04-12 18:54:05 -0700 -_____- 1527260 4 367428 jonlee 2019-04-15 11:04:14 -0700 Created attachment 367428 Patch 1527261 5 367428 wenson_hsieh 2019-04-15 11:07:21 -0700 Comment on attachment 367428 Patch rs=me 1527857 6 367428 commit-queue 2019-04-16 13:52:26 -0700 Comment on attachment 367428 Patch Clearing flags on attachment: 367428 Committed r244357: <https://trac.webkit.org/changeset/244357> 1527858 7 commit-queue 2019-04-16 13:52:27 -0700 All reviewed patches have been landed. Closing bug. 367428 2019-04-15 11:04:14 -0700 2019-04-16 13:52:26 -0700 Patch bug-196814-20190415110413.patch text/plain 4035 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MjcxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9icm93c2Vy YmVuY2gub3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcvQ2hhbmdlTG9n CmluZGV4IDkwNmMzNzAwZmFjY2MyNjJmYjI0NWZlYjI5ZGZlNmU4ZjIyMGM4MjcuLjcyOWYyZTUx OWExN2JiMDJkODdmODlmMGQwMTA3NmJkOGRlNTRhOTYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2Jy b3dzZXJiZW5jaC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDQtMTUgIEpvbiBMZWUgIDxqb25sZWVA YXBwbGUuY29tPgorCisgICAgICAgIFtNb3Rpb25NYXJrXSBUaGUgdGV4dCAia2traiIgaXMgY2F1 c2luZyBGaXJlZm94IGNvbnNvbGUgd2FybmluZzogYHVucmVhY2hhYmxlIGNvZGUgYWZ0ZXIgcmV0 dXJuIHN0YXRlbWVudGAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5NjgxNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogTW90aW9uTWFyay9yZXNvdXJjZXMvZXh0ZW5zaW9ucy5qczoKKyAgICAgICAgKHN1 YnRyYWN0LnN1YnRyYWN0LnNhbXBsZVkpOgorICAgICAgICAqIE1vdGlvbk1hcmsxLjEvcmVzb3Vy Y2VzL2V4dGVuc2lvbnMuanM6CisgICAgICAgIChzdWJ0cmFjdC5zdWJ0cmFjdC5zYW1wbGVZKToK KwogMjAxOS0wMy0yNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBKZXRTdHJlYW0gMiBzaG91bGQgbm90IHJlcG9ydCB0aW1lIHZhbHVlcyBhcyBzY29yZXMKZGlm ZiAtLWdpdCBhL1dlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcvTW90aW9uTWFyay9yZXNvdXJjZXMv ZXh0ZW5zaW9ucy5qcyBiL1dlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcvTW90aW9uTWFyay9yZXNv dXJjZXMvZXh0ZW5zaW9ucy5qcwppbmRleCA2OWZlMzc0ZWU3ZWJiODYzZGIwM2ZjODVjMDIxMTBj MDhjYjg3YWFkLi5mYjlkNTAwODc3ZTM4YTliN2VlZGQ3MjBiZTAxYjhjNTc2YzQ2Y2I5IDEwMDY0 NAotLS0gYS9XZWJzaXRlcy9icm93c2VyYmVuY2gub3JnL01vdGlvbk1hcmsvcmVzb3VyY2VzL2V4 dGVuc2lvbnMuanMKKysrIGIvV2Vic2l0ZXMvYnJvd3NlcmJlbmNoLm9yZy9Nb3Rpb25NYXJrL3Jl c291cmNlcy9leHRlbnNpb25zLmpzCkBAIC0zNzEsNyArMzcxLDcgQEAgVW5pdEJlemllciA9IFV0 aWxpdGllcy5jcmVhdGVDbGFzcygKIAogICAgIHNhbXBsZVk6IGZ1bmN0aW9uKHQpCiAgICAgewot ICAgICAgICByZXR1cm4gKCh0aGlzLl9hLnkgKiB0ICsgdGhpcy5fYi55KSAqIHQgKyB0aGlzLl9j LnkpICogdDtra2tqCisgICAgICAgIHJldHVybiAoKHRoaXMuX2EueSAqIHQgKyB0aGlzLl9iLnkp ICogdCArIHRoaXMuX2MueSkgKiB0OwogICAgIH0sCiAKICAgICBzYW1wbGVEZXJpdmF0aXZlWDog ZnVuY3Rpb24odCkKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2Jyb3dzZXJiZW5jaC5vcmcvTW90aW9u TWFyazEuMS9yZXNvdXJjZXMvZXh0ZW5zaW9ucy5qcyBiL1dlYnNpdGVzL2Jyb3dzZXJiZW5jaC5v cmcvTW90aW9uTWFyazEuMS9yZXNvdXJjZXMvZXh0ZW5zaW9ucy5qcwppbmRleCBlNGE3ZWZkMzg1 ZGZlOTcwM2MyMzI5MTMwNmU1OTgzODVhODFjMWNlLi5jMzAzYzNmM2E2YTQ4Y2M2MzhiM2ZhZjU4 YmFhY2ZlNzAwMWFhOTJlIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9icm93c2VyYmVuY2gub3JnL01v dGlvbk1hcmsxLjEvcmVzb3VyY2VzL2V4dGVuc2lvbnMuanMKKysrIGIvV2Vic2l0ZXMvYnJvd3Nl cmJlbmNoLm9yZy9Nb3Rpb25NYXJrMS4xL3Jlc291cmNlcy9leHRlbnNpb25zLmpzCkBAIC0xLDUg KzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxNS0yMDE3IEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNS0yMDE5IEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNDAw LDcgKzQwMCw3IEBAIFVuaXRCZXppZXIgPSBVdGlsaXRpZXMuY3JlYXRlQ2xhc3MoCiAKICAgICBz YW1wbGVZOiBmdW5jdGlvbih0KQogICAgIHsKLSAgICAgICAgcmV0dXJuICgodGhpcy5fYS55ICog dCArIHRoaXMuX2IueSkgKiB0ICsgdGhpcy5fYy55KSAqIHQ7a2tragorICAgICAgICByZXR1cm4g KCh0aGlzLl9hLnkgKiB0ICsgdGhpcy5fYi55KSAqIHQgKyB0aGlzLl9jLnkpICogdDsKICAgICB9 LAogCiAgICAgc2FtcGxlRGVyaXZhdGl2ZVg6IGZ1bmN0aW9uKHQpCmRpZmYgLS1naXQgYS9QZXJm b3JtYW5jZVRlc3RzL0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4 IDk4MTUzN2QwYmE0MTA0OWQ1OTE4NzFkYjBjMTYyNTQzODAyZmU3YjkuLjUyMDNlMWQwNjdhZjcy YTY3MGM5MDUwNTc1MTBlNTIyMjlkMDhhYzMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMv Q2hhbmdlTG9nCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTktMDQtMTUgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgorCisgICAgICAgIFtN b3Rpb25NYXJrXSBUaGUgdGV4dCAia2traiIgaXMgY2F1c2luZyBGaXJlZm94IGNvbnNvbGUgd2Fy bmluZzogYHVucmVhY2hhYmxlIGNvZGUgYWZ0ZXIgcmV0dXJuIHN0YXRlbWVudGAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjgxNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW90aW9uTWFyay9yZXNv dXJjZXMvZXh0ZW5zaW9ucy5qczoKKyAgICAgICAgKHN1YnRyYWN0LnN1YnRyYWN0LnNhbXBsZVkp OgorCiAyMDE5LTA0LTAzICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+ CiAKICAgICAgICAgLWFwcGxlLXRyYWlsaW5nLXdvcmQgaXMgbmVlZGVkIGZvciBicm93c2VyIGRl dGVjdGlvbgpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25NYXJrL3Jlc291cmNl cy9leHRlbnNpb25zLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25NYXJrL3Jlc291cmNlcy9l eHRlbnNpb25zLmpzCmluZGV4IGU0YTdlZmQzODVkZmU5NzAzYzIzMjkxMzA2ZTU5ODM4NWE4MWMx Y2UuLmMzMDNjM2YzYTZhNDhjYzYzOGIzZmFmNThiYWFjZmU3MDAxYWE5MmUgMTAwNjQ0Ci0tLSBh L1BlcmZvcm1hbmNlVGVzdHMvTW90aW9uTWFyay9yZXNvdXJjZXMvZXh0ZW5zaW9ucy5qcworKysg Yi9QZXJmb3JtYW5jZVRlc3RzL01vdGlvbk1hcmsvcmVzb3VyY2VzL2V4dGVuc2lvbnMuanMKQEAg LTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTcgQXBwbGUgSW5jLiBB bGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE1LTIwMTkgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4g c291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9u LCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBA IC00MDAsNyArNDAwLDcgQEAgVW5pdEJlemllciA9IFV0aWxpdGllcy5jcmVhdGVDbGFzcygKIAog ICAgIHNhbXBsZVk6IGZ1bmN0aW9uKHQpCiAgICAgewotICAgICAgICByZXR1cm4gKCh0aGlzLl9h LnkgKiB0ICsgdGhpcy5fYi55KSAqIHQgKyB0aGlzLl9jLnkpICogdDtra2tqCisgICAgICAgIHJl dHVybiAoKHRoaXMuX2EueSAqIHQgKyB0aGlzLl9iLnkpICogdCArIHRoaXMuX2MueSkgKiB0Owog ICAgIH0sCiAKICAgICBzYW1wbGVEZXJpdmF0aXZlWDogZnVuY3Rpb24odCkK