196813 2019-04-11 04:28:43 -0700 REGRESSION: changing iPad orientation on blogger.com crashes under RemoteScrollingCoordinatorProxy::establishLayerTreeScrollingRelations() 2019-04-11 11:10:04 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1526346 0 koivisto 2019-04-11 04:28:43 -0700 Add some null checks. 1526347 1 koivisto 2019-04-11 04:30:52 -0700 <rdar://problem/49393264> 1526349 2 367213 koivisto 2019-04-11 04:35:17 -0700 Created attachment 367213 patch 1526408 3 367213 commit-queue 2019-04-11 11:10:02 -0700 Comment on attachment 367213 patch Clearing flags on attachment: 367213 Committed r244192: <https://trac.webkit.org/changeset/244192> 1526409 4 commit-queue 2019-04-11 11:10:04 -0700 All reviewed patches have been landed. Closing bug. 367213 2019-04-11 04:35:17 -0700 2019-04-11 11:10:02 -0700 patch establishrelations-nullptr.patch text/plain 2783 koivisto SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQxODcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE5LTA0LTExICBBbnR0aSBLb2l2 aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBjaGFuZ2luZyBp UGFkIG9yaWVudGF0aW9uIG9uIGJsb2dnZXIuY29tIGNyYXNoZXMgdW5kZXIgUmVtb3RlU2Nyb2xs aW5nQ29vcmRpbmF0b3JQcm94eTo6ZXN0YWJsaXNoTGF5ZXJUcmVlU2Nyb2xsaW5nUmVsYXRpb25z KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njgx MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDkzOTMyNjQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gdGVzdCwgY2FuJ3QgcmVwcm8uCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9SZW1vdGVTY3JvbGxpbmdDb29y ZGluYXRvclByb3h5SU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVTY3JvbGxpbmdDb29y ZGluYXRvclByb3h5Ojplc3RhYmxpc2hMYXllclRyZWVTY3JvbGxpbmdSZWxhdGlvbnMpOgorCisg ICAgICAgIE51bGwgY2hlY2sgdGhlIG5vZGVzLgorCiAyMDE5LTA0LTEwICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVncmVzc2lvbihyMjQ0MTQ0KSBQcm9jZXNz U3dhcC5SZXVzZVN1c3BlbmRlZFByb2Nlc3NMb2FkSFRNTFN0cmluZyBBUEkgdGVzdCBpcyBmbGFr eQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9SZW1v dGVTY3JvbGxpbmdDb29yZGluYXRvclByb3h5SU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL1JlbW90ZUxheWVyVHJlZS9pb3MvUmVtb3RlU2Nyb2xsaW5nQ29vcmRp bmF0b3JQcm94eUlPUy5tbQkocmV2aXNpb24gMjQ0MTg3KQorKysgU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvUmVtb3RlTGF5ZXJUcmVlL2lvcy9SZW1vdGVTY3JvbGxpbmdDb29yZGluYXRvclByb3h5 SU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzEsMTUgKzEzMSwyNiBAQCB2b2lkIFJlbW90ZVNj cm9sbGluZ0Nvb3JkaW5hdG9yUHJveHk6OmVzCiAgICAgLy8gVG8gZG8gb3ZlcmxhcCBoaXQgdGVz dGluZyBjb3JyZWN0bHkgd2UgdGVsbCBsYXllcnMgYWJvdXQgc3VjaCByZWxhdGlvbnMuCiAgICAg Zm9yIChhdXRvIHBvc2l0aW9uZWROb2RlSUQgOiBtX3Njcm9sbGluZ1RyZWUtPnBvc2l0aW9uZWRO b2Rlc1dpdGhSZWxhdGVkT3ZlcmZsb3coKSkgewogICAgICAgICBhdXRvKiBwb3NpdGlvbmVkTm9k ZSA9IGRvd25jYXN0PFNjcm9sbGluZ1RyZWVQb3NpdGlvbmVkTm9kZT4obV9zY3JvbGxpbmdUcmVl LT5ub2RlRm9ySUQocG9zaXRpb25lZE5vZGVJRCkpOwotICAgICAgICBhdXRvKiBwb3NpdGlvbmVk TGF5ZXJOb2RlID0gUmVtb3RlTGF5ZXJUcmVlTm9kZTo6Zm9yQ0FMYXllcihwb3NpdGlvbmVkTm9k ZS0+bGF5ZXIoKSk7Ci0KKyAgICAgICAgaWYgKCFwb3NpdGlvbmVkTm9kZSkgeworICAgICAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAg fQogICAgICAgICBWZWN0b3I8R3JhcGhpY3NMYXllcjo6UGxhdGZvcm1MYXllcklEPiBzY3JvbGxD b250YWluZXJMYXllcklEczsKIAogICAgICAgICBmb3IgKGF1dG8gb3ZlcmZsb3dOb2RlSUQgOiBw b3NpdGlvbmVkTm9kZS0+cmVsYXRlZE92ZXJmbG93U2Nyb2xsaW5nTm9kZXMoKSkgewogICAgICAg ICAgICAgYXV0byogb3ZlcmZsb3dOb2RlID0gZG93bmNhc3Q8U2Nyb2xsaW5nVHJlZU92ZXJmbG93 U2Nyb2xsaW5nTm9kZT4obV9zY3JvbGxpbmdUcmVlLT5ub2RlRm9ySUQob3ZlcmZsb3dOb2RlSUQp KTsKKyAgICAgICAgICAgIGlmICghb3ZlcmZsb3dOb2RlKSB7CisgICAgICAgICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAg ICB9CiAgICAgICAgICAgICBzY3JvbGxDb250YWluZXJMYXllcklEcy5hcHBlbmQoUmVtb3RlTGF5 ZXJUcmVlTm9kZTo6bGF5ZXJJRChvdmVyZmxvd05vZGUtPnNjcm9sbENvbnRhaW5lckxheWVyKCkp KTsKICAgICAgICAgfQogCisgICAgICAgIGF1dG8qIHBvc2l0aW9uZWRMYXllck5vZGUgPSBSZW1v dGVMYXllclRyZWVOb2RlOjpmb3JDQUxheWVyKHBvc2l0aW9uZWROb2RlLT5sYXllcigpKTsKKyAg ICAgICAgaWYgKCFwb3NpdGlvbmVkTGF5ZXJOb2RlKSB7CisgICAgICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICB9CiAgICAgICAgIHBv c2l0aW9uZWRMYXllck5vZGUtPnNldFJlbGF0ZWRTY3JvbGxDb250YWluZXJCZWhhdmlvckFuZElE cyhwb3NpdGlvbmVkTm9kZS0+c2Nyb2xsUG9zaXRpb25pbmdCZWhhdmlvcigpLCBXVEZNb3ZlKHNj cm9sbENvbnRhaW5lckxheWVySURzKSk7CiAKICAgICAgICAgbV9sYXllcnNXaXRoU2Nyb2xsaW5n UmVsYXRpb25zLmFkZChwb3NpdGlvbmVkTGF5ZXJOb2RlLT5sYXllcklEKCkpOwo=