196811 2019-04-11 01:23:58 -0700 [WPE] Build error with ENABLE_VIDEO=OFF after r244078 2019-04-11 06:31:25 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra commit-queue eric.carlson hi jer.noble thorton timothy webkit-bug-importer zalan oldest_to_newest 1526337 0 psaavedra 2019-04-11 01:23:58 -0700 An alternative local nightly build of the WPE port fails after changes introduced in r244078: commit 570b1231363977e8a48ac6bee26aa775a94309ac Author: jer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Tue Apr 9 15:57:45 2019 +0000 Source/WebCore: Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order. https://bugs.webkit.org/show_bug.cgi?id=196097 Reviewed by Eric Carlson. Test: media/track/track-in-band-metadata-display-order.html Add a method in Internals to create a TextTrackCueGeneric (which can normally only be created by parsing an in-band media track). This requires adding IDL for TextTrackCueGeneric, and exporting TextTrackCueGeneric for testing. Drive-by fixes: Add runtime logging to MediaControlTextTrackContainerElement. This necessitates modifying the parentMediaElement() method to take a const Node*, and const_cast that constness away in order to return a HTMLMediaElement* TextTrackCue, VTTCue, TextTrackCueGeneric, and DataCue should all use the WTF TypeCasts macros to enable use of is<> and downcast<>. Error: In file included from DerivedSources/ForwardingHeaders/wtf/HashFunctions.h:26, from DerivedSources/WebCore/CSSPropertyNames.h:7, from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/css/CSSStyleDeclaration.h:23, from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/css/CSSComputedStyleDeclaration.h:23, from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/testing/Internals.h:29, from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/testing/Internals.cpp:28: DerivedSources/ForwardingHeaders/wtf/RefPtr.h: In instantiation of 'void WTF::refIfNotNull(T*) [with T = WebCore::TextTrackCueGeneric]': DerivedSources/ForwardingHeaders/wtf/RefPtr.h:57:61: required from 'WTF::RefPtr<T, <template-parameter-1-2> >::RefPtr(T*) [with T = WebCore::TextTrackCueGeneric; PtrTraits = WTF::DumbPtrTraits<WebCore::TextTrackCueGeneric>]' /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/testing/Internals.cpp:3584:16: required from here DerivedSources/ForwardingHeaders/wtf/RefPtr.h:38:14: error: invalid use of incomplete type 'class WebCore::TextTrackCueGeneric' git blame Source/WebCore/html/InputType.h ... b54d1c8871e1 (eric.carlson@apple.com 2013-02-12 06:30:19 +0000 213) #if ENABLE(VIDEO_TRACK) b54d1c8871e1 (eric.carlson@apple.com 2013-02-12 06:30:19 +0000 214) #include "CaptionUserPreferences.h" b54d1c8871e1 (eric.carlson@apple.com 2013-02-12 06:30:19 +0000 215) #include "PageGroup.h" 570b12313639 (jer.noble@apple.com 2019-04-09 15:57:45 +0000 216) #include "TextTrackCueGeneric.h" b54d1c8871e1 (eric.carlson@apple.com 2013-02-12 06:30:19 +0000 217) #endif TextTrackCueGeneric headers are only included when VIDEO_TRACK is enabled and this is only enabled when VIDEO is enabled as well. 1526340 1 367210 psaavedra 2019-04-11 01:28:51 -0700 Created attachment 367210 patch 1526356 2 367210 commit-queue 2019-04-11 06:30:07 -0700 Comment on attachment 367210 patch Clearing flags on attachment: 367210 Committed r244188: <https://trac.webkit.org/changeset/244188> 1526357 3 commit-queue 2019-04-11 06:30:08 -0700 All reviewed patches have been landed. Closing bug. 1526359 4 webkit-bug-importer 2019-04-11 06:31:25 -0700 <rdar://problem/49811152> 367210 2019-04-11 01:28:51 -0700 2019-04-11 06:30:07 -0700 patch bug-196811-20190411102850.patch text/plain 2864 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTAyYWU5ZDA0NDIzNDk2 ZTJkMmEwNTc1NTZhZDc2NmJkMTNiN2RjYy4uN2Y5NzEyOTNiOTVmODgxM2E4NjhiMTRkNDk0NWQz NTBiYWRiMTZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTExICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIEJ1aWxk IGVycm9yIHdpdGggRU5BQkxFX1ZJREVPPU9GRiBhZnRlciByMjQ0MDc4CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY4MTEKKworICAgICAgICBjcmVh dGVHZW5lcmljQ3VlKCkgaXMgb25seSBkZWZpbmVkIHdoZW4gVklERU9fVFJBQ0sgaXMgZW5hYmxl ZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRl c3RpbmcvSW50ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6Y3JlYXRl R2VuZXJpY0N1ZSk6CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuaDoKKwogMjAxOS0wNC0x MCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAg IHJlcXVlc3RBbmltYXRpb25GcmFtZSBzaG91bGQgZXhlY3V0ZSBiZWZvcmUgdGhlIG5leHQgZnJh bWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRleCBkMTI5MDY2YWE2YTllZGU3 YjUwNDFiMjVjNzAzNDE0MTkzZWE0NWM1Li40ZGE0MzBkNjVhYjI4NzgxYTc3MzQ1MGFlNDlkY2Q2 MjhjYzZjMmI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCkBAIC0zNTc3LDIw ICszNTc3LDE1IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IEludGVybmFsczo6c2V0Q2FwdGlvbkRpc3Bs YXlNb2RlKGNvbnN0IFN0cmluZyYgbW9kZSkKICAgICByZXR1cm4geyB9OwogfQogCisjaWYgRU5B QkxFKFZJREVPX1RSQUNLKQogUmVmUHRyPFRleHRUcmFja0N1ZUdlbmVyaWM+IEludGVybmFsczo6 Y3JlYXRlR2VuZXJpY0N1ZShkb3VibGUgc3RhcnRUaW1lLCBkb3VibGUgZW5kVGltZSwgU3RyaW5n IHRleHQpCiB7CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gY29udGV4dERvY3VtZW50KCk7CiAg ICAgaWYgKCFkb2N1bWVudCB8fCAhZG9jdW1lbnQtPnBhZ2UoKSkKICAgICAgICAgcmV0dXJuIG51 bGxwdHI7Ci0jaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAgIHJldHVybiBUZXh0VHJhY2tDdWVH ZW5lcmljOjpjcmVhdGUoKmRvY3VtZW50LCBNZWRpYVRpbWU6OmNyZWF0ZVdpdGhEb3VibGUoc3Rh cnRUaW1lKSwgTWVkaWFUaW1lOjpjcmVhdGVXaXRoRG91YmxlKGVuZFRpbWUpLCB0ZXh0KTsKLSNl bHNlCi0gICAgVU5VU0VEX1BBUkFNKHN0YXJ0VGltZSk7Ci0gICAgVU5VU0VEX1BBUkFNKGVuZFRp bWUpOwotICAgIFVOVVNFRF9QQVJBTSh0ZXh0KTsKLSAgICByZXR1cm4gbnVsbHB0cjsKLSNlbmRp ZgogfQorI2VuZGlmCiAKICNpZiBFTkFCTEUoVklERU8pCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5oCmluZGV4IGMyN2YyNjgzZjVkZDE1Nzc5YWE1MjM0NDUwZjM5MmI5ODM0NzMzYWYuLjU2 Y2U2ZjE2MmFhMDlmMWExZmQ1YzZiOWU2YTE3MDAyMjkyNmMzN2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuaApAQCAtOTEsMTMgKzkxLDE2IEBAIGNsYXNzIFNlcmlhbGl6ZWRTY3JpcHRW YWx1ZTsKIGNsYXNzIFNvdXJjZUJ1ZmZlcjsKIGNsYXNzIFN0cmluZ0NhbGxiYWNrOwogY2xhc3Mg U3R5bGVTaGVldDsKLWNsYXNzIFRleHRUcmFja0N1ZUdlbmVyaWM7CiBjbGFzcyBUaW1lUmFuZ2Vz OwogY2xhc3MgVHlwZUNvbnZlcnNpb25zOwogY2xhc3MgVm9pZENhbGxiYWNrOwogY2xhc3MgV2Vi R0xSZW5kZXJpbmdDb250ZXh0OwogY2xhc3MgWE1MSHR0cFJlcXVlc3Q7CiAKKyNpZiBFTkFCTEUo VklERU9fVFJBQ0spCitjbGFzcyBUZXh0VHJhY2tDdWVHZW5lcmljOworI2VuZGlmCisKICNpZiBF TkFCTEUoU0VSVklDRV9XT1JLRVIpCiBjbGFzcyBTZXJ2aWNlV29ya2VyOwogI2VuZGlmCkBAIC01 NDQsNyArNTQ3LDkgQEAgcHVibGljOgogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IHNldENhcHRpb25z U3R5bGVTaGVldE92ZXJyaWRlKGNvbnN0IFN0cmluZyYpOwogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+ IHNldFByaW1hcnlBdWRpb1RyYWNrTGFuZ3VhZ2VPdmVycmlkZShjb25zdCBTdHJpbmcmKTsKICAg ICBFeGNlcHRpb25Pcjx2b2lkPiBzZXRDYXB0aW9uRGlzcGxheU1vZGUoY29uc3QgU3RyaW5nJik7 CisjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAgIFJlZlB0cjxUZXh0VHJhY2tDdWVHZW5lcmlj PiBjcmVhdGVHZW5lcmljQ3VlKGRvdWJsZSBzdGFydFRpbWUsIGRvdWJsZSBlbmRUaW1lLCBTdHJp bmcgdGV4dCk7CisjZW5kaWYKIAogI2lmIEVOQUJMRShWSURFTykKICAgICBSZWY8VGltZVJhbmdl cz4gY3JlYXRlVGltZVJhbmdlcyhGbG9hdDMyQXJyYXkmIHN0YXJ0VGltZXMsIEZsb2F0MzJBcnJh eSYgZW5kVGltZXMpOwo=