196806 2019-04-10 20:39:08 -0700 WKNavigationResponse._downloadAttribute should return nil if there was no download attribute 2019-04-10 23:35:32 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 196809 InRadar P2 Normal --- 1 david_quesada webkit-unassigned webkit-bug-importer oldest_to_newest 1526291 0 david_quesada 2019-04-10 20:39:08 -0700 rdar://problem/49800762 1526313 1 367204 david_quesada 2019-04-10 22:35:46 -0700 Created attachment 367204 Patch 1526317 2 david_quesada 2019-04-10 22:54:21 -0700 *** This bug has been marked as a duplicate of bug 196809 *** 367204 2019-04-10 22:35:46 -0700 2019-04-10 22:55:41 -0700 Patch file_196806.txt text/plain 6339 david_quesada Y29tbWl0IGRiNDZlOWE5YmI3ZDBmNjExOGY3MDk2MzZmMDFiZTFjOWE2NGEyZGYNCkF1dGhvcjog RGF2aWQgUXVlc2FkYSA8ZGF2aWRfcXVlc2FkYUBhcHBsZS5jb20+DQpEYXRlOiAgIFdlZCBBcHIg MTAgMjI6MzQ6MjMgMjAxOSAtMDcwMA0KDQogICAgV0tOYXZpZ2F0aW9uUmVzcG9uc2UuX2Rvd25s b2FkQXR0cmlidXRlIHNob3VsZCByZXR1cm4gbmlsIGlmIHRoZXJlIHdhcyBubyBkb3dubG9hZCBh dHRyaWJ1dGUNCiAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2 ODA2DQogICAgcmRhcjovL3Byb2JsZW0vNDk4MDA3NjINCiAgICANCiAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4NCiAgICANCiAgICBTb3VyY2UvV2ViS2l0Og0KICAgIA0KICAgIFRoZSBf ZG93bmxvYWRBdHRyaWJ1dGUgcHJvcGVydHkgc2hvdWxkIGJlIGFibGUgdG8gZGlmZmVyZW50aWF0 ZSBhIG5hdmlnYXRpb24gd2hlcmUgdGhlIG9yaWdpbmF0aW5nDQogICAgbGluayBkaWQgbm90IGhh dmUgYSBkb3dubG9hZCBhdHRyaWJ1dGUgKHJlcHJlc2VudGVkIGJ5IGEgbmlsIE5TU3RyaW5nKSBh bmQgb25lIHdoZXJlIHRoZSBsaW5rIGhhZA0KICAgIGEgZG93bmxvYWQgYXR0cmlidXRlIHdpdGgg bm8gZmlsZSBuYW1lIChyZXByZXNlbnRlZCBieSBhbiBlbXB0eSBzdHJpbmcpDQogICAgDQogICAg KiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLTmF2aWdhdGlvblJlc3BvbnNlLm1tOg0KICAgICgtW1dL TmF2aWdhdGlvblJlc3BvbnNlIF9kb3dubG9hZEF0dHJpYnV0ZV0pOg0KICAgIA0KICAgIFRvb2xz Og0KICAgIA0KICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS05hdmlnYXRp b25SZXNwb25zZS5tbToNCiAgICAocmVzcG9uc2VGb3JEb3dubG9hZEF0dHJpYnV0ZVRlc3QpOg0K ICAgICAgICBSZXB1cnBvc2UgdGhlIGJ1bGsgb2YgdGhlIGV4aXN0aW5nIHRlc3QgY2FzZSBpbnRv IGEgdXRpbGl0eSBmdW5jdGlvbiB0aGF0IHNldHMgdXAgdGhlDQogICAgICAgIHNlcnZlciwgbG9h ZHMgdGhlIGluaXRpYWwgcGFnZSB3aXRoIGEgbGluayB3aG9zZSBhdHRyaWJ1dGVzIGFyZSBjb25m aWd1cmFibGUgYnkgdGhlDQogICAgICAgIGNhbGxlciwgY2xpY2tzIHRoZSBsaW5rLCBhbmQgcmV0 dXJucyB0aGUgbmF2aWdhdGlvbiByZXNwb25zZSB0byB0aGUgY2FsbGluZyB0ZXN0Lg0KICAgIChU RVNUKToNCiAgICAgICAgQWRkIHR3byB0ZXN0IGNhc2VzIGZvciBhIGxpbmsgd2l0aCBhbiBlbXB0 eSBkb3dubG9hZCBhdHRyaWJ1dGUgYW5kIG5vIGRvd25sb2FkIGF0dHJpYnV0ZS4NCg0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cN CmluZGV4IDYzYjcxMTY1ODYwLi5iMTAwNzM1MTkzMCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZw0KQEAgLTEsMyArMSwx OCBAQA0KKzIwMTktMDQtMTAgIERhdmlkIFF1ZXNhZGEgIDxkYXZpZF9xdWVzYWRhQGFwcGxlLmNv bT4NCisNCisgICAgICAgIFdLTmF2aWdhdGlvblJlc3BvbnNlLl9kb3dubG9hZEF0dHJpYnV0ZSBz aG91bGQgcmV0dXJuIG5pbCBpZiB0aGVyZSB3YXMgbm8gZG93bmxvYWQgYXR0cmlidXRlDQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2ODA2DQorICAg ICAgICByZGFyOi8vcHJvYmxlbS80OTgwMDc2Mg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuDQorDQorICAgICAgICBUaGUgX2Rvd25sb2FkQXR0cmlidXRlIHByb3BlcnR5 IHNob3VsZCBiZSBhYmxlIHRvIGRpZmZlcmVudGlhdGUgYSBuYXZpZ2F0aW9uIHdoZXJlIHRoZSBv cmlnaW5hdGluZw0KKyAgICAgICAgbGluayBkaWQgbm90IGhhdmUgYSBkb3dubG9hZCBhdHRyaWJ1 dGUgKHJlcHJlc2VudGVkIGJ5IGEgbmlsIE5TU3RyaW5nKSBhbmQgb25lIHdoZXJlIHRoZSBsaW5r IGhhZA0KKyAgICAgICAgYSBkb3dubG9hZCBhdHRyaWJ1dGUgd2l0aCBubyBmaWxlIG5hbWUgKHJl cHJlc2VudGVkIGJ5IGFuIGVtcHR5IHN0cmluZykNCisNCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9Db2NvYS9XS05hdmlnYXRpb25SZXNwb25zZS5tbToNCisgICAgICAgICgtW1dLTmF2aWdhdGlv blJlc3BvbnNlIF9kb3dubG9hZEF0dHJpYnV0ZV0pOg0KKw0KIDIwMTktMDQtMTAgIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPg0KIA0KICAgICAgICAgV2ViIEluc3BlY3Rvcjogc2F2 ZSBzaGVldCBzaG91bGQgYmUgYW5jaG9yZWQgdW5kZXJuZWF0aCB0aGUgdGFiIGJhciB3aGVuIGRl dGFjaGVkDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dL TmF2aWdhdGlvblJlc3BvbnNlLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLTmF2aWdhdGlvblJlc3BvbnNlLm1tDQppbmRleCA3MjhjNDBlZDc3Ny4uZmY0MGQxYWE2NWIg MTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tOYXZpZ2F0 aW9uUmVzcG9uc2UubW0NCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S05hdmlnYXRpb25SZXNwb25zZS5tbQ0KQEAgLTgwLDcgKzgwLDggQEAgLSAoTlNVUkxSZXF1ZXN0 ICopX3JlcXVlc3QNCiANCiAtIChOU1N0cmluZyAqKV9kb3dubG9hZEF0dHJpYnV0ZQ0KIHsNCi0g ICAgcmV0dXJuIF9uYXZpZ2F0aW9uUmVzcG9uc2UtPmRvd25sb2FkQXR0cmlidXRlKCk7DQorICAg IGNvbnN0IGF1dG8mIGRvd25sb2FkQXR0cmlidXRlID0gX25hdmlnYXRpb25SZXNwb25zZS0+ZG93 bmxvYWRBdHRyaWJ1dGUoKTsNCisgICAgcmV0dXJuIGRvd25sb2FkQXR0cmlidXRlLmlzTnVsbCgp ID8gbmlsIDogKE5TU3RyaW5nICopZG93bmxvYWRBdHRyaWJ1dGU7DQogfQ0KIA0KIEBlbmQNCmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cNCmluZGV4IDc2YTU2 NmQ3YzZjLi5iZGY3MDE2ZDlhZiAxMDA2NDQNCi0tLSBhL1Rvb2xzL0NoYW5nZUxvZw0KKysrIGIv VG9vbHMvQ2hhbmdlTG9nDQpAQCAtMSwzICsxLDE5IEBADQorMjAxOS0wNC0xMCAgRGF2aWQgUXVl c2FkYSAgPGRhdmlkX3F1ZXNhZGFAYXBwbGUuY29tPg0KKw0KKyAgICAgICAgV0tOYXZpZ2F0aW9u UmVzcG9uc2UuX2Rvd25sb2FkQXR0cmlidXRlIHNob3VsZCByZXR1cm4gbmlsIGlmIHRoZXJlIHdh cyBubyBkb3dubG9hZCBhdHRyaWJ1dGUNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTY4MDYNCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzQ5ODAwNzYy DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAgICog VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS05hdmlnYXRpb25SZXNwb25zZS5tbToN CisgICAgICAgIChyZXNwb25zZUZvckRvd25sb2FkQXR0cmlidXRlVGVzdCk6DQorICAgICAgICAg ICAgUmVwdXJwb3NlIHRoZSBidWxrIG9mIHRoZSBleGlzdGluZyB0ZXN0IGNhc2UgaW50byBhIHV0 aWxpdHkgZnVuY3Rpb24gdGhhdCBzZXRzIHVwIHRoZQ0KKyAgICAgICAgICAgIHNlcnZlciwgbG9h ZHMgdGhlIGluaXRpYWwgcGFnZSB3aXRoIGEgbGluayB3aG9zZSBhdHRyaWJ1dGVzIGFyZSBjb25m aWd1cmFibGUgYnkgdGhlDQorICAgICAgICAgICAgY2FsbGVyLCBjbGlja3MgdGhlIGxpbmssIGFu ZCByZXR1cm5zIHRoZSBuYXZpZ2F0aW9uIHJlc3BvbnNlIHRvIHRoZSBjYWxsaW5nIHRlc3QuDQor ICAgICAgICAoVEVTVCk6DQorICAgICAgICAgICAgQWRkIHR3byB0ZXN0IGNhc2VzIGZvciBhIGxp bmsgd2l0aCBhbiBlbXB0eSBkb3dubG9hZCBhdHRyaWJ1dGUgYW5kIG5vIGRvd25sb2FkIGF0dHJp YnV0ZS4NCisNCiAyMDE5LTA0LTEwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNv bnkuY29tPg0KIA0KICAgICAgICAgW1dpbl0gVXNlIGEgYnVuZGxlZCB2c3doZXJlLmV4ZSBpbnN0 ZWFkIG9mIGRvd25sb2FkaW5nIGJ5IHVwZGF0ZS12c3doZXJlLnB5DQpkaWZmIC0tZ2l0IGEvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS05hdmlnYXRpb25SZXNwb25zZS5t bSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tOYXZpZ2F0aW9uUmVz cG9uc2UubW0NCmluZGV4IDc4YmY0ZTcxM2FkLi4zZjg5MDU1MjY5NyAxMDA2NDQNCi0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tOYXZpZ2F0aW9uUmVzcG9uc2Uu bW0NCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tOYXZpZ2F0 aW9uUmVzcG9uc2UubW0NCkBAIC0yMTAsMTEgKzIxMCwxMSBAQCBzdGF0aWMgdm9pZCB3cml0ZVJl c3BvbnNlKGludCBzb2NrZXQsIE5TU3RyaW5nICpyZXNwb25zZSkNCiAgICAgRVhQRUNUX0VRKHN0 YXRpY19jYXN0PHNpemVfdD4oYnl0ZXNXcml0dGVuKSwgc3RybGVuKGJ5dGVzKSk7DQogfQ0KIA0K LVRFU1QoV2ViS2l0LCBXS05hdmlnYXRpb25SZXNwb25zZURvd25sb2FkQXR0cmlidXRlKQ0KK3N0 YXRpYyBXS05hdmlnYXRpb25SZXNwb25zZSAqcmVzcG9uc2VGb3JEb3dubG9hZEF0dHJpYnV0ZVRl c3QoTlNTdHJpbmcgKmV4dHJhTGlua0F0dHJpYnV0ZXMpDQogew0KICAgICBUZXN0V2ViS2l0QVBJ OjpUQ1BTZXJ2ZXIgc2VydmVyKFtdKGludCBzb2NrZXQpIHsNCiAgICAgICAgIHJlYWRSZXF1ZXN0 KHNvY2tldCk7DQotICAgICAgICBOU1N0cmluZyAqYm9keSA9IEAiPGEgaWQ9J2xpbmsnIGhyZWY9 Jy9mcm9tSHJlZi50eHQnIGRvd25sb2FkPSdmcm9tRG93bmxvYWRBdHRyaWJ1dGUudHh0Jz5DbGlj ayBNZSE8L2E+IjsNCisgICAgICAgIE5TU3RyaW5nICpib2R5ID0gW05TU3RyaW5nIHN0cmluZ1dp dGhGb3JtYXQ6QCI8YSBpZD0nbGluaycgaHJlZj0nL2Zyb21IcmVmLnR4dCcgJUA+Q2xpY2sgTWUh PC9hPiIsIGV4dHJhTGlua0F0dHJpYnV0ZXNdOw0KICAgICAgICAgdW5zaWduZWQgYm9keUxlbmd0 aCA9IGJvZHkubGVuZ3RoOw0KICAgICAgICAgd3JpdGVSZXNwb25zZShzb2NrZXQsIFtOU1N0cmlu ZyBzdHJpbmdXaXRoRm9ybWF0Og0KICAgICAgICAgICAgIEAiSFRUUC8xLjEgMjAwIE9LXHJcbiIN CkBAIC0yNDAsOCArMjQwLDI1IEBAIFRFU1QoV2ViS2l0LCBXS05hdmlnYXRpb25SZXNwb25zZURv d25sb2FkQXR0cmlidXRlKQ0KIA0KICAgICBbd2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6QCJk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbGluaycpLmNsaWNrKCk7IiBjb21wbGV0aW9uSGFuZGxl cjpuaWxdOw0KICAgICBbZGVsZWdhdGUgd2FpdEZvck5hdmlnYXRpb25SZXNwb25zZUNhbGxiYWNr XTsNCi0gICAgDQotICAgIFdLTmF2aWdhdGlvblJlc3BvbnNlICpyZXNwb25zZSA9IFtkZWxlZ2F0 ZSBuYXZpZ2F0aW9uUmVzcG9uc2VdOw0KKw0KKyAgICByZXR1cm4gcmV0YWluUHRyKFtkZWxlZ2F0 ZSBuYXZpZ2F0aW9uUmVzcG9uc2VdKS5hdXRvcmVsZWFzZSgpOw0KK30NCisNCitURVNUKFdlYktp dCwgV0tOYXZpZ2F0aW9uUmVzcG9uc2VEb3dubG9hZEF0dHJpYnV0ZSkNCit7DQorICAgIFdLTmF2 aWdhdGlvblJlc3BvbnNlICpyZXNwb25zZSA9IHJlc3BvbnNlRm9yRG93bmxvYWRBdHRyaWJ1dGVU ZXN0KEAiZG93bmxvYWQ9J2Zyb21Eb3dubG9hZEF0dHJpYnV0ZS50eHQnIik7DQogICAgIEVYUEVD VF9TVFJFUShyZXNwb25zZS5yZXNwb25zZS5zdWdnZXN0ZWRGaWxlbmFtZS5VVEY4U3RyaW5nLCAi ZnJvbUhlYWRlci50eHQiKTsNCiAgICAgRVhQRUNUX1NUUkVRKHJlc3BvbnNlLl9kb3dubG9hZEF0 dHJpYnV0ZS5VVEY4U3RyaW5nLCAiZnJvbURvd25sb2FkQXR0cmlidXRlLnR4dCIpOw0KIH0NCisN CitURVNUKFdlYktpdCwgV0tOYXZpZ2F0aW9uUmVzcG9uc2VFbXB0eURvd25sb2FkQXR0cmlidXRl KQ0KK3sNCisgICAgV0tOYXZpZ2F0aW9uUmVzcG9uc2UgKnJlc3BvbnNlID0gcmVzcG9uc2VGb3JE b3dubG9hZEF0dHJpYnV0ZVRlc3QoQCJkb3dubG9hZCIpOw0KKyAgICBFWFBFQ1RfU1RSRVEocmVz cG9uc2UuX2Rvd25sb2FkQXR0cmlidXRlLlVURjhTdHJpbmcsICIiKTsNCit9DQorDQorVEVTVChX ZWJLaXQsIFdLTmF2aWdhdGlvblJlc3BvbnNlTm9Eb3dubG9hZEF0dHJpYnV0ZSkNCit7DQorICAg IFdLTmF2aWdhdGlvblJlc3BvbnNlICpyZXNwb25zZSA9IHJlc3BvbnNlRm9yRG93bmxvYWRBdHRy aWJ1dGVUZXN0KEAiIik7DQorICAgIEVYUEVDVF9OVUxMKHJlc3BvbnNlLl9kb3dubG9hZEF0dHJp YnV0ZSk7DQorfQ0K