196802 2019-04-10 19:14:44 -0700 [ews-build] Handle bug titles with unicode characters 2019-04-11 18:52:52 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196797 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu lforschler thorton webkit-bug-importer oldest_to_newest 1526275 0 aakash_jain 2019-04-10 19:14:44 -0700 We should handle bug titles with unicode characters. Currently build fails with an exception for bugs with unicode characters in title. e.g.: https://ews-build.webkit.org/#/builders/19/builds/460 exceptions.UnicodeEncodeError: 'ascii' codec can't encode characters in position 22-24: ordinal not in range(128) /usr/lib64/python2.7/site-packages/twisted/internet/defer.py:1185 in _inlineCallbacks 1184 else: 1185 result = g.send(result) 1186 except StopIteration as e: /usr/lib/python2.7/site-packages/buildbot/process/buildstep.py:705 in run 704 705 results = yield self.start() 706 if results is not None: steps.py:351 in start 350 351 bug_closed = self._is_bug_closed(bug_id) 352 if bug_closed == 1: steps.py:331 in _is_bug_closed 330 bug_title = bug_json.get('summary') 331 self.addURL('Bug {} {}'.format(bug_id, bug_title), '{}show_bug.cgi?id={}'.format(BUG_SERVER_URL, bug_id)) 332 if bug_json.get('status') in self.bug_closed_statuses: exceptions.UnicodeEncodeError: 'ascii' codec can't encode characters in position 22-24: ordinal not in range(128) Corresponding bug: https://bugs.webkit.org/show_bug.cgi?id=196797 REGRESSION (r241734): ⌥⌘↑ and ⌥⌘↓ no longer navigate to previous/next Reading List article 1526276 1 aakash_jain 2019-04-10 19:14:55 -0700 <rdar://problem/49797747> 1526277 2 367189 aakash_jain 2019-04-10 19:18:40 -0700 Created attachment 367189 Patch 1526278 3 367190 aakash_jain 2019-04-10 19:23:49 -0700 Created attachment 367190 Patch 1526288 4 367190 ap 2019-04-10 20:13:28 -0700 Comment on attachment 367190 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367190&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:331 > + bug_title = bug_title.encode('ascii', 'ignore') # FIXME: do not remove non-ascii characters from bug title being displayed. Would encoding as utf-8 make it work? 1526350 5 aakash_jain 2019-04-11 04:44:01 -0700 > Would encoding as utf-8 make it work? If using utf-8, it fails later on inside addURL(). Filed Buildbot bug: https://github.com/buildbot/buildbot/issues/4717 1526557 6 367268 aakash_jain 2019-04-11 17:28:04 -0700 Created attachment 367268 Patch 1526558 7 aakash_jain 2019-04-11 17:29:00 -0700 (In reply to Aakash Jain from comment #6) > Created attachment 367268 [details] > Patch Sample run: https://ews-build.webkit-uat.org/#/builders/8/builds/270 1526591 8 367268 commit-queue 2019-04-11 18:52:50 -0700 Comment on attachment 367268 Patch Clearing flags on attachment: 367268 Committed r244207: <https://trac.webkit.org/changeset/244207> 1526592 9 commit-queue 2019-04-11 18:52:52 -0700 All reviewed patches have been landed. Closing bug. 367189 2019-04-10 19:18:40 -0700 2019-04-10 19:23:47 -0700 Patch bug-196802-20190410221946.patch text/plain 1422 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDE4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBIYW5kbGUgYnVnIHRpdGxlcyB3aXRoIHVuaWNvZGUg Y2hhcmFjdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChWYWxp ZGF0ZVBhdGNoLl9pc19idWdfY2xvc2VkKTogUmVtb3ZlIHVuaWNvZGUgY2hhcmFjdGVycyBmb3Ig bm93IGZyb20gYnVnIHRpdGxlLCB3aXRoIGEgRklYTUUgdG8gYmV0dGVyIGhhbmRsZSB0aGVtLgor CiAyMDE5LTA0LTEwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgog CiAgICAgICAgIFtXaW5dIFVzZSBhIGJ1bmRsZWQgdnN3aGVyZS5leGUgaW5zdGVhZCBvZiBkb3du bG9hZGluZyBieSB1cGRhdGUtdnN3aGVyZS5weQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjQ0MTc3KQorKysgVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMjgsNiAr MzI4LDcgQEAgY2xhc3MgVmFsaWRhdGVQYXRjaChidWlsZHN0ZXAuQnVpbGRTdGVwKQogICAgICAg ICAgICAgcmV0dXJuIC0xCiAKICAgICAgICAgYnVnX3RpdGxlID0gYnVnX2pzb24uZ2V0KCdzdW1t YXJ5JykKKyAgICAgICAgYnVnX3RpdGxlID0gYnVnX3RpdGxlLmVuY29kZSgnYXNjaWknLCAnaWdu b3JlJykgICMgRklYTUU6IGRvIG5vdCByZW1vdmUgdW5pY29kZSBjaGFyYWN0ZXJzIGZyb20gYnVn IHRpdGxlIGJlaW5nIGRpc3BsYXllZC4KICAgICAgICAgc2VsZi5hZGRVUkwoJ0J1ZyB7fSB7fScu Zm9ybWF0KGJ1Z19pZCwgYnVnX3RpdGxlKSwgJ3t9c2hvd19idWcuY2dpP2lkPXt9Jy5mb3JtYXQo QlVHX1NFUlZFUl9VUkwsIGJ1Z19pZCkpCiAgICAgICAgIGlmIGJ1Z19qc29uLmdldCgnc3RhdHVz JykgaW4gc2VsZi5idWdfY2xvc2VkX3N0YXR1c2VzOgogICAgICAgICAgICAgcmV0dXJuIDEK 367190 2019-04-10 19:23:49 -0700 2019-04-11 17:28:02 -0700 Patch bug-196802-20190410222456.patch text/plain 1426 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDE4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBIYW5kbGUgYnVnIHRpdGxlcyB3aXRoIHVuaWNvZGUg Y2hhcmFjdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChWYWxp ZGF0ZVBhdGNoLl9pc19idWdfY2xvc2VkKTogUmVtb3ZlIG5vbi1hc2NpaSBjaGFyYWN0ZXJzIGZv ciBub3cgZnJvbSBidWcgdGl0bGUsIHdpdGggYSBGSVhNRSB0byBiZXR0ZXIgaGFuZGxlIHRoZW0u CisKIDIwMTktMDQtMTAgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+ CiAKICAgICAgICAgW1dpbl0gVXNlIGEgYnVuZGxlZCB2c3doZXJlLmV4ZSBpbnN0ZWFkIG9mIGRv d25sb2FkaW5nIGJ5IHVwZGF0ZS12c3doZXJlLnB5CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNDQxNzcpCisrKyBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTMyOCw2 ICszMjgsNyBAQCBjbGFzcyBWYWxpZGF0ZVBhdGNoKGJ1aWxkc3RlcC5CdWlsZFN0ZXApCiAgICAg ICAgICAgICByZXR1cm4gLTEKIAogICAgICAgICBidWdfdGl0bGUgPSBidWdfanNvbi5nZXQoJ3N1 bW1hcnknKQorICAgICAgICBidWdfdGl0bGUgPSBidWdfdGl0bGUuZW5jb2RlKCdhc2NpaScsICdp Z25vcmUnKSAgIyBGSVhNRTogZG8gbm90IHJlbW92ZSBub24tYXNjaWkgY2hhcmFjdGVycyBmcm9t IGJ1ZyB0aXRsZSBiZWluZyBkaXNwbGF5ZWQuCiAgICAgICAgIHNlbGYuYWRkVVJMKCdCdWcge30g e30nLmZvcm1hdChidWdfaWQsIGJ1Z190aXRsZSksICd7fXNob3dfYnVnLmNnaT9pZD17fScuZm9y bWF0KEJVR19TRVJWRVJfVVJMLCBidWdfaWQpKQogICAgICAgICBpZiBidWdfanNvbi5nZXQoJ3N0 YXR1cycpIGluIHNlbGYuYnVnX2Nsb3NlZF9zdGF0dXNlczoKICAgICAgICAgICAgIHJldHVybiAx Cg== 367268 2019-04-11 17:28:04 -0700 2019-04-11 18:52:50 -0700 Patch bug-196802-20190411202913.patch text/plain 1356 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDIwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTExICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBIYW5kbGUgYnVnIHRpdGxlcyB3aXRoIHVuaWNvZGUg Y2hhcmFjdGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk2ODAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChWYWxp ZGF0ZVBhdGNoLl9pc19idWdfY2xvc2VkKToKKwogMjAxOS0wNC0xMCAgQWxleCBDaHJpc3RlbnNl biAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFdLTmF2aWdhdGlvblJlc3Bv bnNlLl9kb3dubG9hZEF0dHJpYnV0ZSBzaG91bGQgYmUgbmlsIHdoZW4gbm8gZG93bmxvYWQgYXR0 cmlidXRlIGlzIHByZXNlbnQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWls ZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkJKHJldmlzaW9uIDI0NDE4NykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMzI4LDcgKzMyOCw3IEBAIGNs YXNzIFZhbGlkYXRlUGF0Y2goYnVpbGRzdGVwLkJ1aWxkU3RlcCkKICAgICAgICAgICAgIHJldHVy biAtMQogCiAgICAgICAgIGJ1Z190aXRsZSA9IGJ1Z19qc29uLmdldCgnc3VtbWFyeScpCi0gICAg ICAgIHNlbGYuYWRkVVJMKCdCdWcge30ge30nLmZvcm1hdChidWdfaWQsIGJ1Z190aXRsZSksICd7 fXNob3dfYnVnLmNnaT9pZD17fScuZm9ybWF0KEJVR19TRVJWRVJfVVJMLCBidWdfaWQpKQorICAg ICAgICBzZWxmLmFkZFVSTCh1J0J1ZyB7fSB7fScuZm9ybWF0KGJ1Z19pZCwgYnVnX3RpdGxlKSwg J3t9c2hvd19idWcuY2dpP2lkPXt9Jy5mb3JtYXQoQlVHX1NFUlZFUl9VUkwsIGJ1Z19pZCkpCiAg ICAgICAgIGlmIGJ1Z19qc29uLmdldCgnc3RhdHVzJykgaW4gc2VsZi5idWdfY2xvc2VkX3N0YXR1 c2VzOgogICAgICAgICAgICAgcmV0dXJuIDEKICAgICAgICAgcmV0dXJuIDAK