196790 2019-04-10 15:56:08 -0700 [PlayStation] Specify byte order clearly on Remote Inspector Protocol 2019-04-10 18:20:52 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke chris.reid commit-queue don.olmstead ews-watchlist hi joepeck keith_miller mark.lam msaboff ross.kirsling saam webkit-bug-importer oldest_to_newest 1526184 0 basuke 2019-04-10 15:56:08 -0700 The byte order of size field of PlayStation remote inspector protocol is unspecified. It should be network byte order but current implementation just use host byte order. There's no current client with this protocol so it's good chance to change it. 1526213 1 367177 basuke 2019-04-10 16:49:04 -0700 Created attachment 367177 PATCH 1526254 2 367177 commit-queue 2019-04-10 18:19:33 -0700 Comment on attachment 367177 PATCH Clearing flags on attachment: 367177 Committed r244176: <https://trac.webkit.org/changeset/244176> 1526255 3 commit-queue 2019-04-10 18:19:34 -0700 All reviewed patches have been landed. Closing bug. 1526256 4 webkit-bug-importer 2019-04-10 18:20:52 -0700 <rdar://problem/49798570> 367177 2019-04-10 16:49:04 -0700 2019-04-10 18:19:33 -0700 PATCH 196790.diff text/plain 2863 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDcxMGFmZmJkY2ViLi43ZTAxMTg1NmZiNSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDQtMTAgIEJhc3Vr ZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnkuY29tPgorCisgICAgICAgIFtQbGF5U3RhdGlv bl0gU3BlY2lmeSBieXRlIG9yZGVyIGNsZWFybHkgb24gUmVtb3RlIEluc3BlY3RvciBQcm90b2Nv bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2Nzkw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3JpZ2lu YWwgaW1wbGVtZW50YXRpb24gbGFja3MgYnl0ZSBvcmRlciBzcGVjaWZpY2F0aW9uLiBOZXR3b3Jr IGJ5dGUgb3JkZXIgaXMgdGhlCisgICAgICAgIGdvb2QgY2FuZGlkYXRlIGlmIHRoZXJlJ3Mgbm8g c3Ryb25nIHJlYXNvbiB0byBjaG9vc2Ugb3RoZXIuCisgICAgICAgIEN1cnJlbnRseSBubyBjbGll bnQgZXhpc3RzIGZvciBQbGF5U3RhdGlvbiByZW1vdGUgaW5zcGVjdG9yIHByb3RvY29sLCBzbyB3 ZSBjYW4KKyAgICAgICAgY2hhbmdlIHRoZSBieXRlIG9yZGVyIHdpdGhvdXQgY2FyZS4KKworICAg ICAgICAqIGluc3BlY3Rvci9yZW1vdGUvcGxheXN0YXRpb24vUmVtb3RlSW5zcGVjdG9yTWVzc2Fn ZVBhcnNlclBsYXlTdGF0aW9uLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6TWVzc2FnZVBhcnNl cjo6Y3JlYXRlTWVzc2FnZSk6CisgICAgICAgIChJbnNwZWN0b3I6Ok1lc3NhZ2VQYXJzZXI6OnBh cnNlKToKKwogMjAxOS0wNC0wOCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQzOTQzLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvcGxheXN0YXRpb24vUmVtb3Rl SW5zcGVjdG9yTWVzc2FnZVBhcnNlclBsYXlTdGF0aW9uLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3BsYXlzdGF0aW9uL1JlbW90ZUluc3BlY3Rvck1lc3NhZ2VQ YXJzZXJQbGF5U3RhdGlvbi5jcHAKaW5kZXggODU0MDE3MDQ4OWQuLmFiMmQ0NjEyMWY5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9wbGF5c3RhdGlv bi9SZW1vdGVJbnNwZWN0b3JNZXNzYWdlUGFyc2VyUGxheVN0YXRpb24uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3BsYXlzdGF0aW9uL1JlbW90ZUluc3Bl Y3Rvck1lc3NhZ2VQYXJzZXJQbGF5U3RhdGlvbi5jcHAKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNs dWRlICJjb25maWcuaCIKICNpbmNsdWRlICJSZW1vdGVJbnNwZWN0b3JNZXNzYWdlUGFyc2VyLmgi CiAKKyNpbmNsdWRlIDxuZXRpbmV0L2luLmg+CisKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RP UikKIAogbmFtZXNwYWNlIEluc3BlY3RvciB7CkBAIC0zNCw3ICszNiw3IEBAIG5hbWVzcGFjZSBJ bnNwZWN0b3IgewogfCA8LS0tIG9uZSBtZXNzYWdlIGZvciBzZW5kIC8gZGlkUmVjZWl2ZURhdGEg LS0tPiB8CiArLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LSstLS0tLS0tLS0tLS0tLQogfCAgICBzaXplICAgICAgfCAgICAgICAgICAgICAgIGRhdGEgICAg ICAgICAgICAgICB8IChuZXh0IG1lc3NhZ2UpCi18ICAgIDRieXRlICAgICB8ICAgICAgICAgIHZh cmlhYmxlIGxlbmd0aCAgICAgICAgIHwKK3wgIDRieXRlIChOQk8pIHwgICAgICAgICAgdmFyaWFi bGUgbGVuZ3RoICAgICAgICAgfAogKy0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0KICAgICAgICAgICAgICAgIHwgPC0tLS0tLS0t LS0tLSBzaXplIC0tLS0tLS0tLS0tLT4gfAogKi8KQEAgLTUyLDcgKzU0LDggQEAgVmVjdG9yPHVp bnQ4X3Q+IE1lc3NhZ2VQYXJzZXI6OmNyZWF0ZU1lc3NhZ2UoY29uc3QgdWludDhfdCogZGF0YSwg c2l6ZV90IHNpemUpCiAKICAgICBhdXRvIG1lc3NhZ2VCdWZmZXIgPSBWZWN0b3I8dWludDhfdD4o c2l6ZSArIHNpemVvZih1aW50MzJfdCkpOwogICAgIHVpbnQzMl90IHVpbnRTaXplID0gc3RhdGlj X2Nhc3Q8dWludDMyX3Q+KHNpemUpOwotICAgIG1lbWNweSgmbWVzc2FnZUJ1ZmZlclswXSwgJnVp bnRTaXplLCBzaXplb2YodWludDMyX3QpKTsKKyAgICB1aW50MzJfdCBuYm9TaXplID0gaHRvbmwo dWludFNpemUpOworICAgIG1lbWNweSgmbWVzc2FnZUJ1ZmZlclswXSwgJm5ib1NpemUsIHNpemVv Zih1aW50MzJfdCkpOwogICAgIG1lbWNweSgmbWVzc2FnZUJ1ZmZlcltzaXplb2YodWludDMyX3Qp XSwgZGF0YSwgdWludFNpemUpOwogICAgIHJldHVybiBtZXNzYWdlQnVmZmVyOwogfQpAQCAtODQs NiArODcsNyBAQCBib29sIE1lc3NhZ2VQYXJzZXI6OnBhcnNlKCkKIAogICAgICAgICB1aW50MzJf dCBkYXRhU2l6ZSA9IDA7CiAgICAgICAgIG1lbWNweSgmZGF0YVNpemUsICZtX2J1ZmZlclswXSwg c2l6ZW9mKHVpbnQzMl90KSk7CisgICAgICAgIGRhdGFTaXplID0gbnRvaGwoZGF0YVNpemUpOwog ICAgICAgICBpZiAoIWRhdGFTaXplKSB7CiAgICAgICAgICAgICBMT0dfRVJST1IoIk1lc3NhZ2Ug UGFyc2VyIHJlY2VpdmVkIGFuIGludmFsaWQgbWVzc2FnZSBzaXplIik7CiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7Cg==