196784 2019-04-10 14:31:27 -0700 Regression(r244144) ProcessSwap.ReuseSuspendedProcessLoadHTMLString API test is flaky 2019-04-10 23:49:20 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196714 InRadar P2 Normal --- 196774 1 cdumez cdumez achristensen beidson commit-queue ggaren koivisto lforschler webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1526131 0 cdumez 2019-04-10 14:31:27 -0700 ProcessSwap.ReuseSuspendedProcessLoadHTMLString API test is flaky: TestWebKitAPI.ProcessSwap.ReuseSuspendedProcessLoadHTMLString /Volumes/Data/worker/macOS-High-Sierra-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2444 Expected equality of these values: applePID Which is: 70197 [webView _webProcessIdentifier] Which is: 70198 1526137 1 cdumez 2019-04-10 14:46:19 -0700 I have trouble reproducing on my first machine, will try on another machine. 1526198 2 cdumez 2019-04-10 16:11:57 -0700 Flakiness was indeed introduced by r244144. 1526201 3 cdumez 2019-04-10 16:16:03 -0700 I see SuspendedPageProxy::pageEnteredAcceleratedCompositingMode() getting called and it destroys the SuspendedPageProxy because m_suspensionState == SuspensionState::FailedToSuspend. Suspension likely fails because there is no HistoryItem in WebContent process side. I believe failure to suspend is expected here. Depending on how fast SuspendedPageProxy::pageEnteredAcceleratedCompositingMode() gets called, the SuspendedPageProxy may or may not still be there when we need it for the navigation. 1526212 4 367176 cdumez 2019-04-10 16:36:27 -0700 Created attachment 367176 Patch 1526214 5 367178 cdumez 2019-04-10 16:50:11 -0700 Created attachment 367178 Patch 1526328 6 367178 commit-queue 2019-04-10 23:48:25 -0700 Comment on attachment 367178 Patch Clearing flags on attachment: 367178 Committed r244186: <https://trac.webkit.org/changeset/244186> 1526329 7 commit-queue 2019-04-10 23:48:26 -0700 All reviewed patches have been landed. Closing bug. 1526330 8 webkit-bug-importer 2019-04-10 23:49:20 -0700 <rdar://problem/49804290> 367176 2019-04-10 16:36:27 -0700 2019-04-10 16:44:12 -0700 Patch bug-196784-20190410163626.patch text/plain 4396 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmRmYWIxMWE0NzlmZTgwYzk2OGI2Nzc0YTc2NTQxMWI5 NmU4ZmQyZS4uYWE5MDJlNzJlMDdjYTQxNGYxMDdiMTU2OWEwNzNjMDRmYmE5YjUzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDE5LTA0LTEwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUHJvY2Vzc1N3YXAuUmV1c2VTdXNwZW5kZWRQcm9jZXNzTG9hZEhUTUxTdHJpbmcgQVBJIHRl c3QgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5Njc4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFByb2Nlc3NTd2FwLlJldXNlU3VzcGVuZGVkUHJvY2Vzc0xvYWRIVE1MU3RyaW5nIHdhcyBj b3ZlcmluZyBhbiBvcHRpbWl6YXRpb24gd2hlcmUgd2UgcmV1c2UgYSBTdXNwZW5kZWRQYWdlUHJv eHkncworICAgICAgICBwcm9jZXNzIGZvciBhIGNyb3NzLXNpdGUgbGluayBuYXZpZ2F0aW9uIGlm IHRoZSBTdXNwZW5kZWRQYWdlUHJveHkncyByZWdpc3RyYWJsZSBkb21haW4gbWF0Y2hlcy4gVGhl IGlzc3VlIGhvd2V2ZXIKKyAgICAgICAgaXMgdGhhdCB0aGUgdGVzdCBpcyBkb2luZyBsb2FkcyB3 aXRoIGxvYWRIVE1MU3RyaW5nLCB3aGljaCBkbyBub3QgY3JlYXRlIGEgSGlzdG9yeUl0ZW0uIEFz IGEgcmVzdWx0LCBQYWdlQ2FjaGluZworICAgICAgICBmYWlscyBpbiB0aGUgb2xkIFdlYlByb2Nl c3MgYW5kIHdlIGVuZCB1cCBkZXN0cm95aW5nIHRoZSBjb3JyZXNwb25kaW5nIFN1c3BlbmRlZFBh Z2VQcm94eSBpbiB0aGUgVUlQcm9jZXNzIGFzIHNvb24KKyAgICAgICAgYXMgdGhlIG5ldyBwcm9j ZXNzIGhhcyBlbnRlcmVkIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1vZGUuIFRoaXMgbWVhbnMg dGhhdCBkZXBlbmRpbmcgb24gd2hlbiB0aGUgU3VzcGVuZGVkUGFnZQorICAgICAgICBnZXRzIGRl c3Ryb3llZCwgd2UgbWF5IG9yIG1heSBub3QgYmUgYWJsZSB0byByZXVzZSBpdHMgcHJvY2VzcyBm b3IgdGhlIGxpbmsgbmF2aWdhdGlvbi4gTm9ybWFsbHksIHdlIHdvdWxkIGZhbGwKKyAgICAgICAg YmFjayB0byB0aGUgV2ViUHJvY2Vzc0NhY2hlIGFuZCB3ZSB3b3VsZCBiZSBhYmxlIHRvIHJldXNl IHRoZSBvbGQgcHJvY2Vzcy4gSG93ZXZlciwgdGhlIHRlc3Qgd2FzIGV4cGxpY2l0bHkKKyAgICAg ICAgZGlzYWJsaW5nIHRoZSBXZWJQcm9jZXNzQ2FjaGUuCisKKyAgICAgICAgVG8gYWRkcmVzcyB0 aGUgaXNzdWUsIHRoaXMgcGF0Y2g6CisgICAgICAgIDEuIEVuYWJsZXMgdGhlIFdlYlByb2Nlc3ND YWNoZSBzbyB0aGF0IHdlIGdvIGJhY2sgdG8gdGhlIG9sZCBwcm9jZXNzIGV2ZW4gaWYgdGhlIFN1 c3BlbmRlZFBhZ2UgaXMgZ29uZQorICAgICAgICAyLiBMb29zZW4gdGhpcyByZXN0cmljdGlvbiBv biBpT1MgYmVjYXVzZSB0aGUgV2ViUHJvY2Vzc0NhY2hlIGlzIGZvcmNlZnVsbHkgZGlzYWJsZWQg b24gZGV2aWNlcyB3aXRoIHRvbyBsaXR0bGUgUkFNLgorICAgICAgICAzLiBSZW5hbWUgdGhlIEFQ SSB0ZXN0IHRvIG1ha2UgaXQgY2xlYXIgdGhhdCBpdCBkb2VzIG5vdCBuZWNlc3NhcmlseSByZXVz ZSBhIFN1c3BlbmRlZFBhZ2UncyBwcm9jZXNzCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0aW9uLm1tOgorCiAyMDE5LTA0LTEw ICBUYWRldSBaYWdhbGxvICA8dHphZ2FsbG9AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBw b3J0IGZvciBpbmNyZW1lbnRhbCBieXRlY29kZSBjYWNoZSB1cGRhdGVzCmRpZmYgLS1naXQgYS9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25OYXZpZ2F0 aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzU3dh cE9uTmF2aWdhdGlvbi5tbQppbmRleCBmYzRmYTZhMWRjNTQ3M2Q5NDk0NTViZDk1MTZmZWIxZTMy OTExYjVkLi43NTgxNThlZWFhYzM1YTA1ZDg4Y2RkNzg0MGE1ZWExMjAyYzk3MmQ3IDEwMDY0NAot LS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NTd2FwT25O YXZpZ2F0aW9uLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2Ev UHJvY2Vzc1N3YXBPbk5hdmlnYXRpb24ubW0KQEAgLTIzOTUsMTAgKzIzOTUsOSBAQCBURVNUKFBy b2Nlc3NTd2FwLCBSZXVzZVN1c3BlbmRlZFByb2Nlc3MpCiAgICAgRVhQRUNUX0VRKGFwcGxlUElE LCBbd2ViVmlldyBfd2ViUHJvY2Vzc0lkZW50aWZpZXJdKTsKIH0KIAotVEVTVChQcm9jZXNzU3dh cCwgUmV1c2VTdXNwZW5kZWRQcm9jZXNzTG9hZEhUTUxTdHJpbmcpCitURVNUKFByb2Nlc3NTd2Fw LCBMb2FkSFRNTFN0cmluZ1Byb2Nlc3NSZXVzZSkKIHsKICAgICBhdXRvIHByb2Nlc3NQb29sQ29u ZmlndXJhdGlvbiA9IHBzb25Qcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24oKTsKLSAgICBwcm9jZXNz UG9vbENvbmZpZ3VyYXRpb24uZ2V0KCkudXNlc1dlYlByb2Nlc3NDYWNoZSA9IE5POwogICAgIGF1 dG8gcHJvY2Vzc1Bvb2wgPSBhZG9wdE5TKFtbV0tQcm9jZXNzUG9vbCBhbGxvY10gX2luaXRXaXRo Q29uZmlndXJhdGlvbjpwcm9jZXNzUG9vbENvbmZpZ3VyYXRpb24uZ2V0KCldKTsKIAogICAgIGF1 dG8gd2ViVmlld0NvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlv biBhbGxvY10gaW5pdF0pOwpAQCAtMjQzMiwxNiArMjQzMSwyNiBAQCBURVNUKFByb2Nlc3NTd2Fw LCBSZXVzZVN1c3BlbmRlZFByb2Nlc3NMb2FkSFRNTFN0cmluZykKICAgICBUZXN0V2ViS2l0QVBJ OjpVdGlsOjpydW4oJmRvbmUpOwogICAgIGRvbmUgPSBmYWxzZTsKIAotICAgIC8vIFdlIHNob3Vs ZCBoYXZlIGdvbmUgYmFjayB0byB0aGUgd2Via2l0Lm9yZyBwcm9jZXNzIGZvciB0aGlzIGxvYWQg c2luY2Ugd2UgcmV1c2UgU3VzcGVuZGVkUGFnZXMnIHByb2Nlc3Mgd2hlbiBwb3NzaWJsZS4KKyAg ICBFWFBFQ1RfTkUoYXBwbGVQSUQsIFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl0pOwor CisjaWYgIVBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgLy8gVGhlIFdlYlByb2Nlc3NDYWNoZSBp cyBkaXNhYmxlZCBvbiBkZXZpY2VzIHdpdGggdG9vIGxpdHRsZSBSQU0gc28gd2UncmUgbm90IGd1 YXJhbnRlZWQgdG8gZ28gYmFjayB0byB0aGUgb3JpZ2luYWwgV2ViS2l0IHByb2Nlc3Mgb24gaU9T LgorICAgIC8vIE9uIG90aGVyIHBsYXRmb3Jtcywgd2Ugc2hvdWxkIGhhdmUgZ29uZSBiYWNrIHRv IHRoZSBXZWJLaXQgcHJvY2VzcyBmb3IgdGhpcyBsb2FkIHNpbmNlIHRoZSBwcm9jZXNzIHdhcyBp biB0aGUgY2FjaGUgb3IgaW4gc3VzcGVuZGVkIHBhZ2VzLgogICAgIEVYUEVDVF9FUSh3ZWJraXRQ SUQsIFt3ZWJWaWV3IF93ZWJQcm9jZXNzSWRlbnRpZmllcl0pOworI2VuZGlmCiAKICAgICBbd2Vi VmlldyBsb2FkSFRNTFN0cmluZzpodG1sU3RyaW5nIGJhc2VVUkw6W05TVVJMIFVSTFdpdGhTdHJp bmc6QCJwc29uOi8vd3d3LmFwcGxlLmNvbS9tYWluMi5odG1sIl1dOwogCiAgICAgVGVzdFdlYktp dEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKICAgICBkb25lID0gZmFsc2U7CiAKLSAgICAvLyBXZSBz aG91bGQgaGF2ZSBnb25lIGJhY2sgdG8gdGhlIGFwcGxlLmNvbSBwcm9jZXNzIGZvciB0aGlzIGxv YWQgc2luY2Ugd2UgcmV1c2UgU3VzcGVuZGVkUGFnZXMnIHByb2Nlc3Mgd2hlbiBwb3NzaWJsZS4K KyAgICBFWFBFQ1RfTkUod2Via2l0UElELCBbd2ViVmlldyBfd2ViUHJvY2Vzc0lkZW50aWZpZXJd KTsKKworI2lmICFQTEFURk9STShJT1NfRkFNSUxZKQorICAgIC8vIFRoZSBXZWJQcm9jZXNzQ2Fj aGUgaXMgZGlzYWJsZWQgb24gZGV2aWNlcyB3aXRoIHRvbyBsaXR0bGUgUkFNIHNvIHdlJ3JlIG5v dCBndWFyYW50ZWVkIHRvIGdvIGJhY2sgdG8gdGhlIG9yaWdpbmFsIEFwcGxlIHByb2Nlc3Mgb24g aU9TLgorICAgIC8vIE9uIG90aGVyIHBsYXRmb3Jtcywgd2Ugc2hvdWxkIGhhdmUgZ29uZSBiYWNr IHRvIHRoZSBBcHBsZSBwcm9jZXNzIGZvciB0aGlzIGxvYWQgc2luY2UgdGhlIHByb2Nlc3Mgd2Fz IGluIHRoZSBjYWNoZSBvciBpbiBzdXNwZW5kZWQgcGFnZXMuCiAgICAgRVhQRUNUX0VRKGFwcGxl UElELCBbd2ViVmlldyBfd2ViUHJvY2Vzc0lkZW50aWZpZXJdKTsKKyNlbmRpZgogfQogCiBzdGF0 aWMgY29uc3QgY2hhciogZmFpbHNUb0VudGVyUGFnZUNhY2hlVGVzdEJ5dGVzID0gUiJQU09OUkVT T1VSQ0UoCg== 367178 2019-04-10 16:50:11 -0700 2019-04-10 23:48:25 -0700 Patch bug-196784-20190410165010.patch text/plain 1901 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVjMzJhYTA0YzAyNWNjYmM5 NDcxYjU3ZDAxMjY2NmVkOGNkMDZhNDEuLjg2Y2FkOGRkNDdiMmU0OThiMWU3N2NlYzRjMDcwYjI4 NjczYjU2ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTktMDQtMTAgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNDQxNDQpIFBy b2Nlc3NTd2FwLlJldXNlU3VzcGVuZGVkUHJvY2Vzc0xvYWRIVE1MU3RyaW5nIEFQSSB0ZXN0IGlz IGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTY3ODQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIHdlIGVudGVyIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIG1vZGUgaW4gdGhlIG5ldyBwcm9j ZXNzLCB3ZSBzdXBwb3NlZCB0byAqY2xvc2UqIHRoZSBsYXN0CisgICAgICAgIFN1c3BlbmRlZFBh Z2VQcm94eSwgbm90IGRlc3Ryb3kgaXQuIFRoaXMgd2FzIGNhdXNpbmcgZmxha2luZXNzIGluIHRo ZSB0ZXN0IGJlY2F1c2UgaXQgd2FzIHRlc3RpbmcKKyAgICAgICAgdGhhdCB3ZSB3ZXJlIHVzaW5n IHRoZSBTdXNwZW5kZWRQYWdlUHJveHkncyBwcm9jZXNzIGZvciBhIGNyb3NzLXNpdGUgbGluayBu YXZpZ2F0aW9uLCB3aGljaCBpcworICAgICAgICBhbiBvcHRpbWl6YXRpb24uIFRoaXMgb3B0aW1p emF0aW9uIHdhcyBwYXJ0bHkgYnJva2VuIGJ5IHIyNDQxNDQgYXMgdGhlIFN1c3BlbmRlZFBhZ2VQ cm94eSB3b3VsZAorICAgICAgICBub3Qgc29tZXRpbWVzIGJlIGdvbmUgYnkgdGhlIHRpbWUgd2Ug bmVlZCBpdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9TdXNwZW5kZWRQYWdlUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpTdXNwZW5kZWRQYWdlUHJveHk6OnBhZ2VFbnRlcmVkQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ01vZGUpOgorCiAyMDE5LTA0LTEwICBKaWV3ZW4gVGFuICA8amlld2VuX3Rh bkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJ1bkphdmFTY3JpcHRJbkZyYW1lIGZvciBXZWJQ YWdlUHJveHkvV2ViUGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvU3Vz cGVuZGVkUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1N1c3BlbmRlZFBh Z2VQcm94eS5jcHAKaW5kZXggOGQ0OTQ4MDhmZmQyMzliY2U4MTIzYjRlZjVmY2RiN2NiNWM2ZDcx Yy4uZDRlNDEwMTMxZGM5YjJlZTFmOGI3YzIwMDRkMGVlNzcxMGU3OGI2MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvU3VzcGVuZGVkUGFnZVByb3h5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9TdXNwZW5kZWRQYWdlUHJveHkuY3BwCkBAIC0xNjksNyArMTY5 LDcgQEAgdm9pZCBTdXNwZW5kZWRQYWdlUHJveHk6OnBhZ2VFbnRlcmVkQWNjZWxlcmF0ZWRDb21w b3NpdGluZ01vZGUoKQogCiAgICAgaWYgKG1fc3VzcGVuc2lvblN0YXRlID09IFN1c3BlbnNpb25T dGF0ZTo6RmFpbGVkVG9TdXNwZW5kKSB7CiAgICAgICAgIC8vIFdlIG5lZWRlZCB0aGUgZmFpbGVk IHN1c3BlbmRlZCBwYWdlIHRvIHN0YXkgYWxpdmUgdG8gYXZvaWQgZmxhc2hpbmcuIE5vdyB3ZSBj YW4gZ2V0IHJpZCBvZiBpdC4KLSAgICAgICAgbV9wcm9jZXNzLT5wcm9jZXNzUG9vbCgpLnJlbW92 ZVN1c3BlbmRlZFBhZ2UoKnRoaXMpOyAvLyBXaWxsIGRlc3Ryb3kgfHRoaXN8LgorICAgICAgICBj bG9zZSgpOwogICAgIH0KIH0KIAo=