196782 2019-04-10 14:11:27 -0700 [iOS] Fix iokit-get-properties sandbox violations 2019-12-17 10:27:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1526116 0 pvollan 2019-04-10 14:11:27 -0700 A few iokit properties needs to be added to the iOS sandbox. 1526117 1 pvollan 2019-04-10 14:11:45 -0700 rdar://problem/49497720 1526119 2 367161 pvollan 2019-04-10 14:13:31 -0700 Created attachment 367161 Patch 1526141 3 367161 bfulgham 2019-04-10 15:00:44 -0700 Comment on attachment 367161 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367161&action=review r=me > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:300 > + (iokit-property "graphics-featureset-class") ;; <rdar://problem/49497720> In general, it's probably nicer to keep these all in alphabetical order (just for ease of locating them in the future) 1526148 4 367169 pvollan 2019-04-10 15:11:43 -0700 Created attachment 367169 Patch 1526152 5 367169 bfulgham 2019-04-10 15:16:55 -0700 Comment on attachment 367169 Patch Very nice! r=me. 1526157 6 367169 pvollan 2019-04-10 15:27:17 -0700 Comment on attachment 367169 Patch Thanks for reviewing! 1526178 7 367169 commit-queue 2019-04-10 15:50:10 -0700 Comment on attachment 367169 Patch Clearing flags on attachment: 367169 Committed r244159: <https://trac.webkit.org/changeset/244159> 367161 2019-04-10 14:13:31 -0700 2019-04-10 15:00:44 -0700 Patch bug-196782-20190410141330.patch text/plain 1636 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQxNDgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTEwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBGaXggaW9raXQtZ2V0 LXByb3BlcnRpZXMgc2FuZGJveCB2aW9sYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY3ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5 NDk3NzIwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBpb2tpdCBwcm9wZXJ0aWVzIHRvIHRoZSBXZWJDb250ZW50IHNhbmRib3ggb24gaU9TLgor CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktp dC5XZWJDb250ZW50LnNiOgorCiAyMDE5LTA0LTEwICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIHJ1bkphdmFTY3JpcHRJbkZyYW1lIGZvciBXZWJQYWdl UHJveHkvV2ViUGFnZQpJbmRleDogU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2Zp bGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuc2IJKHJldmlzaW9uIDI0NDEzNSkKKysrIFNvdXJjZS9XZWJLaXQvUmVzb3Vy Y2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCSh3 b3JraW5nIGNvcHkpCkBAIC0yOTQsNiArMjk0LDEwIEBACiAgICAgKGlva2l0LXByb3BlcnR5ICJw cm9kdWN0LWRlc2NyaXB0aW9uIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5NDk3Nzg4PgogICAgIChp b2tpdC1wcm9wZXJ0eSAiYXJ0d29yay1kaXNwbGF5LWdhbXV0IikgOzsgPHJkYXI6Ly9wcm9ibGVt LzQ5NDk3Nzg4PgogICAgIChpb2tpdC1wcm9wZXJ0eSAiYXJ0d29yay1zY2FsZS1mYWN0b3IiKSA7 OyA8cmRhcjovL3Byb2JsZW0vNDk0OTc3ODg+CisgICAgKGlva2l0LXByb3BlcnR5ICJhcnR3b3Jr LWRldmljZS1pZGlvbSIpIDs7IDxyZGFyOi8vcHJvYmxlbS80OTQ5NzcyMD4KKyAgICAoaW9raXQt cHJvcGVydHkgImFydHdvcmstZHluYW1pYy1kaXNwbGF5bW9kZSIpIDs7IDxyZGFyOi8vcHJvYmxl bS80OTQ5NzcyMD4KKyAgICAoaW9raXQtcHJvcGVydHkgImNvbXBhdGlibGUtZGV2aWNlLWZhbGxi YWNrIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5NDk3NzIwPgorICAgIChpb2tpdC1wcm9wZXJ0eSAi Z3JhcGhpY3MtZmVhdHVyZXNldC1jbGFzcyIpIDs7IDxyZGFyOi8vcHJvYmxlbS80OTQ5NzcyMD4K ICkKIAogOzsgUmVhZC1vbmx5IHByZWZlcmVuY2VzIGFuZCBkYXRhCg== 367169 2019-04-10 15:11:43 -0700 2019-04-10 15:50:10 -0700 Patch bug-196782-20190410151143.patch text/plain 2580 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDQxNDgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA0LTEwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBGaXggaW9raXQtZ2V0 LXByb3BlcnRpZXMgc2FuZGJveCB2aW9sYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY3ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5 NDk3NzIwPgorCisgICAgICAgIFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAg QWRkIGlva2l0IHByb3BlcnRpZXMgdG8gdGhlIFdlYkNvbnRlbnQgc2FuZGJveCBvbiBpT1MuCisK KyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0 LldlYkNvbnRlbnQuc2I6CisKIDIwMTktMDQtMTAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgcnVuSmF2YVNjcmlwdEluRnJhbWUgZm9yIFdlYlBhZ2VQ cm94eS9XZWJQYWdlCkluZGV4OiBTb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmls ZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQu V2ViQ29udGVudC5zYgkocmV2aXNpb24gMjQ0MTM1KQorKysgU291cmNlL1dlYktpdC9SZXNvdXJj ZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJKHdv cmtpbmcgY29weSkKQEAgLTI3OCwyMiArMjc4LDI2IEBACiAgICAgKGlva2l0LXByb3BlcnR5ICJJ T1N1cmZhY2VBY2NlbGVyYXRvckNhcGFiaWxpdGllc0RpY3QiKQogICAgIChpb2tpdC1wcm9wZXJ0 eS1yZWdleCAjIl5NZXRhbFBsdWdpbihOYW1lfENsYXNzTmFtZSkiKQogICAgIChpb2tpdC1wcm9w ZXJ0eSAiUHJvdG9jb2wgQ2hhcmFjdGVyaXN0aWNzIikKKyAgICAoaW9raXQtcHJvcGVydHkgImFy dHdvcmstZGV2aWNlLWlkaW9tIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5NDk3NzIwPgogICAgIChp b2tpdC1wcm9wZXJ0eSAiYXJ0d29yay1kZXZpY2Utc3VidHlwZSIpCisgICAgKGlva2l0LXByb3Bl cnR5ICJhcnR3b3JrLWRpc3BsYXktZ2FtdXQiKSA7OyA8cmRhcjovL3Byb2JsZW0vNDk0OTc3ODg+ CisgICAgKGlva2l0LXByb3BlcnR5ICJhcnR3b3JrLWR5bmFtaWMtZGlzcGxheW1vZGUiKSA7OyA8 cmRhcjovL3Byb2JsZW0vNDk0OTc3MjA+CisgICAgKGlva2l0LXByb3BlcnR5ICJhcnR3b3JrLXNj YWxlLWZhY3RvciIpIDs7IDxyZGFyOi8vcHJvYmxlbS80OTQ5Nzc4OD4KICAgICAoaW9raXQtcHJv cGVydHktcmVnZXggIyIoY2FudmFzLWhlaWdodHxjYW52YXMtd2lkdGgpIikKICAgICAoaW9raXQt cHJvcGVydHkgImNsYXNzLWNvZGUiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiY29sb3ItYWNjdXJh Y3ktaW5kZXgiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiY29tcGF0aWJsZS1kZXZpY2UtZmFsbGJh Y2siKSA7OyA8cmRhcjovL3Byb2JsZW0vNDk0OTc3MjA+CiAgICAgKGlva2l0LXByb3BlcnR5ICJk ZXZpY2UtaWQiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiZGV2aWNlLXBlcmYtbWVtb3J5LWNsYXNz IikKICAgICAoaW9raXQtcHJvcGVydHkgImVtdSIpCisgICAgKGlva2l0LXByb3BlcnR5ICJncmFw aGljcy1mZWF0dXJlc2V0LWNsYXNzIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5NDk3NzIwPgogICAg IChpb2tpdC1wcm9wZXJ0eSAiaGRjcC1ob292ZXItcHJvdG9jb2wiKQogICAgIChpb2tpdC1wcm9w ZXJ0eSAiaW9tbXUtcHJlc2VudCIpCisgICAgKGlva2l0LXByb3BlcnR5ICJwcm9kdWN0LWRlc2Ny aXB0aW9uIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5NDk3Nzg4PgogICAgIChpb2tpdC1wcm9wZXJ0 eSAicHJvZHVjdC1pZCIpCiAgICAgKGlva2l0LXByb3BlcnR5ICJzb2Z0d2FyZS1iZWhhdmlvciIp CiAgICAgKGlva2l0LXByb3BlcnR5ICJ2ZW5kb3ItaWQiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAi dWktcGlwIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ4ODY3MDM3PgotICAgIChpb2tpdC1wcm9wZXJ0 eSAicHJvZHVjdC1kZXNjcmlwdGlvbiIpIDs7IDxyZGFyOi8vcHJvYmxlbS80OTQ5Nzc4OD4KLSAg ICAoaW9raXQtcHJvcGVydHkgImFydHdvcmstZGlzcGxheS1nYW11dCIpIDs7IDxyZGFyOi8vcHJv YmxlbS80OTQ5Nzc4OD4KLSAgICAoaW9raXQtcHJvcGVydHkgImFydHdvcmstc2NhbGUtZmFjdG9y IikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ5NDk3Nzg4PgogKQogCiA7OyBSZWFkLW9ubHkgcHJlZmVy ZW5jZXMgYW5kIGRhdGEK