196781 2019-04-10 14:04:14 -0700 [iOS Sim Debug] ASSERTION FAILED: m_downloads.isEmpty() Layout Test http/tests/websocket/tests/hybi/network-process-crash-error.html is a flaky crash 2019-04-12 09:11:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167341 InRadar P2 Normal --- 1 sroberts cdumez achristensen beidson cdumez commit-queue darin ggaren lforschler webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1526114 0 sroberts 2019-04-10 14:04:14 -0700 The following layout test is flaky on iOS Simulator Debug http/tests/websocket/tests/hybi/network-process-crash-error.html Probable cause: Test has been crashing on its available history on dashboard. Layout results show an Assertion failure. Looking at bot logs there are no crash logs during the times it is crashing. Found through local testing that if http/tests/download/anchor-load-after-download.html is run before http/tests/websocket/tests/hybi/network-process-crash-error.html it will crash 100% of the time on current revisions all the way down to r240541. It will pass on r240469. In that range https://trac.webkit.org/changeset/240530/webkit unskipped the test, and turned on support for a feature in iOS. I am unsure if this was a change from this revision, or uncovering an old bug. There are some radars for this crash log which I will like in the radar I create. I will also attach the full crash log from the local crash there as well. reproduced locally with: run-webkit-tests http/tests/download/anchor-load-after-download.html http/tests/websocket/tests/hybi/network-process-crash-error.html --ios-simulator --debug --child-process 1 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fnetwork-process-crash-error.html Assertion: https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r244108%20(3228)/http/tests/websocket/tests/hybi/network-process-crash-error-crash-log.txt ASSERTION FAILED: m_downloads.isEmpty() /Volumes/Data/slave/ios-simulator-12-debug/build/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp(53) : WebKit::DownloadProxyMap::~DownloadProxyMap() 1 0x10899bb59 WTFCrash 2 0x10d95b18b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10e5cc1c5 WebKit::DownloadProxyMap::~DownloadProxyMap() 4 0x10e5cc375 WebKit::DownloadProxyMap::~DownloadProxyMap() 5 0x10e5d1818 WebKit::NetworkProcessProxy::~NetworkProcessProx 1526115 1 webkit-bug-importer 2019-04-10 14:04:54 -0700 <rdar://problem/49789381> 1526494 2 367250 cdumez 2019-04-11 15:27:42 -0700 Created attachment 367250 Patch 1526752 3 367250 cdumez 2019-04-12 09:11:51 -0700 Comment on attachment 367250 Patch Clearing flags on attachment: 367250 Committed r244217: <https://trac.webkit.org/changeset/244217> 1526753 4 cdumez 2019-04-12 09:11:52 -0700 All reviewed patches have been landed. Closing bug. 367250 2019-04-11 15:27:42 -0700 2019-04-12 09:11:51 -0700 Patch bug-196781-20190411152741.patch text/plain 3868 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMwZjBlOTIzMTBlMmU0MGY5 MjVhMTBjYzhkZTg5MjQ3ODU4N2ZlMTYuLmM0ZTk0YjYzNjJiZDJmOGI4YjNhODM5MjVmMmVjMTJk YTllMDhmMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTktMDQtMTEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TIFNpbSBEZWJ1Z10gQVNTRVJU SU9OIEZBSUxFRDogbV9kb3dubG9hZHMuaXNFbXB0eSgpIExheW91dCBUZXN0IGh0dHAvdGVzdHMv d2Vic29ja2V0L3Rlc3RzL2h5YmkvbmV0d29yay1wcm9jZXNzLWNyYXNoLWVycm9yLmh0bWwgaXMg YSBmbGFreSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTk2NzgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTc4OTM4MT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSBuZXR3b3Jr IHByb2Nlc3MgZ2V0cyB0ZXJtaW5hdGVkIGJ5IHRoZSBjbGllbnQsIHRoZSBOZXR3b3JrUHJvY2Vz c1Byb3h5IG9iamVjdCAoYW5kIHRodXMgaXRzIERvd25sb2FkUHJveHlNYXAgbWVtYmVyKSBnZXQK KyAgICAgICAgZGVzdHJveWVkIHJpZ2h0IGF3YXksIGJlZm9yZSB3ZSBnZXQgYSBjYWxsIHRvIGRp ZENsb3NlKElQQzo6Q29ubmVjdGlvbiYpLiBBcyBhIHJlc3VsdCwgaWYgdGhlcmUgYXJlIG9uZ29p bmcgZG93bmxvYWRzIGF0IHRoZSB0aW1lCisgICAgICAgIG9mIHRoZSB0ZXJtaW5hdGlvbiwgd2Ug d2lsbCBoaXQgdGhlIGFzc2VydGlvbiBhYm92ZS4gVG8gYWRkcmVzcyB0aGUgaXNzdWUsIHVwZGF0 ZSB0aGUgTmV0d29ya1Byb2Nlc3NQcm94eSBkZXN0cnVjdG9yIHRvIGludmFsaWRhdGUKKyAgICAg ICAgaXRzIERvd25sb2FkUHJveHlNYXAgbWVtYmVyLCBzaW1pbGF0b3IgdG8gd2hhdCBpdCBkb2Vz IGluIGRpZENsb3NlKElQQzo6Q29ubmVjdGlvbiYpLgorCisgICAgICAgICogVUlQcm9jZXNzL0Rv d25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQ cm94eU1hcDo6aW52YWxpZGF0ZSk6CisgICAgICAgIChXZWJLaXQ6OkRvd25sb2FkUHJveHlNYXA6 OnByb2Nlc3NEaWRDbG9zZSk6IERlbGV0ZWQuCisgICAgICAgICogVUlQcm9jZXNzL0Rvd25sb2Fk cy9Eb3dubG9hZFByb3h5TWFwLmg6CisgICAgICAgICogVUlQcm9jZXNzL05ldHdvcmsvTmV0d29y a1Byb2Nlc3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzUHJveHk6 On5OZXR3b3JrUHJvY2Vzc1Byb3h5KToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Byb2Nlc3NQ cm94eTo6ZGlkQ2xvc2UpOgorCiAyMDE5LTA0LTExICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OOiBjaGFuZ2luZyBpUGFkIG9yaWVudGF0aW9u IG9uIGJsb2dnZXIuY29tIGNyYXNoZXMgdW5kZXIgUmVtb3RlU2Nyb2xsaW5nQ29vcmRpbmF0b3JQ cm94eTo6ZXN0YWJsaXNoTGF5ZXJUcmVlU2Nyb2xsaW5nUmVsYXRpb25zKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmNwcApp bmRleCAxYTViMWFiMTI0MzFkM2RkZDNkNmUzOGIxZWNlMTdlYmI5MmQ4NWQxLi5iNTYwN2RkMThj MzVlNGRhYzdlMjIxOWI5MzUyYzdlYjFkYTUzN2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eU1hcC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHlNYXAuY3BwCkBAIC0xMTAsNyAr MTEwLDcgQEAgdm9pZCBEb3dubG9hZFByb3h5TWFwOjpkb3dubG9hZEZpbmlzaGVkKERvd25sb2Fk UHJveHkmIGRvd25sb2FkUHJveHkpCiAgICAgfQogfQogCi12b2lkIERvd25sb2FkUHJveHlNYXA6 OnByb2Nlc3NEaWRDbG9zZSgpCit2b2lkIERvd25sb2FkUHJveHlNYXA6OmludmFsaWRhdGUoKQog ewogICAgIC8vIEludmFsaWRhdGUgYWxsIG91dHN0YW5kaW5nIGRvd25sb2Fkcy4KICAgICBmb3Ig KGNvbnN0IGF1dG8mIGRvd25sb2FkIDogbV9kb3dubG9hZHMudmFsdWVzKCkpIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eU1hcC5oCmlu ZGV4IDdlMzA5MjkxZGJkZDY0MzUzNjhkYjNlNzQzNzc2NjY5M2NmZjcyMjYuLmJlMzhjY2I4MmZi NTU5MzlmNDQyZTgxMmE4ZjUzMGQzNDAwZjUwNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9hZFByb3h5TWFwLmgKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvRG93bmxvYWRzL0Rvd25sb2FkUHJveHlNYXAuaApAQCAtNTksNyArNTksNyBA QCBwdWJsaWM6CiAKICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBtX2Rvd25sb2Fk cy5pc0VtcHR5KCk7IH0KIAotICAgIHZvaWQgcHJvY2Vzc0RpZENsb3NlKCk7CisgICAgdm9pZCBp bnZhbGlkYXRlKCk7CiAKICAgICB2b2lkIGFwcGxpY2F0aW9uRGlkRW50ZXJCYWNrZ3JvdW5kKCk7 CiAgICAgdm9pZCBhcHBsaWNhdGlvbldpbGxFbnRlckZvcmVncm91bmQoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzUHJveHkuY3Bw CmluZGV4IGM2YjAyMGM1NjkyZmU3MjMwMWEyYWZmMjIwMzFmOTgwYTUzMGY0YzcuLjQ3MmZkZWU0 MDM4ZmQ1Yzk0MGExNWMzYTBmMTVjMTRlYzY4ZTBmMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc1Byb3h5LmNwcApAQCAtOTcs NiArOTcsOSBAQCBOZXR3b3JrUHJvY2Vzc1Byb3h5Ojp+TmV0d29ya1Byb2Nlc3NQcm94eSgpCiAg ICAgICAgIHByb3h5LT5yZW1vdmVOZXR3b3JrUHJvY2VzcygqdGhpcyk7CiAjZW5kaWYKIAorICAg IGlmIChtX2Rvd25sb2FkUHJveHlNYXApCisgICAgICAgIG1fZG93bmxvYWRQcm94eU1hcC0+aW52 YWxpZGF0ZSgpOworCiAgICAgZm9yIChhdXRvJiByZXBseSA6IG1fcGVuZGluZ0Nvbm5lY3Rpb25S ZXBsaWVzKQogICAgICAgICByZXBseS5zZWNvbmQoeyB9KTsKIH0KQEAgLTI3Myw3ICsyNzYsNyBA QCB2b2lkIE5ldHdvcmtQcm9jZXNzUHJveHk6OmRpZENsb3NlKElQQzo6Q29ubmVjdGlvbiYpCiAg ICAgYXV0byBwcm90ZWN0ZWRQcm9jZXNzUG9vbCA9IG1ha2VSZWYobV9wcm9jZXNzUG9vbCk7CiAK ICAgICBpZiAobV9kb3dubG9hZFByb3h5TWFwKQotICAgICAgICBtX2Rvd25sb2FkUHJveHlNYXAt PnByb2Nlc3NEaWRDbG9zZSgpOworICAgICAgICBtX2Rvd25sb2FkUHJveHlNYXAtPmludmFsaWRh dGUoKTsKICNpZiBFTkFCTEUoTEVHQUNZX0NVU1RPTV9QUk9UT0NPTF9NQU5BR0VSKQogICAgIG1f Y3VzdG9tUHJvdG9jb2xNYW5hZ2VyUHJveHkuaW52YWxpZGF0ZSgpOwogI2VuZGlmCg==