196780 2019-04-10 13:56:03 -0700 [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion 2019-04-10 16:05:27 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=195945 https://bugs.webkit.org/show_bug.cgi?id=196752 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ews-watchlist lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1526110 0 aakash_jain 2019-04-10 13:56:03 -0700 PrintConfiguration should display Xcode version (e.g.: Xcode: 9.4.1) instead of SDKVersion(e.g.: 10.13). 1526111 1 367159 aakash_jain 2019-04-10 13:57:09 -0700 Created attachment 367159 Patch 1526112 2 ews-watchlist 2019-04-10 13:58:50 -0700 Attachment 367159 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1526145 3 aakash_jain 2019-04-10 15:08:19 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/33/builds/4059 1526194 4 367159 commit-queue 2019-04-10 16:04:21 -0700 Comment on attachment 367159 Patch Clearing flags on attachment: 367159 Committed r244164: <https://trac.webkit.org/changeset/244164> 1526195 5 commit-queue 2019-04-10 16:04:22 -0700 All reviewed patches have been landed. Closing bug. 1526196 6 webkit-bug-importer 2019-04-10 16:05:27 -0700 <rdar://problem/49794460> 367159 2019-04-10 13:57:09 -0700 2019-04-10 16:04:21 -0700 Patch bug-196780-20190410165815.patch text/plain 2224 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDE0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBQcmludENvbmZpZ3VyYXRpb24gc2hvdWxkIGRpc3Bs YXkgWGNvZGUgdmVyc2lvbiBpbnN0ZWFkIG9mIFNES1ZlcnNpb24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5Njc4MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5OgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw c191bml0dGVzdC5weToKKwogMjAxOS0wNC0xMCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgaW5jcmVtZW50YWwgYnl0ZWNvZGUg Y2FjaGUgdXBkYXRlcwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0 ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwcy5weQkocmV2aXNpb24gMjQ0MTQzKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC05NTQsMTEgKzk1NCw4IEBAIGNsYXNz IFByaW50Q29uZmlndXJhdGlvbihzdGVwcy5TaGVsbFNlcXUKICAgICAgICAgICAgIG9zX25hbWUg PSBzZWxmLmNvbnZlcnRfYnVpbGRfdG9fb3NfbmFtZShvc192ZXJzaW9uKQogICAgICAgICAgICAg Y29uZmlndXJhdGlvbiA9IHUnT1M6IHt9ICh7fSknLmZvcm1hdChvc19uYW1lLCBvc192ZXJzaW9u KQogCi0gICAgICAgIHNka19yZSA9ICdNYWNPU1hbXHNcU10qP1NES1ZlcnNpb246WyBcdF0qKC4r PylcbicKLSAgICAgICAgaXNfaW9zX2J1aWxkZXIgPSAnaU9TJyBpbiBzZWxmLmdldFByb3BlcnR5 KCdidWlsZGVybmFtZScsICcnKQotICAgICAgICBpZiBpc19pb3NfYnVpbGRlcjoKLSAgICAgICAg ICAgIHNka19yZSA9ICdpUGhvbmVTaW11bGF0b3JbXHNcU10qP1NES1ZlcnNpb246WyBcdF0qKC4r PylcbicKLSAgICAgICAgbWF0Y2ggPSByZS5zZWFyY2goc2RrX3JlLCBsb2dUZXh0KQorICAgICAg ICB4Y29kZV9yZSA9IHNka19yZSA9ICdYY29kZVsgXHRdKz8oWzAtOS5dKz8pXG4nCisgICAgICAg IG1hdGNoID0gcmUuc2VhcmNoKHhjb2RlX3JlLCBsb2dUZXh0KQogICAgICAgICBpZiBtYXRjaDoK ICAgICAgICAgICAgIHhjb2RlX3ZlcnNpb24gPSBtYXRjaC5ncm91cCgxKS5zdHJpcCgpCiAgICAg ICAgICAgICBjb25maWd1cmF0aW9uICs9IHUnLCBYY29kZToge30nLmZvcm1hdCh4Y29kZV92ZXJz aW9uKQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjQ0MTQzKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMjkx LDcgKzEyOTEsNyBAQCBYY29kZSA5LjQuMQogQnVpbGQgdmVyc2lvbiA5RjIwMDAnJycpCiAgICAg ICAgICAgICArIDAsCiAgICAgICAgICkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3Vs dD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J09TOiBIaWdoIFNpZXJyYSAoMTAuMTMuNCksIFhjb2Rl OiAxMC4xMycpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3Rh dGVfc3RyaW5nPSdPUzogSGlnaCBTaWVycmEgKDEwLjEzLjQpLCBYY29kZTogOS40LjEnKQogICAg ICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKIAogICAgIGRlZiB0ZXN0X2ZhaWx1cmUoc2VsZik6 Cg==