196770 2019-04-10 09:12:03 -0700 Add a way to opt into modern compatibility mode in layout tests 2019-04-10 10:46:51 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin commit-queue graouts lforschler thorton webkit-bug-importer oldest_to_newest 1525960 0 wenson_hsieh 2019-04-10 09:12:03 -0700 SSIA 1525961 1 webkit-bug-importer 2019-04-10 09:12:33 -0700 <rdar://problem/49777550> 1525985 2 367132 wenson_hsieh 2019-04-10 09:48:33 -0700 Created attachment 367132 Patch 1525987 3 367132 graouts 2019-04-10 09:52:51 -0700 Comment on attachment 367132 Patch I guess we don't care about DRT here, right? 1525991 4 wenson_hsieh 2019-04-10 09:54:01 -0700 (In reply to Antoine Quint from comment #3) > Comment on attachment 367132 [details] > Patch > > I guess we don't care about DRT here, right? Indeed — "modern compatibility mode" isn't coming to legacy WebKit. 1526008 5 367132 commit-queue 2019-04-10 10:46:50 -0700 Comment on attachment 367132 Patch Clearing flags on attachment: 367132 Committed r244134: <https://trac.webkit.org/changeset/244134> 1526009 6 commit-queue 2019-04-10 10:46:51 -0700 All reviewed patches have been landed. Closing bug. 367132 2019-04-10 09:48:33 -0700 2019-04-10 10:46:50 -0700 Patch bug-196770-20190410094833.patch text/plain 4909 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmFmMGFkNjNjMDIxNTUyNTc5OTA5ZmU5YmExOTk0YzBj OWI5MzEwNi4uOGE2MDQxMmUzMzE1OTY2MGFhZDQzYjU5NzYxN2ExMTRjMTcyYWRkYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE5LTA0LTEwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBhIHdheSB0byBvcHQgaW50byBtb2Rlcm4gY29tcGF0aWJpbGl0eSBtb2Rl IGluIGxheW91dCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk2NzcwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80OTc3NzU1MD4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBuZXcgdGVz dCBvcHRpb24gdG8gZW5hYmxlIG1vZGVybiBjb21wYXRpYmlsaXR5IG1vZGUgaW4gbGF5b3V0IHRl c3RzLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6Cisg ICAgICAgIChXVFI6OnVwZGF0ZVRlc3RPcHRpb25zRnJvbVRlc3RIZWFkZXIpOgorICAgICAgICAq IFdlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL1Rlc3RPcHRpb25zLmg6CisgICAgICAgIChXVFI6OlRlc3RPcHRpb25zOjpoYXNTYW1l SW5pdGlhbGl6YXRpb25PcHRpb25zIGNvbnN0KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L2NvY29hL1Rlc3RDb250cm9sbGVyQ29jb2EubW06CisgICAgICAgIChXVFI6OlRlc3RDb250cm9s bGVyOjpwbGF0Zm9ybUNyZWF0ZVdlYlZpZXcpOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxl cjo6ZW5hYmxlTW9kZXJuQ29tcGF0aWJpbGl0eU1vZGUpOgorCiAyMDE5LTA0LTA4ICBGdWppaSBI aXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIEFYOiBTdXBwb3J0 IEFQSTogYWNjZXNzaWJpbGl0eVJlcGxhY2VSYW5nZTp3aXRoVGV4dApkaWZmIC0tZ2l0IGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAppbmRleCAzZTllZWI2NTRmNjdhNTQ3OTExYjEwOTBm YjE3NjIxYWU1N2EzNGI2Li4zM2FhNTAwMjJlNjc0Y2JiZTVkOGRjNWU3MGMzMTA0M2NlMThlM2Uz IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAor KysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcApAQCAtMTM2Miw2 ICsxMzYyLDggQEAgc3RhdGljIHZvaWQgdXBkYXRlVGVzdE9wdGlvbnNGcm9tVGVzdEhlYWRlcihU ZXN0T3B0aW9ucyYgdGVzdE9wdGlvbnMsIGNvbnN0IHN0ZDoKICAgICAgICAgICAgIHRlc3RPcHRp b25zLmNvbnRlbnRJbnNldFRvcCA9IHN0ZDo6c3RvZCh2YWx1ZSk7CiAgICAgICAgIGVsc2UgaWYg KGtleSA9PSAiaWdub3JlU3luY2hyb25vdXNNZXNzYWdpbmdUaW1lb3V0cyIpCiAgICAgICAgICAg ICB0ZXN0T3B0aW9ucy5jb250ZXh0T3B0aW9ucy5pZ25vcmVTeW5jaHJvbm91c01lc3NhZ2luZ1Rp bWVvdXRzID0gcGFyc2VCb29sZWFuVGVzdEhlYWRlclZhbHVlKHZhbHVlKTsKKyAgICAgICAgZWxz ZSBpZiAoa2V5ID09ICJzaG91bGRVc2VNb2Rlcm5Db21wYXRpYmlsaXR5TW9kZSIpCisgICAgICAg ICAgICB0ZXN0T3B0aW9ucy5zaG91bGRVc2VNb2Rlcm5Db21wYXRpYmlsaXR5TW9kZSA9IHBhcnNl Qm9vbGVhblRlc3RIZWFkZXJWYWx1ZSh2YWx1ZSk7CiAgICAgICAgIHBhaXJTdGFydCA9IHBhaXJF bmQgKyAxOwogICAgIH0KIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVz dENvbnRyb2xsZXIuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuaApp bmRleCBhY2U2YTU0MTAyYzg5YmRhZWM2YWEzZTNjYzA2NTZjNTkzNThkNTljLi5kZTkxMzBjNjg0 MzQ1ZmQ1ZmY5OGE2YWVmMDY2ZTg1MWNkY2RhYWU1IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5oCkBAIC00NTgsNiArNDU4LDcgQEAgcHJpdmF0ZToKIAogI2lmIFBMQVRG T1JNKENPQ09BKQogICAgIHN0YXRpYyB2b2lkIGZpbmlzaENyZWF0aW5nUGxhdGZvcm1XZWJWaWV3 KFBsYXRmb3JtV2ViVmlldyosIGNvbnN0IFRlc3RPcHRpb25zJik7CisgICAgdm9pZCBlbmFibGVN b2Rlcm5Db21wYXRpYmlsaXR5TW9kZShXS1dlYlZpZXdDb25maWd1cmF0aW9uICopOwogI2VuZGlm CiAKICAgICBzdGF0aWMgY29uc3QgY2hhciogbGlicmFyeVBhdGhGb3JUZXN0aW5nKCk7CmRpZmYg LS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RPcHRpb25zLmggYi9Ub29scy9XZWJL aXRUZXN0UnVubmVyL1Rlc3RPcHRpb25zLmgKaW5kZXggNGQ3ZWExNTQ2OGQ1YzY3Y2Q5M2E0Y2Uw YzM5YTQyMGU1NjljZmRjYS4uMmIxZGJmOWNlNTA0OWVjMWM5ZTQxNjZiZjI1N2UxYjc4YTQzNDZk ZCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0T3B0aW9ucy5oCisrKyBi L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdE9wdGlvbnMuaApAQCAtOTEsNiArOTEsNyBAQCBz dHJ1Y3QgVGVzdE9wdGlvbnMgewogICAgIGJvb2wgZW5hYmxlVW5kb01hbmFnZXJBUEkgeyBmYWxz ZSB9OwogICAgIGJvb2wgc2hvdWxkSGFuZGxlUnVuT3BlblBhbmVsIHsgdHJ1ZSB9OwogICAgIGJv b2wgc2hvdWxkUHJlc2VudFBvcG92ZXJzIHsgdHJ1ZSB9OworICAgIGJvb2wgc2hvdWxkVXNlTW9k ZXJuQ29tcGF0aWJpbGl0eU1vZGUgeyBmYWxzZSB9OwogCiAgICAgZG91YmxlIGNvbnRlbnRJbnNl dFRvcCB7IDAgfTsKIApAQCAtMTQwLDcgKzE0MSw4IEBAIHN0cnVjdCBUZXN0T3B0aW9ucyB7CiAg ICAgICAgICAgICB8fCBlbmFibGVVbmRvTWFuYWdlckFQSSAhPSBvcHRpb25zLmVuYWJsZVVuZG9N YW5hZ2VyQVBJCiAgICAgICAgICAgICB8fCBzaG91bGRIYW5kbGVSdW5PcGVuUGFuZWwgIT0gb3B0 aW9ucy5zaG91bGRIYW5kbGVSdW5PcGVuUGFuZWwKICAgICAgICAgICAgIHx8IHNob3VsZFByZXNl bnRQb3BvdmVycyAhPSBvcHRpb25zLnNob3VsZFByZXNlbnRQb3BvdmVycwotICAgICAgICAgICAg fHwgY29udGVudEluc2V0VG9wICE9IG9wdGlvbnMuY29udGVudEluc2V0VG9wKQorICAgICAgICAg ICAgfHwgY29udGVudEluc2V0VG9wICE9IG9wdGlvbnMuY29udGVudEluc2V0VG9wCisgICAgICAg ICAgICB8fCBzaG91bGRVc2VNb2Rlcm5Db21wYXRpYmlsaXR5TW9kZSAhPSBvcHRpb25zLnNob3Vs ZFVzZU1vZGVybkNvbXBhdGliaWxpdHlNb2RlKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgICAgIGlmICghY29udGV4dE9wdGlvbnMuaGFzU2FtZUluaXRpYWxpemF0aW9uT3B0aW9u cyhvcHRpb25zLmNvbnRleHRPcHRpb25zKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvY29jb2EvVGVzdENvbnRyb2xsZXJDb2NvYS5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvY29jb2EvVGVzdENvbnRyb2xsZXJDb2NvYS5tbQppbmRleCA2ZThkOTQ0NmEwMGFjYjA2ZDll MmYyNGU2Yjk5Y2I0ODBmZWY3NjBlLi5iZDVmMzlmMmNlMjU2NGEwZWQzM2YzMTg4NzdhNzFlMTky NjQxOTA0IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2NvY29hL1Rlc3RDb250 cm9sbGVyQ29jb2EubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9jb2NvYS9UZXN0Q29u dHJvbGxlckNvY29hLm1tCkBAIC0xNTksNiArMTU5LDkgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6 cGxhdGZvcm1DcmVhdGVXZWJWaWV3KFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYsIGNvbnN0IFRlc3RP cHQKICAgICBpZiAob3B0aW9ucy5lbmFibGVVbmRvTWFuYWdlckFQSSkKICAgICAgICAgW2NvcGll ZENvbmZpZ3VyYXRpb24gX3NldFVuZG9NYW5hZ2VyQVBJRW5hYmxlZDpZRVNdOwogCisgICAgaWYg KG9wdGlvbnMuc2hvdWxkVXNlTW9kZXJuQ29tcGF0aWJpbGl0eU1vZGUpCisgICAgICAgIGVuYWJs ZU1vZGVybkNvbXBhdGliaWxpdHlNb2RlKGNvcGllZENvbmZpZ3VyYXRpb24uZ2V0KCkpOworCiAg ICAgaWYgKG9wdGlvbnMuYXBwbGljYXRpb25NYW5pZmVzdC5sZW5ndGgoKSkgewogICAgICAgICBh dXRvIG1hbmlmZXN0UGF0aCA9IFtOU1N0cmluZyBzdHJpbmdXaXRoVVRGOFN0cmluZzpvcHRpb25z LmFwcGxpY2F0aW9uTWFuaWZlc3QuY19zdHIoKV07CiAgICAgICAgIE5TU3RyaW5nICp0ZXh0ID0g W05TU3RyaW5nIHN0cmluZ1dpdGhDb250ZW50c09mRmlsZTptYW5pZmVzdFBhdGggdXNlZEVuY29k aW5nOm51bGxwdHIgZXJyb3I6bnVsbHB0cl07CkBAIC00MDIsNCArNDA1LDE0IEBAIGJvb2wgVGVz dENvbnRyb2xsZXI6OmlzRG9pbmdNZWRpYUNhcHR1cmUoKSBjb25zdAogICAgIHJldHVybiBtX21h aW5XZWJWaWV3LT5wbGF0Zm9ybVZpZXcoKS5fbWVkaWFDYXB0dXJlU3RhdGUgIT0gX1dLTWVkaWFD YXB0dXJlU3RhdGVOb25lOwogfQogCisjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKKyNpbXBv cnQgPFdlYktpdEFkZGl0aW9ucy9UZXN0Q29udHJvbGxlckNvY29hQWRkaXRpb25zLm1tPgorI2Vs c2UKKwordm9pZCBUZXN0Q29udHJvbGxlcjo6ZW5hYmxlTW9kZXJuQ29tcGF0aWJpbGl0eU1vZGUo V0tXZWJWaWV3Q29uZmlndXJhdGlvbiAqKQoreworfQorCisjZW5kaWYKKwogfSAvLyBuYW1lc3Bh Y2UgV1RSCg==