19677 2008-06-19 10:36:57 -0700 Syntax highlighting JavaScript needs to be lazy 2008-06-20 15:22:28 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 14360 1 timothy timothy aroben keishi rik oldest_to_newest 83894 0 timothy 2008-06-19 10:36:57 -0700 The new syntax highlighting is written in JavaScript and can be slow for large documents. We should make is lazy and only syntax highlight visible lines of code and delays the rest until the user scrolls down. Some of the work to make this lazy has already been done in the original patch. Related to bug 14360. 83979 1 21858 timothy 2008-06-20 11:22:50 -0700 Created attachment 21858 Proposed patch 83982 2 21858 aroben 2008-06-20 11:29:25 -0700 Comment on attachment 21858 Proposed patch + if (i < (end - 1)) + deleteContinueFlags(previousCell); I think if (i > 0) would be clearer here. r=me 83983 3 aroben 2008-06-20 11:32:47 -0700 (In reply to comment #2) > (From update of attachment 21858 [edit]) > + if (i < (end - 1)) > + deleteContinueFlags(previousCell); > > I think if (i > 0) would be clearer here. ...and more correct. 84006 4 timothy 2008-06-20 15:22:28 -0700 Landed in r34695. 21858 2008-06-20 11:22:50 -0700 2008-06-20 11:29:25 -0700 Proposed patch 0001-Makes-the-JavaScript-syntax-highlighter-proc.patch text/plain 4660 timothy RnJvbSA1NGI0NDVkZDBhYzVkYWU1OGUwZTVhNmY4NTcyNmNhNGM4OTJmMGJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBGcmksIDIwIEp1biAyMDA4IDA4OjMzOjQ1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBNYWtlcyB0aGUgSmF2YVNjcmlwdCBzeW50YXggaGlnaGxpZ2h0ZXIgcHJvY2VzcyBsaW5l cyBpbiBjaHVua3MKICAgICAgICAgc28gdGhlIHVzZXIgaW50ZXJmYWNlIGlzbid0IGJsb2NrZWQg Zm9yIGxhcmdlIHNjcmlwdCBmaWxlcy4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5Njc3CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL1NvdXJjZUZyYW1lLmpzOgogICAgICAgIChXZWJJ bnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLl9hZGRNZXNzYWdlVG9Tb3VyY2UpOiBVc2Ug dGhlIGNlbGxzCiAgICAgICAgcHJvcGVydHkgb24gdGhlIHJvdyBpbnN0ZWFkIG9mIGdldEVsZW1l bnRzQnlUYWdOYW1lLgogICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBl LnN5bnRheEhpZ2hsaWdodEphdmFzY3JpcHQpOiBVc2UgdGhlCiAgICAgICAgY2VsbHMgcHJvcGVy dHkgb24gdGhlIHJvdyBpbnN0ZWFkIG9mIGdldEVsZW1lbnRzQnlUYWdOYW1lLiBBZGRlZAogICAg ICAgIGEgbmVzdGVkIHByb2Nlc3NDaHVuayBmdW5jdGlvbiB0aGF0IGhpZ2hsaWdodHMgMTAgbGlu ZXMgYXQgYSB0aW1lCiAgICAgICAgVGhpcyBwcm9jZXNzQ2h1bmsgZnVuY3Rpb24gaXMgY2FsbGVk IGF0IGFuIGludGVydmFsIG9mIDI1bXMuIFRoZQogICAgICAgIGNvZGUgaXMgc3RpbGwgaGlnaGxp Z2h0ZWQgcXVpY2tseSwgYW5kIHRoZSB1c2VyIGNhbid0IHRlbGwgaXQgd2Fzbid0CiAgICAgICAg aGlnaGxpZ2h0ZWQgYWxsIGF0IG9uY2UuCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAg ICAgICAgICAgICB8ICAgMTkgKysrKysrKysrKysrKysrKysKIFdlYkNvcmUvcGFnZS9pbnNwZWN0 b3IvU291cmNlRnJhbWUuanMgfCAgIDM3ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0t LQogMiBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDg5 MDMxMDguLjQ4ZWVjMTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMDgtMDYtMjAgIFRpbW90aHkgSGF0Y2hl ciAgPHRpbW90aHlAYXBwbGUuY29tPgogCisgICAgICAgIE1ha2VzIHRoZSBKYXZhU2NyaXB0IHN5 bnRheCBoaWdobGlnaHRlciBwcm9jZXNzIGxpbmVzIGluIGNodW5rcworICAgICAgICBzbyB0aGUg dXNlciBpbnRlcmZhY2UgaXNuJ3QgYmxvY2tlZCBmb3IgbGFyZ2Ugc2NyaXB0IGZpbGVzLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY3NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9pbnNw ZWN0b3IvU291cmNlRnJhbWUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUu cHJvdG90eXBlLl9hZGRNZXNzYWdlVG9Tb3VyY2UpOiBVc2UgdGhlIGNlbGxzCisgICAgICAgIHBy b3BlcnR5IG9uIHRoZSByb3cgaW5zdGVhZCBvZiBnZXRFbGVtZW50c0J5VGFnTmFtZS4KKyAgICAg ICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuc3ludGF4SGlnaGxpZ2h0SmF2 YXNjcmlwdCk6IFVzZSB0aGUKKyAgICAgICAgY2VsbHMgcHJvcGVydHkgb24gdGhlIHJvdyBpbnN0 ZWFkIG9mIGdldEVsZW1lbnRzQnlUYWdOYW1lLiBBZGRlZAorICAgICAgICBhIG5lc3RlZCBwcm9j ZXNzQ2h1bmsgZnVuY3Rpb24gdGhhdCBoaWdobGlnaHRzIDEwIGxpbmVzIGF0IGEgdGltZQorICAg ICAgICBUaGlzIHByb2Nlc3NDaHVuayBmdW5jdGlvbiBpcyBjYWxsZWQgYXQgYW4gaW50ZXJ2YWwg b2YgMjVtcy4gVGhlCisgICAgICAgIGNvZGUgaXMgc3RpbGwgaGlnaGxpZ2h0ZWQgcXVpY2tseSwg YW5kIHRoZSB1c2VyIGNhbid0IHRlbGwgaXQgd2Fzbid0CisgICAgICAgIGhpZ2hsaWdodGVkIGFs bCBhdCBvbmNlLgorCisyMDA4LTA2LTIwICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxl LmNvbT4KKwogICAgICAgICBGaXhlcyBhIGJ1ZyB3aGVyZSB0aGUgc291cmNlIHZpZXcgaW4gdGhl IFJlc291cmNlcyBwYW5lbCBoYWQgYQogICAgICAgICBjb3VwbGUgb2YgZXh0cmEgcGl4ZWxzIGF0 IHRoZSBib3R0b20gd2hlbiBmdWxseSBzY3JvbGxlZC4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w YWdlL2luc3BlY3Rvci9Tb3VyY2VGcmFtZS5qcyBiL1dlYkNvcmUvcGFnZS9pbnNwZWN0b3IvU291 cmNlRnJhbWUuanMKaW5kZXggM2RkYWE1Ni4uMzNkMWZhZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w YWdlL2luc3BlY3Rvci9Tb3VyY2VGcmFtZS5qcworKysgYi9XZWJDb3JlL3BhZ2UvaW5zcGVjdG9y L1NvdXJjZUZyYW1lLmpzCkBAIC0zMjEsNyArMzIxLDcgQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUZy YW1lLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCFyb3cpCiAgICAgICAgICAgICByZXR1cm47 CiAKLSAgICAgICAgdmFyIGNlbGwgPSByb3cuZ2V0RWxlbWVudHNCeVRhZ05hbWUoInRkIilbMV07 CisgICAgICAgIHZhciBjZWxsID0gcm93LmNlbGxzWzFdOwogICAgICAgICBpZiAoIWNlbGwpCiAg ICAgICAgICAgICByZXR1cm47CiAKQEAgLTU5NCw5ICs1OTQsMTEgQEAgV2ViSW5zcGVjdG9yLlNv dXJjZUZyYW1lLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKCF0YWJsZSkKICAgICAgICAgICAg IHJldHVybjsKIAorICAgICAgICB2YXIgaSA9IDA7CiAgICAgICAgIHZhciByb3dzID0gdGFibGUu cm93czsKICAgICAgICAgdmFyIHJvd3NMZW5ndGggPSByb3dzLmxlbmd0aDsKICAgICAgICAgdmFy IHByZXZpb3VzQ2VsbCA9IG51bGw7CisgICAgICAgIHZhciBwcm9jZXNzQ2h1bmtJbnRlcnZhbDsK IAogICAgICAgICBmdW5jdGlvbiBkZWxldGVDb250aW51ZUZsYWdzKGNlbGwpCiAgICAgICAgIHsK QEAgLTYwOCwxNiArNjEwLDMxIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUg PSB7CiAgICAgICAgICAgICBkZWxldGUgY2VsbC5fcmVnZXhwQ29udGludWVzOwogICAgICAgICB9 CiAKLSAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByb3dzTGVuZ3RoOyArK2kpIHsKLSAgICAg ICAgICAgIHZhciByb3cgPSByb3dzW2ldOwotICAgICAgICAgICAgdmFyIGNlbGwgPSByb3cuZ2V0 RWxlbWVudHNCeVRhZ05hbWUoInRkIilbMV07Ci0gICAgICAgICAgICBpZiAoIWNlbGwpCi0gICAg ICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB0aGlzLl9zeW50YXhIaWdobGlnaHRK YXZhc2NyaXB0TGluZShjZWxsLCBwcmV2aW91c0NlbGwpOwotICAgICAgICAgICAgZGVsZXRlQ29u dGludWVGbGFncyhwcmV2aW91c0NlbGwpOwotICAgICAgICAgICAgcHJldmlvdXNDZWxsID0gY2Vs bDsKKyAgICAgICAgLy8gU3BsaXQgdXAgdGhlIHdvcmsgaW50byBjaHVua3Mgc28gd2UgZG9uJ3Qg YmxvY2sgdGhlCisgICAgICAgIC8vIFVJIHRocmVhZCB3aGlsZSBwcm9jZXNzaW5nLgorCisgICAg ICAgIGZ1bmN0aW9uIHByb2Nlc3NDaHVuaygpCisgICAgICAgIHsKKyAgICAgICAgICAgIGZvciAo dmFyIGVuZCA9IE1hdGgubWluKGkgKyAxMCwgcm93c0xlbmd0aCk7IGkgPCBlbmQ7ICsraSkgewor ICAgICAgICAgICAgICAgIHZhciByb3cgPSByb3dzW2ldOworICAgICAgICAgICAgICAgIGlmICgh cm93KQorICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICB2YXIg Y2VsbCA9IHJvdy5jZWxsc1sxXTsKKyAgICAgICAgICAgICAgICBpZiAoIWNlbGwpCisgICAgICAg ICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIHRoaXMuX3N5bnRheEhpZ2hs aWdodEphdmFzY3JpcHRMaW5lKGNlbGwsIHByZXZpb3VzQ2VsbCk7CisgICAgICAgICAgICAgICAg aWYgKGkgPCAoZW5kIC0gMSkpCisgICAgICAgICAgICAgICAgICAgIGRlbGV0ZUNvbnRpbnVlRmxh Z3MocHJldmlvdXNDZWxsKTsKKyAgICAgICAgICAgICAgICBwcmV2aW91c0NlbGwgPSBjZWxsOwor ICAgICAgICAgICAgfQorCisgICAgICAgICAgICBpZiAoaSA+PSByb3dzTGVuZ3RoICYmIHByb2Nl c3NDaHVua0ludGVydmFsKSB7CisgICAgICAgICAgICAgICAgZGVsZXRlQ29udGludWVGbGFncyhw cmV2aW91c0NlbGwpOworICAgICAgICAgICAgICAgIGNsZWFySW50ZXJ2YWwocHJvY2Vzc0NodW5r SW50ZXJ2YWwpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgZGVsZXRlQ29u dGludWVGbGFncyhwcmV2aW91c0NlbGwpOworICAgICAgICBwcm9jZXNzQ2h1bmsuY2FsbCh0aGlz KTsKKyAgICAgICAgcHJvY2Vzc0NodW5rSW50ZXJ2YWwgPSBzZXRJbnRlcnZhbChwcm9jZXNzQ2h1 bmsuYmluZCh0aGlzKSwgMjUpOwogICAgIH0KIH0KLS0gCjEuNS40LjQKCg==