19676 2008-06-19 09:50:18 -0700 [Gtk] text-shadow should apply to text decorations as well 2010-11-27 08:21:53 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED DUPLICATE 48074 Gtk P2 Normal --- 1 jonathon webkit-unassigned mrobinson oldest_to_newest 83887 0 jonathon 2008-06-19 09:50:18 -0700 The Gtk port doesn't currently draw text shadows for text decorations such as underlines. 83914 1 21849 jonathon 2008-06-19 13:36:48 -0700 Created attachment 21849 patch to implement drawing shadows for lines 84293 2 21914 jonathon 2008-06-24 12:59:25 -0700 Created attachment 21914 Updated patch due to changes from bug #19727 87650 3 21914 eric 2008-08-01 16:54:25 -0700 Comment on attachment 21914 Updated patch due to changes from bug #19727 Isn't "drawLineForText" used for drawing underlines? Also this seems like kinda a gross hack. But maybe this is the cleanest way to do this with Cairo. Also, you don't respect Shadow-blur. I think that we should come up with a better way of drawing Cairo shadows instead of this. A shadow is a second copy of the entire image drawn at an offset and blurred. 314129 4 mrobinson 2010-11-27 08:21:53 -0800 *** This bug has been marked as a duplicate of bug 48074 *** 21849 2008-06-19 13:36:48 -0700 2008-06-24 12:59:25 -0700 patch to implement drawing shadows for lines 0001-draw-shadow-for-text-underlines-in-Gtk-Port.patch text/plain 2065 jonathon RnJvbSA5MGZkYTA2ZTBmNzdmY2E1YmRjMmY2M2EwYzhiNjE4ODIyYmNhNWQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb25hdGhvbiBKb25nc21hIDxqb25hdGhvbi5qb25nc21hQGNv bGxhYm9yYS5jby51az4KRGF0ZTogVGh1LCAxOSBKdW4gMjAwOCAxNTozODozMSAtMDUwMApTdWJq ZWN0OiBbUEFUQ0hdIGRyYXcgc2hhZG93IGZvciB0ZXh0IHVuZGVybGluZXMgaW4gR3RrIFBvcnQK Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDEwICsrKysrKysrKysKIC4uLi9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWly by5jcHAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjUg aW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5n ZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdmYzJlZWYuLjc4NmFkMDUgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMDgtMDYtMTkgIEpvbmF0aG9uIEpvbmdzbWEgIDxqb25hdGhvbi5qb25nc21hQGNv bGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZHJhd0xpbmUpOiBkcmF3IHNoYWRvd3Mg Zm9yIHVuZGVybGluZXMgKEJ1ZworICAgICAgICAjMTk2NzYpCisKIDIwMDgtMDYtMTkgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFF0IGJ1aWxkIGZpeC4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250 ZXh0Q2Fpcm8uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0Nv bnRleHRDYWlyby5jcHAKaW5kZXggYjA3ZTJhNC4uMzE3NTVjYSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAK QEAgLTI1NCw2ICsyNTQsMjEgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdMaW5lKGNvbnN0 IEludFBvaW50JiBwb2ludDEsIGNvbnN0IEludFBvaW50JiBwb2ludDIpCiAgICAgICAgIGNhaXJv X3NldF9kYXNoKGNyLCAmZGFzaCwgMSwgcGF0dGVybk9mZnNldCk7CiAgICAgfQogCisgICAgSW50 U2l6ZSBzaGFkb3dTaXplOworICAgIGludCBzaGFkb3dCbHVyOworICAgIENvbG9yIHNoYWRvd0Nv bG9yOworICAgIGdldFNoYWRvdyhzaGFkb3dTaXplLCBzaGFkb3dCbHVyLCBzaGFkb3dDb2xvcik7 CisgICAgYm9vbCBoYXNTaGFkb3cgPSB0ZXh0RHJhd2luZ01vZGUoKSA9PSBjVGV4dEZpbGwgJiYg c2hhZG93Q29sb3IuaXNWYWxpZCgpICYmIChzaGFkb3dTaXplLndpZHRoKCkgfHwgc2hhZG93U2l6 ZS5oZWlnaHQoKSk7CisgICAgaWYgKGhhc1NoYWRvdykgeworICAgICAgICBjYWlyb19zYXZlKGNy KTsKKyAgICAgICAgc2V0Q29sb3IoY3IsIHNoYWRvd0NvbG9yKTsKKyAgICAgICAgY2Fpcm9fdHJh bnNsYXRlKGNyLCBzaGFkb3dTaXplLndpZHRoKCksIHNoYWRvd1NpemUuaGVpZ2h0KCkpOworICAg ICAgICBjYWlyb19tb3ZlX3RvKGNyLCBwMS54KCksIHAxLnkoKSk7CisgICAgICAgIGNhaXJvX2xp bmVfdG8oY3IsIHAyLngoKSwgcDIueSgpKTsKKyAgICAgICAgY2Fpcm9fc3Ryb2tlKGNyKTsKKyAg ICAgICAgY2Fpcm9fcmVzdG9yZShjcik7CisgICAgfQorCiAgICAgY2Fpcm9fbW92ZV90byhjciwg cDEueCgpLCBwMS55KCkpOwogICAgIGNhaXJvX2xpbmVfdG8oY3IsIHAyLngoKSwgcDIueSgpKTsK IAotLSAKMS41LjUKCg== 21914 2008-06-24 12:59:25 -0700 2010-06-10 15:52:22 -0700 Updated patch due to changes from bug #19727 0001-draw-shadow-for-text-underlines-in-Gtk-Port.patch text/plain 1907 jonathon RnJvbSBkZWI5OGZmNmFlNDYwMGZiZjRiNDJlY2RkNjMzMjBiNzUxMDc5MjQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb25hdGhvbiBKb25nc21hIDxqb25hdGhvbi5qb25nc21hQGNv bGxhYm9yYS5jby51az4KRGF0ZTogVGh1LCAxOSBKdW4gMjAwOCAxNTozODozMSAtMDUwMApTdWJq ZWN0OiBbUEFUQ0hdIGRyYXcgc2hhZG93IGZvciB0ZXh0IHVuZGVybGluZXMgaW4gR3RrIFBvcnQK Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgICA4ICsrKysrKysrCiAuLi4vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8u Y3BwICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNl cnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE4ZjU2Yy4uYzZmNzNmMSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBA QAorMjAwOC0wNi0xOSAgSm9uYXRob24gSm9uZ3NtYSAgPGpvbmF0aG9uLmpvbmdzbWFAY29sbGFi b3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZSk6IGRyYXcgc2hhZG93 cyBmb3IgdW5kZXJsaW5lcyAoQnVnCisgICAgICAgICMxOTY3NikKKwogMjAwOC0wNi0yNCAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVsZWFzZSBidWls ZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBo aWNzQ29udGV4dENhaXJvLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3Jh cGhpY3NDb250ZXh0Q2Fpcm8uY3BwCmluZGV4IGIwN2UyYTQuLmEzMTJkN2UgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fp cm8uY3BwCkBAIC0yNTQsNiArMjU0LDE5IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3TGlu ZShjb25zdCBJbnRQb2ludCYgcG9pbnQxLCBjb25zdCBJbnRQb2ludCYgcG9pbnQyKQogICAgICAg ICBjYWlyb19zZXRfZGFzaChjciwgJmRhc2gsIDEsIHBhdHRlcm5PZmZzZXQpOwogICAgIH0KIAor ICAgIEludFNpemUgc2hhZG93U2l6ZTsKKyAgICBpbnQgc2hhZG93Qmx1cjsKKyAgICBDb2xvciBz aGFkb3dDb2xvcjsKKyAgICBpZiAodGV4dERyYXdpbmdNb2RlKCkgPT0gY1RleHRGaWxsICYmIGdl dFNoYWRvdyhzaGFkb3dTaXplLCBzaGFkb3dCbHVyLCBzaGFkb3dDb2xvcikpIHsKKyAgICAgICAg Y2Fpcm9fc2F2ZShjcik7CisgICAgICAgIHNldENvbG9yKGNyLCBzaGFkb3dDb2xvcik7CisgICAg ICAgIGNhaXJvX3RyYW5zbGF0ZShjciwgc2hhZG93U2l6ZS53aWR0aCgpLCBzaGFkb3dTaXplLmhl aWdodCgpKTsKKyAgICAgICAgY2Fpcm9fbW92ZV90byhjciwgcDEueCgpLCBwMS55KCkpOworICAg ICAgICBjYWlyb19saW5lX3RvKGNyLCBwMi54KCksIHAyLnkoKSk7CisgICAgICAgIGNhaXJvX3N0 cm9rZShjcik7CisgICAgICAgIGNhaXJvX3Jlc3RvcmUoY3IpOworICAgIH0KKwogICAgIGNhaXJv X21vdmVfdG8oY3IsIHAxLngoKSwgcDEueSgpKTsKICAgICBjYWlyb19saW5lX3RvKGNyLCBwMi54 KCksIHAyLnkoKSk7CiAKLS0gCjEuNS41Cgo=