196752 2019-04-09 16:58:14 -0700 [ews-build] Add unit tests for PrintConfiguration 2019-04-10 13:58:05 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196780 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu ews-watchlist jbedard lforschler webkit-bug-importer oldest_to_newest 1525813 0 aakash_jain 2019-04-09 16:58:14 -0700 We should add unit tests for PrintConfiguration build step in ews-build. 1525816 1 367085 aakash_jain 2019-04-09 17:02:24 -0700 Created attachment 367085 Patch 1525817 2 ews-watchlist 2019-04-09 17:04:43 -0700 Attachment 367085 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1260: [TestPrintConfiguration.test_success] Undefined variable 'PrintConfiguration' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1294: [TestPrintConfiguration.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1298: [TestPrintConfiguration.test_failure] Undefined variable 'PrintConfiguration' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1330: [TestPrintConfiguration.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1330: [TestPrintConfiguration.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1525831 3 367085 commit-queue 2019-04-09 18:06:47 -0700 Comment on attachment 367085 Patch Clearing flags on attachment: 367085 Committed r244102: <https://trac.webkit.org/changeset/244102> 1525832 4 commit-queue 2019-04-09 18:06:48 -0700 All reviewed patches have been landed. Closing bug. 1525833 5 webkit-bug-importer 2019-04-09 18:08:48 -0700 <rdar://problem/49758837> 367085 2019-04-09 17:02:24 -0700 2019-04-09 18:06:47 -0700 Patch bug-196752-20190409200328.patch text/plain 5465 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDA5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA0LTA5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgdW5pdCB0ZXN0cyBmb3IgUHJpbnRDb25maWd1 cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTY3NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weTogQWRkZWQgdW5p dC10ZXN0cy4KKwogMjAxOS0wNC0wOSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtBdXRvU2l6aW5nXSBBdm9pZCBtYWtpbmcgdGV4dCBwYXJhZ3JhcGhzIHNjcm9s bCBob3Jpem9udGFsbHkgd2hlbiB0aGVyZSBpcyBhIHdpZGUgdGFibGUKSW5kZXg6IFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJl dmlzaW9uIDI0NDA5OSkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw c191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTI0OCw1ICsxMjQ4LDg4IEBAIGNsYXNz IFRlc3RFeHRyYWN0VGVzdFJlc3VsdHMoQnVpbGRTdGVwTWkKICAgICAgICAgcmV0dXJuIHNlbGYu cnVuU3RlcCgpCiAKIAorY2xhc3MgVGVzdFByaW50Q29uZmlndXJhdGlvbihCdWlsZFN0ZXBNaXhp bkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRlZiBzZXRVcChzZWxmKToKKyAg ICAgICAgc2VsZi5sb25nTWVzc2FnZSA9IFRydWUKKyAgICAgICAgcmV0dXJuIHNlbGYuc2V0VXBC dWlsZFN0ZXAoKQorCisgICAgZGVmIHRlYXJEb3duKHNlbGYpOgorICAgICAgICByZXR1cm4gc2Vs Zi50ZWFyRG93bkJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVzdF9zdWNjZXNzKHNlbGYpOgorICAg ICAgICBzZWxmLnNldHVwU3RlcChQcmludENvbmZpZ3VyYXRpb24oKSkKKyAgICAgICAgc2VsZi5z ZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnbWFjT1MtU2llcnJhLVJlbGVhc2UtV0syLVRlc3Rz LUVXUycpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BsYXRmb3JtJywgJ21hYycpCisKKyAg ICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKKyAgICAgICAgICAgIEV4cGVjdFNoZWxs KGNvbW1hbmQ9Wydob3N0bmFtZSddLCB3b3JrZGlyPSd3a2RpcicsIHRpbWVvdXQ9NjAsIGxvZ0Vu dmlyb249RmFsc2UpICsgMAorICAgICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywg c3Rkb3V0PSdld3MxNTAuYXBwbGUuY29tJyksCisgICAgICAgICAgICBFeHBlY3RTaGVsbChjb21t YW5kPVsnZGYnLCAnLWhsJ10sIHdvcmtkaXI9J3drZGlyJywgdGltZW91dD02MCwgbG9nRW52aXJv bj1GYWxzZSkgKyAwCisgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRv dXQ9JycnRmlsZXN5c3RlbSAgICAgU2l6ZSAgIFVzZWQgIEF2YWlsIENhcGFjaXR5IGl1c2VkICBp ZnJlZSAlaXVzZWQgIE1vdW50ZWQgb24KKy9kZXYvZGlzazFzMSAgMTE5R2kgICA5NUdpICAgMjNH aSAgICA4MSUgIDkzNzk1OSA5MjIzMzcyMDM2ODUzODM3ODQ4ICAgIDAlICAgLworL2Rldi9kaXNr MXM0ICAxMTlHaSAgIDIwS2kgICAyM0dpICAgICAxJSAgICAgICAwIDkyMjMzNzIwMzY4NTQ3NzU4 MDcgICAgMCUgICAvcHJpdmF0ZS92YXIvdm0KKy9kZXYvZGlzazBzMyAgMTE5R2kgICAyMkdpICAg OTdHaSAgICAxOSUgIDMzNzU5NSAgICAgICAgICA0Mjk0NjI5Njg0ICAgIDAlICAgL1ZvbHVtZXMv RGF0YScnJyksCisgICAgICAgICAgICBFeHBlY3RTaGVsbChjb21tYW5kPVsnZGF0ZSddLCB3b3Jr ZGlyPSd3a2RpcicsIHRpbWVvdXQ9NjAsIGxvZ0Vudmlyb249RmFsc2UpICsgMAorICAgICAgICAg ICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PSdUdWUgQXByICA5IDE1OjMwOjUy IFBEVCAyMDE5JyksCisgICAgICAgICAgICBFeHBlY3RTaGVsbChjb21tYW5kPVsnc3dfdmVycydd LCB3b3JrZGlyPSd3a2RpcicsIHRpbWVvdXQ9NjAsIGxvZ0Vudmlyb249RmFsc2UpICsgMAorICAg ICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PScnJ1Byb2R1Y3ROYW1l OglNYWMgT1MgWAorUHJvZHVjdFZlcnNpb246CTEwLjEzLjQKK0J1aWxkVmVyc2lvbjoJMTdFMTk5 JycnKSwKKyAgICAgICAgICAgIEV4cGVjdFNoZWxsKGNvbW1hbmQ9Wyd4Y29kZWJ1aWxkJywgJy1z ZGsnLCAnLXZlcnNpb24nXSwgd29ya2Rpcj0nd2tkaXInLCB0aW1lb3V0PTYwLCBsb2dFbnZpcm9u PUZhbHNlKQorICAgICAgICAgICAgKyBFeHBlY3RTaGVsbC5sb2coJ3N0ZGlvJywgc3Rkb3V0PScn J01hY09TWDEwLjEzLnNkayAtIG1hY09TIDEwLjEzIChtYWNvc3gxMC4xMykKK1NES1ZlcnNpb246 IDEwLjEzCitQYXRoOiAvQXBwbGljYXRpb25zL1hjb2RlLmFwcC9Db250ZW50cy9EZXZlbG9wZXIv UGxhdGZvcm1zL01hY09TWC5wbGF0Zm9ybS9EZXZlbG9wZXIvU0RLcy9NYWNPU1gxMC4xMy5zZGsK K1BsYXRmb3JtVmVyc2lvbjogMS4xCitQbGF0Zm9ybVBhdGg6IC9BcHBsaWNhdGlvbnMvWGNvZGUu YXBwL0NvbnRlbnRzL0RldmVsb3Blci9QbGF0Zm9ybXMvTWFjT1NYLnBsYXRmb3JtCitQcm9kdWN0 QnVpbGRWZXJzaW9uOiAxN0UxODkKK1Byb2R1Y3RDb3B5cmlnaHQ6IDE5ODMtMjAxOCBBcHBsZSBJ bmMuCitQcm9kdWN0TmFtZTogTWFjIE9TIFgKK1Byb2R1Y3RVc2VyVmlzaWJsZVZlcnNpb246IDEw LjEzLjQKK1Byb2R1Y3RWZXJzaW9uOiAxMC4xMy40CisKK1hjb2RlIDkuNC4xCitCdWlsZCB2ZXJz aW9uIDlGMjAwMCcnJykKKyAgICAgICAgICAgICsgMCwKKyAgICAgICAgKQorICAgICAgICBzZWxm LmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nT1M6IEhpZ2ggU2ll cnJhICgxMC4xMy40KSwgWGNvZGU6IDEwLjEzJykKKyAgICAgICAgcmV0dXJuIHNlbGYucnVuU3Rl cCgpCisKKyAgICBkZWYgdGVzdF9mYWlsdXJlKHNlbGYpOgorICAgICAgICBzZWxmLnNldHVwU3Rl cChQcmludENvbmZpZ3VyYXRpb24oKSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGxhdGZv cm0nLCAnbWFjJykKKyAgICAgICAgc2VsZi5leHBlY3RSZW1vdGVDb21tYW5kcygKKyAgICAgICAg ICAgIEV4cGVjdFNoZWxsKGNvbW1hbmQ9Wydob3N0bmFtZSddLCB3b3JrZGlyPSd3a2RpcicsIHRp bWVvdXQ9NjAsIGxvZ0Vudmlyb249RmFsc2UpICsgMCwKKyAgICAgICAgICAgIEV4cGVjdFNoZWxs KGNvbW1hbmQ9WydkZicsICctaGwnXSwgd29ya2Rpcj0nd2tkaXInLCB0aW1lb3V0PTYwLCBsb2dF bnZpcm9uPUZhbHNlKSArIDAsCisgICAgICAgICAgICBFeHBlY3RTaGVsbChjb21tYW5kPVsnZGF0 ZSddLCB3b3JrZGlyPSd3a2RpcicsIHRpbWVvdXQ9NjAsIGxvZ0Vudmlyb249RmFsc2UpICsgMCwK KyAgICAgICAgICAgIEV4cGVjdFNoZWxsKGNvbW1hbmQ9Wydzd192ZXJzJ10sIHdvcmtkaXI9J3dr ZGlyJywgdGltZW91dD02MCwgbG9nRW52aXJvbj1GYWxzZSkgKyAxCisgICAgICAgICAgICArIEV4 cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JycnVXBvbiBleGVjdnBlIHN3X3ZlcnMgWydz d192ZXJzJ10gaW4gZW52aXJvbm1lbnQgaWQgNzY5NjU0NTY1MDQwMAorOlRyYWNlYmFjayAobW9z dCByZWNlbnQgY2FsbCBsYXN0KToKKyAgRmlsZSAiL3Vzci9saWIvcHl0aG9uMi43L3NpdGUtcGFj a2FnZXMvdHdpc3RlZC9pbnRlcm5ldC9wcm9jZXNzLnB5IiwgbGluZSA0NDUsIGluIF9mb3JrCisg ICAgZW52aXJvbm1lbnQpCisgIEZpbGUgIi91c3IvbGliL3B5dGhvbjIuNy9zaXRlLXBhY2thZ2Vz L3R3aXN0ZWQvaW50ZXJuZXQvcHJvY2Vzcy5weSIsIGxpbmUgNTIzLCBpbiBfZXhlY0NoaWxkCisg ICAgb3MuZXhlY3ZwZShleGVjdXRhYmxlLCBhcmdzLCBlbnZpcm9ubWVudCkKKyAgRmlsZSAiL3Vz ci9saWIvcHl0aG9uMi43L29zLnB5IiwgbGluZSAzNTUsIGluIGV4ZWN2cGUKKyAgICBfZXhlY3Zw ZShmaWxlLCBhcmdzLCBlbnYpCisgIEZpbGUgIi91c3IvbGliL3B5dGhvbjIuNy9vcy5weSIsIGxp bmUgMzgyLCBpbiBfZXhlY3ZwZQorICAgIGZ1bmMoZnVsbG5hbWUsICphcmdyZXN0KQorT1NFcnJv cjogW0Vycm5vIDJdIE5vIHN1Y2ggZmlsZSBvciBkaXJlY3RvcnknJycpLAorICAgICAgICAgICAg RXhwZWN0U2hlbGwoY29tbWFuZD1bJ3hjb2RlYnVpbGQnLCAnLXNkaycsICctdmVyc2lvbiddLCB3 b3JrZGlyPSd3a2RpcicsIHRpbWVvdXQ9NjAsIGxvZ0Vudmlyb249RmFsc2UpCisgICAgICAgICAg ICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JycnVXBvbiBleGVjdnBlIHhjb2Rl YnVpbGQgWyd4Y29kZWJ1aWxkJywgJy1zZGsnLCAnLXZlcnNpb24nXSBpbiBlbnZpcm9ubWVudCBp ZCA3Njk2NTQ1NjEyNDE2Cis6VHJhY2ViYWNrIChtb3N0IHJlY2VudCBjYWxsIGxhc3QpOgorICBG aWxlICIvdXNyL2xpYi9weXRob24yLjcvc2l0ZS1wYWNrYWdlcy90d2lzdGVkL2ludGVybmV0L3By b2Nlc3MucHkiLCBsaW5lIDQ0NSwgaW4gX2ZvcmsKKyAgICBlbnZpcm9ubWVudCkKKyAgRmlsZSAi L3Vzci9saWIvcHl0aG9uMi43L3NpdGUtcGFja2FnZXMvdHdpc3RlZC9pbnRlcm5ldC9wcm9jZXNz LnB5IiwgbGluZSA1MjMsIGluIF9leGVjQ2hpbGQKKyAgICBvcy5leGVjdnBlKGV4ZWN1dGFibGUs IGFyZ3MsIGVudmlyb25tZW50KQorICBGaWxlICIvdXNyL2xpYi9weXRob24yLjcvb3MucHkiLCBs aW5lIDM1NSwgaW4gZXhlY3ZwZQorICAgIF9leGVjdnBlKGZpbGUsIGFyZ3MsIGVudikKKyAgRmls ZSAiL3Vzci9saWIvcHl0aG9uMi43L29zLnB5IiwgbGluZSAzODIsIGluIF9leGVjdnBlCisgICAg ZnVuYyhmdWxsbmFtZSwgKmFyZ3Jlc3QpCitPU0Vycm9yOiBbRXJybm8gMl0gTm8gc3VjaCBmaWxl IG9yIGRpcmVjdG9yeScnJykKKyAgICAgICAgICAgICsgMSwKKyAgICAgICAgKQorICAgICAgICBz ZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nRmFpbGVkIHRv IHByaW50IGNvbmZpZ3VyYXRpb24nKQorICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKwor CiBpZiBfX25hbWVfXyA9PSAnX19tYWluX18nOgogICAgIHVuaXR0ZXN0Lm1haW4oKQo=