196748 2019-04-09 16:01:50 -0700 Add Resource Load Statistics test case for Ping 2019-04-16 11:57:39 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196974 InRadar P2 Normal --- 1 wilander wilander achristensen commit-queue lforschler sroberts webkit-bug-importer youennf oldest_to_newest 1525785 0 wilander 2019-04-09 16:01:50 -0700 We should add a Resource Load Statistics test case for Ping loads. 1525789 1 webkit-bug-importer 2019-04-09 16:08:34 -0700 <rdar://problem/49754777> 1525790 2 367077 wilander 2019-04-09 16:10:35 -0700 Created attachment 367077 Patch 1525826 3 wilander 2019-04-09 17:41:27 -0700 Thanks, Alex! 1525828 4 367077 commit-queue 2019-04-09 18:03:33 -0700 Comment on attachment 367077 Patch Clearing flags on attachment: 367077 Committed r244101: <https://trac.webkit.org/changeset/244101> 1525829 5 commit-queue 2019-04-09 18:03:35 -0700 All reviewed patches have been landed. Closing bug. 1527795 6 sroberts 2019-04-16 11:33:10 -0700 It appears test http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html added in https://trac.webkit.org/changeset/244101 is a flaky time out. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fping-to-prevalent-resource.html 1527806 7 achristensen 2019-04-16 11:57:39 -0700 Fixing in https://bugs.webkit.org/show_bug.cgi?id=196974 367077 2019-04-09 16:10:35 -0700 2019-04-09 18:03:33 -0700 Patch bug-196748-20190409161034.patch text/plain 6305 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDk0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOThlZjYzNjFjM2Q0YjBhOWRkZGM1 ZTAxYzEwYTgwYTQwN2M2NTI0ZC4uZGU4OThiMTYxNzUyZGMzNjc0OTRjYTM3MGJhOTYwNzg0NzIx ZGFhYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA0LTA5ICBKb2huIFdpbGFuZGVyICA8 d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBSZXNvdXJjZSBMb2FkIFN0YXRpc3Rp Y3MgdGVzdCBjYXNlIGZvciBQaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTY3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9waW5nLXRv LXByZXZhbGVudC1yZXNvdXJjZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAv dGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9waW5nLXRvLXByZXZhbGVudC1yZXNvdXJjZS5o dG1sOiBBZGRlZC4KKwogMjAxOS0wNC0wOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgUmVmcmVzaCBXUFQgc2VydmljZSB3b3JrZXIgZXhwZWN0YXRpb25zCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3Jlc291cmNlTG9hZFN0YXRpc3RpY3Mv cGluZy10by1wcmV2YWxlbnQtcmVzb3VyY2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL3BpbmctdG8tcHJldmFsZW50LXJlc291cmNl LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NDliZmI5MGNjMWFjNWY5MzE1ZGRmMDljZDRiOTMx Yzk4Yjc0N2VmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNv dXJjZUxvYWRTdGF0aXN0aWNzL3BpbmctdG8tcHJldmFsZW50LXJlc291cmNlLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxLDI0IEBACitUZXN0cyB0aGF0IGNvb2tpZSBibG9ja2luZyBpcyBhcHBsaWVk IHRvIHBpbmcgbG9hZHMuCisgICAKKworLS0tLS0tLS0KK0ZyYW1lOiAnPCEtLWZyYW1lMS0tPicK Ky0tLS0tLS0tCitTaG91bGQgcmVjZWl2ZSBmaXJzdC1wYXJ0eSBjb29raWUuCitSZWNlaXZlZCBj b29raWUgbmFtZWQgJ2ZpcnN0UGFydHlDb29raWUnLgorQ2xpZW50LXNpZGUgZG9jdW1lbnQuY29v a2llOiBmaXJzdFBhcnR5Q29va2llPXZhbHVlCisKKy0tLS0tLS0tCitGcmFtZTogJzwhLS1mcmFt ZTItLT4nCistLS0tLS0tLQorU2hvdWxkIHJlY2VpdmUgbm8gY29va2llcy4KK0RpZCBub3QgcmVj ZWl2ZSBjb29raWUgbmFtZWQgJ2ZpcnN0UGFydHlDb29raWUnLgorQ2xpZW50LXNpZGUgZG9jdW1l bnQuY29va2llOgorCistLS0tLS0tLQorRnJhbWU6ICc8IS0tZnJhbWUzLS0+JworLS0tLS0tLS0K K1BpbmcgcmVjZWl2ZWQuCitIVFRQX0hPU1Q6IGxvY2FsaG9zdDo4MDAwCitSRVFVRVNUX1VSSTog L2NvbnRlbnRleHRlbnNpb25zL3Jlc291cmNlcy9zYXZlLXBpbmcucGhwP3Rlc3Q9cGluZy10by1w cmV2YWxlbnQtcmVzb3VyY2UKK05vIGNvb2tpZXMgaW4gcGluZy4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9waW5nLXRvLXByZXZhbGVu dC1yZXNvdXJjZS5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0 aXN0aWNzL3BpbmctdG8tcHJldmFsZW50LXJlc291cmNlLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uM2Y1ZmRh Y2Y1NTZlZDNiYTA1NDFhYzEzZTUwNjFjNTRhN2UwOThhZAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9waW5nLXRvLXByZXZh bGVudC1yZXNvdXJjZS5odG1sCkBAIC0wLDAgKzEsOTcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0 bWwgbGFuZz0iZW4iPgorPGhlYWQ+CisgICAgPG1ldGEgY2hhcnNldD0iVVRGLTgiPgorICAgIDxz Y3JpcHQgc3JjPSIvanMtdGVzdC1yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KKyAg ICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3V0aWwuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+Cis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+VGVzdHMgdGhhdCBjb29raWUgYmxvY2tpbmcgaXMg YXBwbGllZCB0byBwaW5nIGxvYWRzLjwvZGl2PgorPGEgaWQ9InRhcmdldExpbmsiIGhyZWY9IiMi IHBpbmc9Imh0dHA6Ly9sb2NhbGhvc3Q6ODAwMC9jb250ZW50ZXh0ZW5zaW9ucy9yZXNvdXJjZXMv c2F2ZS1waW5nLnBocD90ZXN0PXBpbmctdG8tcHJldmFsZW50LXJlc291cmNlIj5UaGUgbGluazwv YT4KKzxzY3JpcHQ+CisgICAgaWYgKHRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIud2Fp dFVudGlsRG9uZSgpOworCisgICAgY29uc3QgcGFydGl0aW9uSG9zdCA9ICIxMjcuMC4wLjE6ODAw MCI7CisgICAgY29uc3QgdGhpcmRQYXJ0eU9yaWdpbiA9ICJodHRwOi8vbG9jYWxob3N0OjgwMDAi OworICAgIGNvbnN0IHJlc291cmNlUGF0aCA9ICIvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9yZXNv dXJjZXMiOworICAgIGNvbnN0IHRoaXJkUGFydHlCYXNlVXJsID0gdGhpcmRQYXJ0eU9yaWdpbiAr IHJlc291cmNlUGF0aDsKKyAgICBjb25zdCBmaXJzdFBhcnR5Q29va2llTmFtZSA9ICJmaXJzdFBh cnR5Q29va2llIjsKKyAgICBjb25zdCBzdWJQYXRoVG9TZXRGaXJzdFBhcnR5Q29va2llID0gIi9z ZXQtY29va2llLnBocD9uYW1lPSIgKyBmaXJzdFBhcnR5Q29va2llTmFtZSArICImdmFsdWU9dmFs dWUiOworICAgIGNvbnN0IHJldHVyblVybCA9ICJodHRwOi8vIiArIHBhcnRpdGlvbkhvc3QgKyAi L3Jlc291cmNlTG9hZFN0YXRpc3RpY3MvcGluZy10by1wcmV2YWxlbnQtcmVzb3VyY2UuaHRtbCI7 CisgICAgY29uc3Qgc3ViUGF0aFRvR2V0Q29va2llcyA9ICIvZ2V0LWNvb2tpZXMucGhwP25hbWUx PSIgKyBmaXJzdFBhcnR5Q29va2llTmFtZTsKKworICAgIGZ1bmN0aW9uIGFjdGl2YXRlRWxlbWVu dChlbGVtZW50SUQsIGNhbGxiYWNrKSB7CisgICAgICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoZWxlbWVudElEKTsKKyAgICAgICAgdmFyIGNlbnRlclggPSBlbGVtZW50 Lm9mZnNldExlZnQgKyBlbGVtZW50Lm9mZnNldFdpZHRoIC8gMjsKKyAgICAgICAgdmFyIGNlbnRl clkgPSBlbGVtZW50Lm9mZnNldFRvcCArIGVsZW1lbnQub2Zmc2V0SGVpZ2h0IC8gMjsKKyAgICAg ICAgVUlIZWxwZXIuYWN0aXZhdGVBdChjZW50ZXJYLCBjZW50ZXJZKS50aGVuKAorICAgICAgICAg ICAgZnVuY3Rpb24gKCkgeworICAgICAgICAgICAgICAgIGNhbGxiYWNrKCk7CisgICAgICAgICAg ICB9LAorICAgICAgICAgICAgZnVuY3Rpb24gKCkgeworICAgICAgICAgICAgICAgIHRlc3RSdW5u ZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgfQorICAgICAgICApOworICAgIH0KKworICAg IGZ1bmN0aW9uIG9wZW5JZnJhbWUodXJsLCBvbkxvYWRIYW5kbGVyKSB7CisgICAgICAgIGNvbnN0 IGVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJpZnJhbWUiKTsKKyAgICAgICAgZWxl bWVudC5zcmMgPSB1cmw7CisgICAgICAgIGlmIChvbkxvYWRIYW5kbGVyKSB7CisgICAgICAgICAg ICBlbGVtZW50Lm9ubG9hZCA9IG9uTG9hZEhhbmRsZXI7CisgICAgICAgIH0KKyAgICAgICAgZG9j dW1lbnQuYm9keS5hcHBlbmRDaGlsZChlbGVtZW50KTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBy dW5UZXN0KCkgeworICAgICAgICBzd2l0Y2ggKGRvY3VtZW50LmxvY2F0aW9uLmhhc2gpIHsKKyAg ICAgICAgICAgIGNhc2UgIiNzdGVwMSI6CisgICAgICAgICAgICAgICAgLy8gU2V0IGZpcnN0LXBh cnR5IGNvb2tpZSBmb3IgbG9jYWxob3N0LgorICAgICAgICAgICAgICAgIGRvY3VtZW50LmxvY2F0 aW9uLmhyZWYgPSB0aGlyZFBhcnR5QmFzZVVybCArIHN1YlBhdGhUb1NldEZpcnN0UGFydHlDb29r aWUgKyAiIyIgKyByZXR1cm5VcmwgKyAiI3N0ZXAyIjsKKyAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIGNhc2UgIiNzdGVwMiI6CisgICAgICAgICAgICAgICAgLy8gQ2hlY2sgdGhh dCB0aGUgY29va2llIGdldHMgc2VudCBmb3IgbG9jYWxob3N0IHVuZGVyIDEyNy4wLjAuMSBzaW5j ZSBsb2NhbGhvc3QgaXMgbm90IHByZXZhbGVudC4KKyAgICAgICAgICAgICAgICBkb2N1bWVudC5s b2NhdGlvbi5oYXNoID0gInN0ZXAzIjsKKyAgICAgICAgICAgICAgICBvcGVuSWZyYW1lKHRoaXJk UGFydHlCYXNlVXJsICsgc3ViUGF0aFRvR2V0Q29va2llcyArICImbWVzc2FnZT1TaG91bGQgcmVj ZWl2ZSBmaXJzdC1wYXJ0eSBjb29raWUuIiwgcnVuVGVzdCk7CisgICAgICAgICAgICAgICAgYnJl YWs7CisgICAgICAgICAgICBjYXNlICIjc3RlcDMiOgorICAgICAgICAgICAgICAgIC8vIFNldCBs b2NhbGhvc3QgYXMgcHJldmFsZW50IHRvIHB1dCBpdCBpbiB0aGUgYmxvY2tpbmcgY2F0ZWdvcnku CisgICAgICAgICAgICAgICAgZG9jdW1lbnQubG9jYXRpb24uaGFzaCA9ICJzdGVwNCI7CisgICAg ICAgICAgICAgICAgdGVzdFJ1bm5lci5zZXRTdGF0aXN0aWNzUHJldmFsZW50UmVzb3VyY2UodGhp cmRQYXJ0eU9yaWdpbiwgdHJ1ZSwgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICAgICAgICAgIHRl c3RSdW5uZXIuc3RhdGlzdGljc1VwZGF0ZUNvb2tpZUJsb2NraW5nKHJ1blRlc3QpOworICAgICAg ICAgICAgICAgIH0pOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSAi I3N0ZXA0IjoKKyAgICAgICAgICAgICAgICAvLyBDaGVjayB0aGF0IG5vIGNvb2tpZSBnZXRzIHNl bnQgZm9yIGxvY2FsaG9zdCB1bmRlciAxMjcuMC4wLjEgc2luY2UgbG9jYWxob3N0J3MgY29va2ll cyBhcmUgYmxvY2tlZC4KKyAgICAgICAgICAgICAgICBkb2N1bWVudC5sb2NhdGlvbi5oYXNoID0g InN0ZXA1IjsKKyAgICAgICAgICAgICAgICBvcGVuSWZyYW1lKHRoaXJkUGFydHlCYXNlVXJsICsg c3ViUGF0aFRvR2V0Q29va2llcyArICAiJm1lc3NhZ2U9U2hvdWxkIHJlY2VpdmUgbm8gY29va2ll cy4iLCBydW5UZXN0KTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2Ug IiNzdGVwNSI6CisgICAgICAgICAgICAgICAgLy8gQ2xpY2sgdGhlIGxpbmsgdG8gdHJpZ2dlciB0 aGUgcGluZy4KKyAgICAgICAgICAgICAgICBhY3RpdmF0ZUVsZW1lbnQoInRhcmdldExpbmsiLCBm dW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgb3BlbklmcmFtZSh0aGlyZFBhcnR5T3Jp Z2luICsgIi9jb250ZW50ZXh0ZW5zaW9ucy9yZXNvdXJjZXMvZ2V0LXBpbmctZGF0YS5waHA/dGVz dD1waW5nLXRvLXByZXZhbGVudC1yZXNvdXJjZSIsIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAg ICAgICAgICAgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGFyZ2V0TGluayIpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHNldEVuYWJsZUZl YXR1cmUoZmFsc2UsIGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRl c3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgICAgICAgICAgICAgfSk7CisgICAg ICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgICAgIH0pOworICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICB9CisgICAgfQorCisgICAgaWYgKGRvY3VtZW50LmxvY2F0aW9uLmhh c2ggPT09ICIiKSB7CisgICAgICAgIGlmICh0ZXN0UnVubmVyKSB7CisgICAgICAgICAgICBzZXRF bmFibGVGZWF0dXJlKHRydWUsIGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICB0ZXN0UnVu bmVyLmR1bXBDaGlsZEZyYW1lc0FzVGV4dCgpOworICAgICAgICAgICAgICAgIGRvY3VtZW50Lmxv Y2F0aW9uLmhhc2ggPSAic3RlcDEiOworICAgICAgICAgICAgICAgIHJ1blRlc3QoKTsKKyAgICAg ICAgICAgIH0pOworICAgICAgICB9CisgICAgfSBlbHNlIHsKKyAgICAgICAgcnVuVGVzdCgpOwor ICAgIH0KKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=