196741 2019-04-09 12:24:00 -0700 [CMake] WEBKIT_COMPUTE_SOURCES should use the target's derived sources directory 2019-04-09 18:28:40 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 196704 1 don.olmstead don.olmstead achristensen annulen commit-queue mcatanzaro oldest_to_newest 1525709 0 don.olmstead 2019-04-09 12:24:00 -0700 WEBKIT_COMPUTE_SOURCES is using ${DERIVED_SOURCES_DIR} directly. Instead it should rely on the directory specified by the target. 1525722 1 367065 don.olmstead 2019-04-09 12:51:29 -0700 Created attachment 367065 Patch 1525845 2 367065 commit-queue 2019-04-09 18:28:38 -0700 Comment on attachment 367065 Patch Clearing flags on attachment: 367065 Committed r244103: <https://trac.webkit.org/changeset/244103> 1525846 3 commit-queue 2019-04-09 18:28:40 -0700 All reviewed patches have been landed. Closing bug. 367065 2019-04-09 12:51:29 -0700 2019-04-09 18:28:38 -0700 Patch bug-196741.diff text/plain 4637 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlYTRhOTE5MTFhZi4uNjdk NTkwMjMzY2QgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMSBAQAorMjAxOS0wNC0wOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtDTWFrZV0gV0VCS0lUX0NPTVBVVEVfU09VUkNFUyBzaG91bGQgdXNlIHRo ZSB0YXJnZXQncyBkZXJpdmVkIHNvdXJjZXMgZGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY3NDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXRUJLSVRfQ09NUFVURV9TT1VSQ0VTIGlzIHVz aW5nICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0gZGlyZWN0bHkuIEluc3RlYWQgaXQgc2hvdWxkCisg ICAgICAgIHJlbHkgb24gdGhlIGRpcmVjdG9yeSBzcGVjaWZpZWQgYnkgdGhlIHRhcmdldC4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRGUy5jbWFrZToKKyAgICAgICAgQWRkIHZhcmlh YmxlcyB0aGF0IGNhbiBiZSBleHBhbmRlZCB3aXRoaW4gQ01ha2UgdG8gdGhlIGRlcml2ZWQgc291 cmNlcyBkaXJlY3RvcnkgZm9yCisgICAgICAgIGEgdGFyZ2V0LgorCisgICAgICAgICogU291cmNl L2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZToKKyAgICAgICAgVXNlIHZhcmlhYmxlIGV4cGFuc2lv biByYXRoZXIgdGhhbiAke0RFUklWRURfU09VUkNFU19ESVJ9IHRvIGRldGVybWluZSB0aGUgdGFy Z2V0J3MKKyAgICAgICAgZGVyaXZlZCBzb3VyY2VzIGRpcmVjdG9yeS4KKwogMjAxOS0wNC0wOSAg RG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtDTWFrZV0g V1RGIGRlcml2ZWQgc291cmNlcyBzaG91bGQgb25seSBiZSByZWZlcmVuY2VkIGluc2lkZSBXVEYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGUy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9X ZWJLaXRGUy5jbWFrZQppbmRleCBlYjA2NTQwYzIwYS4uYjhkOTQ4ZGM1ZTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9jbWFrZS9XZWJLaXRGUy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RlMu Y21ha2UKQEAgLTM4LDcgKzM4LDE1IEBAIHNldChERVJJVkVEX1NPVVJDRVNfV0VCS0lUTEVHQUNZ X0RJUiAiJHtDTUFLRV9CSU5BUllfRElSfS9EZXJpdmVkU291cmNlcy9XZWJLaXRMCiBzZXQoREVS SVZFRF9TT1VSQ0VTX1dFQktJVF9ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vRGVyaXZlZFNvdXJj ZXMvV2ViS2l0IikKIHNldChERVJJVkVEX1NPVVJDRVNfV0VCSU5TUEVDVE9SVUlfRElSICIke0NN QUtFX0JJTkFSWV9ESVJ9L0Rlcml2ZWRTb3VyY2VzL1dlYkluc3BlY3RvclVJIikKIAorIyBUaGVz ZSB2YWx1ZXMgd2lsbCByZXBsYWNlIHRoZSBhYm92ZSBhZnRlciByZWZhY3RvcmluZyBpcyBjb21w bGV0ZQogc2V0KFdURl9ERVJJVkVEX1NPVVJDRVNfRElSICIke0NNQUtFX0JJTkFSWV9ESVJ9L0Rl cml2ZWRTb3VyY2VzL1dURiIpCitzZXQoSmF2YVNjcmlwdENvcmVfREVSSVZFRF9TT1VSQ0VTX0RJ UiAiJHtDTUFLRV9CSU5BUllfRElSfS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZSIpCitz ZXQoUEFMX0RFUklWRURfU09VUkNFU19ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vRGVyaXZlZFNv dXJjZXMvUEFMIikKK3NldChXZWJDb3JlX0RFUklWRURfU09VUkNFU19ESVIgIiR7Q01BS0VfQklO QVJZX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViQ29yZSIpCitzZXQoV2ViRHJpdmVyX0RFUklWRURf U09VUkNFU19ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViRHJpdmVy IikKK3NldChXZWJLaXRMZWdhY3lfREVSSVZFRF9TT1VSQ0VTX0RJUiAiJHtDTUFLRV9CSU5BUllf RElSfS9EZXJpdmVkU291cmNlcy9XZWJLaXRMZWdhY3kiKQorc2V0KFdlYktpdF9ERVJJVkVEX1NP VVJDRVNfRElSICIke0NNQUtFX0JJTkFSWV9ESVJ9L0Rlcml2ZWRTb3VyY2VzL1dlYktpdCIpCitz ZXQoV2ViSW5zcGVjdG9yVUlfREVSSVZFRF9TT1VSQ0VTX0RJUiAiJHtDTUFLRV9CSU5BUllfRElS fS9EZXJpdmVkU291cmNlcy9XZWJJbnNwZWN0b3JVSSIpCiAKIHNldChGT1JXQVJESU5HX0hFQURF UlNfRElSICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vRm9yd2FyZGluZ0hlYWRlcnMpCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlCmluZGV4IDNjYjY5NmYyYzgwLi5mYWM5ZDQyN2IwMSAxMDA2NDQKLS0t IGEvU291cmNlL2NtYWtlL1dlYktpdE1hY3Jvcy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2Vi S2l0TWFjcm9zLmNtYWtlCkBAIC0zLDggKzMsMTAgQEAKICMgV2ViQ29yZSksIHRoZW4gcHV0IGl0 IHRoZXJlIGluc3RlYWQuCiAKIG1hY3JvKFdFQktJVF9DT01QVVRFX1NPVVJDRVMgX2ZyYW1ld29y aykKKyAgICBzZXQoX2Rlcml2ZWRTb3VyY2VzUGF0aCAkeyR7X2ZyYW1ld29ya31fREVSSVZFRF9T T1VSQ0VTX0RJUn0pCisKICAgICBmb3JlYWNoIChfc291cmNlc0xpc3RGaWxlIElOIExJU1RTICR7 X2ZyYW1ld29ya31fVU5JRklFRF9TT1VSQ0VfTElTVF9GSUxFUykKLSAgICAgIGNvbmZpZ3VyZV9m aWxlKCIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vJHtfc291cmNlc0xpc3RGaWxlfSIgIiR7 REVSSVZFRF9TT1VSQ0VTX0RJUn0vJHtfZnJhbWV3b3JrfS8ke19zb3VyY2VzTGlzdEZpbGV9IiBD T1BZT05MWSkKKyAgICAgIGNvbmZpZ3VyZV9maWxlKCIke0NNQUtFX0NVUlJFTlRfU09VUkNFX0RJ Un0vJHtfc291cmNlc0xpc3RGaWxlfSIgIiR7X2Rlcml2ZWRTb3VyY2VzUGF0aH0vJHtfc291cmNl c0xpc3RGaWxlfSIgQ09QWU9OTFkpCiAgICAgICBtZXNzYWdlKFNUQVRVUyAiVXNpbmcgc291cmNl IGxpc3QgZmlsZTogJHtfc291cmNlc0xpc3RGaWxlfSIpCiAKICAgICAgIGxpc3QoQVBQRU5EIF9z b3VyY2VMaXN0RmlsZVRydWVQYXRocyAiJHtDTUFLRV9DVVJSRU5UX1NPVVJDRV9ESVJ9LyR7X3Nv dXJjZXNMaXN0RmlsZX0iKQpAQCAtMTgsNyArMjAsNyBAQCBtYWNybyhXRUJLSVRfQ09NUFVURV9T T1VSQ0VTIF9mcmFtZXdvcmspCiAKICAgICBpZiAoRU5BQkxFX1VOSUZJRURfQlVJTERTKQogICAg ICAgICBleGVjdXRlX3Byb2Nlc3MoQ09NTUFORCAke1JVQllfRVhFQ1VUQUJMRX0gJHtXVEZfU0NS SVBUU19ESVJ9L2dlbmVyYXRlLXVuaWZpZWQtc291cmNlLWJ1bmRsZXMucmIKLSAgICAgICAgICAg ICItLWRlcml2ZWQtc291cmNlcy1wYXRoIiAiJHtERVJJVkVEX1NPVVJDRVNfRElSfS8ke19mcmFt ZXdvcmt9IgorICAgICAgICAgICAgIi0tZGVyaXZlZC1zb3VyY2VzLXBhdGgiICIke19kZXJpdmVk U291cmNlc1BhdGh9IgogICAgICAgICAgICAgIi0tc291cmNlLXRyZWUtcGF0aCIgJHtDTUFLRV9D VVJSRU5UX1NPVVJDRV9ESVJ9CiAgICAgICAgICAgICAiLS1wcmludC1idW5kbGVkLXNvdXJjZXMi CiAgICAgICAgICAgICAiLS1mZWF0dXJlLWZsYWdzIiAiJHtVTklGSUVEX1NPVVJDRV9MSVNUX0VO QUJMRURfRkVBVFVSRVN9IgpAQCAtMzcsNyArMzksNyBAQCBtYWNybyhXRUJLSVRfQ09NUFVURV9T T1VSQ0VTIF9mcmFtZXdvcmspCiAgICAgICAgIHVuc2V0KF9zb3VyY2VGaWxlVG1wKQogCiAgICAg ICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7UlVCWV9FWEVDVVRBQkxFfSAke1dURl9TQ1JJ UFRTX0RJUn0vZ2VuZXJhdGUtdW5pZmllZC1zb3VyY2UtYnVuZGxlcy5yYgotICAgICAgICAgICAg Ii0tZGVyaXZlZC1zb3VyY2VzLXBhdGgiICIke0RFUklWRURfU09VUkNFU19ESVJ9LyR7X2ZyYW1l d29ya30iCisgICAgICAgICAgICAiLS1kZXJpdmVkLXNvdXJjZXMtcGF0aCIgIiR7X2Rlcml2ZWRT b3VyY2VzUGF0aH0iCiAgICAgICAgICAgICAiLS1zb3VyY2UtdHJlZS1wYXRoIiAke0NNQUtFX0NV UlJFTlRfU09VUkNFX0RJUn0KICAgICAgICAgICAgICItLWZlYXR1cmUtZmxhZ3MiICIke1VOSUZJ RURfU09VUkNFX0xJU1RfRU5BQkxFRF9GRUFUVVJFU30iCiAgICAgICAgICAgICAke19zb3VyY2VM aXN0RmlsZVRydWVQYXRoc30KQEAgLTUzLDcgKzU1LDcgQEAgbWFjcm8oV0VCS0lUX0NPTVBVVEVf U09VUkNFUyBfZnJhbWV3b3JrKQogICAgICAgICB1bnNldChfb3V0cHV0VG1wKQogICAgIGVsc2Ug KCkKICAgICAgICAgZXhlY3V0ZV9wcm9jZXNzKENPTU1BTkQgJHtSVUJZX0VYRUNVVEFCTEV9ICR7 V1RGX1NDUklQVFNfRElSfS9nZW5lcmF0ZS11bmlmaWVkLXNvdXJjZS1idW5kbGVzLnJiCi0gICAg ICAgICAgICAiLS1kZXJpdmVkLXNvdXJjZXMtcGF0aCIgIiR7REVSSVZFRF9TT1VSQ0VTX0RJUn0v JHtfZnJhbWV3b3JrfSIKKyAgICAgICAgICAgICItLWRlcml2ZWQtc291cmNlcy1wYXRoIiAiJHtf ZGVyaXZlZFNvdXJjZXNQYXRofSIKICAgICAgICAgICAgICItLXNvdXJjZS10cmVlLXBhdGgiICR7 Q01BS0VfQ1VSUkVOVF9TT1VSQ0VfRElSfQogICAgICAgICAgICAgIi0tcHJpbnQtYWxsLXNvdXJj ZXMiCiAgICAgICAgICAgICAiLS1mZWF0dXJlLWZsYWdzIiAiJHtVTklGSUVEX1NPVVJDRV9MSVNU X0VOQUJMRURfRkVBVFVSRVN9Igo=