19674 2008-06-19 08:23:03 -0700 Default font size should be the same as Safari, I.E. and Firefox: 16 (v.s. the current 14) 2009-10-05 04:43:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other All RESOLVED FIXED Qt P2 Normal --- 1 ben vestbo abecsi hausmann rhodovan.u-szeged tonikitoo oldest_to_newest 83873 0 ben 2008-06-19 08:23:03 -0700 Safari, Mac IE, Camino, and Mozilla, etc all have a default size of 16 rather then 14. Some more info from when Safari 1.0 changed its default to 16 http://weblogs.mozillazine.org/hyatt/archives/2003_04.html#002993 145170 1 vestbo 2009-09-07 09:08:22 -0700 Simon, any idea why 14 was chosen? Unless we break something really bad I think we should go for 16 too. 145229 2 tonikitoo 2009-09-07 13:08:34 -0700 tor, just a side note: many layout tests are have currently got their results updated to expect fontsize default to 13 ... (yes in DRT/QT default it 13 :( )... so we have a double non-conformation here. // To get DRT compliant to see it in DumpRenderTree.cpp (...) WebPage::WebPage() (...) //some layout tests lets set the default fontsize to 13. settings()->setFontSize(QWebSettings::DefaultFontSize, 13); (...) 145230 3 tonikitoo 2009-09-07 13:12:03 -0700 ok , english version now: "... many layout tests had their expected-results recently updated to expect fontsize default to 13 ..." sorry about the bugmail spam (In reply to comment #2) > tor, just a side note: many layout tests are have currently got their results > updated to expect fontsize default to 13 ... (yes in DRT/QT default it 13 :( > )... so we have a double non-conformation here. // To get DRT compliant to > > see it in DumpRenderTree.cpp > > (...) > WebPage::WebPage() > (...) > //some layout tests lets set the default fontsize to 13. > settings()->setFontSize(QWebSettings::DefaultFontSize, 13); > (...) 147068 4 abecsi 2009-09-14 09:22:18 -0700 Hi! I have changed the font sizes in DRT.cpp and qwebsettings.cpp to 16px and ran run-webkit-tests --ignore-mertics. 7 tests failed which previously didn't. Seems that the others have only font metrics problems. Reni and I are going to fully investigate this issue, and send patches to set the default size to 16px and update the metrics in files which need it. The following tests failed, with render-tree differences: editing/pasteboard/5761530-1.html: DRT places a tab in place of an expected space editing/pasteboard/5780697-2.html: printed size variables differ maybe there is a quirksmode issue too fast/css/getComputedStyle/computed-style-without-renderer.html: border-top-width: 18px should be 1em=16px I met this issue once in another test where there was a approx 2px white border on the top but there shouldn't be. Maybe this expected expected a wrong value previously? fast/css/getComputedStyle/computed-style -webkit-perspective-origin: Xpx Ypx twice there is one pixel Y difference fast/history/history_reload.html: DRT fails the test, but QtLaucher does it right fast/html/text-field-input-types.html: DRT removes a space: -A B C D E F +A B C DE F svg/batik/filters/feTile.svg: left border flows approx 3px over the edge, only one half of the first numbers can be seen svg/custom/getscreenctm-in-mixed-content2.xhtml This tests the behaviour of SVGLocatable::getScreenCTM() in mixed content: Expected matrix [1, 0, 0, 1, 350, 56] Got matrix [1, 0, 0, 1, 405, 55] 147804 5 39694 abecsi 2009-09-17 08:24:38 -0700 Created attachment 39694 Fix default font sizes in DRT.cpp and qwebsettings.cpp The patch reconciliates the default font sizes in DRT.cpp and qwebsettings.cpp for regular/fixed fonts from 13px/13px in DRT vs. 14px/14px in qwebsettings to 16px/13px which is the default on other platforms. This breaks the metrics on ~450 tests, and introduces 8 new failing tests (with --ignore-metrics) which seem to be related to previously hidden bugs: editing/pasteboard/5761530-1.html editing/pasteboard/5780697-2.html fast/css/getComputedStyle/computed-style-without-renderer.html fast/css/getComputedStyle/computed-style fast/history/history_reload.html fast/html/text-field-input-types.html svg/batik/filters/feTile.svg svg/custom/getscreenctm-in-mixed-content2.xhtml These get into the Skipped list for later investigation. I'll push all the changes to my qtwebkit clone on gitorious. 147807 6 vestbo 2009-09-17 08:36:32 -0700 Perfect, I'll land it once it's on gitorious 150890 7 abecsi 2009-09-29 06:30:42 -0700 (In reply to comment #6) > Perfect, I'll land it once it's on gitorious I've pushed my changes to my gitorious clone: http://www.gitorious.org/~bbandix/qtwebkit/bbandix-clone Unforunately the patch has 43718 LOC, which is huge. 150986 8 abecsi 2009-09-29 12:00:41 -0700 Landed in r48873. 39694 2009-09-17 08:24:38 -0700 2009-09-17 08:24:38 -0700 Fix default font sizes in DRT.cpp and qwebsettings.cpp fontsize.patch text/plain 1793 abecsi ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcCBiL1dlYktpdC9xdC9B cGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCA1Zjc0ZjM2Li5lZWRmN2QxIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2Vic2V0 dGluZ3MuY3BwCkBAIC0zNTYsOCArMzU2LDggQEAgUVdlYlNldHRpbmdzOjpRV2ViU2V0dGluZ3Mo KQogICAgIC8vIEluaXRpYWxpemUgb3VyIGdsb2JhbCBkZWZhdWx0cwogICAgIGQtPmZvbnRTaXpl cy5pbnNlcnQoUVdlYlNldHRpbmdzOjpNaW5pbXVtRm9udFNpemUsIDApOwogICAgIGQtPmZvbnRT aXplcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpNaW5pbXVtTG9naWNhbEZvbnRTaXplLCAwKTsKLSBk LT5mb250U2l6ZXMuaW5zZXJ0KFFXZWJTZXR0aW5nczo6RGVmYXVsdEZvbnRTaXplLCAxNCk7Ci0g ZC0+Zm9udFNpemVzLmluc2VydChRV2ViU2V0dGluZ3M6OkRlZmF1bHRGaXhlZEZvbnRTaXplLCAx NCk7CisgZC0+Zm9udFNpemVzLmluc2VydChRV2ViU2V0dGluZ3M6OkRlZmF1bHRGb250U2l6ZSwg MTYpOworIGQtPmZvbnRTaXplcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpEZWZhdWx0Rml4ZWRGb250 U2l6ZSwgMTMpOwogICAgIGQtPmZvbnRGYW1pbGllcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpTdGFu ZGFyZEZvbnQsIFFMYXRpbjFTdHJpbmcoIkFyaWFsIikpOwogICAgIGQtPmZvbnRGYW1pbGllcy5p bnNlcnQoUVdlYlNldHRpbmdzOjpGaXhlZEZvbnQsIFFMYXRpbjFTdHJpbmcoIkNvdXJpZXIgTmV3 IikpOwogICAgIGQtPmZvbnRGYW1pbGllcy5pbnNlcnQoUVdlYlNldHRpbmdzOjpTZXJpZkZvbnQs IFFMYXRpbjFTdHJpbmcoIlRpbWVzIE5ldyBSb21hbiIpKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBhY2E3NWM0Li5kZjZiMDk2 IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJl ZS5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUu Y3BwCkBAIC0xMDIsOCArMTAyLDcgQEAgV2ViUGFnZTo6V2ViUGFnZShRV2lkZ2V0ICpwYXJlbnQs IER1bXBSZW5kZXJUcmVlICpkcnQpCiB7CiAgICAgc2V0dGluZ3MoKS0+c2V0Rm9udFNpemUoUVdl YlNldHRpbmdzOjpNaW5pbXVtRm9udFNpemUsIDUpOwogICAgIHNldHRpbmdzKCktPnNldEZvbnRT aXplKFFXZWJTZXR0aW5nczo6TWluaW11bUxvZ2ljYWxGb250U2l6ZSwgNSk7Ci0gLy8gVG8gZ2V0 IERSVCBjb21wbGlhbnQgdG8gc29tZSBsYXlvdXQgdGVzdHMgbGV0cyBzZXQgdGhlIGRlZmF1bHQg Zm9udHNpemUgdG8gMTMuCi0gc2V0dGluZ3MoKS0+c2V0Rm9udFNpemUoUVdlYlNldHRpbmdzOjpE ZWZhdWx0Rm9udFNpemUsIDEzKTsKKyBzZXR0aW5ncygpLT5zZXRGb250U2l6ZShRV2ViU2V0dGlu Z3M6OkRlZmF1bHRGb250U2l6ZSwgMTYpOwogICAgIHNldHRpbmdzKCktPnNldEZvbnRTaXplKFFX ZWJTZXR0aW5nczo6RGVmYXVsdEZpeGVkRm9udFNpemUsIDEzKTsKICAgICBzZXR0aW5ncygpLT5z ZXRBdHRyaWJ1dGUoUVdlYlNldHRpbmdzOjpKYXZhc2NyaXB0Q2FuT3BlbldpbmRvd3MsIHRydWUp OwogICAgIHNldHRpbmdzKCktPnNldEF0dHJpYnV0ZShRV2ViU2V0dGluZ3M6OkphdmFzY3JpcHRD YW5BY2Nlc3NDbGlwYm9hcmQsIHRydWUpOwo=