196737 2019-04-09 10:49:14 -0700 Web Inspector: Debugger: deleting a special breakpoint should disable it 2019-04-15 11:34:58 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1525674 0 hi 2019-04-09 10:49:14 -0700 Additionally, if the breakpoint is already disabled, we should beep :) 1525675 1 webkit-bug-importer 2019-04-09 10:49:35 -0700 <rdar://problem/49740680> 1527071 2 367394 hi 2019-04-13 14:59:08 -0700 Created attachment 367394 Patch 1527217 3 367394 commit-queue 2019-04-15 10:23:42 -0700 Comment on attachment 367394 Patch Rejecting attachment 367394 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 367394, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=367394&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=196737&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 367394 from bug 196737. Fetching: https://bugs.webkit.org/attachment.cgi?id=367394 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebInspectorUI/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date W: 0ad446a422dcfe0ef19c372b30c9068e4490ba72 and refs/remotes/origin/master differ, using rebase: :040000 040000 bfd667a4cb95ce3496c8eeda90daf7585e8f4e4e 04de1cb3db7d948c9c29d185cfbaa62afb6af147 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebInspectorUI/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebInspectorUI/ChangeLog' is out of date W: 0ad446a422dcfe0ef19c372b30c9068e4490ba72 and refs/remotes/origin/master differ, using rebase: :040000 040000 bfd667a4cb95ce3496c8eeda90daf7585e8f4e4e 04de1cb3db7d948c9c29d185cfbaa62afb6af147 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 469d0a6c447..95611e18b1c master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 244261 = 469d0a6c447955deb0758a84088fb59b25c68f49 r244262 = c2d0cf11ea65cc78da9e2047f9f299bfca13c6cf r244263 = ae4b638a9ab8561574696048984e05b8d8987467 r244264 = 95611e18b1cdcad1c9b7c35dfaacdcb6dffd5253 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/11872083 1527262 4 367429 hi 2019-04-15 11:07:37 -0700 Created attachment 367429 Patch 1527282 5 367429 commit-queue 2019-04-15 11:34:56 -0700 Comment on attachment 367429 Patch Clearing flags on attachment: 367429 Committed r244274: <https://trac.webkit.org/changeset/244274> 1527283 6 commit-queue 2019-04-15 11:34:58 -0700 All reviewed patches have been landed. Closing bug. 367394 2019-04-13 14:59:08 -0700 2019-04-15 11:07:36 -0700 Patch bug-196737-20190413145907.patch text/plain 1789 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkzODM1NTE2MTc2MDYwMzQxODYzMWUzNDNlZjc5 ODI1M2FmOGQzMjQuLmYwYjAzYzA2YTQwNTEyYmZmNDc3NWEwMzM2Y2Q0NGJmMmU4Mjg2MzAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTEzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogZGVsZXRpbmcgYSBzcGVjaWFsIGJyZWFrcG9pbnQgc2hvdWxkIGRpc2FibGUgaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjczNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk3NDA2ODA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9p bnRUcmVlRWxlbWVudC5qczoKKyAgICAgICAgKFdJLkJyZWFrcG9pbnRUcmVlRWxlbWVudC5wcm90 b3R5cGUub25kZWxldGUpOgorCiAyMDE5LTA0LTExICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OKHIyNDQxOTUpOiBU aW1lbGluZXM6IHVuYWJsZSB0byB0YWtlIGhlYXAgc25hcHNob3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRUcmVlRWxlbWVu dC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9p bnRUcmVlRWxlbWVudC5qcwppbmRleCAzMmQxNDlhN2E1M2Q5NWM0ODI0ODk1YjI0ZTkyMTg3Mzgx OTU0MTk4Li4yZmY3YTZiNmYxMWFiMDY0MmQ1ZGY2MTJiY2YzZjgzODc1MWU5ODU2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50 VHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQnJlYWtwb2ludFRyZWVFbGVtZW50LmpzCkBAIC03Nyw4ICs3NywxMyBAQCBXSS5CcmVh a3BvaW50VHJlZUVsZW1lbnQgPSBjbGFzcyBCcmVha3BvaW50VHJlZUVsZW1lbnQgZXh0ZW5kcyBX SS5HZW5lcmFsVHJlZUVsZQogCiAgICAgb25kZWxldGUoKQogICAgIHsKLSAgICAgICAgaWYgKCFX SS5kZWJ1Z2dlck1hbmFnZXIuaXNCcmVha3BvaW50UmVtb3ZhYmxlKHRoaXMuX2JyZWFrcG9pbnQp KQorICAgICAgICBpZiAoIVdJLmRlYnVnZ2VyTWFuYWdlci5pc0JyZWFrcG9pbnRSZW1vdmFibGUo dGhpcy5fYnJlYWtwb2ludCkpIHsKKyAgICAgICAgICAgIGlmICh0aGlzLl9icmVha3BvaW50LmRp c2FibGVkKQorICAgICAgICAgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5iZWVwKCk7Cisg ICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhpcy5fYnJlYWtwb2ludC5kaXNhYmxl ZCA9IHRydWU7CiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgfQogCiAgICAgICAg IC8vIFdlIHNldCB0aGlzIGZsYWcgc28gdGhhdCBUcmVlT3V0bGluZXMgdGhhdCB3aWxsIHJlbW92 ZSB0aGlzCiAgICAgICAgIC8vIEJyZWFrcG9pbnRUcmVlRWxlbWVudCB3aWxsIGtub3cgd2hldGhl ciBpdCB3YXMgZGVsZXRlZCBmcm9tCg== 367429 2019-04-15 11:07:37 -0700 2019-04-15 11:34:56 -0700 Patch bug-196737-20190415110736.patch text/plain 1818 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ5N2U4MTY0YjBjNTVmOGQxNjg3NmM3ODNhNTQw NDg0Y2M3NWRkYzYuLjkyNmE4NWM5MWQyZmE1ZTVhZjVmMTc1ZjYyNGI1NjRmMGIzZjc1OTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE5LTA0LTE1ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE ZWJ1Z2dlcjogZGVsZXRpbmcgYSBzcGVjaWFsIGJyZWFrcG9pbnQgc2hvdWxkIGRpc2FibGUgaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjczNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk3NDA2ODA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg VGltb3RoeSBIYXRjaGVyLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9CcmVha3Bv aW50VHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXSS5CcmVha3BvaW50VHJlZUVsZW1lbnQucHJv dG90eXBlLm9uZGVsZXRlKToKKwogMjAxOS0wNC0xNSAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVnaHQgRXhjZXB0aW9uOiBu dWxsIGlzIG5vdCBhbiBvYmplY3QgKGV2YWx1YXRpbmcgJ3RoaXMuc2VsZWN0ZWRUcmVlRWxlbWVu dC5yZXZlYWwnKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQnJlYWtwb2ludFRyZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvQnJlYWtwb2ludFRyZWVFbGVtZW50LmpzCmluZGV4IDMyZDE0 OWE3YTUzZDk1YzQ4MjQ4OTViMjRlOTIxODczODE5NTQxOTguLjJmZjdhNmI2ZjExYWIwNjQyZDVk ZjYxMmJjZjNmODM4NzUxZTk4NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0JyZWFrcG9pbnRUcmVlRWxlbWVudC5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9CcmVha3BvaW50VHJlZUVsZW1lbnQu anMKQEAgLTc3LDggKzc3LDEzIEBAIFdJLkJyZWFrcG9pbnRUcmVlRWxlbWVudCA9IGNsYXNzIEJy ZWFrcG9pbnRUcmVlRWxlbWVudCBleHRlbmRzIFdJLkdlbmVyYWxUcmVlRWxlCiAKICAgICBvbmRl bGV0ZSgpCiAgICAgewotICAgICAgICBpZiAoIVdJLmRlYnVnZ2VyTWFuYWdlci5pc0JyZWFrcG9p bnRSZW1vdmFibGUodGhpcy5fYnJlYWtwb2ludCkpCisgICAgICAgIGlmICghV0kuZGVidWdnZXJN YW5hZ2VyLmlzQnJlYWtwb2ludFJlbW92YWJsZSh0aGlzLl9icmVha3BvaW50KSkgeworICAgICAg ICAgICAgaWYgKHRoaXMuX2JyZWFrcG9pbnQuZGlzYWJsZWQpCisgICAgICAgICAgICAgICAgSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmJlZXAoKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAg ICAgICB0aGlzLl9icmVha3BvaW50LmRpc2FibGVkID0gdHJ1ZTsKICAgICAgICAgICAgIHJldHVy biB0cnVlOworICAgICAgICB9CiAKICAgICAgICAgLy8gV2Ugc2V0IHRoaXMgZmxhZyBzbyB0aGF0 IFRyZWVPdXRsaW5lcyB0aGF0IHdpbGwgcmVtb3ZlIHRoaXMKICAgICAgICAgLy8gQnJlYWtwb2lu dFRyZWVFbGVtZW50IHdpbGwga25vdyB3aGV0aGVyIGl0IHdhcyBkZWxldGVkIGZyb20K