<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>196734</bug_id>
          
          <creation_ts>2019-04-09 09:36:26 -0700</creation_ts>
          <short_desc>[CMake] Cleanup CMake files after target-oriented changes</short_desc>
          <delta_ts>2019-04-09 10:09:05 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Don Olmstead">don.olmstead</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1525644</commentid>
    <comment_count>0</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2019-04-09 09:36:26 -0700</bug_when>
    <thetext>While working on cleaning up things for https://bugs.webkit.org/show_bug.cgi?id=196704 I&apos;m expecting to see some things that can be refactored or need to be fixed but can&apos;t be addressed till later in the process. This bug is meant to track those things so they don&apos;t get lost in the shuffle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525646</commentid>
    <comment_count>1</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2019-04-09 09:45:30 -0700</bug_when>
    <thetext>In Source/WTF/wtf/CMakeLists.txt the WTF_INCLUDE_DIRECTORIES should only propagate bmalloc includes.

Not fixing yet because this causes a bunch of unrelated changes to be needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525648</commentid>
    <comment_count>2</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2019-04-09 09:46:47 -0700</bug_when>
    <thetext>In Source/WTF/wtf/CMakeLists.txt the forwarding headers directory is used for copying the unified bundles script.

This also requires changes to WebKitMacros.cmake</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1525659</commentid>
    <comment_count>3</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2019-04-09 10:09:05 -0700</bug_when>
    <thetext>I have no idea why there are calls to WEBKIT_CREATE_FORWARDING_HEADERS inside of WTF in Source/WTF/wtf/PlatformMac.cmake</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>