196733 2019-04-09 09:35:34 -0700 [WPE] Avoid async IO starving timers 2019-04-10 01:56:02 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eocanha eocanha benjamin bugs-noreply calvaris cdumez cgarcia cmarcelo commit-queue dbates ews-watchlist zan oldest_to_newest 1525643 0 eocanha 2019-04-09 09:35:34 -0700 When loading a big media file (eg: a 180MB MP4 file) the NetworkProcess downloads the whole file before handing it out to the WebProcess. Further debugging showed that the m_bufferingTimer in NetworkResourceLoader (responsible of sending the downloaded data to the WebProcess via IPC) is triggered several times but eventually stops calling bufferingTimerFired() after the timer deadline has passed. The main thread SharedTimer is starved. This starvation happens because the AsyncIONetwork and DiskCacheRead priorities are higher (have lower values in RunLoopSourcePriority.h) than the MainThreadSharedTimer one. 1525645 1 367043 eocanha 2019-04-09 09:40:46 -0700 Created attachment 367043 Patch 1525893 2 367043 cgarcia 2019-04-10 00:54:06 -0700 Comment on attachment 367043 Patch I think it's time to re-consider using the same priorities than the GTK port, note that fdo backend stopped using -70 for their sources. But yes, in the meantime this patch looks good to me. Thanks! 1525906 3 367043 commit-queue 2019-04-10 01:56:01 -0700 Comment on attachment 367043 Patch Clearing flags on attachment: 367043 Committed r244108: <https://trac.webkit.org/changeset/244108> 1525907 4 commit-queue 2019-04-10 01:56:02 -0700 All reviewed patches have been landed. Closing bug. 367043 2019-04-09 09:40:46 -0700 2019-04-10 01:56:01 -0700 Patch bug-196733-20190409164044.patch text/plain 1794 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQxZWEyMTVjOTFjYzkzMmNlMmEzMTBl ZDA3YmMzMTIyZmVjZWE0YjguLjQ3MTE4ODFjZGRhZjYwMTMxNGUxZTVjZTZiMmE1ZmFiNjk0Nzgw MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDQtMDkgIEVucmlxdWUgT2Nhw7FhIEdvbnrD oWxleiAgPGVvY2FuaGFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBBdm9pZCBhc3luYyBJ TyBzdGFydmluZyB0aW1lcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5NjczMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIElmIEFzeW5jSU9OZXR3b3JrIGFuZCBEaXNrQ2FjaGVSZWFkIHByaW9yaXRpZXMg YXJlIGhpZ2hlciB0aGFuCisgICAgICAgIE1haW5UaHJlYWRTaGFyZWRUaW1lciB0aGUgdGltZXJz IGdldCBzdGFydmVkLiBUaGlzIGNhdXNlcyB0aGUgTmV0d29ya1Byb2Nlc3MKKyAgICAgICAgdG8g YWNjdW11bGF0ZSBNQiBvZiBkYXRhIGluc3RlYWQgb2YgaGFuZGluZyBpdCBkb3duIHRvIHRoZSBX ZWJQcm9jZXNzIChkb25lCisgICAgICAgIHVzaW5nIGEgVGltZXIpLiBUaGlzIGV2ZW50dWFsbHkg Y2F1c2VzIGFuIE91dCBPZiBNZW1vcnkga2lsbCBvbiB0aGUKKyAgICAgICAgTmV0d29ya1Byb2Nl c3Mgb24gc29tZSBlbWJlZGRlZCBwbGF0Zm9ybXMgd2l0aCBsb3cgbWVtb3J5IGxpbWl0cy4KKwor ICAgICAgICBUaGlzIHBhdGNoIGxldmVscyB0aGUgdGhyZWUgcHJpb3JpdGllcyB0byB0aGUgc2Ft ZSB2YWx1ZSwgd2hpbGUgc3RpbGwgbGVhdmluZworICAgICAgICBEaXNrQ2FjaGVXcml0ZSB3aXRo IGxlc3MgcHJpb3JpdHkgdGhhbiBEaXNrQ2FjaGVSZWFkLgorCisgICAgICAgICogd3RmL2dsaWIv UnVuTG9vcFNvdXJjZVByaW9yaXR5Lmg6IENoYW5nZWQgUnVuTG9vcFNvdXJjZVByaW9yaXR5IHZh bHVlcyBmb3IgV1BFLgorCiAyMDE5LTA0LTA4ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRA c29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXVtXaW5DYWlyb10gU2VwYXJhdGUgY29waWVkIGhl YWRlcnMgaW50byBkaWZmZXJlbnQgZGlyZWN0b3JpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL2dsaWIvUnVuTG9vcFNvdXJjZVByaW9yaXR5LmggYi9Tb3VyY2UvV1RGL3d0Zi9nbGliL1J1 bkxvb3BTb3VyY2VQcmlvcml0eS5oCmluZGV4IGM5YTQ1Njc1MTQ5YTZiMDQ3NjgwNDRjY2FkM2Fk NmM4Mzg0MWJlMjkuLjcxMjdhNGU3NTlkOGM4MDA3ZWQxMWRiNmFiNjE4M2QxNTk1N2ZmMDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvUnVuTG9vcFNvdXJjZVByaW9yaXR5LmgKKysr IGIvU291cmNlL1dURi93dGYvZ2xpYi9SdW5Mb29wU291cmNlUHJpb3JpdHkuaApAQCAtMTAyLDkg KzEwMiw5IEBAIGVudW0gUnVuTG9vcFNvdXJjZVByaW9yaXR5IHsKIAogICAgIFJlbGVhc2VVbnVz ZWRSZXNvdXJjZXNUaW1lciA9IC03MCwKIAotICAgIEFzeW5jSU9OZXR3b3JrID0gLTcwLAotICAg IERpc2tDYWNoZVJlYWQgPSAtNzAsCi0gICAgRGlza0NhY2hlV3JpdGUgPSAtNjAKKyAgICBBc3lu Y0lPTmV0d29yayA9IC02MCwKKyAgICBEaXNrQ2FjaGVSZWFkID0gLTYwLAorICAgIERpc2tDYWNo ZVdyaXRlID0gLTUwCiB9OwogCiAjZW5kaWYK