196727 2019-04-09 00:43:55 -0700 [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work. 2019-04-10 01:01:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 takashi.komori webkit-unassigned basuke commit-queue don.olmstead fujii lforschler ross.kirsling webkit-bug-importer oldest_to_newest 1525583 0 takashi.komori 2019-04-09 00:43:55 -0700 On WinCairo MiniBrowser, some of pull down menu doesn't work. We can't disabling JavaScript by clicking Develop menu->Disable JavaScript. This is because page group and preference are not register properly. 1525584 1 367033 takashi.komori 2019-04-09 00:49:27 -0700 Created attachment 367033 Patch 1525594 2 367033 fujii 2019-04-09 02:23:44 -0700 Comment on attachment 367033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367033&action=review > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113 > + auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get()); WebKitBrowserWindow is used only for WinCairo at the memoment, but also for AppleWin in the future (hopefully). Should be renamed. Nit: pageGroup is leaked. auto pageGroup = adoptWK(...); And conf, prefs and context are also leaked. 1525870 3 367099 takashi.komori 2019-04-09 21:48:06 -0700 Created attachment 367099 Patch 1525871 4 takashi.komori 2019-04-09 21:52:16 -0700 (In reply to Fujii Hironori from comment #2) > Comment on attachment 367033 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=367033&action=review > > > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113 > > + auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get()); > WebKitBrowserWindow is used only for WinCairo at the memoment, but also for > AppleWin in the future (hopefully). Should be renamed. Changed to "WinMiniBrowser". If more apropriate one exists, I'll change. > Nit: pageGroup is leaked. > auto pageGroup = adoptWK(...); > And conf, prefs and context are also leaked. Fixed. 1525881 5 367105 takashi.komori 2019-04-09 22:58:08 -0700 Created attachment 367105 Patch 1525895 6 367105 commit-queue 2019-04-10 01:00:46 -0700 Comment on attachment 367105 Patch Clearing flags on attachment: 367105 Committed r244106: <https://trac.webkit.org/changeset/244106> 1525896 7 commit-queue 2019-04-10 01:00:48 -0700 All reviewed patches have been landed. Closing bug. 1525898 8 webkit-bug-importer 2019-04-10 01:01:26 -0700 <rdar://problem/49766482> 367033 2019-04-09 00:49:27 -0700 2019-04-09 21:48:02 -0700 Patch bug-196727-20190409164628.patch text/plain 1517 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzY4N2QxOGZlN2RjNTRjNzQ3NzBhODZlNTI3YWFiZTM4 MzA3ODQ0My4uNzY4YTkxNGI0ZDdmMDRjZGM4MzUzZGE2ZjE2Zjg3YjM4ZWNhM2VlOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA0LTA5ICBUYWthc2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb11bTWluaUJyb3dzZXJdIFB1bGwgZG93biBtZW51ICJEaXNh YmxlIEphdmFTY3JpcHQiIGRvZXNuJ3Qgd29yay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjcyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd2luL1dlYktpdEJyb3dzZXJXaW5k b3cuY3BwOgorICAgICAgICAoV2ViS2l0QnJvd3NlcldpbmRvdzo6Y3JlYXRlKToKKwogMjAxOS0w NC0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBI aWRlIG5leHQgYW5kIHByZXZpb3VzIGZvcm0gY29udHJvbCBidXR0b25zIHdoZW4gV0tXZWJWaWV3 IGlzIGVkaXRhYmxlCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJv d3NlcldpbmRvdy5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRv dy5jcHAKaW5kZXggODVkZTQ0NjJjM2EzMjMxN2VkMzVhMThlNGRmMDdhODM1ZGZhNTYxZC4uZjU4 YzRiN2I2MzQ2YjQzYzU3ZjA1OWM5ZmM2MmNmYzU0ZTk1Mjk3YiAxMDA2NDQKLS0tIGEvVG9vbHMv TWluaUJyb3dzZXIvd2luL1dlYktpdEJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL3dpbi9XZWJLaXRCcm93c2VyV2luZG93LmNwcApAQCAtMTA5LDYgKzEwOSwxMSBAQCBS ZWY8QnJvd3NlcldpbmRvdz4gV2ViS2l0QnJvd3NlcldpbmRvdzo6Y3JlYXRlKEhXTkQgbWFpbldu ZCwgSFdORCB1cmxCYXJXbmQsIGJvbwogICAgIGF1dG8gY29uZiA9IFdLUGFnZUNvbmZpZ3VyYXRp b25DcmVhdGUoKTsKIAogICAgIGF1dG8gcHJlZnMgPSBXS1ByZWZlcmVuY2VzQ3JlYXRlKCk7CisK KyAgICBhdXRvIHBhZ2VHcm91cCA9IFdLUGFnZUdyb3VwQ3JlYXRlV2l0aElkZW50aWZpZXIoY3Jl YXRlV0tTdHJpbmcoIldpbkNhaXJvTWluaUJyb3dzZXIiKS5nZXQoKSk7CisgICAgV0tQYWdlQ29u ZmlndXJhdGlvblNldFBhZ2VHcm91cChjb25mLCBwYWdlR3JvdXApOworICAgIFdLUGFnZUdyb3Vw U2V0UHJlZmVyZW5jZXMocGFnZUdyb3VwLCBwcmVmcyk7CisKICAgICBXS1ByZWZlcmVuY2VzU2V0 RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChwcmVmcywgdHJ1ZSk7CiAgICAgV0tQYWdlQ29uZmlndXJh dGlvblNldFByZWZlcmVuY2VzKGNvbmYsIHByZWZzKTsKIAo= 367099 2019-04-09 21:48:06 -0700 2019-04-09 22:58:05 -0700 Patch bug-196727-20190410134508.patch text/plain 2463 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzY4N2QxOGZlN2RjNTRjNzQ3NzBhODZlNTI3YWFiZTM4 MzA3ODQ0My4uNzY4YTkxNGI0ZDdmMDRjZGM4MzUzZGE2ZjE2Zjg3YjM4ZWNhM2VlOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA0LTA5ICBUYWthc2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb11bTWluaUJyb3dzZXJdIFB1bGwgZG93biBtZW51ICJEaXNh YmxlIEphdmFTY3JpcHQiIGRvZXNuJ3Qgd29yay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjcyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd2luL1dlYktpdEJyb3dzZXJXaW5k b3cuY3BwOgorICAgICAgICAoV2ViS2l0QnJvd3NlcldpbmRvdzo6Y3JlYXRlKToKKwogMjAxOS0w NC0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBI aWRlIG5leHQgYW5kIHByZXZpb3VzIGZvcm0gY29udHJvbCBidXR0b25zIHdoZW4gV0tXZWJWaWV3 IGlzIGVkaXRhYmxlCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJv d3NlcldpbmRvdy5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRv dy5jcHAKaW5kZXggODVkZTQ0NjJjM2EzMjMxN2VkMzVhMThlNGRmMDdhODM1ZGZhNTYxZC4uMGYz NjM0NzAxZWViYzQ5YjE5MTVhZjgyMjYyMDJiZWViODg4NzcxYSAxMDA2NDQKLS0tIGEvVG9vbHMv TWluaUJyb3dzZXIvd2luL1dlYktpdEJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL3dpbi9XZWJLaXRCcm93c2VyV2luZG93LmNwcApAQCAtMTA2LDE2ICsxMDYsMjEgQEAg V0tSZXRhaW5QdHI8V0tVUkxSZWY+IGNyZWF0ZVdLVVJMKGNvbnN0IHN0ZDo6d3N0cmluZyYgc3Ry KQogCiBSZWY8QnJvd3NlcldpbmRvdz4gV2ViS2l0QnJvd3NlcldpbmRvdzo6Y3JlYXRlKEhXTkQg bWFpblduZCwgSFdORCB1cmxCYXJXbmQsIGJvb2wsIGJvb2wpCiB7Ci0gICAgYXV0byBjb25mID0g V0tQYWdlQ29uZmlndXJhdGlvbkNyZWF0ZSgpOworICAgIFdLUmV0YWluUHRyPFdLUGFnZUNvbmZp Z3VyYXRpb25SZWY+IGNvbmYgPSBhZG9wdFdLKFdLUGFnZUNvbmZpZ3VyYXRpb25DcmVhdGUoKSk7 CiAKLSAgICBhdXRvIHByZWZzID0gV0tQcmVmZXJlbmNlc0NyZWF0ZSgpOwotICAgIFdLUHJlZmVy ZW5jZXNTZXREZXZlbG9wZXJFeHRyYXNFbmFibGVkKHByZWZzLCB0cnVlKTsKLSAgICBXS1BhZ2VD b25maWd1cmF0aW9uU2V0UHJlZmVyZW5jZXMoY29uZiwgcHJlZnMpOworICAgIFdLUmV0YWluUHRy PFdLUHJlZmVyZW5jZXNSZWY+IHByZWZzID0gYWRvcHRXSyhXS1ByZWZlcmVuY2VzQ3JlYXRlKCkp OwogCi0gICAgYXV0byBjb250ZXh0ID0gV0tDb250ZXh0Q3JlYXRlV2l0aENvbmZpZ3VyYXRpb24o bnVsbHB0cik7Ci0gICAgV0tQYWdlQ29uZmlndXJhdGlvblNldENvbnRleHQoY29uZiwgY29udGV4 dCk7CisgICAgV0tSZXRhaW5QdHI8V0tQYWdlR3JvdXBSZWY+IHBhZ2VHcm91cCA9IGFkb3B0V0so V0tQYWdlR3JvdXBDcmVhdGVXaXRoSWRlbnRpZmllcihjcmVhdGVXS1N0cmluZygiV2luTWluaUJy b3dzZXIiKS5nZXQoKSkpOworICAgIFdLUGFnZUNvbmZpZ3VyYXRpb25TZXRQYWdlR3JvdXAoY29u Zi5nZXQoKSwgcGFnZUdyb3VwLmdldCgpKTsKKyAgICBXS1BhZ2VHcm91cFNldFByZWZlcmVuY2Vz KHBhZ2VHcm91cC5nZXQoKSwgcHJlZnMuZ2V0KCkpOwogCi0gICAgcmV0dXJuIGFkb3B0UmVmKCpu ZXcgV2ViS2l0QnJvd3NlcldpbmRvdyhjb25mLCBtYWluV25kLCB1cmxCYXJXbmQpKTsKKyAgICBX S1ByZWZlcmVuY2VzU2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChwcmVmcy5nZXQoKSwgdHJ1ZSk7 CisgICAgV0tQYWdlQ29uZmlndXJhdGlvblNldFByZWZlcmVuY2VzKGNvbmYuZ2V0KCksIHByZWZz LmdldCgpKTsKKworICAgIFdLUmV0YWluUHRyPFdLQ29udGV4dFJlZj4gY29udGV4dCA9YWRvcHRX SyhXS0NvbnRleHRDcmVhdGVXaXRoQ29uZmlndXJhdGlvbihudWxscHRyKSk7CisgICAgV0tQYWdl Q29uZmlndXJhdGlvblNldENvbnRleHQoY29uZi5nZXQoKSwgY29udGV4dC5nZXQoKSk7CisKKyAg ICByZXR1cm4gYWRvcHRSZWYoKm5ldyBXZWJLaXRCcm93c2VyV2luZG93KGNvbmYuZ2V0KCksIG1h aW5XbmQsIHVybEJhclduZCkpOwogfQogCiBXZWJLaXRCcm93c2VyV2luZG93OjpXZWJLaXRCcm93 c2VyV2luZG93KFdLUGFnZUNvbmZpZ3VyYXRpb25SZWYgY29uZiwgSFdORCBtYWluV25kLCBIV05E IHVybEJhclduZCkK 367105 2019-04-09 22:58:08 -0700 2019-04-10 01:00:46 -0700 Patch bug-196727-20190410145510.patch text/plain 2363 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzY4N2QxOGZlN2RjNTRjNzQ3NzBhODZlNTI3YWFiZTM4 MzA3ODQ0My4uNzY4YTkxNGI0ZDdmMDRjZGM4MzUzZGE2ZjE2Zjg3YjM4ZWNhM2VlOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE5LTA0LTA5ICBUYWthc2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5DYWlyb11bTWluaUJyb3dzZXJdIFB1bGwgZG93biBtZW51ICJEaXNh YmxlIEphdmFTY3JpcHQiIGRvZXNuJ3Qgd29yay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjcyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvd2luL1dlYktpdEJyb3dzZXJXaW5k b3cuY3BwOgorICAgICAgICAoV2ViS2l0QnJvd3NlcldpbmRvdzo6Y3JlYXRlKToKKwogMjAxOS0w NC0wNiAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBI aWRlIG5leHQgYW5kIHByZXZpb3VzIGZvcm0gY29udHJvbCBidXR0b25zIHdoZW4gV0tXZWJWaWV3 IGlzIGVkaXRhYmxlCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJv d3NlcldpbmRvdy5jcHAgYi9Ub29scy9NaW5pQnJvd3Nlci93aW4vV2ViS2l0QnJvd3NlcldpbmRv dy5jcHAKaW5kZXggODVkZTQ0NjJjM2EzMjMxN2VkMzVhMThlNGRmMDdhODM1ZGZhNTYxZC4uNWE2 ZTkyYzM4YWRlMmVjZjYwYWJkMGQ4MWRkNmZkOTE5NzZmZWVhMCAxMDA2NDQKLS0tIGEvVG9vbHMv TWluaUJyb3dzZXIvd2luL1dlYktpdEJyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlC cm93c2VyL3dpbi9XZWJLaXRCcm93c2VyV2luZG93LmNwcApAQCAtMTA2LDE2ICsxMDYsMjEgQEAg V0tSZXRhaW5QdHI8V0tVUkxSZWY+IGNyZWF0ZVdLVVJMKGNvbnN0IHN0ZDo6d3N0cmluZyYgc3Ry KQogCiBSZWY8QnJvd3NlcldpbmRvdz4gV2ViS2l0QnJvd3NlcldpbmRvdzo6Y3JlYXRlKEhXTkQg bWFpblduZCwgSFdORCB1cmxCYXJXbmQsIGJvb2wsIGJvb2wpCiB7Ci0gICAgYXV0byBjb25mID0g V0tQYWdlQ29uZmlndXJhdGlvbkNyZWF0ZSgpOworICAgIGF1dG8gY29uZiA9IGFkb3B0V0soV0tQ YWdlQ29uZmlndXJhdGlvbkNyZWF0ZSgpKTsKIAotICAgIGF1dG8gcHJlZnMgPSBXS1ByZWZlcmVu Y2VzQ3JlYXRlKCk7Ci0gICAgV0tQcmVmZXJlbmNlc1NldERldmVsb3BlckV4dHJhc0VuYWJsZWQo cHJlZnMsIHRydWUpOwotICAgIFdLUGFnZUNvbmZpZ3VyYXRpb25TZXRQcmVmZXJlbmNlcyhjb25m LCBwcmVmcyk7CisgICAgYXV0byBwcmVmcyA9IGFkb3B0V0soV0tQcmVmZXJlbmNlc0NyZWF0ZSgp KTsKIAotICAgIGF1dG8gY29udGV4dCA9IFdLQ29udGV4dENyZWF0ZVdpdGhDb25maWd1cmF0aW9u KG51bGxwdHIpOwotICAgIFdLUGFnZUNvbmZpZ3VyYXRpb25TZXRDb250ZXh0KGNvbmYsIGNvbnRl eHQpOworICAgIGF1dG8gcGFnZUdyb3VwID0gYWRvcHRXSyhXS1BhZ2VHcm91cENyZWF0ZVdpdGhJ ZGVudGlmaWVyKGNyZWF0ZVdLU3RyaW5nKCJXaW5NaW5pQnJvd3NlciIpLmdldCgpKSk7CisgICAg V0tQYWdlQ29uZmlndXJhdGlvblNldFBhZ2VHcm91cChjb25mLmdldCgpLCBwYWdlR3JvdXAuZ2V0 KCkpOworICAgIFdLUGFnZUdyb3VwU2V0UHJlZmVyZW5jZXMocGFnZUdyb3VwLmdldCgpLCBwcmVm cy5nZXQoKSk7CiAKLSAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBXZWJLaXRCcm93c2VyV2luZG93 KGNvbmYsIG1haW5XbmQsIHVybEJhclduZCkpOworICAgIFdLUHJlZmVyZW5jZXNTZXREZXZlbG9w ZXJFeHRyYXNFbmFibGVkKHByZWZzLmdldCgpLCB0cnVlKTsKKyAgICBXS1BhZ2VDb25maWd1cmF0 aW9uU2V0UHJlZmVyZW5jZXMoY29uZi5nZXQoKSwgcHJlZnMuZ2V0KCkpOworCisgICAgYXV0byBj b250ZXh0ID1hZG9wdFdLKFdLQ29udGV4dENyZWF0ZVdpdGhDb25maWd1cmF0aW9uKG51bGxwdHIp KTsKKyAgICBXS1BhZ2VDb25maWd1cmF0aW9uU2V0Q29udGV4dChjb25mLmdldCgpLCBjb250ZXh0 LmdldCgpKTsKKworICAgIHJldHVybiBhZG9wdFJlZigqbmV3IFdlYktpdEJyb3dzZXJXaW5kb3co Y29uZi5nZXQoKSwgbWFpblduZCwgdXJsQmFyV25kKSk7CiB9CiAKIFdlYktpdEJyb3dzZXJXaW5k b3c6OldlYktpdEJyb3dzZXJXaW5kb3coV0tQYWdlQ29uZmlndXJhdGlvblJlZiBjb25mLCBIV05E IG1haW5XbmQsIEhXTkQgdXJsQmFyV25kKQo=