196709 2019-04-08 14:45:38 -0700 [ews-build] Scripts using Buildbot API have CORS error 2019-04-08 17:42:34 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1525384 0 aakash_jain 2019-04-08 14:45:38 -0700 Any script using Buildbot API will have CORS error, since buildbot is not setting CORS header appropriately. We need to set allowed_origins in Buildbot configuration as per: http://docs.buildbot.net/latest/manual/configuration/www.html#web-server 1525385 1 aakash_jain 2019-04-08 14:45:45 -0700 <rdar://problem/49710473> 1525390 2 366985 aakash_jain 2019-04-08 14:48:43 -0700 Created attachment 366985 Patch 1525407 3 366985 ap 2019-04-08 15:03:02 -0700 Comment on attachment 366985 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366985&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:14 > +c['www'] = dict(port=8010, allowed_origins=["*"]) This has security considerations that I wouldn't want to think through unless I have to. What are the scripts that hit the error? Only JavaScript running in the browser is strictly subject to CORS. Some scripting also enables those checks, but that can always be disabled. 1525458 4 366985 ap 2019-04-08 16:35:24 -0700 Comment on attachment 366985 Patch OK, I think that this is fine. We have the same rules on build.webkit.org anyway. 1525488 5 366985 commit-queue 2019-04-08 17:42:33 -0700 Comment on attachment 366985 Patch Clearing flags on attachment: 366985 Committed r244060: <https://trac.webkit.org/changeset/244060> 1525489 6 commit-queue 2019-04-08 17:42:34 -0700 All reviewed patches have been landed. Closing bug. 366985 2019-04-08 14:48:43 -0700 2019-04-08 17:42:33 -0700 Patch bug-196709-20190408174945.patch text/plain 1096 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDA0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE5LTA0LTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBTY3JpcHRzIHVzaW5nIEJ1aWxkYm90IEFQSSBoYXZl IENPUlMgZXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5NjcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL21hc3Rlci5jZmc6IFNldCBhbGxvd2Vk X29yaWdpbnMgYXBwcm9wcmlhdGVseS4KKwogMjAxOS0wNC0wOCAgQWFrYXNoIEphaW4gIDxhYWth c2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2V3cy1idWlsZF0gRG8gbm90IHVwbG9hZCBh cmNoaXZlIHdoZW4gQ29tcGlsZSBGYWlscwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL21hc3Rlci5jZmcJKHJldmlzaW9uIDI0NDA0NikKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2V3cy1idWlsZC9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0xMSw3 ICsxMSw3IEBAIGlzX3Rlc3RfbW9kZV9lbmFibGVkID0gb3MuZ2V0ZW52KCdCVUlMREIKIAogYyA9 IEJ1aWxkbWFzdGVyQ29uZmlnID0ge30KIAotY1snd3d3J10gPSBkaWN0KHBvcnQ9ODAxMCkKK2Nb J3d3dyddID0gZGljdChwb3J0PTgwMTAsIGFsbG93ZWRfb3JpZ2lucz1bIioiXSkKIAogY1snd3d3 J11bJ3VpX2RlZmF1bHRfY29uZmlnJ10gPSB7IAogICAgICdCdWlsZGVycy5zaG93X3dvcmtlcnNf bmFtZSc6IFRydWUsCg==