196708 2019-04-08 14:34:37 -0700 ASSERTION FAILED: !scope.exception() || !hasProperty in JSObject::get 2019-04-09 00:54:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1525373 0 tzagallo 2019-04-08 14:34:37 -0700 ... 1525375 1 tzagallo 2019-04-08 14:35:31 -0700 <rdar://problem/49556803> 1525386 2 366984 tzagallo 2019-04-08 14:46:54 -0700 Created attachment 366984 Patch 1525517 3 366984 ysuzuki 2019-04-08 19:00:06 -0700 Comment on attachment 366984 Patch r=me 1525518 4 366984 ysuzuki 2019-04-08 19:00:19 -0700 Comment on attachment 366984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366984&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:2375 > EXCEPTION_ASSERT(!throwScope.exception() || !hasProperty); You can remove this line. 1525572 5 367031 tzagallo 2019-04-09 00:16:20 -0700 Created attachment 367031 Patch for landing 1525585 6 367031 commit-queue 2019-04-09 00:54:23 -0700 Comment on attachment 367031 Patch for landing Clearing flags on attachment: 367031 Committed r244069: <https://trac.webkit.org/changeset/244069> 1525586 7 commit-queue 2019-04-09 00:54:25 -0700 All reviewed patches have been landed. Closing bug. 366984 2019-04-08 14:46:54 -0700 2019-04-09 00:16:16 -0700 Patch bug-196708-20190408234644.patch text/plain 3138 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2ViZjVmZmU4OWEwMjk1Njg0Mjc2NmNhNDM2YWE3MDcwZDBmZjg5Li5mMGU1ODk3NjgwMWZiYzM2 ZDBmZWEyM2QwZjc2ZDliYmNjM2E0MGY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNC0wOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAhc2NvcGUuZXhjZXB0aW9uKCkgfHwgIWhh c1Byb3BlcnR5IGluIEpTT2JqZWN0OjpnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NjcwOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk1NTY4 MDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYG9w ZXJhdGlvblB1dFRvU2NvcGVgIG5lZWRzIHRvIHJldHVybiBlYXJseSBpZiBhbiBleGNlcHRpb24g aXMgdGhyb3duIHdoaWxlCisgICAgICAgIGNoZWNraW5nIGlmIGBoYXNQcm9wZXJ0eWAuCisKKyAg ICAgICAgKiBqaXQvSklUT3BlcmF0aW9ucy5jcHA6CisKIDIwMTktMDQtMDcgIE1pY2hhZWwgU2Fi b2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI0MzY0Mik6 IENyYXNoIGluIHJlZGRpdC5jb20gcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU T3BlcmF0aW9ucy5jcHAKaW5kZXggYjhlYzRjZDUyZTMxZDBjYWY2ODhhYjg2YmEyMGZhNjQxY2U3 ZWY0YS4uYzcyNTgyN2ZiZGQ0MWQzMjBjMTQyN2U1OTI2YWY1NDBjNDRjMTBlMSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCkBAIC0yMzczLDYgKzIzNzMs NyBAQCB2b2lkIEpJVF9PUEVSQVRJT04gb3BlcmF0aW9uUHV0VG9TY29wZShFeGVjU3RhdGUqIGV4 ZWMsIGNvbnN0IEluc3RydWN0aW9uKiBwYykKIAogICAgIGJvb2wgaGFzUHJvcGVydHkgPSBzY29w ZS0+aGFzUHJvcGVydHkoZXhlYywgaWRlbnQpOwogICAgIEVYQ0VQVElPTl9BU1NFUlQoIXRocm93 U2NvcGUuZXhjZXB0aW9uKCkgfHwgIWhhc1Byb3BlcnR5KTsKKyAgICBSRVRVUk5fSUZfRVhDRVBU SU9OKHRocm93U2NvcGUsIHZvaWQoKSk7CiAgICAgaWYgKGhhc1Byb3BlcnR5CiAgICAgICAgICYm IHNjb3BlLT5pc0dsb2JhbExleGljYWxFbnZpcm9ubWVudCgpCiAgICAgICAgICYmICFpc0luaXRp YWxpemF0aW9uKGdldFB1dEluZm8uaW5pdGlhbGl6YXRpb25Nb2RlKCkpKSB7CmRpZmYgLS1naXQg YS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDlmMmQ3NjAwMWRj NWIxN2MwY2ZkMDQ3N2JmMGQ4YjdhOTRiOGFkMzcuLjc4NzQ2MjFlZjZhZWMwNDNjMjY2Yjg4NDU5 NDQyYzQ4ZmQ5NjZkZWIgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMDggIFRhZGV1IFphZ2FsbG8g IDx0emFnYWxsb0BhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogIXNjb3Bl LmV4Y2VwdGlvbigpIHx8ICFoYXNQcm9wZXJ0eSBpbiBKU09iamVjdDo6Z2V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY3MDgKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzQ5NTU2ODAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3RyZXNzL3Byb3h5LWdldHRlci1zdGFjay1vdmVyZmxvdy5qczog QWRkZWQuCisgICAgICAgIChjb25zdC5oYW5kbGVyLmdldCB0YXJnZXQpOgorICAgICAgICAoY29u c3QuaGFuZGxlci5oYXMpOgorICAgICAgICAodHJ5LndpdGgpOgorICAgICAgICAoY2F0Y2gpOgor CiAyMDE5LTA0LTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT04gKHIyNDM2NDIpOiBDcmFzaCBpbiByZWRkaXQuY29tIHBhZ2UKZGlmZiAt LWdpdCBhL0pTVGVzdHMvc3RyZXNzL3Byb3h5LWdldHRlci1zdGFjay1vdmVyZmxvdy5qcyBiL0pT VGVzdHMvc3RyZXNzL3Byb3h5LWdldHRlci1zdGFjay1vdmVyZmxvdy5qcwpuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42 MzFmODcwZDc5YjUzZjVlNDY4NDgyM2VkOTM4YjY0ZDZhMWU2ZjRiCi0tLSAvZGV2L251bGwKKysr IGIvSlNUZXN0cy9zdHJlc3MvcHJveHktZ2V0dGVyLXN0YWNrLW92ZXJmbG93LmpzCkBAIC0wLDAg KzEsMjQgQEAKKy8vQCBpZiAkaml0VGVzdHMgdGhlbiBydW5EZWZhdWx0KCItLXVzZUxMSW50PTAi KSBlbHNlIHNraXAgZW5kCisKK2NvbnN0IG8gPSB7fTsKK2NvbnN0IGhhbmRsZXIgPSB7CisgIGdl dCh0YXJnZXQsIHByb3AsIHJlY2VpdmVyKSB7CisgICAgICBvLl9fcHJvdG9fXyA9IHJlY2VpdmVy OworICB9LAorICBoYXModGFyZ2V0LCBwcm9wKSB7CisgICAgICBvLl9fcHJvdG9fXyA9IHVuZGVm aW5lZDsKKyAgICAgIHJldHVybiAxOworICB9Cit9OworCitjb25zdCBwID0gbmV3IFByb3h5KHt9 LCBoYW5kbGVyKTsKK2hhbmRsZXIuX19wcm90b19fID0gcDsKK3RyeSB7CisgICAgd2l0aCAocCkg eworICAgICAgICBhID0gMAorICAgIH0KKyAgICB0aHJvdyBuZXcgRXJyb3IoIlNob3VsZCB0aHJv dyBSYW5nZUVycm9yIik7Cit9IGNhdGNoIChlcnJvcikgeworICAgIGlmIChlcnJvci5tZXNzYWdl ICE9PSAiTWF4aW11bSBjYWxsIHN0YWNrIHNpemUgZXhjZWVkZWQuIikKKyAgICAgICAgdGhyb3cg bmV3IEVycm9yKCJFeHBlY3RlZCBzdGFjayBvdmVyZmxvdywgYnV0IGdvdDogIiArIGVycm9yKTsK K30K 367031 2019-04-09 00:16:20 -0700 2019-04-09 00:54:23 -0700 Patch for landing bug-196708-20190409091608.patch text/plain 3143 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2ViZjVmZmU4OWEwMjk1Njg0Mjc2NmNhNDM2YWE3MDcwZDBmZjg5Li40YzRlMjg2Nzc0N2I1ZGQ2 ZjM2OWQzYzg0NTJkYjM5NmFmZjYxM2Q4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNC0wOCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAhc2NvcGUuZXhjZXB0aW9uKCkgfHwgIWhh c1Byb3BlcnR5IGluIEpTT2JqZWN0OjpnZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5NjcwOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDk1NTY4 MDM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgWXVzdWtlIFN1enVraS4KKworICAgICAgICBgb3Bl cmF0aW9uUHV0VG9TY29wZWAgbmVlZHMgdG8gcmV0dXJuIGVhcmx5IGlmIGFuIGV4Y2VwdGlvbiBp cyB0aHJvd24gd2hpbGUKKyAgICAgICAgY2hlY2tpbmcgaWYgYGhhc1Byb3BlcnR5YC4KKworICAg ICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmNwcDoKKwogMjAxOS0wNC0wNyAgTWljaGFlbCBTYWJv ZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjQzNjQyKTog Q3Jhc2ggaW4gcmVkZGl0LmNvbSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRP cGVyYXRpb25zLmNwcAppbmRleCBiOGVjNGNkNTJlMzFkMGNhZjY4OGFiODZiYTIwZmE2NDFjZTdl ZjRhLi4xZjBhMmVkMGYzMmEwZDk3MmExNjZjZTliMGZkOTQwNGEzNTUxZjNhIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKQEAgLTIzNzIsNyArMjM3Miw3 IEBAIHZvaWQgSklUX09QRVJBVElPTiBvcGVyYXRpb25QdXRUb1Njb3BlKEV4ZWNTdGF0ZSogZXhl YywgY29uc3QgSW5zdHJ1Y3Rpb24qIHBjKQogICAgIH0KIAogICAgIGJvb2wgaGFzUHJvcGVydHkg PSBzY29wZS0+aGFzUHJvcGVydHkoZXhlYywgaWRlbnQpOwotICAgIEVYQ0VQVElPTl9BU1NFUlQo IXRocm93U2NvcGUuZXhjZXB0aW9uKCkgfHwgIWhhc1Byb3BlcnR5KTsKKyAgICBSRVRVUk5fSUZf RVhDRVBUSU9OKHRocm93U2NvcGUsIHZvaWQoKSk7CiAgICAgaWYgKGhhc1Byb3BlcnR5CiAgICAg ICAgICYmIHNjb3BlLT5pc0dsb2JhbExleGljYWxFbnZpcm9ubWVudCgpCiAgICAgICAgICYmICFp c0luaXRpYWxpemF0aW9uKGdldFB1dEluZm8uaW5pdGlhbGl6YXRpb25Nb2RlKCkpKSB7CmRpZmYg LS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDlmMmQ3 NjAwMWRjNWIxN2MwY2ZkMDQ3N2JmMGQ4YjdhOTRiOGFkMzcuLjFmMDk3OTY2MDUwNGFhNGMwNGJk NTE0MDhkN2RjN2ZiMzE0Y2ZiNWMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBi L0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDQtMDggIFRhZGV1IFph Z2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog IXNjb3BlLmV4Y2VwdGlvbigpIHx8ICFoYXNQcm9wZXJ0eSBpbiBKU09iamVjdDo6Z2V0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY3MDgKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzQ5NTU2ODAzPgorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3Vr ZSBTdXp1a2kuCisKKyAgICAgICAgKiBzdHJlc3MvcHJveHktZ2V0dGVyLXN0YWNrLW92ZXJmbG93 LmpzOiBBZGRlZC4KKyAgICAgICAgKGNvbnN0LmhhbmRsZXIuZ2V0IHRhcmdldCk6CisgICAgICAg IChjb25zdC5oYW5kbGVyLmhhcyk6CisgICAgICAgICh0cnkud2l0aCk6CisgICAgICAgIChjYXRj aCk6CisKIDIwMTktMDQtMDcgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjI0MzY0Mik6IENyYXNoIGluIHJlZGRpdC5jb20gcGFnZQpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvcHJveHktZ2V0dGVyLXN0YWNrLW92ZXJmbG93Lmpz IGIvSlNUZXN0cy9zdHJlc3MvcHJveHktZ2V0dGVyLXN0YWNrLW92ZXJmbG93LmpzCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjYzMWY4NzBkNzliNTNmNWU0Njg0ODIzZWQ5MzhiNjRkNmExZTZmNGIKLS0tIC9kZXYvbnVs bAorKysgYi9KU1Rlc3RzL3N0cmVzcy9wcm94eS1nZXR0ZXItc3RhY2stb3ZlcmZsb3cuanMKQEAg LTAsMCArMSwyNCBAQAorLy9AIGlmICRqaXRUZXN0cyB0aGVuIHJ1bkRlZmF1bHQoIi0tdXNlTExJ bnQ9MCIpIGVsc2Ugc2tpcCBlbmQKKworY29uc3QgbyA9IHt9OworY29uc3QgaGFuZGxlciA9IHsK KyAgZ2V0KHRhcmdldCwgcHJvcCwgcmVjZWl2ZXIpIHsKKyAgICAgIG8uX19wcm90b19fID0gcmVj ZWl2ZXI7CisgIH0sCisgIGhhcyh0YXJnZXQsIHByb3ApIHsKKyAgICAgIG8uX19wcm90b19fID0g dW5kZWZpbmVkOworICAgICAgcmV0dXJuIDE7CisgIH0KK307CisKK2NvbnN0IHAgPSBuZXcgUHJv eHkoe30sIGhhbmRsZXIpOworaGFuZGxlci5fX3Byb3RvX18gPSBwOwordHJ5IHsKKyAgICB3aXRo IChwKSB7CisgICAgICAgIGEgPSAwCisgICAgfQorICAgIHRocm93IG5ldyBFcnJvcigiU2hvdWxk IHRocm93IFJhbmdlRXJyb3IiKTsKK30gY2F0Y2ggKGVycm9yKSB7CisgICAgaWYgKGVycm9yLm1l c3NhZ2UgIT09ICJNYXhpbXVtIGNhbGwgc3RhY2sgc2l6ZSBleGNlZWRlZC4iKQorICAgICAgICB0 aHJvdyBuZXcgRXJyb3IoIkV4cGVjdGVkIHN0YWNrIG92ZXJmbG93LCBidXQgZ290OiAiICsgZXJy b3IpOworfQo=