196699 2019-04-08 11:06:46 -0700 -f[no-]var-tracking-assignments is GCC-only 2019-04-08 13:59:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling clopez commit-queue don.olmstead mcatanzaro webkit-bug-importer oldest_to_newest 1525262 0 ross.kirsling 2019-04-08 11:06:46 -0700 -f[no-]var-tracking-assignments is GCC-only 1525263 1 366954 ross.kirsling 2019-04-08 11:07:07 -0700 Created attachment 366954 Patch 1525266 2 ross.kirsling 2019-04-08 11:10:57 -0700 This was introduced in bug 185462 and causes JSCOnly to fail on Mac. (Interestingly, "unknown argument" is just a warning for clang-cl, but it's an error for clang proper.) 1525301 3 mcatanzaro 2019-04-08 12:58:40 -0700 I guess you can just remove it because it's broken, bug #186273. The warning seems to be gone in GCC 9 anyway. 1525302 4 mcatanzaro 2019-04-08 12:58:59 -0700 Please close that bug if you take this approach. 1525313 5 ross.kirsling 2019-04-08 13:09:27 -0700 Oh sure, happy to remove it instead if we no longer need it. 1525317 6 366973 ross.kirsling 2019-04-08 13:17:51 -0700 Created attachment 366973 Patch for landing 1525348 7 366973 commit-queue 2019-04-08 13:57:44 -0700 Comment on attachment 366973 Patch for landing Clearing flags on attachment: 366973 Committed r244044: <https://trac.webkit.org/changeset/244044> 1525349 8 commit-queue 2019-04-08 13:57:46 -0700 All reviewed patches have been landed. Closing bug. 1525350 9 webkit-bug-importer 2019-04-08 13:59:27 -0700 <rdar://problem/49710076> 366954 2019-04-08 11:07:07 -0700 2019-04-08 13:17:49 -0700 Patch bug-196699-20190408110702.patch text/plain 1399 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MTBhZmZiZGNlYmQxOWJiMTI1ZmUyZTMxM2VmODc5YTk4NjQyNWJjLi5iYzJhMTZiNWFiMjY2OTFi ZGE5Y2I0ODllMjNjMTEzNDFiZDI5M2QwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOS0wNC0wOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgLWZbbm8tXXZhci10cmFja2luZy1hc3NpZ25tZW50cyBpcyBHQ0Mt b25seQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2 Njk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBD TWFrZUxpc3RzLnR4dDoKKwogMjAxOS0wNC0wOCAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjQzOTQzLgpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDc4NGU4NGE4YzJjYjYwYzM5YTVhY2E5 NmYwZDY2ZDNkN2ZlMTllM2EuLmU1MGM4MjNkMDEwZTJmZWYwMjcyMDNjZDM2ZDQ2NjRhMmU4YzBi NDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEyNzEsNyArMTI3MSw5 IEBAIGlmIChDT01QSUxFUl9JU19HQ0NfT1JfQ0xBTkcpCiAgICAgIyBBdm9pZCB1c2luZyBmdXNl ZCBtdWx0aXBseS1hZGQgaW5zdHJ1Y3Rpb25zIHNpbmNlIHRoaXMgY291bGQgZ2l2ZSBkaWZmZXJl bnQgcmVzdWx0cwogICAgICMgZm9yIGUuZy4gcGFyc2VJbnQgZGVwZW5kaW5nIG9uIHRoZSBwbGF0 Zm9ybSBhbmQgY29tcGlsYXRpb24gZmxhZ3MuCiAgICAgV0VCS0lUX0FERF9UQVJHRVRfQ1hYX0ZM QUdTKEphdmFTY3JpcHRDb3JlIC1mZnAtY29udHJhY3Q9b2ZmKQorZW5kaWYgKCkKIAoraWYgKENN QUtFX0NPTVBJTEVSX0lTX0dOVUNYWCkKICAgICAjIEF2b2lkICJ2YXJpYWJsZSB0cmFja2luZyBz aXplIGxpbWl0IGV4Y2VlZGVkIgogICAgIHNldF9zb3VyY2VfZmlsZXNfcHJvcGVydGllcyhidWls dGlucy9CdWlsdGluTmFtZXMuY3BwIFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAtZm5vLXZhci10 cmFja2luZy1hc3NpZ25tZW50cykKIGVuZGlmICgpCg== 366973 2019-04-08 13:17:51 -0700 2019-04-08 13:57:44 -0700 Patch for landing bug-196699-20190408131747.patch text/plain 1577 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MTBhZmZiZGNlYmQxOWJiMTI1ZmUyZTMxM2VmODc5YTk4NjQyNWJjLi45MGEyM2Q3ZjM3NWE0NmMy ODZkM2Q4ZTU1N2RjYmU0MWM1MWNhZmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOS0wNC0wOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgLWZbbm8tXXZhci10cmFja2luZy1hc3NpZ25tZW50cyBpcyBHQ0Mt b25seQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2 Njk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRG9uIE9sbXN0ZWFkLgorCisgICAgICAgICogQ01h a2VMaXN0cy50eHQ6CisgICAgICAgIEp1c3QgcmVtb3ZlIHRoZSBidWlsZCBmbGFnIGFsdG9nZXRo ZXIgLS0gaXQgc3VwcG9zZWRseSBkb2Vzbid0IHNvbHZlIHRoZSBwcm9ibGVtIGl0IHdhcyBtZWFu dCB0bworICAgICAgICBhbmQgc2FpZCBwcm9ibGVtIGV2aWRlbnRseSBubyBsb25nZXIgb2NjdXJz IGFzIG9mIEdDQyA5LgorCiAyMDE5LTA0LTA4ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBw bGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNDM5NDMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNzg0ZTg0YThjMmNiNjBjMzlhNWFjYTk2 ZjBkNjZkM2Q3ZmUxOWUzYS4uNmM2ZjU0ODNlNDZlMDc3NmYzNTM1YWFiMGNmYjZmM2FmNWQ3YWVl ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTI3MSw5ICsxMjcxLDYg QEAgaWYgKENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORykKICAgICAjIEF2b2lkIHVzaW5nIGZ1c2Vk IG11bHRpcGx5LWFkZCBpbnN0cnVjdGlvbnMgc2luY2UgdGhpcyBjb3VsZCBnaXZlIGRpZmZlcmVu dCByZXN1bHRzCiAgICAgIyBmb3IgZS5nLiBwYXJzZUludCBkZXBlbmRpbmcgb24gdGhlIHBsYXRm b3JtIGFuZCBjb21waWxhdGlvbiBmbGFncy4KICAgICBXRUJLSVRfQUREX1RBUkdFVF9DWFhfRkxB R1MoSmF2YVNjcmlwdENvcmUgLWZmcC1jb250cmFjdD1vZmYpCi0KLSAgICAjIEF2b2lkICJ2YXJp YWJsZSB0cmFja2luZyBzaXplIGxpbWl0IGV4Y2VlZGVkIgotICAgIHNldF9zb3VyY2VfZmlsZXNf cHJvcGVydGllcyhidWlsdGlucy9CdWlsdGluTmFtZXMuY3BwIFBST1BFUlRJRVMgQ09NUElMRV9G TEFHUyAtZm5vLXZhci10cmFja2luZy1hc3NpZ25tZW50cykKIGVuZGlmICgpCiAKIFdFQktJVF9N QUtFX0ZPUldBUkRJTkdfSEVBREVSUyhKYXZhU2NyaXB0Q29yZQo=