196690 2019-04-08 07:45:16 -0700 [JSCOnly] Add an 32bit JSCOnly EWS that runs tests 2019-04-09 08:44:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra aakash_jain ap commit-queue dbates ews-watchlist glenn lforschler mcatanzaro pvollan webkit-bug-importer xan.lopez oldest_to_newest 1525178 0 psaavedra 2019-04-08 07:45:16 -0700 We are trying to bring the X86 port in JSC up to speed. We are now at a point where it would make sense to have a EWS bot to track regressions, since some of them will apply to all 32bit ports. If this is set up in a Linux x86-64 machine all you need to do is build JSC with build-jsc --32-bit (recently made to work). 1525181 1 366935 psaavedra 2019-04-08 07:47:28 -0700 Created attachment 366935 patch 1525182 2 psaavedra 2019-04-08 07:50:32 -0700 We are already aware about the new EWS CI (https://bugs.webkit.org/show_bug.cgi?id=196641) but , in meantime, we wish go ahead with this new EWS. The idea is to move all the EWS workers at the same time in the future. 1525193 3 366935 mcatanzaro 2019-04-08 08:57:15 -0700 Comment on attachment 366935 patch What architecture is this? x86? Could we name it jsc-i386-ews, jsc-i686-ews, or something to make it more clear? 1525208 4 psaavedra 2019-04-08 09:38:36 -0700 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 366935 [details] > patch > > What architecture is this? x86? > > Could we name it jsc-i386-ews, jsc-i686-ews, or something to make it more > clear? Yes. it is i386. Since it other EWS for x86_64 has not a reference to the PC architecture in the name I assumed as a right notation just add the 32 bit and make no references to the architecture. In others words no architecture reference = PC. I have no objections to rename the worker with other nomenclature whatever you'd prefer better. 1525211 5 ap 2019-04-08 09:41:28 -0700 Having i386 in the name would be consistent with jsc-armv7-ews. 1525578 6 psaavedra 2019-04-09 00:34:02 -0700 (In reply to Alexey Proskuryakov from comment #5) > Having i386 in the name would be consistent with jsc-armv7-ews. Yes, this makes sense. 1525580 7 367032 psaavedra 2019-04-09 00:40:34 -0700 Created attachment 367032 patch 1525581 8 psaavedra 2019-04-09 00:41:09 -0700 (In reply to Pablo Saavedra from comment #6) > (In reply to Alexey Proskuryakov from comment #5) > > Having i386 in the name would be consistent with jsc-armv7-ews. > > Yes, this makes sense. New patch uploaded with the required changes 1525621 9 367032 commit-queue 2019-04-09 08:43:06 -0700 Comment on attachment 367032 patch Clearing flags on attachment: 367032 Committed r244076: <https://trac.webkit.org/changeset/244076> 1525622 10 commit-queue 2019-04-09 08:43:07 -0700 All reviewed patches have been landed. Closing bug. 1525623 11 webkit-bug-importer 2019-04-09 08:44:24 -0700 <rdar://problem/49736225> 366935 2019-04-08 07:47:28 -0700 2019-04-09 00:40:18 -0700 patch bug-196690-20190408164727.patch text/plain 2471 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzMwNzZlMDcyZjYyNWM2NjhlMjVlOGMyOTFhOWI1MTUz MzMwYTZlYy4uN2VhOGEwNmNjMzVjYTUzOTM3OWI1Mzk1ZTVjYzM2YTNhYTRiOGUyMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA0LTA4ICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtKU0NPbmx5XSBBZGQgYW4gMzJiaXQgSlNDT25seSBFV1MgdGhhdCBydW5zIHRl c3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY2 OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFF1 ZXVlU3RhdHVzU2VydmVyL2NvbmZpZy9xdWV1ZXMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vY29uZmlnL2V3cy5qc29uOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv dG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHk6CisgICAgICAgICh0 ZXN0X2V3c19uYW1lKToKKwogMjAxOS0wNC0wOCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250 QGlnYWxpYS5jb20+CiAKICAgICAgICAgRW5hYmxlIERGRyBvbiBNSVBTCmRpZmYgLS1naXQgYS9U b29scy9RdWV1ZVN0YXR1c1NlcnZlci9jb25maWcvcXVldWVzLnB5IGIvVG9vbHMvUXVldWVTdGF0 dXNTZXJ2ZXIvY29uZmlnL3F1ZXVlcy5weQppbmRleCBmMzEwOGMwYWEzNjk1NDZmZTQzYmU1MjQ0 Nzk1NDU1ZWRiNDkyYmFjLi4yOTQwOTdhM2M1NDA0ZDI5M2E4MzcwMTcxMTEwOTc5ZmI0YjA3YjJk IDEwMDY0NAotLS0gYS9Ub29scy9RdWV1ZVN0YXR1c1NlcnZlci9jb25maWcvcXVldWVzLnB5Cisr KyBiL1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2NvbmZpZy9xdWV1ZXMucHkKQEAgLTQwLDYgKzQw LDcgQEAgYWxsX3F1ZXVlX25hbWVzID0gWwogICAgICJqc2MtZXdzIiwKICAgICAianNjLW1pcHMt ZXdzIiwKICAgICAianNjLWFybXY3LWV3cyIsCisgICAgImpzYy0zMmJpdC1ld3MiLAogICAgICJt YWMtZXdzIiwKICAgICAibWFjLXdrMi1ld3MiLAogICAgICJtYWMtZGVidWctZXdzIiwKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9ld3MuanNvbiBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9ld3MuanNvbgppbmRleCBkZTExMGUz ZThiNjUwNTUwNTIzMTE0ODhiNzMwMzBmMjMxYTJiOTRiLi5iYTA3NTlkMGY5YzRhMTY0NTg4ZmNh Y2YxYjEwNmM5N2JiM2E4Mjg5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jb25maWcvZXdzLmpzb24KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL2V3cy5qc29uCkBAIC00Nyw2ICs0NywxMiBAQAogICAgICAgICAibmFtZSI6ICJqc2Mt ZXdzIiwKICAgICAgICAgImdyb3VwIjogImpzYyIsCiAgICAgICAgICJydW5UZXN0cyI6IHRydWUK KyAgICB9LAorCSJKU0MgMzJiaXQgRVdTIjogeworICAgICAgICAicG9ydCI6ICJqc2Mtb25seSIs CisgICAgICAgICJuYW1lIjogImpzYy0zMmJpdC1ld3MiLAorICAgICAgICAiZ3JvdXAiOiAianNj IiwKKyAgICAgICAgInJ1blRlc3RzIjogZmFsc2UKICAgICB9LAogICAgICJKU0MgTUlQUzMyZWwg RVdTIjogewogICAgICAgICAicG9ydCI6ICJqc2Mtb25seSIsCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0 LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5 c3RlbV91bml0dGVzdC5weQppbmRleCA2ZTlmYjg5ZTBiOGFlMDllYjQ5OTZhNDRhMTYwODNmMTBk MzZmYzRlLi5mNmE3ZGY4ZWMzYTVmZGY2ZjZlNWFjMTU5MjI3NGRlMDBlMTQ2NTZlIDEwMDY0NAot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lz dGVtX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5k cy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKQEAgLTIxMiw2ICsyMTIsNyBAQCBNT0NL OiB1cGRhdGVfc3RhdHVzOiAlKG5hbWUpcyBDaGVja2VkIHJlbGV2YW5jZSBvZiBwYXRjaAogICAg ICAgICAgICAgJ2lvcy1ld3MnLAogICAgICAgICAgICAgJ2lvcy1zaW0tZXdzJywKICAgICAgICAg ICAgICdqc2MtZXdzJywKKyAgICAgICAgICAgICdqc2MtMzJiaXQtZXdzJywKICAgICAgICAgICAg ICdqc2MtbWlwcy1ld3MnLAogICAgICAgICAgICAgJ2pzYy1hcm12Ny1ld3MnLAogICAgICAgICAg ICAgJ21hYy1kZWJ1Zy1ld3MnLAo= 367032 2019-04-09 00:40:34 -0700 2019-04-09 08:43:06 -0700 patch bug-196690-20190409094033.patch text/plain 2501 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ0MDY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmFmMGFkNjNjMDIxNTUyNTc5OTA5ZmU5YmExOTk0YzBj OWI5MzEwNi4uMDIyNTFlNjIyNzJjMTBhYzk0NzUwZDI2ODA4ZDBhMTM3MzE2YzgxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE5LTA0LTA4ICBQYWJsbyBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtKU0NPbmx5XSBBZGQgYW4gaTM4NiBKU0NPbmx5IEVXUyB0aGF0IHJ1bnMgdGVz dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjY5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogUXVl dWVTdGF0dXNTZXJ2ZXIvY29uZmlnL3F1ZXVlcy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb246CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weToKKyAgICAgICAgKHRl c3RfZXdzX25hbWUpOgorCiAyMDE5LTA0LTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1 amlpQHNvbnkuY29tPgogCiAgICAgICAgIEFYOiBTdXBwb3J0IEFQSTogYWNjZXNzaWJpbGl0eVJl cGxhY2VSYW5nZTp3aXRoVGV4dApkaWZmIC0tZ2l0IGEvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIv Y29uZmlnL3F1ZXVlcy5weSBiL1Rvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2NvbmZpZy9xdWV1ZXMu cHkKaW5kZXggZjMxMDhjMGFhMzY5NTQ2ZmU0M2JlNTI0NDc5NTQ1NWVkYjQ5MmJhYy4uMWYxZGVj Njg0ZTE1MjhlNzMwNWZkNmQ1NGE3YWQwZTcxZWM0NzEzNSAxMDA2NDQKLS0tIGEvVG9vbHMvUXVl dWVTdGF0dXNTZXJ2ZXIvY29uZmlnL3F1ZXVlcy5weQorKysgYi9Ub29scy9RdWV1ZVN0YXR1c1Nl cnZlci9jb25maWcvcXVldWVzLnB5CkBAIC00MCw2ICs0MCw3IEBAIGFsbF9xdWV1ZV9uYW1lcyA9 IFsKICAgICAianNjLWV3cyIsCiAgICAgImpzYy1taXBzLWV3cyIsCiAgICAgImpzYy1hcm12Ny1l d3MiLAorICAgICJqc2MtaTM4Ni1ld3MiLAogICAgICJtYWMtZXdzIiwKICAgICAibWFjLXdrMi1l d3MiLAogICAgICJtYWMtZGVidWctZXdzIiwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NvbmZpZy9ld3MuanNvbiBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL2NvbmZpZy9ld3MuanNvbgppbmRleCBkZTExMGUzZThiNjUwNTUwNTIzMTE0ODhiNzMwMzBm MjMxYTJiOTRiLi4xYWE3N2UyOGFlNTc2OTBiNWI3OTI0NTgxYmFlODEyY2IxMmZmZWE5IDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb24KKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2V3cy5qc29uCkBAIC00Nyw2 ICs0NywxMiBAQAogICAgICAgICAibmFtZSI6ICJqc2MtZXdzIiwKICAgICAgICAgImdyb3VwIjog ImpzYyIsCiAgICAgICAgICJydW5UZXN0cyI6IHRydWUKKyAgICB9LAorCSJKU0MgaTM4NiBFV1Mi OiB7CisgICAgICAgICJwb3J0IjogImpzYy1vbmx5IiwKKyAgICAgICAgIm5hbWUiOiAianNjLWkz ODYtZXdzIiwKKyAgICAgICAgImdyb3VwIjogImpzYyIsCisgICAgICAgICJydW5UZXN0cyI6IGZh bHNlCiAgICAgfSwKICAgICAiSlNDIE1JUFMzMmVsIEVXUyI6IHsKICAgICAgICAgInBvcnQiOiAi anNjLW9ubHkiLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKaW5kZXggNmU5 ZmI4OWUwYjhhZTA5ZWI0OTk2YTQ0YTE2MDgzZjEwZDM2ZmM0ZS4uMDdkZDM5ZGY4Njc5YTg3M2Zj NDZiNWE3YWNjNTBkNjA2ZTNhMjM4NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0 ZXN0LnB5CkBAIC0yMTIsNiArMjEyLDcgQEAgTU9DSzogdXBkYXRlX3N0YXR1czogJShuYW1lKXMg Q2hlY2tlZCByZWxldmFuY2Ugb2YgcGF0Y2gKICAgICAgICAgICAgICdpb3MtZXdzJywKICAgICAg ICAgICAgICdpb3Mtc2ltLWV3cycsCiAgICAgICAgICAgICAnanNjLWV3cycsCisgICAgICAgICAg ICAnanNjLWkzODYtZXdzJywKICAgICAgICAgICAgICdqc2MtbWlwcy1ld3MnLAogICAgICAgICAg ICAgJ2pzYy1hcm12Ny1ld3MnLAogICAgICAgICAgICAgJ21hYy1kZWJ1Zy1ld3MnLAo=