196689 2019-04-08 01:30:10 -0700 Enable DFG on MIPS 2019-04-08 05:34:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED InRadar P2 Normal --- 1 guijemont guijemont benjamin cdumez cmarcelo commit-queue dbates ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer xan.lopez zan oldest_to_newest 1525141 0 guijemont 2019-04-08 01:30:10 -0700 Since the bytecode change, we enabled the baseline JIT on mips in r240432, but DFG is still missing. 1525143 1 366920 guijemont 2019-04-08 01:38:44 -0700 Created attachment 366920 Patch The patch enabling DFG on MIPS. All tests are passing. 1525145 2 366920 xan.lopez 2019-04-08 01:53:58 -0700 Comment on attachment 366920 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=366920&action=review Makes sense to me, just a small nit. > Tools/Scripts/run-jsc-stress-tests:452 > +if $architecture == "x86" I believe 'eq' is used for string comparison. 1525146 3 xan.lopez 2019-04-08 01:58:32 -0700 (In reply to Xan Lopez from comment #2) > Makes sense to me, just a small nit. > > > Tools/Scripts/run-jsc-stress-tests:452 > > +if $architecture == "x86" > > I believe 'eq' is used for string comparison. And nevermind this, thought it was a perl script! 1525165 4 366920 commit-queue 2019-04-08 05:33:03 -0700 Comment on attachment 366920 Patch Clearing flags on attachment: 366920 Committed r244000: <https://trac.webkit.org/changeset/244000> 1525166 5 commit-queue 2019-04-08 05:33:04 -0700 All reviewed patches have been landed. Closing bug. 1525167 6 webkit-bug-importer 2019-04-08 05:34:18 -0700 <rdar://problem/49693329> 366920 2019-04-08 01:38:44 -0700 2019-04-08 05:33:03 -0700 Patch bug-196689-20190408103843.patch text/plain 4685 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMjQzOTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 M2NkODg0Njc5YzNmNWZhNjM0MDJjNjllOGYyYTQ5MDIyYmFhOGQ5Li5jOGM4NDI5Mjc5NWQ2NTlh YjU0MTFkMmE2MzcwOTYzOTcwOThhNThlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNC0wOCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgRW5hYmxlIERGRyBvbiBNSVBTCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTY2ODkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB0aGUgYnl0ZWNvZGUgY2hhbmdlLCB3 ZSBlbmFibGVkIHRoZSBiYXNlbGluZSBKSVQgb24gbWlwcyBpbgorICAgICAgICByMjQwNDMyLCBi dXQgREZHIGlzIHN0aWxsIG1pc3NpbmcuIFdpdGggdGhpcyBjaGFuZ2UsIGFsbCB0ZXN0cyBhcmUK KyAgICAgICAgcGFzc2luZyBvbiBhIGNpMjAgYm9hcmQuCisKKyAgICAgICAgKiBqaXQvUmVnaXN0 ZXJTZXQuY3BwOgorICAgICAgICAoSlNDOjpSZWdpc3RlclNldDo6Y2FsbGVlU2F2ZVJlZ2lzdGVy cyk6CisgICAgICAgIEFkZGVkIHMwLCB3aGljaCBpcyB1c2VkIGluIGxsaW50LgorCiAyMDE5LTA0 LTA1ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10g T1NSRXhpdCByZWNvdmVyeSBmb3IgU3BlY3VsYXRpdmVBZGQgZG9lcyBub3QgY29uc2llciAiQSA9 IEEgKyBBIiBwYXR0ZXJuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJj ZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGU2MjViNjQ4YTUzNGYwZDE0NGE3YTU2Zjc5ZTMyODg3YmU1 ZjA5OGEuLjFlYzE0ODFmMWEwYzZlMTc0NzllMjI1MmU1YWI0NWExMTVkNDBlMTAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTktMDQtMDggIEd1aWxsYXVtZSBFbW9udCAgPGd1aWplbW9udEBpZ2Fs aWEuY29tPgorCisgICAgICAgIEVuYWJsZSBERkcgb24gTUlQUworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk2Njg5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgdGhlIGJ5dGVjb2RlIGNoYW5nZSwg d2UgZW5hYmxlZCB0aGUgYmFzZWxpbmUgSklUIG9uIG1pcHMgaW4KKyAgICAgICAgcjI0MDQzMiwg YnV0IERGRyBpcyBzdGlsbCBtaXNzaW5nLiBXaXRoIHRoaXMgY2hhbmdlLCBhbGwgdGVzdHMgYXJl CisgICAgICAgIHBhc3Npbmcgb24gYSBjaTIwIGJvYXJkLgorCisgICAgICAgICogd3RmL1BsYXRm b3JtLmg6IEVuYWJsZSBERkcgb24gTUlQUyBieSBkZWZhdWx0LgorCiAyMDE5LTA0LTA1ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgV2Vha1B0cjxFbGVt ZW50PiBwb3NzaWJsZSBhbmQgZGVwbG95IGl0IGluIGZvcm0gYXNzb2NpYXRlZCBlbGVtZW50cyBj b2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1JlZ2lzdGVyU2V0LmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVnaXN0ZXJTZXQuY3BwCmluZGV4IDc5ZGU4 YzQ5N2I1NjkzZWU3NWFhNjBkYTNkMTZhZWQ4NWMwMTNhMzEuLmVkMjk0Y2IyZDljODJjOWRkNWE5 YzU1YTIxMmNiYmJlN2Q5YmY1ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvUmVnaXN0ZXJTZXQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVnaXN0 ZXJTZXQuY3BwCkBAIC0xNTQsNiArMTU0LDcgQEAgUmVnaXN0ZXJTZXQgUmVnaXN0ZXJTZXQ6OmNh bGxlZVNhdmVSZWdpc3RlcnMoKQogICAgICAgICByZWcgPSBzdGF0aWNfY2FzdDxBUk02NFJlZ2lz dGVyczo6RlBSZWdpc3RlcklEPihyZWcgKyAxKSkKICAgICAgICAgcmVzdWx0LnNldChyZWcpOwog I2VsaWYgQ1BVKE1JUFMpCisgICAgcmVzdWx0LnNldChNSVBTUmVnaXN0ZXJzOjpzMCk7CiAjZWxz ZQogICAgIFVOUkVBQ0hBQkxFX0ZPUl9QTEFURk9STSgpOwogI2VuZGlmCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRl eCA2YWNiMWNiN2ZiNjkzMDg0MmJlNGE4MTlhMjI0N2Q4YTBlM2U3NTllLi4wMzQzMWRmMzZjNmQ4 MGUyMDgxNDM5ZmZhOWNhMTczNjNjYzZhNmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTc2MywxOCArNzYz LDExIEBACiAjZW5kaWYKIAogI2lmIFVTRShKU1ZBTFVFMzJfNjQpCi0jaWYgQ1BVKEFSTV9USFVN QjIpICYmIE9TKExJTlVYKQotLyogT24gQVJNdjcvTGludXggdGhlIEpJVCBpcyBlbmFibGVkIHVu bGVzcyBleHBsaWNpdGx5IGRpc2FibGVkLiAqLworI2lmIChDUFUoQVJNX1RIVU1CMikgfHwgQ1BV KE1JUFMpKSAmJiBPUyhMSU5VWCkKKy8qIE9uIEFSTXY3IGFuZCBNSVBTIG9uIExpbnV4IHRoZSBK SVQgaXMgZW5hYmxlZCB1bmxlc3MgZXhwbGljaXRseSBkaXNhYmxlZC4gKi8KICNpZiAhZGVmaW5l ZChFTkFCTEVfSklUKQogI2RlZmluZSBFTkFCTEVfSklUIDEKICNlbmRpZgotI2VsaWYgQ1BVKE1J UFMpICYmIE9TKExJTlVYKQotLyogU2FtZSBvbiBNSVBTL0xpbnV4LCBidXQgREZHIGlzIGRpc2Fi bGVkIGZvciBub3cuICovCi0jaWYgIWRlZmluZWQoRU5BQkxFX0pJVCkKLSNkZWZpbmUgRU5BQkxF X0pJVCAxCi0jZW5kaWYKLSN1bmRlZiBFTkFCTEVfREZHX0pJVAotI2RlZmluZSBFTkFCTEVfREZH X0pJVCAwCiAjZWxzZQogLyogRGlzYWJsZSBKSVQgYW5kIGZvcmNlIENfTE9PUCBvbiBhbGwgb3Ro ZXIgMzJiaXQgYXJjaGl0ZWN0dXJlcy4gKi8KICN1bmRlZiBFTkFCTEVfSklUCmRpZmYgLS1naXQg YS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2M0OTIzNzQ2MDA1Y2Y3 NTljNTU1YmNhNDI0NWY1Yzk4Nzg1YmIyMC4uYmJlYTFjYmU0ZjcwYTM0NDQwN2MxZGY2YzFiYjlh NmY5ZGU3MjNlNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA0LTA4ICBHdWlsbGF1bWUgRW1vbnQgIDxndWlq ZW1vbnRAaWdhbGlhLmNvbT4KKworICAgICAgICBFbmFibGUgREZHIG9uIE1JUFMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjY4OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRoZSBieXRlY29k ZSBjaGFuZ2UsIHdlIGVuYWJsZWQgdGhlIGJhc2VsaW5lIEpJVCBvbiBtaXBzIGluCisgICAgICAg IHIyNDA0MzIsIGJ1dCBERkcgaXMgc3RpbGwgbWlzc2luZy4gV2l0aCB0aGlzIGNoYW5nZSwgYWxs IHRlc3RzIGFyZQorICAgICAgICBwYXNzaW5nIG9uIGEgY2kyMCBib2FyZC4KKworICAgICAgICAq IFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6IEVuYWJsZSBERkcgdGVzdHMgb24gTUlQUy4K KwogMjAxOS0wNC0wNSAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgog CiAgICAgICAgIFdlIHNob3VsZCBwYXNzIG1pbmltdW1FZmZlY3RpdmVEZXZpY2VXaWR0aCB0byB3 ZWIgcHJvY2VzcyBvbiBuZXcgcGFnZSBjcmVhdGlvbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRl c3RzCmluZGV4IDhkZDA1ZjhhZTAxMjc1ZTdkOTU2MDA5OTQ2ZjViMzI1MzdiNzhhOTQuLjJhYmJi MGIwYjFmYTMzNGJjMzJiZGMyMGUwOWE3YWQ4OWQxNWViNzggMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0 cmVzcy10ZXN0cwpAQCAtNDQ5LDggKzQ0OSw4IEBAICRob3N0T1MgPSBkZXRlcm1pbmVPUyB1bmxl c3MgJGhvc3RPUwogJGFyY2hpdGVjdHVyZSA9IGRldGVybWluZUFyY2hpdGVjdHVyZSB1bmxlc3Mg JGFyY2hpdGVjdHVyZQogJGlzRlRMUGxhdGZvcm0gPSAhKCRhcmNoaXRlY3R1cmUgPT0gIng4NiIg fHwgJGFyY2hpdGVjdHVyZSA9PSAiYXJtIiB8fCAkYXJjaGl0ZWN0dXJlID09ICJtaXBzIiB8fCAk aG9zdE9TID09ICJ3aW5kb3dzIikKIAotaWYgWyJtaXBzIiwgIng4NiJdLmluY2x1ZGU/KCRhcmNo aXRlY3R1cmUpCi0gICAgIyBUaGUgSklUIGlzIHRlbXBvcmFyaWx5IGRpc2FibGVkIG9uIHRoZXNl IHBsYXRmb3JtcyBzaW5jZQoraWYgJGFyY2hpdGVjdHVyZSA9PSAieDg2IgorICAgICMgVGhlIEpJ VCBpcyB0ZW1wb3JhcmlseSBkaXNhYmxlZCBvbiB0aGlzIHBsYXRmb3JtIHNpbmNlCiAgICAgIyBo dHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjM3NTQ3CiAgICAgJGppdFRlc3RzID0g ZmFsc2UKIGVuZAo=