196676 2019-04-06 04:44:17 -0700 [ews-app] Exception while loading status-bubble when no build step has started 2019-04-23 10:53:18 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196675 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain commit-queue lforschler webkit-bug-importer oldest_to_newest 1525013 0 aakash_jain 2019-04-06 04:44:17 -0700 Noticed following exception in logs. This seems to happen when the build has just started, and ews-app has received the build-start event, but not the first step-start event. We should handle it appropriately. 2019-04-06 11:22:44,444 - Internal Server Error: /status-bubble/366884/ Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner response = get_response(request) File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response response = self.process_exception_by_middleware(e, request) File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view return self.dispatch(request, *args, **kwargs) File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 88, in dispatch return handler(request, *args, **kwargs) File "/usr/lib/python2.7/site-packages/django/views/decorators/clickjacking.py", line 58, in wrapped_view resp = view_func(*args, **kwargs) File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 193, in get bubbles, show_submit_to_ews, show_failure_to_apply = self._build_bubbles_for_patch(patch) File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 182, in _build_bubbles_for_patch bubble = self._build_bubble(patch, queue) File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 111, in _build_bubble timestamp = self.get_build_timestamp(build) File "/var/ews/OpenSource/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py", line 130, in get_build_timestamp return self._iso_time(build.step_set.last().started_at) AttributeError: 'NoneType' object has no attribute 'started_at' 1529579 1 368030 aakash_jain 2019-04-23 07:49:43 -0700 Created attachment 368030 Patch 1529645 2 368030 commit-queue 2019-04-23 10:52:01 -0700 Comment on attachment 368030 Patch Clearing flags on attachment: 368030 Committed r244547: <https://trac.webkit.org/changeset/244547> 1529646 3 commit-queue 2019-04-23 10:52:03 -0700 All reviewed patches have been landed. Closing bug. 1529647 4 webkit-bug-importer 2019-04-23 10:53:18 -0700 <rdar://problem/50135802> 368030 2019-04-23 07:49:43 -0700 2019-04-23 10:52:01 -0700 Patch bug-196676-20190423104942.patch text/plain 1687 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NDUzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTIzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gRXhjZXB0aW9uIHdoaWxlIGxvYWRpbmcgc3RhdHVzLWJ1 YmJsZSB3aGVuIG5vIGJ1aWxkIHN0ZXAgaGFzIHN0YXJ0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NjY3NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9l d3Mvdmlld3Mvc3RhdHVzYnViYmxlLnB5OgorICAgICAgICAoU3RhdHVzQnViYmxlLmdldF9idWls ZF90aW1lc3RhbXApOiBDaGVjayBpZiBidWlsZCBzdGVwIGlzIHByZXNlbnQgYmVmb3JlIGFjY2Vz c2luZyBpdHMgdGltZXN0YW1wLgorCiAyMDE5LTA0LTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQVRLXSBJbXBsZW1lbnQgQXRrQ29tcG9u ZW50SWZhY2Ugc2Nyb2xsX3RvIG1ldGhvZHMKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1hcHAvZXdzL3ZpZXdzL3N0YXR1c2J1YmJsZS5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92aWV3cy9zdGF0dXNidWJibGUucHkJKHJldmlz aW9uIDI0NDUzOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdz L3N0YXR1c2J1YmJsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMTMwLDkgKzEzMCwxNCBAQCBjbGFz cyBTdGF0dXNCdWJibGUoVmlldyk6CiAgICAgICAgIHJldHVybiAnJwogCiAgICAgZGVmIGdldF9i dWlsZF90aW1lc3RhbXAoc2VsZiwgYnVpbGQpOgotICAgICAgICBpZiBub3QgYnVpbGQuY29tcGxl dGVfYXQ6ICAjIEluLXByb2dyZXNzIGJ1aWxkCi0gICAgICAgICAgICByZXR1cm4gc2VsZi5faXNv X3RpbWUoYnVpbGQuc3RlcF9zZXQubGFzdCgpLnN0YXJ0ZWRfYXQpCi0gICAgICAgIHJldHVybiBz ZWxmLl9pc29fdGltZShidWlsZC5jb21wbGV0ZV9hdCkKKyAgICAgICAgaWYgYnVpbGQuY29tcGxl dGVfYXQ6CisgICAgICAgICAgICByZXR1cm4gc2VsZi5faXNvX3RpbWUoYnVpbGQuY29tcGxldGVf YXQpCisKKyAgICAgICAgcmVjZW50X2J1aWxkX3N0ZXAgPSBidWlsZC5zdGVwX3NldC5sYXN0KCkK KyAgICAgICAgaWYgcmVjZW50X2J1aWxkX3N0ZXA6CisgICAgICAgICAgICByZXR1cm4gc2VsZi5f aXNvX3RpbWUocmVjZW50X2J1aWxkX3N0ZXAuc3RhcnRlZF9hdCkKKworICAgICAgICByZXR1cm4g c2VsZi5faXNvX3RpbWUoYnVpbGQuc3RhcnRlZF9hdCkKIAogICAgIGRlZiBfaXNvX3RpbWUoc2Vs ZiwgdGltZSk6CiAgICAgICAgIHJldHVybiAnW1snICsgZGF0ZXRpbWUuZGF0ZXRpbWUuZnJvbXRp bWVzdGFtcCh0aW1lKS5pc29mb3JtYXQoKSArICdaXV0nCg==