196674 2019-04-06 04:05:11 -0700 [ews-build] Do not upload archive when Compile Fails 2019-04-08 09:33:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dewei_zhu lforschler webkit-bug-importer oldest_to_newest 1525010 0 aakash_jain 2019-04-06 04:05:11 -0700 When compiling webkit fails, ews unapply the patch and compiles clean tree. However after compiling clean tree, it should not upload the archive from clean tree. In these builds, ews uploaded the archive for clean tree and trigerred API tests which passed, these api test results would be misleading since they did not test the right archive. https://ews-build.webkit.org/#/builders/7/builds/229 https://ews-build.webkit.org/#/builders/7/builds/246 https://ews-build.webkit.org/#/builders/7/builds/249 1525011 1 366884 aakash_jain 2019-04-06 04:22:23 -0700 Created attachment 366884 Patch 1525197 2 366884 ap 2019-04-08 09:03:06 -0700 Comment on attachment 366884 Patch It makes me sad that we don't have tests for such issues. 1525202 3 366884 commit-queue 2019-04-08 09:32:17 -0700 Comment on attachment 366884 Patch Clearing flags on attachment: 366884 Committed r244021: <https://trac.webkit.org/changeset/244021> 1525203 4 commit-queue 2019-04-08 09:32:19 -0700 All reviewed patches have been landed. Closing bug. 1525204 5 webkit-bug-importer 2019-04-08 09:33:20 -0700 <rdar://problem/49698545> 366884 2019-04-06 04:22:23 -0700 2019-04-08 09:32:17 -0700 Patch bug-196674-20190406072322.patch text/plain 2913 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzk2MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE5LTA0LTA2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBEbyBub3QgdXBsb2FkIGFyY2hpdmUgd2hlbiBDb21w aWxlIEZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xOTY2NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXMucHk6CisgICAgICAgIChC dWlsZEZhY3RvcnkuX19pbml0X18pOiBSZW1vdmUgc3RlcHMgd2hpY2ggcmVxdWlyZSBkeW5hbWlj IGRlY2lzaW9uIGFib3V0IHdoZXRoZXIgdG8gcnVuIG9yIG5vdC4KKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChDb21waWxlV2ViS2l0LmV2 YWx1YXRlQ29tbWFuZCk6IER5bmFtaWNhbGx5IGRlY2lkZSB3aGljaCBzdGVwcyB0byBydW4gYmFz ZWQgb24gY29tcGlsZSBzdGF0dXMuCisgICAgICAgIChDb21waWxlV2ViS2l0VG9ULmV2YWx1YXRl Q29tbWFuZCk6IEV4cGxpY2l0bHkgb3ZlcnJpZGUgQ29tcGlsZS5ldmFsdWF0ZUNvbW1hbmQgc28g dGhhdCBpdCAKKyAgICAgICAgZG9lc24ndCBpbmhlcml0IENvbXBpbGVXZWJLaXQuZXZhbHVhdGVD b21tYW5kIHdoaWNoIGR5bmFtaWNhbGx5IGFkZHMgbW9yZSBzdGVwcy4KKwogMjAxOS0wNC0wNSAg WW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIHNo b3VsZCBwYXNzIG1pbmltdW1FZmZlY3RpdmVEZXZpY2VXaWR0aCB0byB3ZWIgcHJvY2VzcyBvbiBu ZXcgcGFnZSBjcmVhdGlvbi4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWls ZC9mYWN0b3JpZXMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL2ZhY3Rvcmllcy5weQkocmV2aXNpb24gMjQzOTYxKQorKysgVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkod29ya2luZyBjb3B5KQpAQCAtNzAsMTEg KzcwLDcgQEAgY2xhc3MgQnVpbGRGYWN0b3J5KEZhY3RvcnkpOgogICAgICAgICBGYWN0b3J5Ll9f aW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxz ZSwgYWRkaXRpb25hbEFyZ3VtZW50cykKICAgICAgICAgc2VsZi5hZGRTdGVwKEtpbGxPbGRQcm9j ZXNzZXMoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKENvbXBpbGVXZWJLaXQoKSkKLSAgICAgICAg c2VsZi5hZGRTdGVwKFVuQXBwbHlQYXRjaElmUmVxdWlyZWQoKSkKLSAgICAgICAgc2VsZi5hZGRT dGVwKENvbXBpbGVXZWJLaXRUb1QoKSkKICAgICAgICAgaWYgdHJpZ2dlcnM6Ci0gICAgICAgICAg ICBzZWxmLmFkZFN0ZXAoQXJjaGl2ZUJ1aWx0UHJvZHVjdCgpKQotICAgICAgICAgICAgc2VsZi5h ZGRTdGVwKFVwbG9hZEJ1aWx0UHJvZHVjdCgpKQogICAgICAgICAgICAgc2VsZi5hZGRTdGVwKHRy aWdnZXIuVHJpZ2dlcihzY2hlZHVsZXJOYW1lcz10cmlnZ2Vycywgc2V0X3Byb3BlcnRpZXM9c2Vs Zi5wcm9wZXJ0aWVzVG9QYXNzVG9UcmlnZ2VycygpIG9yIHt9KSkKIAogICAgIGRlZiBwcm9wZXJ0 aWVzVG9QYXNzVG9UcmlnZ2VycyhzZWxmKToKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI0Mzk2MSkKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNTE4LDYgKzUx OCwxMCBAQCBjbGFzcyBDb21waWxlV2ViS2l0KHNoZWxsLkNvbXBpbGUpOgogICAgIGRlZiBldmFs dWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKICAgICAgICAgaWYgY21kLmRpZEZhaWwoKToKICAgICAg ICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoRmFpbGVkVG9CdWlsZCcsIFRydWUpCisgICAg ICAgICAgICBzZWxmLmJ1aWxkLmFkZFN0ZXBzQWZ0ZXJDdXJyZW50U3RlcChbVW5BcHBseVBhdGNo SWZSZXF1aXJlZCgpLCBDb21waWxlV2ViS2l0VG9UKCldKQorICAgICAgICBlbHNlOgorICAgICAg ICAgICAgc2VsZi5idWlsZC5hZGRTdGVwc0FmdGVyQ3VycmVudFN0ZXAoW0FyY2hpdmVCdWlsdFBy b2R1Y3QoKSwgVXBsb2FkQnVpbHRQcm9kdWN0KCldKQorCiAKICAgICAgICAgcmV0dXJuIHN1cGVy KENvbXBpbGVXZWJLaXQsIHNlbGYpLmV2YWx1YXRlQ29tbWFuZChjbWQpCiAKQEAgLTUzMiw2ICs1 MzYsOSBAQCBjbGFzcyBDb21waWxlV2ViS2l0VG9UKENvbXBpbGVXZWJLaXQpOgogICAgIGRlZiBo aWRlU3RlcElmKHNlbGYsIHJlc3VsdHMsIHN0ZXApOgogICAgICAgICByZXR1cm4gbm90IHNlbGYu ZG9TdGVwSWYoc3RlcCkKIAorICAgIGRlZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKKyAg ICAgICAgcmV0dXJuIHNoZWxsLkNvbXBpbGUuZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCkKKwog CiBjbGFzcyBDb21waWxlSlNDT25seShDb21waWxlV2ViS2l0KToKICAgICBuYW1lID0gImJ1aWxk LWpzYyIK