196673 2019-04-06 03:37:01 -0700 Broken API Test TestWebKitAPI.SafeBrowsing.WKWebViewGoBackIFrame 2019-04-07 20:00:33 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED DUPLICATE 196688 https://bugs.webkit.org/show_bug.cgi?id=196665 https://bugs.webkit.org/show_bug.cgi?id=196688 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain achristensen ap lforschler webkit-bot-watchers-bugzilla oldest_to_newest 1525007 0 aakash_jain 2019-04-06 03:37:01 -0700 TestWebKitAPI.SafeBrowsing.WKWebViewGoBackIFrame is consistently timing out on iOS. It was recently added in https://bugs.webkit.org/show_bug.cgi?id=196665 e.g.: https://ews-build.webkit.org/#/builders/9/builds/197 https://ews-build.webkit.org/#/builders/9/builds/198 https://ews-build.webkit.org/#/builders/9/builds/199 https://ews-build.webkit.org/#/builders/9/builds/200 https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3494/steps/run-api-tests/logs/stdio 1525008 1 366883 aakash_jain 2019-04-06 03:40:19 -0700 Created attachment 366883 Patch 1525109 2 ap 2019-04-07 18:39:07 -0700 We should just roll back the patch. It is not OK to land fixes without tests, and a broken test is equivalent to no test. 1525110 3 ap 2019-04-07 18:39:30 -0700 No review needed for rollback. 1525128 4 aakash_jain 2019-04-07 19:59:25 -0700 (In reply to Alexey Proskuryakov from comment #2) > We should just roll back the patch. It is not OK to land fixes without tests, and a broken test is equivalent to no test. Rolled out in https://bugs.webkit.org/show_bug.cgi?id=196688 1525130 5 aakash_jain 2019-04-07 20:00:23 -0700 *** This bug has been marked as a duplicate of bug 196688 *** 366883 2019-04-06 03:40:19 -0700 2019-04-07 20:00:33 -0700 Patch bug-196673-20190406064117.patch text/plain 1437 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0Mzk2MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA0LTA2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBCcm9rZW4gQVBJIFRlc3QgVGVzdFdlYktpdEFQSS5TYWZlQnJvd3Npbmcu V0tXZWJWaWV3R29CYWNrSUZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTY2NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2FmZUJyb3dz aW5nLm1tOiBEaXNhYmxlZCB0aGUgdGVzdCBmb3Igbm93IHNpbmNlCisgICAgICAgIGl0J3MgaW1w YWN0aW5nIHRoZSBpbmZyYXN0cnVjdHVyZSAoc2xvd2luZyBkb3duIEVXUyBmb3IgQVBJIHRlc3Rz KS4KKwogMjAxOS0wNC0wNSAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29t PgogCiAgICAgICAgIFdlIHNob3VsZCBwYXNzIG1pbmltdW1FZmZlY3RpdmVEZXZpY2VXaWR0aCB0 byB3ZWIgcHJvY2VzcyBvbiBuZXcgcGFnZSBjcmVhdGlvbi4KSW5kZXg6IFRvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2FmZUJyb3dzaW5nLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvU2FmZUJyb3dzaW5nLm1tCShyZXZp c2lvbiAyNDM5NjEpCisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Nh ZmVCcm93c2luZy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDMzLDcgKzQzMyw3IEBAIFRFU1QoU2Fm ZUJyb3dzaW5nLCBXS1dlYlZpZXdHb0JhY2spCiAgICAgRVhQRUNUX1RSVUUoW1t3ZWJWaWV3IFVS TF0gaXNFcXVhbDpyZXNvdXJjZVVSTChAInNpbXBsZTIiKV0pOwogfQogCi1URVNUKFNhZmVCcm93 c2luZywgV0tXZWJWaWV3R29CYWNrSUZyYW1lKQorVEVTVChTYWZlQnJvd3NpbmcsIERJU0FCTEVE X1dLV2ViVmlld0dvQmFja0lGcmFtZSkKIHsKICAgICBwaGlzaGluZ1Jlc291cmNlTmFtZSA9IEAi c2ltcGxlIjsKICAgICBDbGFzc01ldGhvZFN3aXp6bGVyIHN3aXp6bGVyKG9iamNfZ2V0Q2xhc3Mo IlNTQkxvb2t1cENvbnRleHQiKSwgQHNlbGVjdG9yKHNoYXJlZExvb2t1cENvbnRleHQpLCBbU2lt cGxlTG9va3VwQ29udGV4dCBtZXRob2RGb3JTZWxlY3RvcjpAc2VsZWN0b3Ioc2hhcmVkTG9va3Vw Q29udGV4dCldKTsK